--- Log opened Mon Sep 14 00:00:18 2020 00:17 -!- jonatack [~jon@109.232.227.133] has joined #rust-bitcoin 00:17 -!- jonatack [~jon@109.232.227.133] has quit [Client Quit] 00:18 -!- jonatack [~jon@109.232.227.133] has joined #rust-bitcoin 02:44 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has quit [Quit: ZNC 1.7.5 - https://znc.in] 02:45 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #rust-bitcoin 02:45 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-kakrvzdysumbeepk] has quit [Ping timeout: 244 seconds] 02:45 -!- real_or_random is now known as Guest88768 02:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving] 02:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 02:46 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-jkeelzewuuuzwtst] has joined #rust-bitcoin 02:51 -!- jonatack [~jon@109.232.227.133] has quit [Ping timeout: 256 seconds] 03:19 -!- Kasey14Bashirian [~Kasey14Ba@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 03:28 -!- jonatack [~jon@37.164.23.29] has joined #rust-bitcoin 04:43 -!- jonatack [~jon@37.164.23.29] has quit [Ping timeout: 260 seconds] 04:56 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 07:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 07:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 07:26 < BlueMatt> ariard: ok, waiting for coffee to kick in then I'll review 633 :) 07:50 -!- Kasey14Bashirian [~Kasey14Ba@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds] 08:20 < ariard> BlueMatt: good I'm around if it needs fix! 08:24 < BlueMatt> ariard: I'm confused about your response at https://github.com/rust-bitcoin/rust-lightning/pull/633#discussion_r487594042 08:25 < BlueMatt> ariard: ChannelPublicKeys is used *both* for our own and our counterparty's public keys. 08:25 < BlueMatt> ah, i see your point 08:26 < BlueMatt> ok, yea, its good the way it is. 08:27 < BlueMatt> ariard: wait, but i thought we use the "counterparty" name to be "opposite of holder" ie remote, and use "countersignatory/broadcaster" when it could be us or them 08:27 < BlueMatt> so "counterparty" shouldnt be used there, but "countersignatory"? 08:27 < BlueMatt> that was my original complaint 08:28 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 08:38 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 09:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 09:19 < ariard> BlueMatt: I think you're right, I've been confused by the comment saying somehow only spendable by us when it fact this should said only spendable by countersignatory 09:19 < BlueMatt> cool. I'm most of the way through the latest diff and all good so far.... 09:20 < BlueMatt> just that one note. 09:29 < ariard> BlueMatt: updated only top commit 09:59 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 10:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 11:22 < BlueMatt> ariard: can you squash until each commit builds + passes tests? 11:22 < BlueMatt> ariard: at least 4491986f12aa83b30abc3f87892473bea274ab52 doesn't 11:23 < BlueMatt> ariard: then i think its good to go! 12:22 < ariard> BlueMatt: fixed and squashed a bunch 12:24 < BlueMatt> ariard: did you see my one last note about a confusing comment? 12:24 < BlueMatt> https://github.com/rust-bitcoin/rust-lightning/pull/633#discussion_r488137059 12:44 < BlueMatt> ariard: eh, I'll do it in a later pr. 13:03 < ariard> BlueMatt: arrfff, meeting btw 13:03 < BlueMatt> ariard: oh, right. 13:04 < BlueMatt> ariard: I'm already doing a fixup to fix that other bug we found in review anyway, so nbd. 14:52 < BlueMatt> ariard: well, fixing that one bug turned up another one :/ https://github.com/rust-bitcoin/rust-lightning/pull/690/commits/3a025cb2fbb50369ee5cb7e986eaf8c8cde6ad4d 17:41 -!- drolmer_ [~drolmer@unaffiliated/drolmer] has joined #rust-bitcoin 17:41 -!- drolmer [~drolmer@unaffiliated/drolmer] has quit [Quit: adios] 23:31 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 23:40 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 23:53 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin --- Log closed Tue Sep 15 00:00:19 2020