--- Log opened Sun Oct 25 00:00:57 2020 01:31 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 01:35 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 02:03 -!- belcher_ is now known as belcher 04:05 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 04:19 -!- Chet75McDermott [~Chet75McD@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 04:37 -!- jonatack [~jon@213.152.161.10] has quit [Ping timeout: 258 seconds] 05:40 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin 07:59 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 08:16 -!- schmidty [sid297174@gateway/web/irccloud.com/x-vcwwtbtkiufpxkzl] has quit [Read error: Connection reset by peer] 08:16 -!- schmidty [sid297174@gateway/web/irccloud.com/x-daioqeuzgyrmmhur] has joined #rust-bitcoin 09:26 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin 09:32 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 264 seconds] 09:32 -!- jonatack [~jon@82.102.27.163] has joined #rust-bitcoin 09:43 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #rust-bitcoin 10:36 < stevenroose> apoelstra dr_orlovsky, elichai2 the serde impls that was added in https://github.com/rust-bitcoin/rust-bitcoin/pull/497 for PSBT doesn't work with JSON. 10:36 < stevenroose> Because of the BTreeMap with non-string keys. When using derive, this can be worked around using `serde(with = "..")`, I have modules to do that from another project. But we don't use derive, but a manual `serde_struct_impl`. 10:37 < stevenroose> Is that just a workaround because we can't have serde_derive because of dependency madness? It seems that the serde_struct_impl is equivalent to derive 10:37 < dr_orlovsky> is MSRV prevents us from using derive or it is the fact that we do not want to add another dependency? (serde_with) 10:38 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 10:38 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 10:41 -!- Chet75McDermott [~Chet75McD@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 10:44 < stevenroose> yeah it seems that we don't have derive because of MSRV, but it also seems that directing the user to "pin" the serde version would be able to solve that issue 11:33 < stevenroose> K so I got all that cleaned up and using derive etc 11:33 < stevenroose> I wanted to add one more thing though and I can't figure that out, and a crate like serde_with would very much help with that :| 11:34 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 11:34 < stevenroose> I want the BTreeMap> serialize the bytes as hex, seems quite hard using raw serde 11:38 < stevenroose> https://github.com/rust-bitcoin/rust-bitcoin/pull/508 11:39 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 11:46 < stevenroose> Ok another topic and RFC: My PR with the taproot tagged hashes is done: https://github.com/rust-bitcoin/rust-bitcoin/pull/259 11:46 < stevenroose> There's been some conversation to perhaps move the hash definitions directly into bitcoin_hashes. What are the opinions on that here? 11:47 < stevenroose> They are not strictly "hash implementations" as much as some sugar on top of hash implementations. But then `Hmac` and `sha256d` are also in that ballpark. 11:47 < stevenroose> I could be convinced either way, but I'm interested in opinions. 12:12 < dr_orlovsky> For me it seems that everything related to transaction- or block-specific data types must reside in bitcoin; while bitcoin_hashes are for non-specific generic types. By this logic it is clear why sha256d & sha256t are in bitcoin_hashes and Txid and PubkeyHash are in bitcoin crate. Thus, specific hash types, used in Script (Tapscript) and sciptPubkey should go to bitcoin crate alongside PubkeyHash etc 13:57 -!- jonatack [~jon@82.102.27.163] has quit [Quit: jonatack] 13:58 -!- jonatack [~jon@82.102.27.163] has joined #rust-bitcoin 16:38 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:12c:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 260 seconds] 16:41 -!- tibo [~tibo@2400:4050:2a83:7000:2d2c:d671:abd5:d95e] has joined #rust-bitcoin 22:17 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 22:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 22:41 -!- DeanWeen is now known as DeanGuss 23:11 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 23:12 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin --- Log closed Mon Oct 26 00:00:58 2020