--- Log opened Mon Dec 28 00:01:01 2020
00:38 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:39 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
00:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:20 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 260 seconds]
02:35 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
02:39 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has joined #rust-bitcoin
02:54 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #rust-bitcoin
03:19 -!- Camylle38Cumming [~Camylle38@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
04:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
04:33 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
05:50 -!- jeremyrubin [~jr@2607:fb90:46c:8e30:300e:3023:6b28:256b] has quit [Ping timeout: 260 seconds]
06:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
06:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
06:34 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 264 seconds]
06:34 -!- jonatack [~jon@213.152.162.10] has joined #rust-bitcoin
07:29 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has quit [Ping timeout: 260 seconds]
08:34 < andytoshi> elichai2: can you ack https://github.com/rust-bitcoin/rust-secp256k1/pull/264 ? then i will update the new-release PR for rust-secp
08:34 < andytoshi> meanwhile on rust-bitcoin i think we just need #508, and a rust-secp bump, and then we're good to go
08:55 < elichai2> andytoshi: reviewed #264
08:57 < andytoshi> tahkns, looking now
08:58 < andytoshi> oh, we should also release a new version of bitcoin_hashes..
08:58 < andytoshi> good catch on the >= 4 thing
10:30 < andytoshi> elichai2: heh oops, also the rucovery unit tests don't work with #246 ... lemme first fix CI to detect that
10:38 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
10:49 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
10:54 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
11:25 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Quit: leaving]
11:26 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #rust-bitcoin
11:26 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
11:26 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
11:35 < andytoshi> o.O how do the rust-bitcoin tests pass on 1.29.0 ... it looks like we pin cc _after_ compile-testing everything
11:38 < andytoshi> somehow travis is using cc 1.0.41
11:41 < andytoshi> ahh bitcoinconsensus is holding cc down to 1.41
11:44 < andytoshi> elichai2: https://github.com/rust-bitcoin/rust-secp256k1/pull/264 i think is good to go now. i added 3 (very small) commits
11:45 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
11:45 -!- jeremyrubin [~jr@2607:fb90:8062:c5e6:300e:3023:6b28:256b] has joined #rust-bitcoin
11:47 < elichai2> andytoshi: done
11:48 < andytoshi> thanks!
12:14 < andytoshi> lol, the only breaking change in bitcoin_hashes was removing schemars
12:14 < andytoshi> i guess we gotta do a major rev for that, but gross
12:14 < andytoshi> jeremyrubin: are you interested in trying to get schemars working on bitcoin_hashes now that we've fixed CI?
12:29 < jeremyrubin> Hey -- the removal feels rushed and kinda annoying because the schemars code was not the issue at all afaict, it is the jsonvalid which is only used for testing.
12:32 -!- Camylle38Cumming [~Camylle38@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds]
12:33 < andytoshi> we can hold off for a bit
12:34 < jeremyrubin> it's already merged
12:34 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
12:35 < andytoshi> i mean on releasing
12:35 < jeremyrubin> ok
12:35 < andytoshi> we merged it because i wanted to fix CI and schemars was blocking that
12:37 < andytoshi> lemme see if i can put schemars back without jsonvalid
12:38 < andytoshi> which would simplify my life because then i don't need to do a major rev
12:38 < jeremyrubin> cool -- I was also taking a look at it; I can hold off. don't want to make you do work for code you don't care to maintain tho
12:39 < jeremyrubin> I think if you just switch the cfg flag to "test-incompat-msrv" for the tests
12:39 < jeremyrubin> it should work fine (that way the tests can still be run if need be, rather than deleted outright)
12:40 < andytoshi> no, it won't, cargo won't run at all if jsonvalid is in the dep tree
12:40 < jeremyrubin> interesting -- even if it moves to an optional non dev dep?
12:40 < andytoshi> no, you can move it to an optional non-dev dep
12:40 < andytoshi> but then it's an actual dep
12:41 < andytoshi> and e.g. if it braeksi in a minor rev then that's a breaking change for us, etc
12:41 < jeremyrubin> hmmm
12:42 < jeremyrubin> but that feels semantic
12:42 < jeremyrubin> because as a dev dep it ends up being more like a dep
12:42 < andytoshi> i'm not sure what you mean. dev-deps are not exposed downstream in any way under any circumstances
12:42 < jeremyrubin> Yeah i guess it's being annoyed at cargo for no optional dev-deps
12:44 < jeremyrubin> looks like the "blessed" way of doing this is to just make a new repo which contains some extended tests if we want it tested
12:44 < jeremyrubin> https://github.com/rust-lang/cargo/issues/1596#issuecomment-295465919
12:45 < andytoshi> heh, you can do that
12:45 < andytoshi> it doesn't have to be in a separate repo
12:45 < jeremyrubin> ah sure. separate integration test crate
12:46 < jeremyrubin> in any case, if you just remove all the tests it should be OK
12:51 < andytoshi> it actually looks like it works if i just remove the jsonvalid dep and make no other changes
13:00 < jeremyrubin> ah yeah that should work, but the tests with the feature schemars enabled should fail I think?
13:01 < andytoshi> they seem to work
13:01 < andytoshi> not on 1.29.0 naturally
13:02 < andytoshi> oh wait, these are gated on "schemars" and "serde"
13:03 < andytoshi> yeah ok, if i enable both features then they don't compile
13:06 < jeremyrubin> yep. I can search for a diff jsonschema validating library
13:06 < jeremyrubin> or do a sub crate
13:19 < jeremyrubin> (i meant longer term btw; disable the tests for now)
13:20 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
13:22 < andytoshi> yeah that makes sense
13:23 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
15:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
15:09 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
15:10 < andytoshi> https://github.com/rust-bitcoin/rust-secp256k1/pull/257 rust-secp 0.20
15:10 < andytoshi> elichai2: BlueMatt: stevenroose: sgeisler:
15:11 < andytoshi> or whoever else is around and would liekx to take a aloo
15:11 < andytoshi> look
15:21 < andytoshi> ack 508 except for the debug printf stevenroose
15:41 < andytoshi> actually i'd also like  https://github.com/rust-bitcoin/rust-bitcoin/pull/537 in before release
16:40 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:f414:9b65:b890:9d87] has joined #rust-bitcoin
17:23 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
18:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
18:14 < fiatjaf2> does secp256k1 do bip340 signatures?
18:22 < fiatjaf2> ok, apparently not
20:30 -!- jeremyrubin [~jr@2607:fb90:8062:c5e6:300e:3023:6b28:256b] has quit [Ping timeout: 264 seconds]
20:31 -!- jeremyrubin [~jr@2601:645:c200:14:346f:5d3:a503:bdf1] has joined #rust-bitcoin
--- Log closed Tue Dec 29 00:01:01 2020