--- Log opened Fri Jan 08 00:00:09 2021
00:06 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
00:17 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 246 seconds]
00:18 -!- jonatack [~jon@104.254.90.195] has joined #rust-bitcoin
00:20 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds]
00:39 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
00:52 -!- da39a3ee5e6b4b0d [~da39a3ee5@67.23.55.162] has joined #rust-bitcoin
02:08 -!- tibo_ [~tibo@2400:4050:2a83:7000:d0e3:3ce:81b7:590b] has quit []
02:10 -!- tibo [~tibo@2400:4050:2a83:7000:31d1:edb5:88fe:c183] has joined #rust-bitcoin
02:11 -!- tibo_ [~tibo@2400:4050:2a83:7000:5903:700c:b766:eb25] has joined #rust-bitcoin
02:15 -!- tibo [~tibo@2400:4050:2a83:7000:31d1:edb5:88fe:c183] has quit [Ping timeout: 264 seconds]
02:17 -!- tibo [~tibo@2400:4050:2a83:7000:9894:9a92:9e55:d983] has joined #rust-bitcoin
02:18 -!- tibo__ [~tibo@2400:4050:2a83:7000:ad41:15de:6bd7:ea72] has joined #rust-bitcoin
02:20 -!- tibo_ [~tibo@2400:4050:2a83:7000:5903:700c:b766:eb25] has quit [Ping timeout: 264 seconds]
02:21 -!- tibo [~tibo@2400:4050:2a83:7000:9894:9a92:9e55:d983] has quit [Ping timeout: 264 seconds]
03:03 -!- da39a3ee5e6b4b0d [~da39a3ee5@67.23.55.162] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:17 -!- Eleanora59Hansen [~Eleanora5@static.57.1.216.95.clients.your-server.de] has quit [Remote host closed the connection]
03:20 -!- Velma55Bauch [~Velma55Ba@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
03:25 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
03:31 -!- da39a3ee5e6b4b0d [~da39a3ee5@67.23.55.162] has joined #rust-bitcoin
03:40 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
03:48 -!- jonatack [~jon@104.254.90.195] has quit [Quit: jonatack]
03:52 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
03:56 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds]
03:57 -!- jonatack [~jon@184.75.221.43] has joined #rust-bitcoin
04:13 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
04:29 -!- tibo__ [~tibo@2400:4050:2a83:7000:ad41:15de:6bd7:ea72] has quit [Remote host closed the connection]
04:29 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
05:26 -!- da39a3ee5e6b4b0d [~da39a3ee5@67.23.55.162] has quit [Ping timeout: 265 seconds]
05:32 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has joined #rust-bitcoin
05:50 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:49 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has joined #rust-bitcoin
06:55 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
06:56 -!- Velma55Bauch [~Velma55Ba@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
07:04 -!- nickler_ [~nickler@static.219.205.69.159.clients.your-server.de] has joined #rust-bitcoin
07:04 -!- nickler__ [~nickler@static.219.205.69.159.clients.your-server.de] has joined #rust-bitcoin
07:05 -!- nickler_ [~nickler@static.219.205.69.159.clients.your-server.de] has quit [Client Quit]
07:05 -!- nickler__ [~nickler@static.219.205.69.159.clients.your-server.de] has quit [Client Quit]
07:08 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
07:27 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
07:41 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
08:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:27 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has joined #rust-bitcoin
08:31 < ariard> BlueMatt: 761 SGTM
08:37 < ariard> also Sergi nit
08:38 < BlueMatt> hmm?
08:47 < ariard> I mean ready-to-merge IMO unless you expect more eyes
08:47 < BlueMatt> but what about sergi?
08:47 < BlueMatt> he didnt comment there, did he?
08:47 < ariard> he has a small PR
08:48 < ariard> 769, sorry for confusion
08:48 < BlueMatt> oh, right.
08:50 < BlueMatt> ariard: I'm not sure how we got de-synced on the meaning of "key_derivation_params" - they are an arbitrary id already
08:50 < BlueMatt> sure, our api implementation uses them to store (non-secret) cryptographic material, but they dont need to be.
08:51 < ariard> they don't need to be non-secret, meaning they can be secret?
08:52 < ariard> right our interface already allow to implement an identifier for the external world, so my suggestion should be more a comment above our API to inform implementor?
08:54 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:57 < BlueMatt> yea, but the docs *do* say that https://docs.rs/lightning/0.0.12/lightning/chain/keysinterface/trait.ChannelKeys.html#tymethod.key_derivation_params
08:58 < BlueMatt> anyway, if there's a place you saw that doesnt mention it or isnt clear, we should definitely fix it. as you note its separate from 761, so gonna merge that.
08:59 < ariard> yep, could be clearer as "These should be sufficient to a) identify this ChannelKeys object uniquely and lookup or b) re-derive its keys consuming the arbitrary identifier"
08:59 < ariard> signaling clearly you have two options at implementation
08:59 < BlueMatt> yea, ok, plus probably a discussion of the implications?
09:00 < ariard> right, which is more theoritically for implications
09:00 < BlueMatt> ie "an external signer probably should do X..."
09:00 < ariard> yep, agree
09:00 < BlueMatt> cool
09:05 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
09:25 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
09:43 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
09:50 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection timed out]
09:50 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
11:57 -!- jonatack [~jon@184.75.221.43] has quit [Quit: jonatack]
12:09 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
12:14 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds]
12:16 -!- jonatack [~jon@213.152.162.89] has joined #rust-bitcoin
12:34 -!- nickler_ [~nickler@static.219.205.69.159.clients.your-server.de] has joined #rust-bitcoin
12:34 -!- nickler_ [~nickler@static.219.205.69.159.clients.your-server.de] has quit [Client Quit]
15:25 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/548
15:28 < andytoshi> sighh byteorder broke us in a minor release
15:29 < andytoshi> which is depended on by base64-compat
15:30 < andytoshi> we should really prioritize writing our own encoding crate
16:44 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.28.247] has joined #rust-bitcoin
17:07 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
17:50 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
19:19 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
19:52 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.28.247] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:11 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
21:16 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
21:29 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has joined #rust-bitcoin
21:50 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
21:52 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
21:53 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
21:54 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:14 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
23:34 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
23:48 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
--- Log closed Sat Jan 09 00:00:10 2021