--- Log opened Wed Apr 07 00:00:18 2021 00:07 -!- kiltzman [~k1ltzman@195.189.99.96] has quit [Ping timeout: 240 seconds] 00:08 -!- kiltzman [~k1ltzman@195.189.99.96] has joined #rust-bitcoin 00:36 -!- tibo [~tibo@2400:4050:2a83:7000:f5cd:3236:d15d:3835] has joined #rust-bitcoin 00:39 -!- tibo_ [~tibo@2400:4050:2a83:7000:d080:c31d:1431:6e88] has quit [Ping timeout: 258 seconds] 01:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 01:13 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin 01:13 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 01:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin 01:44 -!- tibo_ [~tibo@2400:4050:2a83:7000:9c2:905d:79d2:123c] has joined #rust-bitcoin 01:47 -!- tibo [~tibo@2400:4050:2a83:7000:f5cd:3236:d15d:3835] has quit [Ping timeout: 250 seconds] 01:50 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-jfgygubnaewcijny] has quit [Ping timeout: 248 seconds] 01:52 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-ezuxkekmentqtzba] has joined #rust-bitcoin 02:13 < elichai2> andytoshi: I think this can be merged forcefully https://github.com/rust-bitcoin/rust-bitcoin/pull/582 02:13 < elichai2> as for rust-secp I think this PR is the main blocker for the rest https://github.com/rust-bitcoin/rust-secp256k1/pull/290 02:14 < elichai2> (I think it deserves broader agreement and not a single reviewer) 02:37 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 252 seconds] 02:40 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #rust-bitcoin 03:42 -!- collins [c5e868c3@197.232.104.195] has joined #rust-bitcoin 03:45 -!- collins [c5e868c3@197.232.104.195] has quit [Client Quit] 04:44 -!- belcher_ is now known as belcher 05:44 -!- tibo [~tibo@2400:4050:2a83:7000:b40b:c7e9:d63a:34d0] has joined #rust-bitcoin 05:47 -!- tibo_ [~tibo@2400:4050:2a83:7000:9c2:905d:79d2:123c] has quit [Ping timeout: 245 seconds] 05:47 -!- tibo [~tibo@2400:4050:2a83:7000:b40b:c7e9:d63a:34d0] has quit [Remote host closed the connection] 06:57 -!- tibo [~tibo@2400:4050:2a83:7000:b40b:c7e9:d63a:34d0] has joined #rust-bitcoin 07:01 -!- tibo [~tibo@2400:4050:2a83:7000:b40b:c7e9:d63a:34d0] has quit [Ping timeout: 258 seconds] 07:09 -!- jfroche [6d597512@gateway/web/cgi-irc/kiwiirc.com/ip.109.89.117.18] has joined #rust-bitcoin 07:10 -!- __gotcha [~Thunderbi@plone/gotcha] has joined #rust-bitcoin 07:11 < __gotcha> First time here, sorry if I do not know your practices. 07:13 < __gotcha> In the context of a good first issue, we came to question this function: https://github.com/rust-bitcoin/rust-lightning/blob/main/lightning/src/ln/channel.rs#L3330 07:13 < __gotcha> It takes the min between a tenth of a value and nine tens of the same value. 07:14 < __gotcha> IOW, no need to compute anything. 07:14 < __gotcha> What would be the proper process to question that code ? 07:14 < __gotcha> Here ? Via comments on Github ? Via an issue on Github ? 07:16 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 246 seconds] 07:17 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #rust-bitcoin 08:01 < andytoshi> elichai2: ok 290 merged 08:22 -!- fjahr [sid374480@gateway/web/irccloud.com/x-ilpsykelulslvhrl] has quit [Ping timeout: 260 seconds] 08:24 -!- fjahr [sid374480@gateway/web/irccloud.com/x-bvvkqfeiyvkgcmqm] has joined #rust-bitcoin 08:27 < elichai2> Any downstream user can verify this doesn't break their stuff? https://github.com/rust-bitcoin/rust-secp256k1/pull/270 (ping BlueMatt dr-orlovsky shesek ) I'm a little afraid that someone used serde to serialize and backup keys and we might break their backup 08:27 < BlueMatt> I have never written anything using serde :shrug: 08:28 < BlueMatt> but, yea, that would worry me somewhat 08:28 < BlueMatt> yay open source, we never really know who exactly our users are and its hard to contact them to ask questions like this :( 08:29 < elichai2> yeah :( 08:29 < elichai2> we need something like crater lol 08:31 < elichai2> I guess i'll find some time and write a big test using ~5 different serde serializers and checking that their serialization before the PR works after the PR (and vise versa) 08:32 < BlueMatt> cool, all my prs are rebased and pass new CI, plz2review andytoshi 08:39 < andytoshi> kk on the phone, can work on reviews in 20 08:49 < BlueMatt> lol, I'm not in *that* much of a rush :) 08:58 -!- __gotcha [~Thunderbi@plone/gotcha] has quit [Ping timeout: 246 seconds] 08:58 < BlueMatt> ariard: let me know if you have more questions on https://github.com/rust-bitcoin/rust-lightning/pull/815 - I'm kinda itching to finally hit merge on it :) 09:00 -!- tibo [~tibo@2400:4050:2a83:7000:b40b:c7e9:d63a:34d0] has joined #rust-bitcoin 09:05 -!- tibo [~tibo@2400:4050:2a83:7000:b40b:c7e9:d63a:34d0] has quit [Ping timeout: 250 seconds] 09:21 < dr-orlovsky> elichai2: thanks for pingning, but all of my code are yet not used in production environment so even if it is broken somewhere (I doubt since I do not work with private keys in 99.9% of cases) it should be fixed anyway 09:21 < dr-orlovsky> so you are free of merging 09:21 < dr-orlovsky> *free to merge 11:53 -!- belcher is now known as belcher_ 12:09 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 12:31 -!- kiltzman [~k1ltzman@195.189.99.96] has quit [Ping timeout: 265 seconds] 12:36 -!- kiltzman [~k1ltzman@5.206.224.243] has joined #rust-bitcoin 13:56 < Thomas[m]111> elichai2: We only added more tests in this PR, all existing tests still pass and use `serde_test` which should make them serializer independent. 13:56 < Thomas[m]111> If you still see a risk, I think we should document those specific cases as more test cases that we put as a patch before any of the current work to show that they pass before and afterwards. 13:58 < Thomas[m]111> This may be a bit of an ignorant position but I would expect downstream projects to have tests for all the stuff that matters and that hopefully includes backups. So even if it breaks something, upgrading the version should highlight that and we can always release a fix on top of it. My 2c :) 14:00 -!- tibo [~tibo@2400:4050:2a83:7000:b40b:c7e9:d63a:34d0] has joined #rust-bitcoin 14:26 -!- tibo [~tibo@2400:4050:2a83:7000:b40b:c7e9:d63a:34d0] has quit [Remote host closed the connection] 14:26 -!- tibo [~tibo@2400:4050:2a83:7000:b40b:c7e9:d63a:34d0] has joined #rust-bitcoin 14:41 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 14:41 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin 14:41 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 14:41 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin 15:59 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 17:27 -!- jfroche [6d597512@gateway/web/cgi-irc/kiwiirc.com/ip.109.89.117.18] has quit [Quit: Connection closed] 18:44 < ariard> BlueMatt: just acked'it modulo a small nit :) 18:44 < ariard> #861 sounds also pretty mature to me, left a review 18:45 < BlueMatt> ariard: awesome, thanks. Now I'm gonna go beat the socks off lnd and c-lightning in this payment benchmark thinggy :) 18:52 < BlueMatt> ariard: hmmm, no, I think its right to say max there? 18:53 < BlueMatt> ariard: because the issue is that the liquidity limit (ie htlc_maximum or channel value) is smaller 20:21 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 20:25 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 248 seconds] --- Log closed Thu Apr 08 00:00:19 2021