--- Day changed Mon Jun 06 2016
04:32 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has joined #secp256k1
07:41 -!- roconnor [~roconnor@host-45-78-199-89.dyn.295.ca] has joined #secp256k1
09:16 -!- mdavid613 [~Adium@cpe-172-251-161-231.socal.res.rr.com] has joined #secp256k1
09:38 < gmaxwell> andytoshi: if you look in secp256k1.h for the definition of SECP256K1_ARG_NONNULL  you'll see that it's dummied out when SECP256K1_BUILD is true.
09:39 < gmaxwell> andytoshi: so none of our argchecks should be getting compiled with attribute non-null ... can you look at where you're getting the warning and see whats going wrong?
09:41 < gmaxwell> andytoshi: e.g. is the warning really triggered by the non-null attribute or do we perhaps have checks out of order, and it's warning because of null check after we already dereferenced?
09:48 < gmaxwell> heh. GCC now reconizes git conflict markers and gives sensible error messages for them.
09:48 < sipa_> ha!
09:49 < gmaxwell> (GCC 6 feature)
10:19 -!- maaku [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has quit [Quit: No Ping reply in 180 seconds.]
10:21 -!- maaku [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has joined #secp256k1
11:00 -!- sipa_ is now known as sipa
11:00 -!- sipa [~pw@2a02:348:86:3011::1] has quit [Changing host]
11:00 -!- sipa [~pw@unaffiliated/sipa1024] has joined #secp256k1
11:11 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds]
11:26 < andytoshi> gmaxwell: oops, i missed this .. did you find an answer?
11:26 < gmaxwell> andytoshi: no, I don't have GCC 6 here.
11:27 < andytoshi> kk one sec, i'll 0bin a compile output
11:28 < andytoshi> http://0bin.net/paste/SabUU3Zyo9j-Ajfe#1UyIPBoS0bzTokESGUlvvTwERK5zzFJubJYu8qW42GJ
11:28 < andytoshi> it is definitely in ARG_CHECK
11:30 < andytoshi> oh, it's in the benchmarks only, i'll bet SECP256K1_BUILD is not defined there
11:30 < andytoshi> yup. so is the proper fix to add it?
11:31 < andytoshi> in Makefile.am, to bench_*_CPPFLAGS
11:33 < gmaxwell> Yup. Sounds right to me, at least if the benchmark is #including the source rather than using it as a library.
11:33 < andytoshi> kk 2 minutes, i'll update the PR
11:34 < andytoshi> i knew this felt funny, that's why it got its own commit :)
11:34 < gmaxwell> Though, as an aside, we _really_ need to add some examples that use the library correctly. Otherwise people are going to copy our tests/benchmarks.
11:34 < gmaxwell> Yea, I really didn't want to disable that warning too.. it's the compiler telling us it's removing our null checks.
11:35 < andytoshi> well, if you copy the benchmarks i think it literally won't work .. but agreed in general
11:35 < andytoshi> i think contracthashtool is the closest thing, and probably anyone reading that would conclude it's not production-ready because of all the all-caps error messages :)
11:35 < andytoshi> s/won't work/won't compile due to internal headers being included/
11:36 < gmaxwell> we should probably include a little commandline "generate a private public keypair" tool.
11:36 < gmaxwell> which also internally tests the keypair by signing a message and verifying it, so it shows most of the api.
11:36 < andytoshi> agreed
11:37 < andytoshi> i think i'd have done that long ago, but for the main application (bitcoin) i'd need a base58 encoder as well, and that sucked all my motivation up..
11:38 < sipa> andytoshi: https://github.com/bitcoin/libbase58 ?
11:38 < andytoshi> oh wow, how long has that been there?
11:39 < andytoshi> ah, it does require sha256 though ... can we please expose that in libsecp?
11:39 < andytoshi> i know "we're not a general crypto library" but the library is hard to use without it
11:48 < gmaxwell> We could have a little demo thing that just printed hex.
11:49 < gmaxwell> it wouldn't be actually useful (sad) but would be an okay thing to copy and paste code from.
12:03 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has joined #secp256k1
12:08 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 276 seconds]
12:10 -!- afk11 [~afk11@109.255.154.81] has joined #secp256k1
12:10 -!- afk11 [~afk11@109.255.154.81] has quit [Changing host]
12:10 -!- afk11 [~afk11@unaffiliated/afk11] has joined #secp256k1
16:13 -!- maaku [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has quit [Remote host closed the connection]
16:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
16:15 -!- Guest81996 [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has joined #secp256k1
16:22 -!- Guest81996 [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has quit [Quit: No Ping reply in 180 seconds.]
16:24 -!- maaku_ [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has joined #secp256k1
17:06 -!- maaku_ [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has quit [Remote host closed the connection]
17:08 -!- maaku_ [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has joined #secp256k1
17:57 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 240 seconds]
18:03 -!- afk11 [~afk11@109.255.154.81] has joined #secp256k1
18:03 -!- afk11 [~afk11@109.255.154.81] has quit [Changing host]
18:03 -!- afk11 [~afk11@unaffiliated/afk11] has joined #secp256k1
18:07 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #secp256k1
19:10 -!- mdavid613 [~Adium@cpe-172-251-161-231.socal.res.rr.com] has quit [Quit: Leaving.]
19:21 -!- roconnor [~roconnor@host-45-78-199-89.dyn.295.ca] has quit [Ping timeout: 244 seconds]
20:48 -!- mdavid613 [~Adium@cpe-172-251-161-231.socal.res.rr.com] has joined #secp256k1
20:51 -!- mdavid613 [~Adium@cpe-172-251-161-231.socal.res.rr.com] has quit [Read error: Connection reset by peer]
20:53 -!- mdavid613 [~Adium@cpe-172-251-161-231.socal.res.rr.com] has joined #secp256k1
20:59 -!- mdavid613 [~Adium@cpe-172-251-161-231.socal.res.rr.com] has quit [Read error: Connection reset by peer]
21:00 -!- mdavid613 [~Adium@cpe-172-251-161-231.socal.res.rr.com] has joined #secp256k1
21:14 -!- mdavid613 [~Adium@cpe-172-251-161-231.socal.res.rr.com] has quit [Quit: Leaving.]
21:54 -!- maaku_ [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has quit [Ping timeout: 244 seconds]
21:54 -!- maaku [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has joined #secp256k1
23:07 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-izdgswuchwrrbabq] has quit [Ping timeout: 260 seconds]
23:08 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-hjwrojpksxoiknqt] has joined #secp256k1
23:36 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]