--- Log opened Tue Feb 11 00:00:40 2020
00:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds]
00:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
00:24 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds]
03:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
03:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds]
04:50 < real_or_random> gmaxwell: fwiw, nickler and me were also wondering why you said okay here but then took the other approach https://github.com/bitcoin-core/secp256k1/pull/710#discussion_r377405007
04:50 < real_or_random> which is fine of course but maybe also lost in rebase?
05:08 < gmaxwell> ah, because I did it and then undid it after it turned into a mess. The issue is that ctx is opaque in util.h and as as a result it was making the benchmarks (which include util.h) fail to build, and changing that would require massive ugly rearrangements.
05:10 < gmaxwell> (commented there)
05:11 < gmaxwell> sorry, forgot I'd said okay.
05:11 < gmaxwell> I think probably things that just use the library like benchmarks should perhaps not be using an internal header like util.h
05:15 < real_or_random> ah I see
05:16 < real_or_random> github is really broken in this PR
05:19 < real_or_random> I've only now noticed your comments from 30min ago. previously I had seen only the comment in the main thread
05:23 < gmaxwell> glad to hear you say 'in this PR'; I haven't used github much lately and I wondered if it was this bad everywhere.
05:29 < real_or_random> I think it gets confused when handling comments on old commits, in particular multiple comments on the "same" line but in different commits etc
05:29 < real_or_random> which is probably not easy to handle correctly but surely can be improved
05:30 < real_or_random> I guess we rarely hit this case because we usually have fixup commits and then explicitly ask for squash/rebase
05:30 < gmaxwell> I had fixup commits for a week, got no comments on them seperately so I squashed them.
05:31 < gmaxwell> (when I rebased)
05:32 < real_or_random> yes, everyone was kind of slow in that PR :/
05:55 < nickler> you mean fast (compared to other PRs) :P
05:57 < gmaxwell> he meant slow on every PR. :P
05:59 < gmaxwell> not to sound non-appriciative, all the review was helpful.
06:09 -!- belcher [~belcher@unaffiliated/belcher] has joined #secp256k1
07:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
07:25 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
--- Log closed Tue Feb 11 07:32:13 2020
--- Log opened Tue Feb 11 07:32:13 2020
07:49 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds]
08:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #secp256k1
08:28 < elichai2> https://twitter.com/mountain_ghosts/status/1227196942863806465
09:32 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
09:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds]
11:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
11:54 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
13:18 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
13:43 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #secp256k1
13:58 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
14:11 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds]
16:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
16:25 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds]
20:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
20:41 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds]
21:33 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
22:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
23:26 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 260 seconds]
--- Log closed Wed Feb 12 00:00:37 2020