--- Log opened Fri Feb 21 00:01:00 2020
00:43 < real_or_random> weird
03:16 < real_or_random> sorry for bringing this up now but I'm somewhat concerned that more users of the API used the return values as the length of the ECDH secret
03:16 < real_or_random> https://github.com/bitcoin-core/secp256k1/pull/710#discussion_r370987476
03:17 < real_or_random> if we force this to 1 now, some implementations could end up deriving shared keys of length 1
03:18 < real_or_random> maybe it's better to call illegal_callback if hashfp returns an integer which is not 0 or 1?
04:16 < nickler> I'm not too concerned, that would require someone to do smart tricks and reading the implementation without reading the docs for ecdh nor ecdh_hashfp.
04:16 < nickler> Also this would only happen in bindings for different languages because usually the size of your output is just static.
04:16 < nickler> In a hypothetical world it could also fix someones code who relies on ecdh() actually returning 0 or 1.
04:18 < real_or_random> I think rust-secp256k1 has demonstrated that this mistake is realistic
04:23 < real_or_random> maybe bailing out can be a good idea independently of this concern
04:28 < nickler> it's realistic only in the very specific circumstances of rust-secp
04:30 < nickler> would be even less of a concern if we had a release process to communicate changes. Hopefully, one day. I hope we can use CoreDev to come up with a plan towards a release.
04:32 < real_or_random> yep indeed
08:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
08:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #secp256k1
08:30 -!- gmaxwell [gmaxwell@wikimedia/KatWalsh/x-0001] has left #secp256k1 []
08:35 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
08:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 255 seconds]
09:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
10:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
10:21 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #secp256k1
11:02 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
11:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
11:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
11:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1
11:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
11:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
11:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #secp256k1
11:45 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
11:46 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #secp256k1
18:05 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
--- Log closed Sat Feb 22 00:00:00 2020