--- Log opened Mon Jan 09 00:00:10 2023
00:39 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
02:00 -!- michaelfolkson [~michaelfo@138.68.143.20] has quit [Quit: ZNC 1.8.2 - https://znc.in]
02:02 -!- michaelfolkson [~michaelfo@138.68.143.20] has joined #secp256k1
03:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
03:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
04:03 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Read error: Connection reset by peer]
04:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds]
04:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
06:36 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
06:39 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
07:05 -!- leagen [~sdfknbdfb@136.49.220.126] has quit [Ping timeout: 260 seconds]
07:24 -!- hg [~halosghos@user/halosghost] has joined #secp256k1
08:31 -!- leagen [~sdfknbdfb@95.sub-174-197-14.myvzw.com] has joined #secp256k1
09:03 -!- leagen [~sdfknbdfb@95.sub-174-197-14.myvzw.com] has quit [Ping timeout: 272 seconds]
09:19 -!- DeanGuss [~dean@user/deanguss] has quit [Ping timeout: 268 seconds]
09:20 -!- DeanWeen [~dean@nonplayercharacter.me] has joined #secp256k1
10:04 -!- leagen [~sdfknbdfb@192.sub-174-246-195.myvzw.com] has joined #secp256k1
10:05 < real_or_random> sipa nickler: Can I get a Concept (N)ACK on https://github.com/bitcoin-core/secp256k1/pull/1187? (Just the last two trivial/renaming commits, the other ones have been merged as part of #1186 already)
10:11 < sipa> There are a few other global non-exported constants like secp256k1_scalar_one. Do we want to make those uppercase too?
10:13 < sipa> (not necessarily in the same PR)
10:17 < real_or_random> I'm not sure sure about these. We could make it a general convention that globals are uppercase but I think for variables prefixed with secp256k1_ it's rather obvious and then the convention that just macros are uppercase may be better 
10:17 < real_or_random> sipa: thanks for your review. why rebase though? it should merge cleanly
10:17 < sipa> Oh because the github PR view still shows the old commits in there.
10:18 < sipa> It does apply cleanly.
10:19 < real_or_random> ok my thought was that rebasing will invalidate an ACK
10:19 < real_or_random> I mean... it doesn't matter much, all of this is trivial and also trivial to reACK
10:19 < real_or_random> and this will give you only the two commits https://github.com/bitcoin-core/secp256k1/pull/1187/files/39e8f0e3d7ba7924e9cc5f9e0c56747e942f1eab..5e03c7c3365e610983e7ee8c4e136b5374774cff
10:51 -!- hg [~halosghos@user/halosghost] has quit [Read error: Connection reset by peer]
10:54 -!- hg [~halosghos@user/halosghost] has joined #secp256k1
11:50 -!- leagen [~sdfknbdfb@192.sub-174-246-195.myvzw.com] has quit [Ping timeout: 252 seconds]
12:22 -!- leagen [~sdfknbdfb@14.sub-174-246-222.myvzw.com] has joined #secp256k1
12:45 -!- leagen [~sdfknbdfb@14.sub-174-246-222.myvzw.com] has quit [Ping timeout: 265 seconds]
12:55 -!- leagen [~sdfknbdfb@154.sub-174-246-192.myvzw.com] has joined #secp256k1
13:23 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.7.1]
13:26 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
14:16 -!- DeanWeen is now known as DeanGuss
14:16 -!- DeanGuss [~dean@nonplayercharacter.me] has quit [Changing host]
14:16 -!- DeanGuss [~dean@user/deanguss] has joined #secp256k1
14:20 -!- leagen [~sdfknbdfb@154.sub-174-246-192.myvzw.com] has quit [Ping timeout: 260 seconds]
15:05 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
15:08 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
15:37 -!- hg [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.7.1]
16:45 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
16:45 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
18:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
18:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
--- Log closed Tue Jan 10 00:00:10 2023