--- Log opened Mon Jun 19 00:00:34 2023
02:22 -!- tromp [~textual@92.110.219.57] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
02:34 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
03:58 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
04:34 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
04:50 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
04:52 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
05:20 -!- cfields_ [~cfields@user/cfields] has quit [Server closed connection]
05:20 -!- cfields [~cfields@user/cfields] has joined #secp256k1
05:31 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 240 seconds]
05:31 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
05:42 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
07:53 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
08:04 < real_or_random> sipa nickler meeting
08:04 < nickler> hi
08:04 < sipa> hi
08:05 < real_or_random> hi 
08:06 < real_or_random> topics? :)
08:06 < nickler> state of the ellswift PR maybe?
08:06 < real_or_random> yep
08:07 < real_or_random> I think it's waiting for review again
08:07 < nickler> the version from before the last update looked good to me
08:08 < real_or_random> I had some local fixups/nits last week that I'll need to rebase. shouldn't take longer than an hour, and no matter if sipa wants to pick them or not, I'll plan to ACK this then 
08:08 < sipa> ok
08:09 < sipa> happy to include any nits/fixups
08:09 < real_or_random> sounds good
08:11 < sipa> @nickler Also thanks for the signed-digit ecmult_const review; I'll go look over that soon.
08:11 < real_or_random> we could also talk about this request here https://github.com/bitcoin-core/secp256k1/pull/1329#issuecomment-1595788690 ... I mean we don't want to merge this right now but we could perhaps give some review so that becomes a clean branch
08:11 < real_or_random> not sure if this helps him right now, but it's something we can offer and it needs to be done anyway
08:12 < sipa> Clean in what sense?
08:14 < sipa> I don't think the timeline there for merging is realistic. But it may be helpful if they could say "is being reviewed" too.
08:14 < real_or_random> in a state that is "ready to merge" from a code quality perspective  
08:14 < real_or_random> at the moment it
08:14 < real_or_random> it's a bunch of commits that needs to be stashed, and also some code can be improved etc. 
08:14 < real_or_random> I think just noone bothered to review it at this stage 
08:15 < nickler> sipa: cool, I just had minor comments in the SD PR. Looks pretty good.
08:16 < nickler> real_or_random: not sure what you mean clean. what's the difference to a full review?
08:19 < real_or_random> I think there's no difference
08:19 < sipa> No difference between?
08:20 < real_or_random> okay, sorry, let me explain
08:20 < real_or_random> I think the timeline suggested in the fiat-crypto/cryptopt issue is to 1) get fiat C code merged, 2) then consider cryptopt 
08:21 < real_or_random> I don't think we want to deviate from this plan, so cryptopt depends on the fiat C code
08:21 < real_or_random> but we can still review the current cryptopt PR (even if we know we want to deal with fiat C first)
08:22 < sipa> But currently, the fiat-crypto code seems to be blocked by the int128 issue being resolved, while technically there is no real blocker for cryptopt (except our preference to do the fiat-crypto step first).
08:22 < real_or_random> right, we can certainly change plans here
08:24 < real_or_random> I think the only thing I'm saying in the end is: we could review the cryptopt PR right now. and maybe that helps him. perhaps just a tiny bit, but it's something. (getting it merged would of course be better, but I don't think we can manage, and I don't think we'll want to promise anything)
08:25 < sipa> I'll try to have a deeper look.
08:26 < real_or_random> ok
08:28 < real_or_random> more to say? more topics?
08:29 < sipa> i don't
08:30 < nickler> I probably don't have the bandwidth to review the cryptoopt PR until it has merge-priority.
08:30 < real_or_random> make sense
08:32 < real_or_random> end of meeting, I think
09:16 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
09:27 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
09:52 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
10:47 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
11:49 -!- Nebraskka [~Nebraskka@user/nebraskka] has quit [Server closed connection]
11:50 -!- Nebraskka [~Nebraskka@user/nebraskka] has joined #secp256k1
14:32 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
18:13 < roconnor> https://github.com/bitcoin-core/secp256k1/blob/30574f22ea0d158a0414323f8c350fa8ddcabd30/src/modinv64_impl.h#L252
18:13 < roconnor> A nanosecond could be saved by moving this line after the break.
18:14 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
18:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
18:20 < sipa> woah
19:22 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
19:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
21:54 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
21:55 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
23:48 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
--- Log closed Tue Jun 20 00:00:36 2023