--- Log opened Mon Sep 04 00:00:12 2023
00:01 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
00:46 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
02:28 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
03:39 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
03:46 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
04:21 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
04:27 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
05:32 < nickler> siv2r: "why do we need the adaptor_recover func to be const-time wrt to the signature?"
05:32 < nickler> Maybe there's not deeper meaning and this just sort of documents that this is the case. I don't see how it makes sense conceptually since both sig and adaptor sig are fed to the recoverer from the outside. It'd make very slightly more sense if the function was constant time wrt the adaptor sig.
05:32 < nickler> The important ctime test here is that ecdsa_adaptor_decrypt is CT wrt the deckey.
05:34 < hebasto> is today is a release day?
05:40 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
05:48 < nickler> I think so
05:48 < nickler> doesDoes https://github.com/bitcoin-core/secp256k1/pull/1295 need to be reflected in the change log? ("this affects this ABI and could affect downstream libs/apps in unintended ways")
05:51 < hebasto> yes, I guess; from https://github.com/bitcoin-core/secp256k1/pull/1295#issuecomment-1535137633
05:52 < sipa> right, it makes symbols invisible externally, in theory someone could be linking against them
05:53 < sipa> this os very borderline though, because these symbols are not even in our header files, so one would need some manual hacking of headers to even get to them
05:56 < hebasto> additionally, this message to the user is important by itself -- "Symbol visibility ... is now considered to be part of the ABI."
05:58 < sipa> if symbol visibility was not considered to be part of the ABI, then arguably a change in it isn't an observable ABI change...
05:58 < sipa> cfields: opinion?
06:01 < sipa> nickler: are you asking to include it in change logs, or because we may need to bump the library version number as a result?
06:21 < real_or_random> sipa:  when would you be available?
06:22 < sipa> i'm here now
06:23 < sipa> so (1) are there changes we still want to make (changelog or otherwise), and (2) what version number? 0.3.3 or 0.4.0
06:23 < nickler> 2) I think 0.4.0 since we added a new feature (ellswift)
06:23 < sipa> agree
06:24 < nickler> as for the visibility, I don't know exactly what this is about, just making sure that the change log is complete
06:24 < nickler> I haven't found anything else that would need to be added to the change log
06:25 < sipa> i think it's mostly CI/build/config changes
06:29 < hebasto> adding a new feature is considered as a backward compatible ABI change, right?
06:29 < sipa> yes
06:31 < hebasto> therefore, new libtool C:R:A should be 3:0:1
06:43 < real_or_random> yep, that sounds right
06:59 < sipa> semver 0.4.0, libtool 3:0:1; sounds right
07:14 < nickler> that'll result in libsecp256k1.so.2.1.0
07:15 < sipa> while the current one is libsecp256k1.so.2.0.3
07:31 < hebasto> I think v0.3.2 has `libsecp256k1.so.2.0.2` library name
07:31 < sipa> right
07:40 < real_or_random> hebasto: did you see the release PR?
07:43 < hebasto> real_or_random: +
07:46 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
08:15 < hebasto> was https://github.com/bitcoin-core/secp256k1/actions/runs/6074742473 cancelled manually or is it a bug?
08:15 < sipa> cancelled manually
08:15 < hebasto> okay then :)
08:38 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
09:04 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
09:18 -!- roconnor [~quassel@coq/roconnor] has quit [Ping timeout: 246 seconds]
09:20 -!- roconnor [~quassel@coq/roconnor] has joined #secp256k1
09:47 < hebasto> just a reminder -- https://github.com/bitcoin-core/secp256k1/releases still waits for 0.4.0 entry :)
09:48 < sipa> on it
09:49 < sipa> https://github.com/bitcoin-core/secp256k1/releases/tag/v0.4.0
09:50 < hebasto> \o/
09:53 < hebasto> real_or_random: suggesting to remove manually all runs from https://github.com/bitcoin-core/secp256k1/actions/workflows/release.yml to do not distract from the CI workflow
10:01 < real_or_random> oh I had not realized that these appear in a different category
10:01 < real_or_random> but I'm not sure if I understand your suggestion
10:02 < hebasto> https://usercontent.irccloud-cdn.com/file/bpALV3PS/image.png
10:03 < hebasto> after deleting all of them, the "Release" category will gone
10:04 < hebasto> or we could wait 90 days :)
10:09 < real_or_random> oh I see, sure, I can do that
10:10 < hebasto> cool
10:11 < hebasto> it looks tidy now :)
10:11 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
10:19 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
12:05 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
12:58 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
13:11 -!- RubenSomsen_ [sid301948@user/rubensomsen] has joined #secp256k1
13:11 -!- jarolrod___ [sid475272@id-475272.uxbridge.irccloud.com] has joined #secp256k1
13:12 -!- uasf_ [~uasf@2604:a880:2:d0::1bda:1001] has joined #secp256k1
13:12 -!- RubenSomsen [sid301948@user/rubensomsen] has quit [Ping timeout: 246 seconds]
13:12 -!- uasf [~uasf@2604:a880:2:d0::1bda:1001] has quit [Read error: Connection reset by peer]
13:12 -!- windsok_ [~windsok@rarepepe.cash] has quit [Read error: Connection reset by peer]
13:12 -!- jarolrod__ [sid475272@id-475272.uxbridge.irccloud.com] has quit [Ping timeout: 246 seconds]
13:12 -!- RubenSomsen_ is now known as RubenSomsen
13:14 -!- windsok [~windsok@rarepepe.cash] has joined #secp256k1
14:00 -!- roconnor [~quassel@coq/roconnor] has quit [Ping timeout: 240 seconds]
14:00 -!- roconnor [~quassel@coq/roconnor] has joined #secp256k1
14:16 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
14:47 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 246 seconds]
14:48 -!- achow101 [~achow101@user/achow101] has joined #secp256k1
18:46 -!- preimage [~halosghos@user/halosghost] has joined #secp256k1
20:06 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.0.3]
21:51 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
22:04 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
23:40 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
--- Log closed Tue Sep 05 00:00:13 2023