--- Log opened Mon Nov 13 00:00:24 2023 01:27 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 02:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 02:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 03:42 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Read error: Connection reset by peer] 04:51 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 05:20 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 05:21 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1 06:39 < sipa> If possible, I'd like to get some review on #1058 now... the math is similar (but easier) than #1184, it gives a >10% speedup for keygen/signing, and is otherwise mostly a bunch of build system changes 06:52 < bitcoin-git> [secp256k1] fanquake opened pull request #1441: asm: add .note.GNU-stack section for non-exec stack (master...avoid_exec_stack_ld) https://github.com/bitcoin-core/secp256k1/pull/1441 07:24 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 07:36 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 07:54 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 08:05 -!- preimage [~halosghos@user/halosghost] has joined #secp256k1 08:18 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection] 09:21 -!- achow101 [~achow101@user/achow101] has joined #secp256k1 09:49 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 10:12 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 10:32 < real_or_random> sipa: hm jonas and I will be pretty busy this week, and he's out next week. I'll see what I can do next week but perhaps stratospher or theStack are available, given they have looked also at 1184 10:33 < real_or_random> (good to hear that the math is easier than 1184, I thought it's harder...) 10:38 < sipa> no endomorphism :) 10:44 < real_or_random> aha 10:44 < real_or_random> ok, makes sense :) 10:45 < sipa> in theory the endomorphism could be used there too, but because it's in a precomputation setting, doing so doesn't reduce the number of doublings to perform 10:46 < sipa> so it'd just be a table size reduction, for a bit of extra CPU to apply the endomorphism 13:26 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 13:32 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 14:34 < roconnor> sipa: Did you know that https://github.com/bitcoin-core/secp256k1/blob/master/src/field_5x52_int128_impl.h#L162 is signed instead of unsigned? 14:42 < roconnor> also I don't immediately see how to establish the 114 bit here: https://github.com/bitcoin-core/secp256k1/blob/master/src/field_5x52_int128_impl.h#L215 14:42 < roconnor> In the _mul_ version the corresponding check is 115 bits. 14:42 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.1.0] 14:43 < sipa> roconnor: i mean, i can read! 14:43 < roconnor> (keep in min that a4 was doubled in https://github.com/bitcoin-core/secp256k1/blob/master/src/field_5x52_int128_impl.h#L192). 14:43 < sipa> int64_t certainly looks signed 14:43 < sipa> but i'm very surprised that there are any signed variabled in there 14:43 < roconnor> Just a bit odd that it is unsigned in the _mul_ version, and then you do bit shifting with the signed value. 14:47 < sipa> it appears to be a typo introduced here: https://github.com/bitcoin-core/secp256k1/commit/25b35c7ecb4419f3ca8cae0acf31a9ebe1d0a2e9#diff-35bbd3490af4fba588fa0e1cabfb6642d198e639170a6efc0b8dd5ee44d214b2R158 15:02 < roconnor> Everything else seems to check out other than that one VERIFY_BITS_128(&d, 114); on line 215. 15:02 < roconnor> I wonder if I can make that fail. 15:07 < roconnor> hmm, seem it might be true. 15:14 < roconnor> Okay I managed to establish the tigher bound. 15:29 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 17:13 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 240 seconds] 20:00 -!- theStack [~theStack@95.179.145.232] has quit [Server closed connection] 20:48 -!- siv2r [~siv2r@ec2-13-233-108-143.ap-south-1.compute.amazonaws.com] has quit [Server closed connection] 20:48 -!- siv2r [~siv2r@ec2-13-233-108-143.ap-south-1.compute.amazonaws.com] has joined #secp256k1 21:41 -!- windsok [~windsok@rarepepe.cash] has quit [Server closed connection] 21:42 -!- windsok [~windsok@rarepepe.cash] has joined #secp256k1 21:56 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has quit [Server closed connection] 21:56 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has joined #secp256k1 22:16 -!- real_or_random [sid554204@user/real-or-random/x-4440763] has quit [Server closed connection] 22:16 -!- real_or_random [sid554204@user/real-or-random/x-4440763] has joined #secp256k1 23:34 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 --- Log closed Tue Nov 14 00:00:25 2023