--- Log opened Fri Apr 19 00:00:31 2024
00:11 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
00:13 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
01:08 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Read error: Connection reset by peer]
01:44 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
02:48 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
03:37 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
04:00 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
05:32 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
05:37 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
07:14 -!- preimage [~halosghos@user/halosghost] has joined #secp256k1
07:15 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
07:21 < bitcoin-git> [secp256k1] josibake opened pull request #1519: Add BIP352 `silentpayments` module (master...bip352-silentpayments-module) https://github.com/bitcoin-core/secp256k1/pull/1519
07:33 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
07:35 < josie> do you all have a preference for PR format? was looking through a few of the larger, open PRs and noticed the commits are larger and review is addressed with fixup! commits. im more in the habit of many small commits and force pushing to the branch, but happy to adjust the format if there is a preference here
07:42 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
08:25 < nickler_> I don't as long as it makes sense. If commits can be broken up into smaller, self-contained, commits I think that's generally better. E.g. the pubkey_sort PR could be two commits - one for the internal API and one for secp256k1_pubkey_sort.
08:26 < nickler_> force push seems fine too. When I review I have a local branch that I can compare with the force-pushed version. But I think it makes sense to sometimes highlight specific fixups in separate commits.
08:27 < nickler_> Also some branches are more difficult to apply fixups to. So it saves some time to make fixup commits until review has mostly concluded and then squash only once.
08:45 < josie> nickler_: thanks! useful context
09:00 -!- preimage [~halosghos@user/halosghost] has quit [Ping timeout: 240 seconds]
09:12 -!- preimage [~halosghos@user/halosghost] has joined #secp256k1
09:17 < bitcoin-git> [secp256k1] real-or-random closed pull request #1471: Add silentpayments (BIP352) module (master...silentpayments-module-demo) https://github.com/bitcoin-core/secp256k1/pull/1471
10:45 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
10:49 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
11:20 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
11:21 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
11:45 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
11:49 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
11:49 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
11:54 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
12:00 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.2.2]
13:23 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
13:24 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
13:31 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Read error: Connection reset by peer]
15:00 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
15:02 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
17:06 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
17:07 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
17:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Quit: Leaving]
17:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
17:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 260 seconds]
17:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
21:19 < stratospher[m]> https://github.com/bitcoin-core/secp256k1/pull/1058/commits/fde1dfcd8d0a2a6444491b235d9ae2926f4ad7f4#r1554856207 - `points_total` isn't used inside the loop where u = gen/2 is calculated, then how does doing `VERIFY_CHECK(points_total > 0)` help?
--- Log closed Sat Apr 20 00:00:32 2024