--- Log opened Sun May 03 00:00:11 2020
07:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
07:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo
08:05 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #utreexo
09:32 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:12 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #utreexo
10:23 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:38 < kcalvinalvin> Ok so I knew this was gonna bite us eventually.. :/ but the heights are being called wrong and I think that's the problem
10:40 < kcalvinalvin> Way back when everything was in text, parseblock would get everything from blk*.dat and every following binary was based off of that. So when you call the first line, it gave you the block #1 not block #0
10:41 < kcalvinalvin> So to keep compatibility with that, I made the GetRawBlocksFromFile() ignore block 0. So when you pass 0 as the height value, it would give you block #1
10:42 < kcalvinalvin> Right now in the latest master, we're calling GetRawBlocksFromFile() with 1 so it's giving us block #2
10:43 < kcalvinalvin> So all the heights are messed up... I'll make a PR that has the GetRawBlocksFromFile() actually give you block #1 when you give it 1
10:48 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #utreexo
10:53 < ja> sounds good!
13:20 < kcalvinalvin> #PR 120 adds the mentioned documentation. Ended up being cleaner since all the directories are already moved heh
13:20 < kcalvinalvin> Rebasing...... was not fun
13:20 < kcalvinalvin> until I realized I'm not changing much
13:21 < kcalvinalvin> I'll push the changed I mentioned above later today/tomorrow
13:30 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:55 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #utreexo
15:47 < adiabat> kcalvinalvin: I think I fixed the heights thing on friday?
15:47 < adiabat> what I changed was:
15:48 < adiabat> now when you make calls to GetRawBlocksFromFile() or the rev version, and ask for block 0, it will return an error
15:49 < adiabat> but if you don't ask for block 0, it decrements the block height by one and gets that.  So asking for block 1 will give you byte offset 0
15:49 < adiabat> This seems to work OK; the heights agree with the heights stored in rev block data.
15:50 < adiabat> maybe there's a cleaner way to do it but I think the height problem is fixed
15:50 < adiabat> it's in a9af95c65c7e54ace029a8992b316da501b325ff which is the most recent commit to master
15:51 < adiabat> just don't want you to write another fix 
15:52 < adiabat> (I mean you can if you don't like mine heh)
15:52 < adiabat> (just wanted you to at least know about mine first)
16:17 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds]
17:07 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Quit: jb55]
18:04 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo
21:04 < kcalvinalvin> Is the current master working for you on testnet3?
21:06 < kcalvinalvin> I'm crashing at around when the spends start happening (to be exact, I'm crashing at block #387)
21:07 < kcalvinalvin> Yeah I did see the off by 1 fixes commit
21:07 < kcalvinalvin> I don't know... but it is crashing earlier than before...
21:07 < kcalvinalvin> I'll dig around today
--- Log closed Mon May 04 00:00:11 2020