--- Log opened Wed May 13 00:00:19 2020 01:25 < kcalvinalvin> In pollard.go, rem2(), a lot of ```var hn *hashableNode``` have same position 01:25 < kcalvinalvin> is this the expected result? 01:28 < kcalvinalvin> There's also duplicate destinations. I'm guessing this is 2 different pair of cousins sharing an aunt? 03:43 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 03:55 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo 04:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 04:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo 04:16 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 04:24 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo 06:03 < adiabat> ja: huh, had not seen that. I guess it's standard library so can use it 06:04 < adiabat> kcalvinalvin: yeah added it when I changed pollard save /load. seems simpler this way and isn't dependent on being a file, so could be to a network 06:05 < adiabat> hn *hashableNodes having the same position is not great, I know why it happens... 06:05 < adiabat> I think there's deduplication so it doesn't actually hash twice? 06:07 < adiabat> but possibly not everything, given line 202 - " // TODO this doesn't cover eveything " 06:07 < adiabat> duplicates happen frequently on higher rows 06:08 < adiabat> e.g in printout.txt bottom tree 06:09 < adiabat> if 01, 04 have both changed, then 08 needs to be hashed (due to 01) and 10 needs to be hashed (due to 04) 06:09 < adiabat> then 12 and 13, because of 08 and 10 06:09 < adiabat> and then 14, twice 06:09 < adiabat> both because of 12 and because of 13 06:10 < adiabat> so that ends up in the nextHashDirt, which should get deduped on line 168... 06:12 < adiabat> but there are other ways as well, like 06:12 < adiabat> sometimes you have 2 swaps of the same element on the same row, like swap (04, 05) and (02, 04) 06:13 < adiabat> I don't know how much duplicate work is being done, hopefully there aren't many cases of hashing the same thing more than once 06:13 < adiabat> if there are, it's worth it to catch those before it happens since hashing is probably a lot slower than the code to move stuff around 06:14 < adiabat> hmmm also dedupeSwapDirt() doesn't *actually* dedupe! 06:15 < adiabat> it dedupes *between* the two slice arguments, but not if the a argument has duplicates 06:16 < adiabat> so... hm yeah maybe there's duplicate hashing / work still going on, you're welcome to check for that 06:16 < adiabat> i'm in network world now, which... eh not the most exciting but whatever 23:28 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Ping timeout: 260 seconds] 23:36 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #utreexo --- Log closed Thu May 14 00:00:20 2020