--- Log opened Sun May 24 00:00:30 2020 11:10 < dergoegge> hey guys! i am computer science student from Berlin and i would like to contribute some more to utreexo. any pointers on what i should work on? 11:41 < ja> dergoegge: IMHO some more comments in the algorithms would be nice 11:41 < ja> dergoegge: people seems to want a script interpreter to enable full-node equivalent security, the others can talk to you about that 11:42 < ja> dergoegge: maybe check out if kcalvinalvin has some branches to see what he is working on 12:12 -!- dergoegge [~dergoegge@196.240.57.220] has quit [Ping timeout: 265 seconds] 12:54 -!- dergoegge [~dergoegge@196.240.57.220] has joined #utreexo 12:55 < ja> dergoegge: did you see my problem with dedupeSwapDirt ? maybe you can confirm the bug or tell me if i am wrong 12:59 < ja> dergoegge: ah, calvin just sent a new PR 16:09 < dergoegge> ja: can confirm thats either a bug or the documentation of dedupeSwapDirt is inaccurate. 16:14 < ja> thanks. i think it is most likely a bug, would be weird to write the docs if there were such a weird edge case. probably an off-by-one 16:15 < ja> would be awesome if it could explain the problems people have been having syncing testnet 16:15 < dergoegge> ja: should i look into fixing it or do you want to do that? 16:16 < ja> dergoegge: i think it would be a great first issue, so if you want, please go ahead! 16:17 < dergoegge> ja: ok great 17:09 < dergoegge> ja: not an off-by-one but still an easy fix: #129 17:11 < dergoegge> are these testnet issues documented somewhere? 18:23 < ja> dergoegge: no, but if you try syncing to testnet, it halts somewhere, should be easy to reproduce. but you need the testnet chain of course 18:32 < dergoegge> ja: just ran into that issue. i opened a issue on github #130. is that what other people have been reporting aswell? 18:33 < dergoegge> i had the same issue for the current master and the branch with my fix for dedupeSwapDirt 18:41 < ja> hmm i don't know, because i havn't tried recently. but probably tadge will come on in about 12 hours and he can tell you 18:41 < ja> thanks for the fix! 20:45 < rjected> adiabat: Can you explain to me what you mean by "within its arguments"? Do you just mean the arguments should be modified in dedupeSwapDirt()? 20:58 < rjected> we can for sure do that, but there would be exra elements in `a` if any dedupe actually happened. It would also prevent needing to allocate the `c` array (can just modify `a` itself and return a slice of `a`) 21:04 < rjected> you'd always have to overwrite the first argument with the return value though 21:05 < kcalvinalvin> dergoegge I left a comment on issue #130 --- Log closed Mon May 25 00:00:31 2020