--- Log opened Tue May 26 00:00:31 2020 05:42 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has joined #utreexo 08:32 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 08:37 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo 09:43 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has quit [Ping timeout: 264 seconds] 10:11 -!- dergoegge [~dergoegge@ip5b41d881.dynamic.kabel-deutschland.de] has joined #utreexo 10:12 -!- fanquake [sid369002@gateway/web/irccloud.com/x-phqdamalznlcbqrw] has quit [Ping timeout: 265 seconds] 10:14 -!- fanquake [sid369002@gateway/web/irccloud.com/x-xwnmppxqhszbxoka] has joined #utreexo 10:16 -!- dergoegge [~dergoegge@ip5b41d881.dynamic.kabel-deutschland.de] has quit [Ping timeout: 272 seconds] 10:16 -!- dergoegg1 [~dergoegge@196.240.57.156] has joined #utreexo 11:32 -!- dergoegg1 [~dergoegge@196.240.57.156] has quit [Ping timeout: 258 seconds] 12:32 < adiabat> We have received several complaints about variable names and the official utreexo steering committee is looking in to the matter 12:33 < adiabat> heh but ok what should things be called, like in types.go lines 68-96 or so 12:33 < adiabat> bitcoin blocks are just... "blocks" 12:33 < adiabat> along side that block there's the accumulator proof, which is a bunch of hashes and some int64s 12:34 < adiabat> and also the leafData for every input spent. 12:34 < adiabat> right now it's 12:34 < adiabat> bitcoin block: block 12:35 < adiabat> extra data associated with that block: UData 12:35 < adiabat> block and UData together: UBlock 12:36 < adiabat> or maybe don't even stick the accumulator proof and leafdata slice together into the same struct? 12:36 < adiabat> then a "UBlock" would just be - block, accumulator proof, []leafdata 12:37 < adiabat> (oh and rememberLeaves which I guess could also be merged into the accumulator.BatchProof if that's easier 15:07 < adiabat> also I can't figure out how to do the UtxoViewpoint without changing btcd; everything is unexported 15:07 < adiabat> just need to capitalize a bunch of stuff then it'll work 15:10 < ja> adiabat: i use vim-go , it has a command called GoRename which does everything automatically. i think it calls into gopls 15:11 < adiabat> for the UBlock structs? 15:11 < adiabat> Yeah my IDE can rename everything too, I was just wondering if people have better names 15:11 < ja> aaah ok 15:11 < adiabat> kcalvinalvin didn't seem to like the names :) 15:11 < ja> which IDE do you use? 15:11 < adiabat> LiteIDE 15:11 < adiabat> it's go-specific and pretty simple but I like 15:12 < adiabat> *it 15:58 -!- dergoegge [~dergoegge@196.240.57.204] has joined #utreexo 16:13 < dergoegge> adiabat: UtxoViewpoint has methods to add tx outputs: *AddTxOut*, not 100% sure if that works as needed though 17:17 < adiabat> dergoegge: unfortunately it doesn't fit, it needs a transaction, and adds all its outputs 17:17 < adiabat> we don't have transactions, just utxos 17:18 < adiabat> I made a NewUtxoEntry() function for btcd, it's super simple and I just coped the clone() method 17:18 < adiabat> func NewUtxoEntry(amount int64, pkScript []byte, blockHeight int32, isCoinbase bool) *UtxoEntry { obvious } 17:19 < ja> obvious, my favorite language keyword ;) 17:21 < ja> adiabat: is the output of updateDirt supposed to be unique? because it is not 17:22 < ja> i mean, i have repeating values like 140, 141, 140, 141... 21:08 < kcalvinalvin> adiabat I'll clean up my re-naming PR and push it this week 21:46 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Quit: ZNC 1.7.4+deb7 - https://znc.in] 21:47 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined #utreexo --- Log closed Wed May 27 00:00:32 2020