--- Log opened Fri May 29 00:00:37 2020
01:23 < kcalvinalvin> Just looked at PR #135 and it works well. Just have to get a PR into btcd...
01:24 < kcalvinalvin> Maybe coax them by presenting this as a first PR of the whole Utreexo implementation later down the road? (which I want to do)
05:31 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has quit [Ping timeout: 246 seconds]
05:34 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has joined #utreexo
07:19 < adiabat> rjected: can you ask btcd people?  I think the NewUtxoEntry() is super minimal change that they'd be cool with but you know more about what they're working on?
07:19 < adiabat> also yeah #135 works and checks all the signatures but it's slow... 
07:19 < adiabat> which I mean, yeah
07:20 < adiabat> checking signatures is the slow part
07:20 < kcalvinalvin> #137 is the backup I guess. One thing I'm working out but it should also work
07:21 < kcalvinalvin> after that thing is worked out
07:27 < adiabat> OK... I mean, I really like the #135 way better and think exporting just that will be OK...
07:27 < adiabat> so I don't want you to spend a ton of effort on other ways and we don't end up using it...
07:27 < adiabat> but yeah #135 is fun with the dedupe
07:27 < adiabat> that took some figuring out but I like it
07:28 < adiabat> and I *think* it protects against misordered dedupe.  Though not on the genproofs side, but we're not checking consensus on genproofs side anyway
07:29 < adiabat> also I could try hooking more in to the attach block btcd stuff but... for now checking all txs/sigs is pretty good
07:29 < adiabat> but... yeah there is all that like, soft forks and stuff to deal with
07:33 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined #utreexo
07:38 < kcalvinalvin> I do like the fake UtxoView thingy. I think the rev stuff may be out of order..? Can't fail with utxoview
08:02 < adiabat> rev stuff is out of order?  I think it's in the right order
08:03 < adiabat> but yeah, the fact that it's a map lets you add things in on the fly, like the dedupe output skiplist
08:03 < adiabat> which seems to work; I manually tried to get it to fail and it seemed to work
08:04 < kcalvinalvin> Yeah idk what's going on with my branch
08:05 < kcalvinalvin> Besides mempool, what's the next "big" feature to finish?
08:05 < kcalvinalvin> Lots of small cleansups/fixes todo
08:07 < rjected> adiabat: yeah I can ask
08:11 < rjected> I'm just going to put an issue up on btcd and tag people to get opinions
08:12 < rjected> It would be best though if accompanied by a PR
08:15 < rjected> I guess now that I think about it, maybe a PR is the best place to have discussion so I'll just ping ppl on irc
08:16 < adiabat> I can make the NewUtxoEntry() PR
08:17 < adiabat> it's 15 lines or something
08:17 < adiabat> https://github.com/mit-dci/utreexo/pull/135/files#diff-3f7b8f9991ea957f1f4ad9f5a95415f0R104-R117
08:17 < adiabat> or you can, whichever works better :)
08:19 < kcalvinalvin> adiabat ibdsim doesn't resume right now right?
08:19 < kcalvinalvin> And ttl values aren't being used as well right?
08:26 < rjected> If you change the value/pkscript params to a *wire.TxOut then I think it would be all good
08:26 < rjected> Like I would hit "approve" on review
08:27 < adiabat> kcalvinalvin: I think IBDsim is still OK with resuming
08:27 < adiabat> ttl is not used now though
08:28 < adiabat> rjected: you think they'll want a *wire.TxOut instead of amount int64, pkScript []byte?
08:28 < adiabat> sure either way works
08:36 < rjected> It doesn't really matter too much it's really just a nit because the type is already there, like why not use it
08:41 < rjected> oh crap I just remembered we can't actually merge anything because roasbeef needs to turn off travis
08:43 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has quit [Ping timeout: 264 seconds]
08:46 < rjected> fun times in btcd land
08:57 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has joined #utreexo
08:57 < adiabat> turn off travis...? huh
08:59 < kcalvinalvin> Oh yeah cuz github integration with travis literally blocks merging if travis doesn't pass
08:59 < adiabat> fun :)
09:15 < rjected> yep, and this #1575 pr got merged which removed the Travis yml (we're switching to GitHub actions) so now travis is confused and can't run, so nothing passes and nothing is mergeable
09:17 < adiabat> ok made PR #1588 in btcd
09:17 < adiabat> looking at it though, really they should change AddTxOut()... 
09:17 < adiabat> but whatever, either way is fine
09:22 < rjected> changing AddTxOut would be a larger change and is also changing the signature of an exported function so a little more controversial
09:24 < rjected> but it being controversial depends on whether or not people are actually using that function
09:24 < rjected> I don't think people are, and stuff gets changed all the time
09:25 < rjected> but yeah
10:40 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 246 seconds]
10:56 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has quit [Ping timeout: 240 seconds]
11:06 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has joined #utreexo
11:16 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has quit [Read error: Connection reset by peer]
11:21 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has joined #utreexo
12:01 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined #utreexo
13:14 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has quit [Read error: Connection reset by peer]
13:17 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has joined #utreexo
14:09 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 264 seconds]
18:40 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:48 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #utreexo
19:03 < rjected> travis is removed, cool stuff
19:13 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:32 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has left #utreexo []
19:46 -!- dergoegge [~dergoegge@196.240.57.44] has joined #utreexo
19:47 -!- dergoegge [~dergoegge@196.240.57.44] has quit [Client Quit]
20:15 < ja> rjected: what do you mean? utreexo never used travis
20:16 < kcalvinalvin> ja he's talking about btcd. They had a problem where you couldn't merge anything to btcd since travis was giving an error for all PRs
20:16 < ja> ah ok, thanks 
20:16 < kcalvinalvin> https://github.com/btcsuite/btcd/pull/1588
20:16 < kcalvinalvin> relevant I guess
20:27 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined #utreexo
20:48 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #utreexo
21:15 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:07 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
23:10 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo
23:40 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 265 seconds]
--- Log closed Sat May 30 00:00:37 2020