--- Log opened Tue Jun 02 00:00:41 2020 00:05 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined #utreexo 03:45 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 246 seconds] 04:32 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 04:36 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo 06:19 < adiabat> hey utreexo dev call in ~10 min @ meet.jit.si/utreexo 06:20 < adiabat> actually I might be a couple min late so say 9:35 06:45 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined #utreexo 07:35 < rjected> ok adiabat/dergoegge/kcalvinalvin you're all invited to rjected/btcd 07:35 < rjected> I can cherry pick the utxoview commit if you want? 07:36 < adiabat> sure that works, then we could change imports and merge #135 07:40 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has joined #utreexo 07:42 < rjected> alright cherry-picked 07:44 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 246 seconds] 08:29 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Read error: Connection reset by peer] 08:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 08:32 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo 08:32 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #utreexo 09:28 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined #utreexo 10:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 10:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #utreexo 11:11 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 246 seconds] 12:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 12:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #utreexo 12:52 < dergoegge> should the accumulator panic? i mean it's not that important but its more go-like to have libs not panic but instead return errors. 12:57 < dergoegge> also what would you guys think of a separate package for all this blk/rev/index file stuff? 13:32 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined #utreexo 14:07 -!- dergoegge [dergoegge@gateway/vpn/nordvpn/dergoegge] has quit [Quit: leaving] 14:08 < rjected> Yeah I think in go panics are usually avoided in favor of errors unless the rest of the program can't run anyways due to the thing causing the panic 14:53 < rjected> also we might wanna look at btcd/blockchain/fullblocktests if we want to easily test stuff like reorgs and whatnot 16:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 16:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #utreexo 16:09 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 16:23 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo 17:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 17:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #utreexo 20:16 < ja> looks like elements passed to dedupeSwapDirt are not sorted 21:38 < ja> sent a PR to fix it 22:07 < ja> regarding panics, i think an internal function should definitely panic if its contract is violated. go has a weak type system, it is basically impossible to restrict the types such that no illegal parameters can be passed 22:07 < ja> if we wanted no panics, basically every function would then have to return error. it pollutes the type signatures 22:09 < ja> we should document function invariants and make sure we do not violate them 22:10 < ja> why doesn't the division operator return error in go? ;) because some operations have contracts that the caller is responsible for keeping 22:47 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 264 seconds] --- Log closed Wed Jun 03 00:00:40 2020