--- Log opened Tue Nov 24 00:00:25 2020
00:55 -!- reallll is now known as belcher
04:53 < adiabat> bip30...? making sure coinbase txs say what height they are?
04:53 < adiabat> I don't think utreexowould affect that, the node still knows what height blocks are and can check that the coinbase input says that
04:54 < adiabat> there's no "proof" as its coinbase, but there's still a validation step.  So I guess we have to make sure we don't skip it, as usually there will be both
08:08 < kcalvinalvin> It reads in btcd that there shouldn't be a new tx with an hash that matches one of the utxo's txhash
08:08 < kcalvinalvin> So it does a map read to see if there is a match among all the utxos
08:09 < kcalvinalvin> func (b *BlockChain) checkBIP0030 in blockchain/validate.go
08:10 < kcalvinalvin> Not relevant?
08:19 < kcalvinalvin> oh btw adiabat did you get started on the messages?
08:19 < kcalvinalvin> I think I have time to give it a go if you haven't
11:20 < adiabat> kcalvinalvin haven't done messages yet
11:20 < adiabat> will probably do matchknown then messages
11:21 < adiabat> "So it does a map read to see if there is a match among all the utxos" -- what what????
11:24 < adiabat> func (b *BlockChain) checkBIP0030() ... how about that
11:24 < adiabat> I assume bitcoind doesn't do this...
11:28 < adiabat> yeah so that's another thing we could do to improve btcd -- take this whole thing out
11:28 < adiabat> the *only* way to make a transaction with a colliding txid is the coinbase transaction.  or hash collision in which case, whatever, all bets are off
11:29 < adiabat> so there's no point in ever checking non-coinbase txs for colliding txids
11:31 < adiabat> also:
11:31 < adiabat> utxo := view.LookupEntry(outpoint)
11:31 < adiabat> if utxo != nil && !utxo.IsSpent() {
11:32 < adiabat> IsSpent()...? do the DB returns spent txos..?
11:34 < adiabat> hm.  OK I'm thinking of bip34, which... supercedes bip30?
11:35 < adiabat> so maybe the isBIP0030Node isn't true anymore because once bip34 is enfoced, you don't need bip30 anymore
11:35 < adiabat> and maybe the bip30 code is left in for like testing / testnet / pre-soft fork etc
19:40 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #utreexo
19:55 -!- reallll [~belcher@unaffiliated/belcher] has joined #utreexo
19:57 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
22:25 < kcalvinalvin> adiabat ok I'll get started on messages
22:38 < kcalvinalvin> hmmm seems like bitcoind does something similar. src/validation.cpp, line 2045, on master (specifically commit 31c9987976af8ac5ad40091256ac41a2ccb078cd)
22:40 < kcalvinalvin> It does say the BIP30 checking is only done if BIP34 is not activated yet
--- Log closed Wed Nov 25 00:00:26 2020