--- Log opened Wed Apr 28 00:00:39 2021
00:57 < kcalvinalvin> https://github.com/mit-dci/utreexo/issues/263
00:58 < kcalvinalvin> So we've been putting in the target hashes so it makes sense to lift the 1<<16 limit
02:23 -!- stevenroose [~steven@irc.roose.io] has quit [Ping timeout: 252 seconds]
02:24 -!- stevenroose [~steven@irc.roose.io] has joined #utreexo
06:36 < adiabat_> What do you mean by "putting in the target hashes"?
06:37 < adiabat_> "targets" should be the UTXOs that are getting spent in the block, and the positions of the corresponding leaves
06:39 < adiabat_> On github, when you say "we're adding extra data besides the proofs so it's possible to be greater than 1<<16", I don't see it
06:40 < adiabat_> If we are, that's a bug and we shouldn't be.  But in lines 176-183, len(sortedTargets) == len(bp.Targets), right?
07:40 < kcalvinalvin> adiabat_: https://github.com/mit-dci/utreexo/issues/263#issuecomment-828225486
07:40 < kcalvinalvin> 187-189
11:24 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo
11:56 < adiabat_> There are 2 checks, numTargets and numHashes
11:57 < adiabat_> the numHashes check is probably wrong, but the issue & code here relates to numTargets
11:58 < adiabat_> or were we only getting errors with numHashes?  Because yeah I can see how numHashes could go over 65K in some cases
12:45 < kcalvinalvin> We were only getting numHashes
12:46 < kcalvinalvin> Sorry :( I was meaning "numHashes" when I was saying "numTargets"
12:46 < kcalvinalvin> (I do this too often don't I)
13:00 < adiabat_> ah OK yeah numTargets shouldn't be limited... or like a million or something as a sanity check
13:00 < adiabat_> I can fix that now
13:00 < adiabat_> er
13:00 < adiabat_> argh
13:00 < adiabat_> numHASHES shouldn't be limited
13:00 < adiabat_> numTargets should still be limited; if there are more than 32K targets something is wrong
13:01 < adiabat_> but a few hundred thousand hashes seems possible in some cases
20:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
20:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #utreexo
22:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
22:14 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #utreexo
--- Log closed Thu Apr 29 00:00:40 2021