--- Log opened Thu Aug 12 00:00:36 2021
12:28 < adiabat> kcalvinalvin: question about .rev blocks
12:28 < adiabat> do they contain data about inputs that are created in the same block?
12:29 < adiabat> my guess is they do, but that seems pointless; they don't need to
12:29 < adiabat> maybe that's just an optimization they haven't bothered with in bitcoind?
12:30 < adiabat> I think part of one of the bugs was that I was assuming things created / destroyed in the same block wouldn't show up in the rev data
13:50 -!- nemo_ [lukechampi@2600:3c03::f03c:91ff:fe55:92ba] has quit [Ping timeout: 252 seconds]
13:55 -!- nemo_ [~lukechamp@li640-31.members.linode.com] has joined #utreexo
16:55 -!- rjected [~rjected@2001:470:69fc:105::949] has quit [Ping timeout: 252 seconds]
18:14 < kcalvinalvin> adiabat: I believe they do
18:14 < kcalvinalvin> https://github.com/bitcoin/bitcoin/blob/21438d55d553ae5bf3be7c0d4431aaf136db6c6b/src/validation.cpp#L1875-L1942
18:15 < kcalvinalvin> This is the loop where things get added to the rev.dat (variable blockundo)
18:16 < kcalvinalvin> I don't see any dedupe stuff that we have in our binaries
18:16 < kcalvinalvin> https://github.com/bitcoin/bitcoin/blob/21438d55d553ae5bf3be7c0d4431aaf136db6c6b/src/validation.cpp#L1938-L1940
18:17 < kcalvinalvin> The only time they don't add to the blockundo is when i == 0 (i being the tx index in the block)
18:17 < kcalvinalvin> Also, 304 is ready to merge
19:53 -!- rjected [~rjected@2001:470:69fc:105::949] has joined #utreexo
22:19 < kcalvinalvin> Ok am looking again at issue 285. Looked at your comment dergoegge
22:20 < kcalvinalvin> I think I'm just gonna re-implement things by just adding a bool field in polNode
22:20 < kcalvinalvin> Like.. this *is* consensus code and it shouldn't be this hard for us to figure things out
22:20 < kcalvinalvin> Whatever memory we're saving by doing n.niece[0] = n isn'
22:20 < kcalvinalvin> t worth the complexity in my opinion
--- Log closed Fri Aug 13 00:00:37 2021