--- Log opened Wed Aug 21 00:00:47 2019 03:13 < jonasschnelli> Would adding a freebsd image to bitcoinbuilds.org make sense (build a job on freebsd)? 03:14 < fanquake> jonasschnelli: probably. We sort of run BSD builds on cirrus at the moment. 03:19 < jonasschnelli> Yes. Right. 03:23 < jonasschnelli> I guess I should look at cfields "keep all depends" concept... the cache storage consumption of bitcoinbuilds.org is currently around 700GB (keep last 30 days) 05:04 < jonasschnelli> The functional test together with the sanitizers do now also run on bitcoinbuilds.org 05:04 < jonasschnelli> The issue was that BITCOIN_CONFIG was not exported (env) 06:08 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-jlacsifbunngnxdy] has joined #bitcoin-builds 06:37 < jonasschnelli> does travis actually build the shahead that was requested or just the HEAD? I think it does build the HEAD, right? 06:38 < jonasschnelli> During the test run, it calls "git fetch origin +refs/pull/16654/merge:" 06:39 < jonasschnelli> So I assume regardless of the head that was present during the build-request, it builds the head 06:39 < jonasschnelli> (i mean the PR head) 06:55 < jonatack> Dumb question: I've been testing depends builds for `RAPIDCHECK=1 make`. It builds fine, but how to run make check? I'm seeing "make: *** No rule to make target 'check'. Stop." 06:55 < fanquake> Are you trying to run make check in depends? 06:57 < jonatack> Yes. I wanted to verify by running tests. Make check from root isn't picking up the install. Am I missing a flag? 06:59 < fanquake> Running which tests? There isn’t a make check target in depends. 07:02 < jonatack> Right. Depends builds are only for building? How are they used afterward? I'm probably missing something obvious here. 07:03 < dongcarl> jonatack: Haha I've made this mistake before lol 07:04 < dongcarl> Depends's main purpose is to build shared libraries that bitcoin can link against 07:04 < fanquake> Once you’ve down a depends build “make -C depends/“ from inside bitcoin/, you pass the prefix that is created to Bitcoin Cores configure. i.e ./configure —prefix=/path/to/some/depends/prefix 07:04 < dongcarl> It doesn't have any checks, but I guess you could 07:05 < fanquake> I shall tag in dongcarl, as I need to sleep 😴 07:05 < dongcarl> fanquake: Any reviews you wanna throw my way? 07:05 < dongcarl> (as in reviews I need to do) 07:06 < jonatack> thanks! makes sense 07:07 < jonatack> fanquake: updated the rapidcheck makefile. g'nite 07:08 < fanquake> dongcarl: can you take a look at my windows linker PR. I feel like the build failure that Marco posted isn’t related, as the bots gitian builds seemed to have worked fine? I feel like I’ve seen his error message elsewhere before. 07:08 < fanquake> dongcarl: Or, you could concept ACK / NACK my osslsigncode PR. 07:08 < dongcarl> fanquake: Cool, will definitely take a look at windows linker as I've been working on that 07:08 < fanquake> Thanks in advance 👍 07:08 < fanquake> jonatack: no worries. 07:14 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-jlacsifbunngnxdy] has quit [Ping timeout: 250 seconds] 07:14 -!- dongcarl [sid321684@gateway/web/irccloud.com/x-afidupeuhgxebcrz] has quit [Ping timeout: 250 seconds] 07:16 -!- gertjaap [sid322815@gateway/web/irccloud.com/x-dafwzvlhafrrkgpr] has quit [Ping timeout: 250 seconds] 07:18 -!- gertjaap [sid322815@gateway/web/irccloud.com/x-ljopdyjrxzicveyy] has joined #bitcoin-builds 07:18 -!- dongcarl [sid321684@gateway/web/irccloud.com/x-mqyoooxnrjpulpen] has joined #bitcoin-builds 07:19 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-virceihzfqfvnmqe] has joined #bitcoin-builds 07:31 < dongcarl> MarcoFalke: wen c++17? 07:43 < cfields> fanquake: windows linker PR? 07:44 < dongcarl> cfields: https://github.com/bitcoin/bitcoin/pull/16667 08:52 < cfields> fanquake: found your problem there :) 08:58 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-builds 10:52 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 250 seconds] 11:05 -!- jonatack [~jon@jau64-1-88-171-168-34.fbx.proxad.net] has joined #bitcoin-builds 11:19 -!- jonatack [~jon@jau64-1-88-171-168-34.fbx.proxad.net] has quit [Ping timeout: 276 seconds] 11:20 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-builds 12:41 < MarcoFalke> dongcarl: wen c++14? 12:42 < MarcoFalke> https://github.com/bitcoin/bitcoin/pull/15262 😭 12:43 < MarcoFalke> [09:39] So I assume regardless of the head that was present during the build-request, it builds the head 12:43 < MarcoFalke> No, it builds the pull merged with master 12:45 < dongcarl> MarcoFalke: Well... I think 17 has a lot of useful features that 14 doesn't... like optional and variant that can make future code more readable 12:46 < dongcarl> in the words of gmax: "(C++17 OTOH...)" 12:46 < MarcoFalke> have you seen src/optional.h ? 12:46 < MarcoFalke> Someone should do that for variant 12:47 < MarcoFalke> C++14 makes lambdas more usable 12:47 < MarcoFalke> but yeah, mostly minor stylistic stuff 12:49 < dongcarl> MarcoFalke: Okay now, using boost is just cheating :p 12:50 < MarcoFalke> We are stuck with boost due to https://en.cppreference.com/w/cpp/experimental/fs/path anyway, soooo .... 12:52 < dongcarl> MarcoFalke: I feel like this is your roundabout way of making me work on using BCP on our codebase :p 12:55 < MarcoFalke> someone should remove boost::chrono and boost::thread first 12:55 < MarcoFalke> by then std::fs will be a thing and we can remove it as well 13:11 < jonasschnelli> [21:43:16] No, it builds the pull merged with master 13:12 < jonasschnelli> ^ yes. But always the pull head and not the head that was present while requesting the build 13:12 < jonasschnelli> (AFAIK) 13:12 < MarcoFalke> Why would they be different 13:13 < MarcoFalke> Oh, yeah if you force push it will build the later version 13:15 < MarcoFalke> I think the only way to find out is to run `git log --format=fuller -1` or similar 13:19 < cfields> dongcarl: agree, btw. 13:19 < cfields> I've made the same argument in the past when c++14 has come up. 13:23 < dongcarl> cfields: It seems previously the hiccup was distro compat? 13:23 < dongcarl> But I thought RHEL has a Developer Tools thing 13:23 < dongcarl> where they have an updated GCC? 13:52 < cfields> dongcarl: I can't really remember the history now :( 16:24 < fanquake> cfields: good call, new I'd seen those messages before 16:24 < fanquake> *knew 17:56 -!- Netsplit *.net <-> *.split quits: hebasto, nothingmuch, alko, fjahr, phantomcircuit, achow101, harding, meshcollider, wumpus, jonatack, (+13 more, use /NETSPLIT to show all of them) 18:13 -!- Netsplit over, joins: molz, jonasschnelli, meshcollider, aj, phantomcircuit, alko, jonatack 18:13 -!- fanquake [sid369002@gateway/web/irccloud.com/x-jupgkcdrrufypwdn] has joined #bitcoin-builds 18:13 -!- wumpus [~ircclient@2001:bc8:3bec:100::1] has joined #bitcoin-builds 18:13 -!- gertjaap [sid322815@gateway/web/irccloud.com/x-qsqvzvbgrnaphitl] has joined #bitcoin-builds 18:13 -!- Netsplit over, joins: achow101, nothingmuch, harding, MarcoFalke 18:13 -!- dongcarl_ [sid321684@gateway/web/irccloud.com/x-wijpsqwfojirdjau] has joined #bitcoin-builds 18:13 -!- Netsplit over, joins: fjahr, ariard, elichai2 18:14 -!- grubles [~grubles@207.246.88.88] has joined #bitcoin-builds 18:15 -!- Netsplit over, joins: jb55, hebasto, luke-jr 18:17 -!- fanquake is now known as Guest95396 18:21 -!- grubles is now known as Guest48292 18:21 -!- Guest95396 [sid369002@gateway/web/irccloud.com/x-jupgkcdrrufypwdn] has quit [] 18:21 -!- fanquake [sid369002@gateway/web/irccloud.com/x-wldabmtwklcqgksi] has joined #bitcoin-builds 18:24 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-builds 21:19 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 22:17 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-virceihzfqfvnmqe] has quit [Quit: Connection closed for inactivity] --- Log closed Thu Aug 22 00:00:48 2019