--- Log opened Tue Aug 25 00:00:59 2020
00:08 -!- jonatack [~jon@37.166.120.102] has quit [Ping timeout: 240 seconds]
00:22 < fanquake> hebasto: kill your builds.  I'm going to fix that nit
00:22 < fanquake> I did mean to add the additional info to the patch body, like the rest of the commits.
00:22 < hebasto> killed :)
00:23 -!- jonatack [~jon@37.166.201.6] has joined #bitcoin-builds
00:23 -!- jonatack [~jon@37.166.201.6] has quit [Client Quit]
00:23 -!- jonatack [~jon@37.166.120.102] has joined #bitcoin-builds
00:28 -!- jonatack [~jon@37.166.120.102] has quit [Ping timeout: 256 seconds]
00:28 < hebasto> fanquake: wait a minute; verifying patch to `translations.pro`
00:36 < hebasto> fanquake: I was confused by these lines in log
00:36 < hebasto> https://www.irccloud.com/pastebin/fF6dhjAy/
00:37 < hebasto> but the patch looks correct
00:38 < fanquake> hebasto: ok. I'm surprised there is any fuzziness. I've have pushed up the change, and hopefully answered your other question
00:38 < fanquake> Ideally quite a few of these Qt patches are going to dissappear once we start using 5.15.x
00:38 < hebasto> that's great!
01:09 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
01:09 < fanquake> hebasto: I'd like to keep them as no-ops mostly for the ease of review, and the fact that we *know* the previous commands are working.
01:10 < fanquake> We could update/potentially improve some of them now, however, in the qt case, any changes might be irrelevant with the 5.15.x changes, so might as well wait until then.
01:10 < fanquake> For miniupnpnc, all of the patching here is basically just manipulating some version/user-agent strings, and it seems that we can drop the patches if we move to 2.1.
01:10 < hebasto> fanquake: agree
01:10 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-builds
01:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
01:31 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-builds
03:06 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-builds
03:16 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-zcrgwbzzktutshgw] has quit [Ping timeout: 260 seconds]
03:17 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-zagxgkeksxnjlhza] has joined #bitcoin-builds
03:33 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
03:39 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-builds
03:50 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-kfkojwklepiwbotn] has quit [Ping timeout: 272 seconds]
03:50 -!- felixweis [sid154231@gateway/web/irccloud.com/x-tjakxxqoraoowpeh] has quit [Ping timeout: 244 seconds]
03:50 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-tvwaejwbstchkagt] has quit [Ping timeout: 260 seconds]
04:00 -!- felixweis [sid154231@gateway/web/irccloud.com/x-jlmbxhhtbxlzhkla] has joined #bitcoin-builds
04:00 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-ktcafifpocehctxo] has joined #bitcoin-builds
04:01 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-wcxpoytoutibnrpn] has joined #bitcoin-builds
04:18 -!- Pamela49West [~Pamela49W@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-builds
05:31 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
05:32 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-builds
06:09 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-builds
06:12 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
06:21 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-eujonyheguhhaxjc] has joined #bitcoin-builds
10:39 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
10:48 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-builds
11:42 < hebasto> MarcoFalke: I've added a second commit to the fix branch in #19761 due to this error https://travis-ci.org/github/hebasto/bitcoin/jobs/721091828#L3922
11:42 < gribble> https://github.com/bitcoin/bitcoin/issues/19761 | build: improve sed robustness by not using sed by fanquake · Pull Request #19761 · bitcoin/bitcoin · GitHub
11:51 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-wcxpoytoutibnrpn] has quit [Ping timeout: 244 seconds]
11:52 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-gntvfqouzyoqmzvm] has joined #bitcoin-builds
15:22 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-eujonyheguhhaxjc] has quit [Quit: Connection closed for inactivity]
16:42 -!- Pamela49West [~Pamela49W@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
16:43 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
16:58 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-builds
17:03 < fanquake> hebasto: what do you mean by remove intermediate commit IDs? iiuc I’d rather leave them so we’ve got proper patch files. Same as all the other patch files we have.
--- Log closed Wed Aug 26 00:00:59 2020