--- Log opened Thu Apr 08 00:00:19 2021
01:10 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
01:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-builds
03:20 -!- Maria14Kozey [~Maria14Ko@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-builds
03:36 -!- ctrlbreak_MAD [~ctrlbreak@159.2.165.130] has joined #bitcoin-builds
03:39 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has quit [Ping timeout: 246 seconds]
06:48 -!- belcher_ is now known as belcher
06:55 < dongcarl> hebasto, cfields_, fanquake: Meeting in 5mins! :-)
07:00 < dongcarl> Hello everyone
07:00 < dongcarl> #startmeeting
07:00 < dongcarl> Let's wait a few mins while people get here
07:01 < fanquake> hi
07:01 < dongcarl> \o
07:01 < cfields_> :)
07:02 < dongcarl> Going to wait another 1min
07:02 < dongcarl> Then we'll get started
07:03 < dongcarl> Alright
07:03 < dongcarl> Glad to see y'all here
07:03 < dongcarl> How about... Let's start with fanquake this time?
07:03 < fanquake> I'm actually just finishing up another meeting, while watching this chat
07:03 < dongcarl> Oh!
07:04 < dongcarl> Okay haha
07:04 < dongcarl> I'll start then...
07:04 < dongcarl> An update on Guix: things are progressing well and PRs are getting merged...
07:04 < dongcarl> Not sure if everyone saw this, but here's the current state: https://i.imgur.com/SxbFfmV.png
07:05 < dongcarl> One thing I'd like help on is: https://github.com/bitcoin/bitcoin/pull/21427#issuecomment-809800343
07:05 < dongcarl> I believe cfields_ was going to help me with this sometime later today, but if anyone has ideas I'd love to hear them :-)
07:06  * dongcarl looking thru my other PRs
07:06 < cfields_> dongcarl: not really sure what I'm looking at with this current state of guix.
07:07 < dongcarl> cfields_: Sorry I shoulda put a legend...
07:07 < dongcarl> Purple = merged
07:07 < dongcarl> Arrow = depends on
07:07 < dongcarl> Green = open
07:07 < dongcarl> Blue = open but blocked
07:07 < dongcarl> Grey = nice to have but not necessary
07:08 < dongcarl> Red = local-branch not pushed
07:08 < cfields_> All very helpful context, heh. Thanks.
07:08 < dongcarl> :-)
07:08 < dongcarl> Note that the security check sanity one needs symbol/security changes from fanquake to work (I should update the diagram accordingly)
07:09 < fanquake> Yes, I've got those changes pretty much ready to go
07:10 < dongcarl> fanquake: Great! :-)
07:10 < fanquake> Just need to be able to pip install something in guix..
07:10 < dongcarl> fanquake: Oh! What's the package? I'll just package it
07:10 < fanquake> Can download prior, but can't install once inside the container, as the filesystem is readonly
07:10 < cfields_> dongcarl: yeah, the makefile one I'm going to have to page in, heh. Let's look at that after this meeting.
07:10 < fanquake> LIEF
07:10 < dongcarl> cfields_: Sounds good :-)
07:10 < dongcarl> fanquake: Okay, let me package it today and send you a diff of manifest.scm
07:11 < fanquake> dongcarl: cool. I can open a PR with some changes tomorrow then
07:11 < dongcarl> Sounds like a plan!
07:11 < dongcarl> Okay that's all for me :-)
07:11 < cfields_> dongcarl: maybe we could make some time as well to help figure out what's up with my guix env?
07:12 < cfields_> I never followed up from the last attempt :\
07:12 < dongcarl> cfields_: I'd be more than happy to!
07:12 < fanquake> I haven't got much in the way of PRs open at the moment. Planning on opening a few more shortly
07:13 < fanquake> https://github.com/bitcoin/bitcoin/pull/19817 is there if someone wants a rabbit hole. Apparently the change in compiler breaks "dark mode" on macOS..
07:13 < dongcarl> Wuuuuut
07:13 < cfields_> fanquake: lol, I've never clicked on a link so fast...
07:14 < cfields_> I wanted to know what a compiler's "dark mode" was. I misunderstood what you said :)
07:14 < fanquake> heh
07:14 < fanquake> relevant comment towards the bottom of the thread. I haven't verified yet.
07:14 < fanquake> It was posted on !st of April, so half thought it might have been a joke
07:15 < fanquake> Also need to finish up the boost changes to fixup #21135. So that boost in depends is also being built with -fcf-protection for macOS and Windows. Linux builds get it because it's on by default in the compiler.
07:15 < gribble> https://github.com/bitcoin/bitcoin/issues/21135 | scripts: check for control flow instrumentation in security-check.py by fanquake · Pull Request #21135 · bitcoin/bitcoin · GitHub
07:16 < fanquake> Probably all from me tbh. I'll post some more in here tomorrow once I
07:16 < fanquake> *I'm a bit more sorted, and had a look at Carls diff.
07:17 < dongcarl> Hmmm... Is #21135 going to be changed drastically once we start using LIEF?
07:17 < gribble> https://github.com/bitcoin/bitcoin/issues/21135 | scripts: check for control flow instrumentation in security-check.py by fanquake · Pull Request #21135 · bitcoin/bitcoin · GitHub
07:17 < cfields_> Doesn't it pretty much get rewritten?
07:17 < fanquake> If anything it will be simpler todo
07:18 < fanquake> Yes. LIEF will eliminate a lot of boilerplate/parsing code for us
07:18 < dongcarl> Okay cool :-)
07:18 < fanquake> for ex https://github.com/fanquake/bitcoin/tree/macos_win_lief
07:19 < cfields_> Nice
07:20 < cfields_> Has anyone checked the status of llvm's lld for macos recently?
07:20 < cfields_> Wondering if it might be time to start hacking on it.
07:21 < dongcarl> cfields_: What was the problem last time? I've forgotten
07:21 < dongcarl> Qt?
07:21 < fanquake> I haven't. But had been thinking it might be time to revisit
07:21 < cfields_> dongcarl: it wasn't complete, but iirc it was aaaaaalllllmost enough to link bitcoind and qt. Yeah, -qt was likely the problem.
07:22 < fanquake> cory didd you have a branch with any changes from last time you looked?
07:22 < cfields_> Ok, I'll give that another go from llvm-git. I'll open an issue to track it, imo we should be keeping a close watch on that.
07:22 < fanquake> sounds good
07:23 < dongcarl> cfields_: Sounds wonderful
07:23 < cfields_> fanquake: no, it was just a local test. I used FORCE_USE_SYSTEM_CLANG and set my path to my git build, and IIRC it pretty much just worked.
07:24 < cfields_> Thanks for doing the hard part there, dongcarl.
07:24 < dongcarl> cfields_: Hehe you helped a lot in making FORCE_USE_SYSTEM_CLANG possible :-)
07:25 < dongcarl> Anything else people want to talk about?
07:25 < jarolrod_> fanquake: if you do a depends build natively on macOS, dark mode will not work at all (11 and 10.15). But if you cross-compile it, it works. Weird
07:26 < fanquake> cfields_ nice
07:26 < dongcarl> jarolrod_: ?!
07:26 < cfields_> dongcarl: quick meeting, guess things must be building pretty smoothly these days :)
07:26 < fanquake> dongcarl: I don't think so
07:26 < cfields_> jarolrod_: huh.
07:28 < cfields_> Must have to do with packaging, then? Since native/cross builds have different packaging steps?
07:28 < cfields_> Oh right, nm, cross is affected too with a different toolchain.
07:29 < fanquake> something to investigate when feeling motivated heh
07:29 < dongcarl> Okay sounds like we'll adjourn for now with a motion to check out the dark mode stuff :-)
07:30 < dongcarl> #endmeeting
07:30 < dongcarl> fanquake: Thanks for coming out even though it's very late your end
07:30 < cfields_> And I'll open an issue to track llvm.lld.
07:30 < cfields_> +1
07:30 < fanquake> dongcarl: sounds good. thanks for hosting
07:31 < fanquake> no worries
08:00 < jarolrod_> here: https://github.com/bitcoin-core/gui/pull/274#pullrequestreview-631505467
08:00 < jarolrod_> I've included pictures comparing all the build options, so you dont have to ! :)
10:46 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-builds
10:50 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
11:23 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-builds
11:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds]
11:28 -!- lukedashjr is now known as luke-jr
14:10 -!- nckx [~nckx@tobias.gr] has quit [Quit: Updating my Guix System — https://guix.gnu.org]
14:22 -!- nckx [~nckx@tobias.gr] has joined #bitcoin-builds
17:21 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-builds
17:24 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
20:21 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-builds
20:25 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
21:36 < hebasto> dongcarl: fanquake: cfields_: sorry for missing meeting, was having an unpredictable health issue
--- Log closed Fri Apr 09 00:00:20 2021