--- Log opened Thu Aug 19 00:00:42 2021
00:38 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
01:32 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Quit: Bridge terminating on SIGTERM]
01:35 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined #bitcoin-core-builds
01:52 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
01:58 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
02:51 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds
03:50 < laanwj> i think it's fine to use -dev for that
03:52 < laanwj> i guess it's good to keep some things (gui, build) in separate channels, but it's not like traffic on the development channels is so high we really need tons of them, and testing seems general enough for the main channel
05:55 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
06:08 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-builds
06:29 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
06:30 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
06:53 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-builds
06:54 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 268 seconds]
06:55 -!- lukedashjr is now known as luke-jr
07:01 -!- red_librarian [~red_libra@119-170-154-163.rev.home.ne.jp] has joined #bitcoin-core-builds
07:06 -!- red_librarian [~red_libra@119-170-154-163.rev.home.ne.jp] has quit [Client Quit]
07:51 < laanwj> i wonder if we can get rid of HAVE_THREAD_LOCAL for 23.0
07:52 < laanwj> seems like thread local storage is a non-arcane something we can assume to be present by now
07:52 < hebasto> is it depends on minimal supported libc version?
07:52 < laanwj> yes
07:55 < sipa> iirc there was something with macos having a very inefficient implementation (or none at all) for a while
07:55 < sipa> being the reason why we didn't enable it everywhere
07:57 < laanwj> i thought it was because of glibc symbol, can't remember anything about macos, but that would be good to check too then (not that we use it in any performance-critical places, assuming the overhead is only on-access ofc)
07:57 < laanwj> for a long time thread-local-storage was something arcane and badly implemented all over the board, it's just that we're 5 years later now
07:59 < laanwj> either things improved or it's time to forget about it completely, and replace the use with alternative implementations that don't require it
07:59 < sipa> yeah, that seems fair
08:01 < laanwj> but yeah if TLS is *slower* than coordinating things with a lock it defeats its purpose :)
08:02 < sipa> indeed
08:53 -!- stortz [~stortz@user/stortz] has joined #bitcoin-core-builds
09:29 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
09:38 -!- stortz [~stortz@user/stortz] has quit [Quit: Client closed]
09:39 -!- provoostenator [~quassel@user/provoostenator] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
09:40 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
09:40 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-builds
10:04 < jonatack> not sure this is helpful, but the static assert on HAVE_THREAD_LOCAL near the top of src/sync.cpp failed for me on 3-4 CI tasks yesterday (win and mac IIRC) on my first push that didn't take it into account
10:06 < jonatack> (when the DEBUG_LOCKCONTENTION directive was removed)
10:25 < laanwj> jonatack: in your case i don't understand where the use of HAVE_THREAD_LOCAL comes from
10:25 < laanwj> none of the touched code seems to be doing anything with thread-local storage
10:25 < laanwj> or maybe i'm missing something obvious
10:35 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 258 seconds]
10:44 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
10:49 < jonatack> laanwj: looks like it was added in commit f7f7e2cd3 "threads: add a thread_local autoconf check" in #11722 "Switched sync.{cpp,h} to std threading primitives" 
10:49 < gribble> https://github.com/bitcoin/bitcoin/issues/11722 | Switched sync.{cpp,h} to std threading primitives. by tjps · Pull Request #11722 · bitcoin/bitcoin · GitHub
10:49 < jonatack> (ah, gribble is on duty in this channel, nice)
12:44 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer]
12:45 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-builds
13:06 -!- contrapumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-builds
13:07 -!- contrapumpkin [~woohoo@user/copumpkin] has quit [Client Quit]
13:08 -!- copumpkin [~woohoo@user/copumpkin] has quit [Ping timeout: 252 seconds]
13:33 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-builds
13:34 -!- cfields [~cfields@207.172.223.102] has quit [Quit: No Ping reply in 180 seconds.]
13:34 -!- cfields [~cfields@207.172.223.102] has joined #bitcoin-core-builds
14:28 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-builds
14:29 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 258 seconds]
14:30 -!- lukedashjr is now known as luke-jr
14:34 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-builds
14:37 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
14:37 -!- lukedashjr is now known as luke-jr
14:51 < hebasto> we have a new "Build Parsing Results" Cirrus CI task -- looks like it complains about naming in `.cirrus.yml`
16:08 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 258 seconds]
16:31 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
16:37 < fanquake> laanwj: I have some related changes that I can PR shortly. 
17:40 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
18:22 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds]
18:34 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-builds
--- Log closed Fri Aug 20 00:00:43 2021