--- Log opened Thu Aug 26 00:00:49 2021 03:37 < laanwj> finally bump the minimum libc and that problem is solved at least 03:39 < laanwj> in retrosepct we really shouldn't have added thread_local-using code in the first place, it has caused so many issues 03:42 < fanquake> laanwj: I have a branch that bumps glibc, and has the associated tidy-ups 04:56 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds] 05:16 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds 09:44 -!- copumpkin [~woohoo@user/copumpkin] has quit [Read error: Connection reset by peer] 09:46 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-builds 09:47 -!- copumpkin [~woohoo@user/copumpkin] has quit [Read error: Connection reset by peer] 09:48 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-builds 13:02 < hebasto> for now, results for v22.0rc3 from all 4 guix builders are identical and passed `guix-verify` 13:58 -!- dongcarl4 [~dongcarl@96.224.58.144] has joined #bitcoin-core-builds 14:01 -!- dongcarl [~dongcarl@96.224.58.144] has quit [Quit: Ping timeout (120 seconds)] 14:01 -!- dongcarl4 is now known as dongcarl 14:06 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed] 21:35 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds] 21:47 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-builds 22:38 < laanwj> 6 attestations already, nice! 22:39 < laanwj> it's just as fast as with gitian builders already 22:59 < hebasto> is #20586 good enough to get merged in the early 23.0 release stage? 23:00 < gribble> https://github.com/bitcoin/bitcoin/issues/20586 | Fix Windows build with --enable-werror by hebasto · Pull Request #20586 · bitcoin/bitcoin · GitHub 23:34 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 23:38 < laanwj> again the CI failing on a backport PR #22808 23:39 < laanwj> we should disable the fuzzing on 0.21 branch 23:39 < fanquake> laanwj: I had a similar opinion about that PR. I think the insistence that we need -werror everywhere at the sake of random suppression’s and workarounds is meh 23:40 < fanquake> especially given the way it’s being done (in general) is not that coherent. Mix of code changes, turning off warnings, pragmas in code etc 23:40 < laanwj> fanquake: it makes some sense for the CI I guess 23:41 -!- jarolrod [sid475272@id-475272.highgate.irccloud.com] has quit [Ping timeout: 250 seconds] 23:41 < hebasto> yes, it was mostly for CI 23:41 < laanwj> yes, I agree, what convinced me about this specific PR is that the pragmas are in win32-specific code that is going away anyhow 23:41 < hebasto> laanwj: fanquake: https://github.com/bitcoin/bitcoin/pull/22730#issuecomment-906713466 23:42 < laanwj> but in general 'fixes' for warnings, if done at all, should improve the code (e.g. reduce risk of bugs) not work around them with pragmas or deliberately convoluted code 23:44 < laanwj> hebasto: yes, please include #22730 in #22808 23:44 -!- jarolrod [sid475272@id-475272.highgate.irccloud.com] has joined #bitcoin-core-builds 23:44 < hebasto> will do 23:50 < laanwj> would be nice to have a gribble here 23:52 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-builds --- Log closed Fri Aug 27 00:00:50 2021