--- Log opened Mon Sep 06 00:00:59 2021
04:19 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
04:30 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds
05:03 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
05:36 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds
08:05 < laanwj> I'm kind of confused here https://github.com/bitcoin/bitcoin/pull/22397#issuecomment-913709377 , why don't we use pkg-config?
08:06 < laanwj> it's meant to exactly avoid this scenario of having to do custom path detection for every platform and architecture
08:07 < hebasto> laanwj: ubuntu focal does not provide`.pc` file for `miniupnpc` package -- https://packages.ubuntu.com/focal/amd64/miniupnpc/filelist
08:08 < laanwj> which seems to be getting out of hand now
08:08 < laanwj> hebasto: it does, you need to look at miniupnpc-dev
08:08 < laanwj> hebasto: it does, you need to look at libminiupnpc-dev
08:08 < hebasto> yes, you're right
08:10 < laanwj> debian (i think in contrast with fedora) splits up libraries in a binary-only package and a -dev package, the former is for runtime use, the latter is used to build software against it
08:12 < hebasto> https://packages.ubuntu.com/focal/amd64/libnatpmp-dev/filelist does not list `.pc` file
08:14 < laanwj> right
08:14 < laanwj> so maybe we could at least try pkg-config detection, and fall back for libnatpmp in the standard system path if it fails, i dunno
08:15 < laanwj> and try to get this fixed upstream
08:16 < hebasto> fanquake is working on it -- #22644
08:16 < gribble> https://github.com/bitcoin/bitcoin/issues/22644 | Deprecate UPnP support, require 2.1 or later by fanquake · Pull Request #22644 · bitcoin/bitcoin · GitHub
08:17 < laanwj> ok, that seems better to me than os/arch specific logic forest
08:17 < laanwj> though deprecating UPnP seems unrelated
08:18 < hebasto> I meant his message "I am planning to add pkg-config support to upstream libnatpmp."
08:24 < hebasto> `miniupnpc` and `libnatpmp` packages from depends also lack `.pc` files
08:43 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has joined #bitcoin-core-builds
08:45 < laanwj> yes, i guess they're not in upstream either
08:46 < laanwj> i guess #22397 is a valid temporary solution anyhow
08:46 < gribble> https://github.com/bitcoin/bitcoin/issues/22397 | build: Fix macOS Apple Silicon build with miniupnpc and libnatpmp by hebasto · Pull Request #22397 · bitcoin/bitcoin · GitHub
08:47 < laanwj> it joins the list of boost and qt with all kinds of library-specific location logic
08:47 < laanwj> pkg-config was nice in theory but useless in practice for us
08:48 < hebasto> `pkg-config` does a great job for other packages :)
08:49 < laanwj> yes, thinking of it, pkg-config does work for qt
08:49 < laanwj> it's boost that flat out refuses to support the scheme
09:04 < laanwj> while they do provide cmake config files, it seems
10:30 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 252 seconds]
11:49 < jarolrod> my apologies, I didn't include this reasoning when I had ack
11:49 < jarolrod> I should have included the .pc file issue so that it would be more clear as to why I went and ack'ed it
13:14 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-builds
17:16 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-builds
17:20 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds]
17:40 < fanquake> Yea I would have rather avoided that PR, or at least the upnpc half of it
17:40 < fanquake> The  number of people using upnpc or libnatpmp on an M1 device is probably 0 anyways
17:43 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
21:36 -!- Netsplit *.net <-> *.split quits: sdaftuar1
21:37 -!- Netsplit over, joins: sdaftuar1
21:41 -!- Netsplit *.net <-> *.split quits: MarcoFalke, jonasschnelli, windsok, real_or_random, _0x0ff
21:41 -!- _0x0ff [~0x0ff@163.172.166.225] has joined #bitcoin-core-builds
21:41 -!- Netsplit over, joins: windsok
21:41 -!- Netsplit over, joins: jonasschnelli
21:42 -!- Netsplit over, joins: real_or_random
21:42 -!- _0x0ff [~0x0ff@163.172.166.225] has quit [Changing host]
21:42 -!- _0x0ff [~0x0ff@user/0x0ff/x-0302470] has joined #bitcoin-core-builds
21:42 -!- Netsplit over, joins: MarcoFalke
21:57 -!- Netsplit *.net <-> *.split quits: harding
21:57 -!- harding [quassel@newmail.dtrt.org] has joined #bitcoin-core-builds
--- Log closed Tue Sep 07 00:00:00 2021