--- Log opened Thu Mar 10 00:00:21 2022 01:08 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 250 seconds] 01:08 -!- harding [quassel@newmail.dtrt.org] has quit [Ping timeout: 252 seconds] 01:08 -!- harding [quassel@newmail.dtrt.org] has joined #bitcoin-core-builds 01:26 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds 03:02 < laanwj> it prints "Found macOS SDK at '/home/guest/sdk-path/Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers', using..." twice during guix build now, i guess because of the two macos platforms? 03:04 < sipa> @laanwj: that was my guess as well 03:04 < fanquake> yes, because it's checking for both macOS hosts 03:05 < fanquake> we should change that to an OR so it only checks once 03:12 < fanquake> will open a PR to fix it now 03:16 < fanquake> #24520 03:16 < gribble> https://github.com/bitcoin/bitcoin/issues/24520 | guix: only check for the macOS SDK once by fanquake · Pull Request #24520 · bitcoin/bitcoin · GitHub 03:25 < laanwj> fanquake: thanks! 04:11 < hebasto> please someone grab #24415 04:12 < gribble> https://github.com/bitcoin/bitcoin/issues/24415 | build: Fix Boost.Process test for Boost 1.78 by hebasto · Pull Request #24415 · bitcoin/bitcoin · GitHub 04:15 < emzy> Oh 23.0 release candidate 2 is out. I'm still compiling RC1. LOL 04:15 < emzy> computer to slow. 04:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 05:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 05:34 < laanwj> emzy: it makes sense to wait for rc1 build to finish, i think, to make sure the work already done (and that didn't change) is cached 05:35 < laanwj> hebasto: will take a look 05:35 < laanwj> oh, i have no access to macOS x86_64 either 05:36 < laanwj> nor any macos for that matter 05:41 < emzy> laanwj: yes I will let it run. 05:42 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:43 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 06:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 06:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 07:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 07:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 08:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 08:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:31 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 09:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 09:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 10:26 < dongcarl> Question for reviewers for #24322: I made .la versions of the internal libraries that need to be linked into libbitcoinkernel, but didn't remove the .a ones, given that we correctly pass LIBTOOL_APP_LDFLAGS to all the binaries we build, perhaps we should remove the .a ones so that we don't recompile things twice? Lmk 10:26 < gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl · Pull Request #24322 · bitcoin/bitcoin · GitHub 10:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 10:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 10:49 < laanwj> dongcarl: what's the difference? can the .la files only be linked dynamically? 10:50 < laanwj> i mean, we probably want to keep bitcoind as one independent binary for now 10:52 < dongcarl> laanwj: So libtool will yell at you if you try to link a shared library (libbitcoinkernel) against static ones (libbitcoincrypto.a). However, if you link against .la files, libtool can either link statically or dynamically, and since we specify https://github.com/bitcoin/bitcoin/blob/93feabcb30e34bfc458742e0e8b327b404599f29/configure.ac#L687, there 10:52 < dongcarl> would be no difference for existing binaries 10:52 < laanwj> dongcarl: sounds like a win to not build things twice then! 10:53 < dongcarl> Cool, will update 10:54 < laanwj> assuming this doesn't hit a snag on some obscure os *cough mingw cough* 10:54 < dongcarl> OH TRUE 10:54 < dongcarl> Will run a Guix build to see if symbol-check complains 11:06 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-builds 11:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 11:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 11:53 < dongcarl> Okay I hope I'm not going crazy, but we use `$(LIBLEVELDB_SSE42)` in a bunch of Makefiles, but it's never defined, only `$(LIBLEVELDB_SSE42_INT)` is defined... 11:54 < laanwj> dongcarl: huh! 11:55 < laanwj> dongcarl: that seems completely unnecessary 11:55 < dongcarl> laanwj: You mean we should just remove all the `LIBLEVELDB_SSE42` references? 11:56 < laanwj> it's added to LIBCRC32C which is part of LIBLEVELDB 11:56 < laanwj> dongcarl: yes, it's seems it would be duplicate 11:56 < dongcarl> laanwj: The funny thing is `LIBLEVELDB_SSE42_INT` is not referenced ANYWHERE 11:56 < dongcarl> not even in libcrc32c 11:57 < dongcarl> It's just defined 11:57 < laanwj> eh 11:57 < laanwj> EXTRA_LIBRARIES += $(LIBCRC32C_SSE42_INT) 11:57 < laanwj> oh 11:57 < dongcarl> Right but it's not linked anywhere 11:58 < dongcarl> Or maybe I'm thinking about it the wrong way 11:58 < laanwj> LIBCRC32C_SSE42_INT is 11:58 < laanwj> not LIBLEVELDB_SSE42_INT 11:58 < laanwj> i'm confused 11:59 < laanwj> i don't think there *is* any leveldb sse42 code 11:59 < laanwj> maybe it's a leftover from an older version before crc32c existed 11:59 < sipa> Maybe it's a leftover... right 11:59 < laanwj> which engulfed all the platform specific code 12:00 < sipa> yes, leveldb used to have platform-specific crc32 code, before it got split off into a separate lib, iirc 12:00 < dongcarl> Oh okay cool cool 12:00 < dongcarl> I will remove then 12:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 12:05 < laanwj> would be a nice cleanup 12:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 12:55 < luke-jr> laanwj: do you have nightmares about scons? :P 13:16 < jonatack> laanwj: i'm here for the vocabulary like "engulfed" 13:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 13:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 14:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 14:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 15:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 15:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 15:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 15:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds 16:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 16:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 16:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 16:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 16:20 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 16:23 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds 16:40 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 17:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 17:11 -!- Guest76 [~Guest76@2607:fb91:482:8a54:c8e5:21ef:c34f:f50e] has joined #bitcoin-core-builds 17:11 -!- Guest76 [~Guest76@2607:fb91:482:8a54:c8e5:21ef:c34f:f50e] has quit [Client Quit] 17:11 -!- Guest76 [~Guest76@2607:fb91:482:8a54:c8e5:21ef:c34f:f50e] has joined #bitcoin-core-builds 17:12 -!- Guest76 [~Guest76@2607:fb91:482:8a54:c8e5:21ef:c34f:f50e] has quit [Client Quit] 17:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 18:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 18:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 18:45 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 272 seconds] 19:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 19:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 19:25 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 19:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds] 20:04 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 20:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:23 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 21:03 < dongcarl> laanwj: You were right mingw is giving me problems... Similar to: https://github.com/bitcoin/bitcoin/issues/19772 21:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 21:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 21:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 21:32 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 22:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 22:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 23:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds 23:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds --- Log closed Fri Mar 11 00:00:22 2022