--- Log opened Wed Jun 08 00:00:46 2022 02:04 < vasild> hebasto: so, with autotools minisketch is compiled with c++ -DHAVE_CLMUL which disables the code which does val>>8 with val being unsigned char 02:04 < vasild> and now with cmake -DHAVE_CLMUL is used too 02:04 < hebasto> vasild: yeap 02:05 < hebasto> and two other defines as well :) 02:05 < vasild> unrelated to cmake, maybe #ifndef HAVE_CLMUL 02:05 < vasild> #error code is broken 02:07 < vasild> I guess it would be undesirable if some user compiles without -DHAVE_CLMUL 02:16 -!- theStack [~theStack@95.179.145.232] has joined #bitcoin-core-builds 02:28 < fanquake> hebasto: where would you like comments/feedback on your cmake branches posted? In here, on the commits directly? 02:30 < hebasto> maybe open a draft pr to keep discussion records? 02:30 < fanquake> I think it's still a bit early for that to go to bitcoin/bitcoin, but you could open on against your own repo for now? 02:31 < hebasto> I'll do it 02:34 < vasild> create a branch named "cmake" in github.com:hebasto/bitcoin and people may open pull requests against it (in the hebasto/bitcoin repository) 02:36 < vasild> I would try to do the debug (-g3 -O0), release (-O2) and werror flags 02:39 < vasild> I guess we can aim at having cmake -DFOO=YES or cmake -DFOO=NO mimic ./configure --enable-foo or ./configure --disable-foo? 02:40 < hebasto> ^ that is an idea :) 02:55 < laanwj> having a formally defined mapping would make a ./configure compatibility wrapper script easiest to do too 03:12 < hebasto> https://github.com/hebasto/bitcoin/pull/3 created to collect comments and feedback on cmake 03:44 -!- Guest1 [~Guest1@2607:fb90:d448:c44f:0:34:7dbd:b201] has joined #bitcoin-core-builds 03:47 -!- Guest1 [~Guest1@2607:fb90:d448:c44f:0:34:7dbd:b201] has quit [Client Quit] 05:50 -!- real_or_- is now known as real_or_random 13:36 < hebasto> fanquake: re "16:42:32 so the binaries "compile", but are broken" -- fixed, https://github.com/hebasto/bitcoin/pull/3#issuecomment-1150386349 13:45 < fanquake> Cool, I'll take another look and leave some more feedback. Left a few comments 14:27 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 14:36 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds 15:26 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 23:38 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] --- Log closed Thu Jun 09 00:00:47 2022