--- Log opened Thu Sep 01 00:00:06 2022
00:00 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 255 seconds]
00:27 < vasild> hebasto: by default I get this: -- Could NOT find BerkeleyDB: Found unsuitable version ".", but required is at least "4.8" (found BerkeleyDB_LIBRARY-NOTFOUND)
00:28 < vasild> this looks strange: unsuitable version "."
00:31 < vasild> it probably comes from this: set(BerkeleyDB_VERSION ${BerkeleyDB_VERSION_MAJOR}.${BerkeleyDB_VERSION_MINOR}), investigating...
00:33 < vasild> this is because it finds /usr/include/db.h which does not contain DB_VERSION_MAJOR :/
00:34 < hebasto> vasild: what system?
00:34 < vasild> freebsd 12.3
00:35 < hebasto> thanks for report, will look into it
00:35 < vasild> so, freebsd ships by default with this file: https://github.com/freebsd/freebsd-src/blob/main/include/db.h
00:36 < hebasto> it is not Berkeley DB header, isn't it?
00:36 < vasild> hebasto: I will see how to tweak/fix it
00:36 < vasild> it is
00:36 < hebasto> thanks!
00:38 < vasild> but I think is for some bdb 1.85 or whatever version, not suitable, the "proper" one is in /usr/local/include/db5/db.h
00:43 < hebasto> what if you add db5 to PATH_SUFFIXES in FindBerkeyDB.cmake ?
00:49 < vasild> yes, just did that, easy
00:49 < vasild> and also for the library
00:51 < vasild> hebasto: feel free to pick the top 2 commits from https://github.com/vasild/bitcoin/commits/220807-cmake
00:51 < vasild> I think that is more effective than posting diffs on github
01:17 < vasild> In the parity table at https://github.com/bitcoin/bitcoin/pull/25797, --enable-debug has TBD
01:17 < vasild> Should that be -DCMAKE_BUILD_TYPE=Debug ?
01:30 < vasild> Why prepare a custom variable hardened_cxx_flags and later set(CMAKE_CXX_FLAGS_RELHARDENED "${hardened_cxx_flags}"? Is it not possible to directly try_append_cxxflag(CMAKE_CXX_FLAGS_RELHARDENED, ...?
01:42 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
02:23 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds
03:03 < hebasto> vasild: looks like leftovers from the initial implementation :) -- will improve it
03:04 < vasild> ok, if it works without them, it would be simpler
03:08 < vasild> hebasto: I pushed 2 more commits in https://github.com/vasild/bitcoin/commits/220807-cmake - to use -O0 -g3 in "Debug" builds
03:09 < vasild> and to enable -Werror if -DWERROR=ON is given
03:10 < vasild> should be equivalent to autotools' --enable-debug and --enable-werror
03:12 < hebasto> vasild: thank you
03:14 < vasild> hmm, I forgot to optionally add -Wno-error=return-type, like in configure.ac
03:38 < hebasto> vasild: an update -- `CMAKE_CXX_FLAGS_RELHARDENED` is a cache variable, `hardened_cxx_flags` is a local variable. I see it is convenient to use a temporary local variable to collect all flags, and assign a cache variable once only
03:38 < vasild> yes
06:28 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
08:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
08:23 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds
09:08 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds
09:34 < vasild> hebasto: what about the --enable-debug equivalent? Should that be -DCMAKE_BUILD_TYPE=Debug ?
09:35 < vasild> you did not take that idea from https://github.com/vasild/bitcoin/commits/220807-cmake
09:36 < vasild> about the werror option: consider this check instead for broken -Wno-error=return-type
09:36 < vasild> https://github.com/vasild/bitcoin/commit/cd86485b6b664b4fc92c285d3de3ac94ac954429
09:37 < vasild> it actually checks if it is broken, like in configure.ac
09:38 < hebasto> vasild: right, there must be a check
09:39 < vasild> I am looking now to adding all the Wall Wwhatnot options...
09:40 < vasild> seems they should be added unconditionally
09:40 < hebasto> as CMake has its own "Debug" build type, and people has accustomed to it, I'm still vague about modifying it. Maybe introduce our own "BlaBlaDebug" build type
09:40 < hebasto> ^^ right, also #25972
09:41 < gribble> https://github.com/bitcoin/bitcoin/issues/25972 | build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set by fanquake · Pull Request #25972 · bitcoin/bitcoin · GitHub
09:43 < vasild> I am not sure about Debug either
09:43 < vasild> what would cmake do by default in -DCMAKE_BUILD_TYPE=Debug ?
09:44 < hebasto>  `-O0 -g`
09:45 < vasild> hmm, and our own "debug" mode should do `-O0 -g3 -ftrapv` (if I read configure.ac correctly)
09:46 < vasild> maybe ok to hijack cmake's -DCMAKE_BUILD_TYPE=Debug since there is no big difference
09:47 < hebasto> idk...
09:47 < hebasto> if we going to introduce our own type, a nice name is required
09:49 < vasild> no idea :)
12:46 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
13:10 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
13:37 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds
15:03 -!- gnusha [~gnusha@user/gnusha] has joined #bitcoin-core-builds
15:03 -!- Topic for #bitcoin-core-builds: Bitcoin Core build system discussions | Channel logs: https://gnusha.org/bitcoin-builds/ | To get started learning about our build system: https://github.com/bitcoin/bitcoin/tree/master/depends
15:03 -!- Topic set by orionwl [] [Tue May 25 06:15:05 2021]
15:03 [Users #bitcoin-core-builds]
15:03 [ achow101] [ emzy         ] [ harding      ] [ josie[m]       ] [ real_or_random_] [ vasild    ] 
15:03 [ ariard  ] [ fanquake_    ] [ hebasto      ] [ kanzure        ] [ RubenSomsen    ] [ willcl_ark] 
15:03 [ b10c    ] [ fjahr_       ] [ Jackielove4u ] [ koolazer       ] [ ryanofsky      ] [ windsok   ] 
15:03 [ cfields_] [ ghost43      ] [ jarolrod     ] [ luke-jr        ] [ sipa           ] 
15:03 [ darosior] [ glozow       ] [ jkczyz       ] [ M0x1729[m]1    ] [ sipsorcery     ] 
15:03 [ dlb76   ] [ gnusha       ] [ jonasschnelli] [ MacroFake      ] [ stick          ] 
15:03 [ dongcarl] [ greypw2546002] [ jonatack     ] [ michaelfolkson2] [ stickies-v     ] 
15:03 [ doppo   ] [ gribble      ] [ josibake____ ] [ orionwl        ] [ tobtoht        ] 
15:03 -!- Irssi: #bitcoin-core-builds: Total of 43 nicks [0 ops, 0 halfops, 0 voices, 43 normal]
15:03 -!- Channel #bitcoin-core-builds created Sat May 22 03:59:28 2021
15:04 -!- meshcollider [meshcollid@jujube.rpblc.net] has joined #bitcoin-core-builds
15:05 -!- Irssi: Join to #bitcoin-core-builds was synced in 141 secs
15:06 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
16:38 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
21:13 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 252 seconds]
21:26 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-builds
21:33 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-builds
21:34 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
22:12 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-builds
22:15 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
22:19 -!- lukedashjr [~luke-jr@user/luke-jr] has quit [Ping timeout: 252 seconds]
22:21 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-builds
--- Log closed Fri Sep 02 00:00:07 2022