--- Log opened Thu Jan 16 00:00:49 2025 00:02 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds] 03:45 -!- Guest90 [~Guest49@49.37.51.72] has joined #bitcoin-core-builds 03:45 -!- Guest90 [~Guest49@49.37.51.72] has quit [Client Quit] 04:19 -!- josie [~josibake@suhail.uberspace.de] has joined #bitcoin-core-builds 06:17 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds 07:10 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds] 07:23 -!- jackielove4u1 [~jackielov@user/jackielove4u] has joined #bitcoin-core-builds 07:25 -!- jackielove4u [~jackielov@user/jackielove4u] has quit [Ping timeout: 248 seconds] 07:25 -!- jackielove4u1 is now known as jackielove4u 10:37 < darosior> I used to be able to just pass "-fprofile-instr-generate -fcoverage-mapping" to instrument for source based coverage. For some reason i'm struggling to replicate this with cmake. I've been trying variations of: 10:37 < darosior> cmake -B fuzzcovbuild/ --preset=libfuzzer -DCMAKE_C_COMPILER=clang-19 -DCMAKE_CXX_COMPILER=clang++-19 -DAPPEND_CFLAGS="-fprofile-instr-generate -fcoverage-mapping" -DAPPEND_CXXFLAGS="-fprofile-instr-generate -fcoverage-mapping" 10:37 < darosior> Am i missing something obvious? With `cmake --build --verbose` i do see it being taken into account, just my binary simply doesn't generate the profraw file. 11:21 < darosior> Ok i was just being stupid 11:21 < darosior> Many such instances 11:34 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds 11:35 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 11:36 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds 11:47 < hebasto> darosior: so, it works, isn't it? 11:49 < darosior> Yes it does, i just made a typo in -DAPPEND_LDFLAGS (missed the `-D` part somehow so i didnt get the unknown var warning from cmake) 11:52 < hebasto> darosior: fwiw, you can replace `-DAPPEND_CXXFLAGS="some flags" -DAPPEND_LDFLAGS="some flags"` with `-DCMAKE_CXX_FLAGS="some flags"` 12:07 < darosior> Ah i was afraid it would unset other flags instead of just appending 12:19 < hebasto> darosior: they will be prepended 12:20 < darosior> ok thanks 12:55 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 20:44 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds 23:32 -!- eval-exec [~Thunderbi@45.78.56.68.16clouds.com] has quit [Ping timeout: 260 seconds] --- Log closed Fri Jan 17 00:00:50 2025