--- Log opened Wed Sep 30 04:26:29 2015
04:26 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev
04:26 -!- Irssi: #bitcoin-core-dev: Total of 17 nicks [0 ops, 0 halfops, 0 voices, 17 normal]
04:26 -!- Irssi: Join to #bitcoin-core-dev was synced in 1 secs
05:48 < GitHub21> [bitcoin] laanwj opened pull request #6741: doc: Change #bitcoin-dev IRC channel to #bitcoin-core-dev (master...2015_09_channel_split) https://github.com/bitcoin/bitcoin/pull/6741
05:49 -!- fanquake [~Adium@unaffiliated/fanquake] has joined #bitcoin-core-dev
05:51 -!- fkhan [weechat@gateway/vpn/mullvad/x-xpcqfjvlalgcqvdn] has joined #bitcoin-core-dev
05:53 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
05:57 < fanquake> Time to sit and watch the talent roll in
05:59 -!- gavinandresen [~gavin@unaffiliated/gavinandresen] has joined #bitcoin-core-dev
06:16 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
06:17 -!- jgarzik [~jgarzik@unaffiliated/jgarzik] has joined #bitcoin-core-dev
06:20 -!- goregrind [~goregrind@unaffiliated/goregrind] has joined #bitcoin-core-dev
06:32 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
07:08 -!- fanquake [~Adium@unaffiliated/fanquake] has quit [Quit: Leaving.]
07:09 -!- fanquake [~Adium@45.56.158.22] has joined #bitcoin-core-dev
07:09 -!- fanquake [~Adium@45.56.158.22] has quit [Changing host]
07:09 -!- fanquake [~Adium@unaffiliated/fanquake] has joined #bitcoin-core-dev
07:10 -!- fanquake [~Adium@unaffiliated/fanquake] has quit [Client Quit]
07:19 -!- ParadoxSpiral [~ParadoxSp@p508B8D42.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
08:03 -!- lecusemb1e [~lecusembl@f9beb4d9.violates.me] has joined #bitcoin-core-dev
08:14 < GitHub156> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/1119cc3f5918575ca397518c9fd31a64704c7e4f
08:14 < GitHub156> bitcoin/master 1119cc3 Wladimir J. van der Laan: Merge pull request #6741...
08:14 < GitHub69> [bitcoin] laanwj closed pull request #6741: doc: Change #bitcoin-dev IRC channel to #bitcoin-core-dev (master...2015_09_channel_split) https://github.com/bitcoin/bitcoin/pull/6741
08:51 -!- challisto [~dell@76.16.149.33] has joined #bitcoin-core-dev
08:52 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:57 -!- andytoshi [~andytoshi@wpsoftware.net] has joined #bitcoin-core-dev
08:58 -!- andytoshi [~andytoshi@wpsoftware.net] has quit [Changing host]
08:58 -!- andytoshi [~andytoshi@unaffiliated/andytoshi] has joined #bitcoin-core-dev
09:00 -!- cfields [~quassel@unaffiliated/cfields] has joined #bitcoin-core-dev
09:00 < GitHub166> [bitcoin] arnuschky opened pull request #6742: Changed logging to make -logtimestamps to work also for -printtoconsole (master...feature-logtimestamps-toconsole) https://github.com/bitcoin/bitcoin/pull/6742
09:18 -!- harding [~harding@mail.dtrt.org] has joined #bitcoin-core-dev
09:46 -!- maaku [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has joined #bitcoin-core-dev
09:48 -!- ProfMac [~ProfMac@2001:470:b8ac:0:5cc1:a999:7262:4dfc] has joined #bitcoin-core-dev
09:52 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev
09:55 -!- AtashiCon [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev
09:56 -!- helo [~helo@unaffiliated/helo] has joined #bitcoin-core-dev
10:05 -!- teward [teward@ubuntu/member/teward] has joined #bitcoin-core-dev
10:09 -!- rubensayshi [~ruben@91.206.81.13] has quit [Remote host closed the connection]
10:14 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev
10:30 -!- fkhan [weechat@gateway/vpn/mullvad/x-xpcqfjvlalgcqvdn] has quit [Read error: Connection reset by peer]
10:51 -!- fkhan [~weechat@unaffiliated/loteriety] has joined #bitcoin-core-dev
10:57 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Quit: Lost terminal]
11:07 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
11:21 -!- stonecoldpat [~a9380004@janus-nat-128-240-225-56.ncl.ac.uk] has joined #bitcoin-core-dev
11:31 -!- fkhan [~weechat@unaffiliated/loteriety] has quit [Ping timeout: 240 seconds]
11:32 -!- ParadoxSpiral_ [~ParadoxSp@p508B9B56.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
11:35 -!- ParadoxSpiral [~ParadoxSp@p508B8D42.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
11:45 -!- fkhan [weechat@gateway/vpn/mullvad/x-jfozayxakgwlhkes] has joined #bitcoin-core-dev
12:15 -!- evoskuil [~evoskuil@c-73-225-134-208.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
12:35 -!- GAit [~GAit@2.230.161.158] has joined #bitcoin-core-dev
12:35 -!- instagibbs [~greg@pool-108-31-210-40.washdc.fios.verizon.net] has joined #bitcoin-core-dev
12:36 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
12:42 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:02 -!- GAit [~GAit@2.230.161.158] has quit [Quit: Leaving.]
13:12 -!- neha [~narula@mint-square.mit.edu] has joined #bitcoin-core-dev
13:17 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #bitcoin-core-dev
13:19 < rusty> sipa: libsecp questions.  How do I check that the signature is in canonical form (small s value)?  You've made signature struct "opaque".
13:19 < rusty> Does verify do this?
13:20 < sipa> rusty: no, there is no functionality for doing that
13:20 < sipa> we should add it, though - i'm thinking about changing the signature parsing code anyway
13:20 < rusty> sipa: yeah... that's what I figured.  I hand around sigs in lightning as 64 byte raw vals, and I'm having to hack it.
13:21 < sipa> how do you convert them from/to 64 byte format?
13:21 < rusty> struct signature { 	u8 r[32];	u8 s[32]; };
13:21 < rusty> sipa: I stole the DER encode/decode from bitcoin.
13:21 < sipa> got it
13:22 < sipa> well, it would not be hard to add another parse/serialize function
13:22 < sipa> that converts to a well-defined 64-byte format
13:22 < rusty> sipa: yes, your comments even refer to it :)
13:22 < sipa> DER is a needless complication, both for client and library
13:22 < sipa> well there is such a format for the recoverable signatures
13:23 < rusty> "use the secp256k1_ecdsa_signature_serialize_* and  secp256k1_ecdsa_signature_serialize_* functions." :)
13:23 < sipa> rusty: someone sent a PR today to fix that
13:26 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
13:28 < gmaxwell> we already produce canonical form in all cases, it's just there is no way to verify it.
13:28 < gmaxwell> If _parse too verification flags, it could be asked to check for that trivally.
13:28 < rusty> sipa: secp256k1_ecdsa_signature_serialize()/_parse() then?  I'll have to dig into your slightly weird scalar system to implement it.
13:29 < gmaxwell> though perhaps it would better be done with a seperate sig_has_low_s().
13:29 < sipa> rusty: give me 5 mins, i'll implement it
13:29 < rusty> gmaxwell: yes, I have a couple of "assert(sig_valid(s))" scattered through my code.
13:30 < sipa> i don't like adding dozens of flags
13:30 < rusty> gmaxwell: (which is "return true;" for schnorr, and tests for top s bit for ecdh)
13:30 < sipa> in fact, i prefer none...
13:30 < rusty> gmaxwell: so in practice, a standalone check would fit me better.  I guess that's a data point?
13:30 < sipa> rusty: good. decided.
13:30 < gmaxwell> I sort of dread doing the testing if there are flags. :(  Also I think parsing for lows but sloppy DER doesn't make logical sense.
13:31 < sipa> i think i have a nearly-complete BER parser
13:31 < sipa> it's only twice as long as the current parse code
13:31 < gmaxwell> sipa: I am ... really not looking forward to writing tests for that. :( Also, how can it be BER, I assume it must length limit the outputs?
13:32 < sipa> gmaxwell: yes, up to a fixed limit
13:33 < gmaxwell> Also, there exist no other nearly complete BER parsers, so I dunno how I can do a differential test against it.
13:33 < rusty> sipa: I really want to be able to insist it's normalized.  Actually, I want that for everything.  If someone slips something in which causes me to build an invalid tx, I'm hosed.
13:33 < sipa> my design goal is: accept everything that is valid BER or accepted by openssl
13:33 < sipa> rusty: oh, absolutely... i don't want to encourage BER as default
13:34 < sipa> rusty: there needs to be a strict DER parser one (which is much easier)
13:34 < sipa> but for use in Bitcoin we can't just only have a strict DER one
13:34 < sipa> rusty: also, #secp256k1
14:04 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
14:11 -!- ParadoxSpiral_ [~ParadoxSp@p508B9B56.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
14:36 -!- amiller [~socrates1@unaffiliated/socrates1024] has joined #bitcoin-core-dev
14:56 -!- pigeons [~pigeons@94.242.209.214] has joined #bitcoin-core-dev
14:56 -!- PRab [~chatzilla@2601:40a:8000:8f9b::3416:dab0] has joined #bitcoin-core-dev
15:22 < michagogo> https://usercontent.irccloud-cdn.com/file/s0ybRJT5/IMG_2998.PNG
15:23 < michagogo> https://usercontent.irccloud-cdn.com/file/lhLarj9q/IMG_2999.PNG
15:23 < sipa> michagogo: it should definitely recompute things (either on the fly, or at startup and update)
15:24 < sipa> that's how the BIP34/66 implementation works as well
15:24 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:24 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
15:26 -!- Squidicuz [~squid@pool-72-74-133-29.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
15:34 < CodeShark> michagogo: I've been considering two approaches...either save state or recompute. I think it's inevitable we need to save some state at runtime (i.e. as part of the block index)...but we can recompute at startup
15:42 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 264 seconds]
15:54 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:55 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
16:59 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #bitcoin-core-dev
17:19 < BlueMatt> wumpus: how did you measure the maxresident-during-compile thing?
17:19 < BlueMatt> I'll run it on this jessie server
17:28 -!- zxzzt_ [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:33 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev
18:05 -!- goregrind [~goregrind@unaffiliated/goregrind] has quit [Ping timeout: 252 seconds]
18:09 -!- goregrind [~goregrind@unaffiliated/goregrind] has joined #bitcoin-core-dev
18:15 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:38 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev
18:55 -!- Guest1234 [~ubuntu@ec2-52-0-91-57.compute-1.amazonaws.com] has joined #bitcoin-core-dev
20:03 -!- jgarzik [~jgarzik@unaffiliated/jgarzik] has quit [Quit: Leaving]
20:03 -!- jgarzik [~jgarzik@104-178-201-106.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
20:03 -!- jgarzik [~jgarzik@104-178-201-106.lightspeed.tukrga.sbcglobal.net] has quit [Changing host]
20:03 -!- jgarzik [~jgarzik@unaffiliated/jgarzik] has joined #bitcoin-core-dev
20:05 -!- baldur [~baldur@pool-173-52-43-219.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
20:58 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:38 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
22:09 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
22:10 < rusty> BlueMatt: /usr/bin/time -v ?
22:13 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:25 -!- ParadoxSpiral [~ParadoxSp@p508B9B56.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
22:54 -!- ParadoxSpiral [~ParadoxSp@p508B9B56.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
23:00 < BlueMatt> rusty: except per-compile-target
23:00 < BlueMatt> but, yea, thats probably how he did it
23:00 < BlueMatt> I'm just lazy and was hoping for a one-liner instead of doing it myself
23:00 < BlueMatt> I guess CXX=......
23:02 -!- zveda [~zveda@unaffiliated/zveda] has joined #bitcoin-core-dev
23:03 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev
23:03 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host]
23:03 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
23:06 -!- go1111111 [~go1111111@162.244.138.37] has joined #bitcoin-core-dev
23:06 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:07 -!- zveda [~zveda@unaffiliated/zveda] has left #bitcoin-core-dev ["Ex-Chat"]
23:22 -!- CodeShark_ [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev
23:28 -!- devrandom [~devrandom@unaffiliated/niftyzero1] has joined #bitcoin-core-dev
23:35 < wumpus> BlueMatt: yes, it's a time (logging the output to a file), CC=/CXX=, and a python script to process the results: https://gist.github.com/laanwj/108877a28ec03836568a
23:36 < BlueMatt> ha! ask and ye shall succeed in being lazy :)
23:47 < petertodd> interesting, got a report of Slush accepting low-S/high-S malleability: original: https://www.blocktrail.com/BTC/tx/586536ec5212cd53e243025f2dbf3330b47ac9aada1f2634ac63f590ea11f86f, mined: https://www.blocktrail.com/BTC/tx/1f94af0fbf2adc5f2ffaad45ad67d0ef844d76e879c05af4cd2c7c5ddf8ee43d
23:47 < petertodd> 01000000022fba7d9ec118ddbe16efab46781e6899d65655ae936f57d078a4779e42a19b9a020000006a473044022036b64863715dff966f48604e1cf326af7619bb6b80a9777cac8c2a8810c6e3670220167a13b85207431a1556ebc7fe2c9ac90184dbf60305072d7eb20ea7aa97c41c012102b6243b0e1571f366383a98e432aea1781de7f527b7687e27c0a01e8fc8c60d1dffffffff4ed840270c06c648899a2b2b07796591ba735ab3acec3a8439a5dfa6d9d869972d0000006a4730440220258d60de0f6135991c25d2b406950bf ...
23:47 < BlueMatt> jwtf
23:47 < BlueMatt> wtf
23:47 < petertodd> ... 6449a83821cd5630be0c7e3d8d6c6641602206e8efbef129dad1993fd3171dd908be899e76f9b336611bda4e7859f8381949501210238577ad5be7a48dc4bea10b473242cc6cb63a80887e7022a0a21005fe5b1f61fffffffff03b6c73e01000000001976a9142248f32ecfcddc8ede9ed1a45353eafffa4b15fa88acb6c73e01000000001976a9141b726719c8913fb9ff845a35a6054f2b665c951188acac704801000000001976a9142239da3ac4c7e210381178ca66d056ae212c6fe188ac00000000
23:47 < petertodd> 01000000022fba7d9ec118ddbe16efab46781e6899d65655ae936f57d078a4779e42a19b9a020000006b483045022036b64863715dff966f48604e1cf326af7619bb6b80a9777cac8c2a8810c6e367022100e985ec47adf8bce5eaa9143801d36535b92a00f0ac43990e41204fe5259e7d25012102b6243b0e1571f366383a98e432aea1781de7f527b7687e27c0a01e8fc8c60d1dffffffff4ed840270c06c648899a2b2b07796591ba735ab3acec3a8439a5dfa6d9d869972d0000006a4730440220258d60de0f6135991c25d2b406950 ...
23:47 < BlueMatt> wait, why wasnt that softforked out yet????
23:47 < petertodd> ... bf6449a83821cd5630be0c7e3d8d6c6641602206e8efbef129dad1993fd3171dd908be899e76f9b336611bda4e7859f8381949501210238577ad5be7a48dc4bea10b473242cc6cb63a80887e7022a0a21005fe5b1f61fffffffff03b6c73e01000000001976a9142248f32ecfcddc8ede9ed1a45353eafffa4b15fa88acb6c73e01000000001976a9141b726719c8913fb9ff845a35a6054f2b665c951188acac704801000000001976a9142239da3ac4c7e210381178ca66d056ae212c6fe188ac00000000
23:47 < petertodd> no, bip66 doesn't deal with low-s/hig-s
23:48 < BlueMatt> i know it doesnt
23:48 < BlueMatt> but it easily could have
23:48 < BlueMatt> i guess thats the malleability bip.....
23:48 < petertodd> well, could ave posed problems with old wallets
23:48 < CodeShark_> BIP62 does that - BIP66 was pushed out as a fix to a more urgent issue
23:48 < petertodd> (low-s/ig-s isn't related to the urgent problem of OpenSSL consensus)
23:49 < petertodd> it'd be interesting to know what exactly is slush running and/or and what parts of IsStandard() have been commented out
23:50 < BlueMatt> I'm aware of the reasons
23:50 < BlueMatt> but....its already in the fucking code......
23:50 < gmaxwell> There is no filtering of low/high S malleability.
23:50 < BlueMatt> dude, who the fuck knows what slush is running
23:50 < BlueMatt> gmaxwell: isnt it nonstandard?
23:50 < gmaxwell> NO
23:50 < gmaxwell> :)
23:50 < BlueMatt> ohhhhh
23:50 < BlueMatt> somehow i thought it was
23:50 < gmaxwell> We cannot filter it right now because filtering is incompatible with a great many signers.
23:51 < BlueMatt> i thought we had whittled that down to like one or two wallets
23:51 < gmaxwell> Even in BIP66 it was going to be version gated.
23:51 < petertodd> gmaxwell: oh, I thought we had that in IsStandard()... that takes all the fun out of it
23:51 < gmaxwell> BlueMatt: oh no, I really really doubt that. I think you're remembering chasing canonical encodings.
23:51 < gmaxwell> I wish.
23:52 < BlueMatt> i thought it was, at one point, just blockchain.info and like one or two other really strange wallets
23:52 < BlueMatt> this was a long time ago
23:52 < BlueMatt> I'm sure more exist now
23:52 < gmaxwell> I wanted to talk to petertodd about this actually.  an interesting thing to do would be to use the RBF code to prefer lows.
23:52 < petertodd> gmaxwell: haha
23:52 < gmaxwell> BlueMatt: like _anyone_ who doesn't use ECDSA code that came from us will make the wrong kind. 
23:52 < petertodd> gmaxwell: speaking of, python-bitcoinlib now does low-S right
23:53 < BlueMatt> gmaxwell: yes, that much I knew
23:53 < BlueMatt> but long ago there were't /that/ many other wallets :p
23:53 < BlueMatt> easiest solution: get one pool to just change everything mined to low-S
23:53 < BlueMatt> then people's wallets would break in largely harmless ways
23:54 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:54 < BlueMatt> probably not entirely harmless, so maybe its dangerous
23:54 < CodeShark_> one would hope ;)
23:54 < BlueMatt> but I dont see anything that would obviously break without being trivially human-fixable
23:54 < CodeShark_> I bet many wallets still track transactions by signed transaction hash
23:54 < BlueMatt> most do, I'm sure
23:55 < BlueMatt> but thats my point
23:55 < BlueMatt> you'd show two txn
23:55 < BlueMatt> and one failed
23:55 < BlueMatt> (hopefully) not a huge deal anywhere
23:56 < CodeShark_> in any case, this scenario is trivial to pull off so wallets that do think this is a big deal have a serious security issue
23:57 < CodeShark_> karpeles excuses notwithstanding ;)