--- Day changed Sun Oct 25 2015 00:00 < CodeShark> the document says "Whenever lock-in for the unknown upgrade is detected, the software should warn loudly about the upcoming soft fork. It should warn even more loudly after the next retarget period." - I'm saying if at least half the blocks in an interval show a particular set bit that we do not recognize, we should probably start warning 00:01 < CodeShark> regardless of whether or not it's locked in 00:04 < CodeShark> moreover, if we up the thresholds later on and still have soft forks deployed that have not locked in nor expired, it gets tricky 00:05 < CodeShark> 95% minimum for lock in is probably a good idea - but for warning I'd go WAY lower 00:06 < gmaxwell> but I think it should not be <50% in some analysis window. 00:06 < CodeShark> right - at least 50% 00:07 < CodeShark> it indicates that there's sufficient hash power on the network to enforce it 00:07 < CodeShark> regardless of what the actual activation mechanism might be 00:10 < gmaxwell> it also means that if someone is just trying to trigger the warning for lulz they need enough hashpower to cause much more trouble. :) 00:11 < CodeShark> right 00:12 < CodeShark> and we also need to consider cases where nVersion is not a versionbits version 00:12 < gmaxwell> CodeShark: treat as unknown versionbits. 00:13 < CodeShark> what if 25% set bit 4 and a disjoint 25% set bit 5 (and we don't recognize either bit 4 nor 5) 00:14 < CodeShark> that means 50% of versions are unknown, but they are different versions - still no hashpower majority on either 00:15 < CodeShark> the logic I was considering was checking whether nVersion starts with bits 001. If so, count each unknown bit separately for the interval. If not, use different logic 00:16 < gmaxwell> my expectation is that we should warn if half the hashpower is doing something we don't know about. 00:17 < CodeShark> that would be easiest - just count how many blocks have unrecognized nVersion (versionbits or no) within an interval 00:18 < CodeShark> if at least 50%, warn (which is similar to the current logic...except that the test is not > CBlock::CURRENT_VERSION 00:18 < sipa> but within which interval? 00:18 -!- danielsocials [~quassel@45.32.248.113] has joined #bitcoin-core-dev 00:18 < CodeShark> well, for ISM we were using a window of 1000, right? 00:18 < sipa> if the versions _are_ versionbits compatible, you can treat them as an unknown versionbits, and warn if it trigger 00:18 < CodeShark> and for the current warning system we use a window of 100 00:19 < sipa> which remains the case potentially after the window expires 00:19 < CodeShark> right - so we would check a moving window of 100 and continue warning regardless of whether or not anything strange happens afterwards 00:21 < CodeShark> I'm concerned about reading too much into the deployment mechanism...especially if we're presumably running obsolete software 00:22 < CodeShark> if half or more of hashing power is doing something we don't recognize, we better figure out what's going on 00:23 -!- danielsocials [~quassel@45.32.248.113] has quit [Ping timeout: 272 seconds] 00:25 < CodeShark> easiest would be to replace if (pindex->nVersion > CBlock::CURRENT_VERSION) ++nUpgraded; with if (CheckVersion(pindex->nVersion) != VALID) ++nUpgraded; 00:26 < CodeShark> or CheckVersion(pindex, blockRuleIndex, consensusParams) rather 00:26 < CodeShark> in 00:26 < CodeShark> UpdateTip 00:27 < CodeShark> where CheckVersion handles all the logic for determining what constitutes a recognized and valid version 00:27 < CodeShark> and use a sticky flag...once it's triggered it remains set 00:29 < CodeShark> if it *is* versionbits compatible, we can check whether it is a versionbits version and check for lock-in windows and stuff like that 00:36 -!- ParadoxSpiral [~ParadoxSp@p508B9F77.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:40 -!- ParadoxSpiral_ [~ParadoxSp@p508B8D4F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:43 -!- ParadoxSpiral [~ParadoxSp@p508B9F77.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 00:46 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Ping timeout: 255 seconds] 00:46 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev 00:51 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Ping timeout: 244 seconds] 00:52 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev 00:55 -!- danielsocials [~quassel@45.32.248.113] has joined #bitcoin-core-dev 01:34 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mgngsvojfrzyafkk] has joined #bitcoin-core-dev 01:42 -!- rcutmore_ [~rcutmore@172.77.36.248] has joined #bitcoin-core-dev 01:43 -!- rcutmore [~rcutmore@172.77.36.248] has quit [Ping timeout: 244 seconds] 01:49 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 02:34 -!- go111111111 [~go1111111@162.244.138.37] has quit [Ping timeout: 250 seconds] 02:47 -!- go111111111 [~go1111111@104.200.154.3] has joined #bitcoin-core-dev 02:49 < GitHub9> [bitcoin] CodeShark opened pull request #6888: Clear strMiscWarning before running PartitionAlert (master...alert_tests) https://github.com/bitcoin/bitcoin/pull/6888 02:57 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 03:09 -!- pigeons [~pigeons@94.242.209.214] has quit [Remote host closed the connection] 03:21 -!- pigeons [~pigeons@94.242.209.214] has joined #bitcoin-core-dev 03:21 -!- pigeons is now known as Guest25608 03:38 -!- danielsocials [~quassel@45.32.248.113] has quit [Remote host closed the connection] 04:11 -!- danielsocials [~quassel@45.32.248.113] has joined #bitcoin-core-dev 04:15 -!- danielsocials [~quassel@45.32.248.113] has quit [Remote host closed the connection] 04:16 -!- danielsocials [~quassel@45.32.248.113] has joined #bitcoin-core-dev 04:17 -!- danielsocials [~quassel@45.32.248.113] has quit [Remote host closed the connection] 04:49 -!- CodeShark [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 264 seconds] 05:30 -!- CodeShark [~androirc@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev 05:32 < CodeShark> wumpus: should I open an issue for PR #6888? 06:13 < wumpus> don't think that's necessary 06:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mgngsvojfrzyafkk] has quit [Quit: Connection closed for inactivity] 07:03 -!- Thireus1 [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev 07:05 -!- Thireus [~Thireus@icy.thireus.fr] has quit [Ping timeout: 246 seconds] --- Log closed Sun Oct 25 07:14:16 2015 --- Log opened Sun Oct 25 07:14:46 2015 07:14 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 07:14 -!- Irssi: #bitcoin-core-dev: Total of 78 nicks [0 ops, 0 halfops, 0 voices, 78 normal] 07:14 !cameron.freenode.net [freenode-info] channel trolls and no channel staff around to help? please check with freenode support: http://freenode.net/faq.shtml#gettinghelp 07:15 -!- Thireus1 [~Thireus@icy.thireus.fr] has quit [Ping timeout: 265 seconds] 07:18 -!- Thireus1 [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev 07:18 -!- Thireus [~Thireus@icy.thireus.fr] has quit [Remote host closed the connection] 07:21 -!- Thireus [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev 07:23 -!- Irssi: Join to #bitcoin-core-dev was synced in 524 secs 07:24 -!- Thireus1 [~Thireus@icy.thireus.fr] has quit [Ping timeout: 250 seconds] 08:35 -!- rcutmore_ [~rcutmore@172.77.36.248] has quit [Quit: Leaving] 09:09 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:18 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ijvqzdijcfdlarqz] has joined #bitcoin-core-dev 09:35 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 255 seconds] 09:36 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 10:04 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 10:07 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 10:44 -!- CodeShark_ [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev 10:56 -!- maaku__ [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has quit [Read error: Connection reset by peer] 10:57 -!- CodeShark_ [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 246 seconds] 10:57 -!- belcher [~user@unaffiliated/belcher] has quit [Disconnected by services] 10:57 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 10:58 -!- challisto [~challisto@c-76-16-149-33.hsd1.il.comcast.net] has joined #bitcoin-core-dev 10:58 -!- challisto [~challisto@c-76-16-149-33.hsd1.il.comcast.net] has quit [Changing host] 10:58 -!- challisto [~challisto@unaffiliated/challisto] has joined #bitcoin-core-dev 13:06 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 13:15 -!- JoeLiu [uid88238@gateway/web/irccloud.com/x-bxoeeszbjbfotwos] has joined #bitcoin-core-dev 13:52 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 14:05 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 14:08 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 14:15 -!- ParadoxSpiral_ [~ParadoxSp@p508B8D4F.dip0.t-ipconnect.de] has quit [Quit: cya] 14:17 -!- CodeShark_ [CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev 14:59 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:25 -!- JoeLiu [uid88238@gateway/web/irccloud.com/x-bxoeeszbjbfotwos] has quit [Quit: Connection closed for inactivity] 15:32 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 15:34 < gmaxwell> uh. hm. this looks wrong in my logs. "connection from x:y accepted" then after ver/verack "Moving x:y to tried". 15:34 < gmaxwell> Just becausewe got a connection _from_ something does not make it addrman tried. 15:38 -!- go111111111 [~go1111111@104.200.154.3] has quit [Quit: Leaving] 15:44 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:15 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 16:27 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 16:27 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Max SendQ exceeded] 16:27 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:07 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 17:10 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 17:25 -!- CodeShark [~androirc@cpe-76-167-237-202.san.res.rr.com] has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )] 17:25 -!- CodeShark_ [CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [] 17:25 -!- CodeShark [CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev 17:38 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 17:40 -!- evoskuil [~evoskuil@c-73-225-134-208.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 17:41 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 18:10 -!- evoskuil [~evoskuil@c-73-225-134-208.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:13 -!- CodeShark [CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 250 seconds] 18:14 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ijvqzdijcfdlarqz] has quit [Quit: Connection closed for inactivity] 18:23 -!- jgarzik [~jgarzik@unaffiliated/jgarzik] has quit [Quit: Leaving] 19:01 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 246 seconds] 19:02 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 19:40 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:47 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving] 19:54 < BlueMatt> someone wanna kick travis on #6875 19:57 < sipa> done 19:58 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer] 19:59 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 20:05 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 20:29 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:16 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 21:19 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 240 seconds] 21:19 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:20 -!- JoeLiu [uid88238@gateway/web/irccloud.com/x-eaaqgywbjydjzzlg] has joined #bitcoin-core-dev 21:24 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:30 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 22:08 -!- go1111111 [~go1111111@162.244.138.37] has joined #bitcoin-core-dev 22:13 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:32 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:33 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Client Quit] 23:25 -!- JoeLiu [uid88238@gateway/web/irccloud.com/x-eaaqgywbjydjzzlg] has quit [Quit: Connection closed for inactivity]