--- Day changed Sat Oct 31 2015
01:08 < GitHub195> [bitcoin] laanwj opened pull request #6919: Backport chainstate obfuscation to 0.11 (0.11...2015_10_backport_chainstate_obfuscation) https://github.com/bitcoin/bitcoin/pull/6919
01:09 < gmaxwell> wumpus: sorry if I came across as suggesting we should wait on #6917 for any reason; that wasn't my goal. Rather, earlier you mentioned some doubt on which sync operation needed to do what, and maybe the new behavior is too strong, and my thought was if there isn't a performance regression "who cares, don't bother thinking about it."
01:15 -!- dixson3 [~dixson3@cpe-72-182-110-15.austin.res.rr.com] has quit [Read error: Connection reset by peer]
01:15 < wumpus> I think that optimization on windows should be a different issue. It's not like we ever paid attention to that before :-) I agree with sipa that benchmarking before and after would be nice - though I'm not sure exactly how - I have a slow windows laptop, probably bogged down by lots of crap, so I doubt it will yield any resuls within the noise margin :-)
01:17 < wumpus> (that said, having looked at various syncs of block 0 to block 200000, I didn't notice any noticable difference)
01:18 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Remote host closed the connection]
01:18 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev
01:20 < wumpus> (and benchmarking in wine wouldn't be interesting, as these are exactly the OS specific things...)
01:24 < wumpus> goal of Flush() seems to be 'flush application and OS buffers to file' and Sync() 'flush buffers to file, then wait for sync to disk to complete'. As far as I see windows' FlushFileBuffers has no way to distinguish between them
01:25 < wumpus> what the previous implementation did was to leave Flush() empty. But that doesn't feel right at least...
01:26 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Remote host closed the connection]
01:27 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev
01:36 < wumpus> ... it's something that could be done again later if it turns out to be safe
01:39 < wumpus> (e.g. I think the rationale for that is "by using the OS API directly, anything written is by definition flushed to the OS". The POSIX implementation uses FILE* which has its own bufers)
01:40 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mukbbbuzallrncty] has joined #bitcoin-core-dev
01:42 < wumpus> (then uses fflush in Flush(), "forces a write of all user-space buffered data for the given output or update stream via the stream's underlying write function". Yeah we don't need that...)
01:50 < GitHub48> [bitcoin] Diapolo opened pull request #6920: remove unneded include from rpcserver.cpp and rpcclient.cpp (master...univalue) https://github.com/bitcoin/bitcoin/pull/6920
01:51 < gmaxwell> Can we ask diapolo to test this leveldb fix?
01:58 < GitHub69> [bitcoin] Diapolo opened pull request #6921: [Trivial] remove unneeded spaces from init.cpp (master...trivial_typo_space) https://github.com/bitcoin/bitcoin/pull/6921
01:59 < wumpus> I think so!
01:59 < gmaxwell> Does github have messaging?
02:00 < wumpus> nope, all you can do si @ someone
02:00 -!- deepcore [~deepcore@2a01:79d:469e:ed94:8e70:5aff:fe5c:ae78] has joined #bitcoin-core-dev
02:02 < wumpus> for those that like living on the edge: https://github.com/laanwj/bitcoin/commit/2fc32341cc6cbede2238151888ddc91ca93c7740
02:02 < gmaxwell> "The edge of what?" "No one is sure..."
02:03 < wumpus> yes, that edge ;-)
02:03 < gmaxwell> Writefile and such isn't buffered like (some) libc functions?
02:05 < wumpus> it's more like write() - a sytem call
02:07 < wumpus> using libc and FILE* would be possible on windows too, but I'm not convinced of those in mingw
02:08 < wumpus> (and the Sync requires an ugly construct to unwrap the file handle then, as we do here https://github.com/bitcoin/bitcoin/blob/master/src/util.cpp#L608 )
02:14 < GitHub10> [bitcoin] Diapolo opened pull request #6922: minor updates/changes in txmempool.h/.cpp (master...txmempool) https://github.com/bitcoin/bitcoin/pull/6922
02:15 < wumpus> sigh....
02:15  * wumpus kicks diapolo
02:21 < wumpus> way to drown out the super cool work have been doing lately in 'let's fudge two lines areound' kind of pulls...
02:21 < wumpus> +people
02:25 < wumpus> "strip: unable to rename 'bitcoin-qt.exe'; reason: File exists"
02:32 < CodeShark> do node count statistics going back more than two years exist? or at least reasonable estimates?
02:33 < CodeShark> or if not continuous data at least a few discrete samples
02:36 < wumpus> I don't think so (you may be better off asking in #bitcoin though, apart from the counting methodology this is not essentially dev related)
03:07 < GitHub88> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/48b5b84ee511...a6e80e401716
03:07 < GitHub88> bitcoin/master c939792 Peter Todd: Add BIP65 CHECKLOCKTIMEVERIFY to release notes
03:07 < GitHub88> bitcoin/master a6e80e4 Wladimir J. van der Laan: Merge pull request #6883...
03:07 < GitHub104> [bitcoin] laanwj closed pull request #6883: Add BIP65 CHECKLOCKTIMEVERIFY to release notes (master...cltv-release-notes-v0.12.0) https://github.com/bitcoin/bitcoin/pull/6883
03:08 < gmaxwell> FWIW, I think testnet has activated BIP65.
03:08 < phantomcircuit> gmaxwell, not clear to me which chain is longer though...
03:24 < tulip> phantomcircuit: on 0.11.0 I'm seeing the expected "This version is obsolete; upgrade required!". 
03:27 < phantomcircuit> the chains are equal length now...
03:31 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
03:35 < GitHub125> [bitcoin] laanwj closed pull request #6921: [Trivial] remove unneeded spaces from init.cpp (master...trivial_typo_space) https://github.com/bitcoin/bitcoin/pull/6921
03:38 < tulip> phantomcircuit: yeah, bouncing between tips. 
03:39 -!- jgarzik [~jgarzik@unaffiliated/jgarzik] has joined #bitcoin-core-dev
03:45 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
04:05 < GitHub197> [bitcoin] laanwj closed pull request #6920: remove unneded include from rpcserver.cpp and rpcclient.cpp (master...univalue) https://github.com/bitcoin/bitcoin/pull/6920
04:17 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
04:27 < GitHub161> [bitcoin] Diapolo closed pull request #6922: minor updates/changes in txmempool.h/.cpp (master...txmempool) https://github.com/bitcoin/bitcoin/pull/6922
04:27 < GitHub49> [bitcoin] Diapolo closed pull request #6710: [Qt] polish new ban ui from #6315 (master...polish_ban_ui) https://github.com/bitcoin/bitcoin/pull/6710
04:27 < GitHub100> [bitcoin] Diapolo closed pull request #6371: banlist updates (master...banlist) https://github.com/bitcoin/bitcoin/pull/6371
04:28 < GitHub180> [bitcoin] Diapolo closed pull request #6309: [Qt] simplify code for third party TX urls handling (master...txurls) https://github.com/bitcoin/bitcoin/pull/6309
04:28 < GitHub0> [bitcoin] Diapolo closed pull request #5466: [Qt] log cert errors for payment requests and harden test-cases (master...pr_harden_certchecks) https://github.com/bitcoin/bitcoin/pull/5466
04:48 -!- CodeShark [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit []
04:49 -!- CodeShark [~androirc@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev
04:49 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer]
04:50 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
05:00 < jonasschnelli> ^^ Diaplolo is closing..
05:05 -!- CodeShark [~androirc@cpe-76-167-237-202.san.res.rr.com] has quit [Read error: Connection reset by peer]
05:05 -!- CodeShark [~androirc@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev
05:23 -!- tulip [~tulip@162.248.140.238] has quit [Remote host closed the connection]
05:27 -!- tulip [~tulip@162.248.140.238] has joined #bitcoin-core-dev
05:34 < dcousens> and deleting
05:38 < dcousens> shouldn't BIP65 be Accepted now?
06:06 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
06:09 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
06:19 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Quit: Lost terminal]
06:24 -!- deepcore [~deepcore@2a01:79d:469e:ed94:8e70:5aff:fe5c:ae78] has quit [Quit: WeeChat 1.3]
06:33 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds]
06:58 -!- Thireus [~Thireus@icy.thireus.fr] has quit [Ping timeout: 246 seconds]
06:59 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
07:01 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Client Quit]
07:28 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:26 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
08:28 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
08:42 -!- tulip [~tulip@162.248.140.238] has quit [Remote host closed the connection]
08:44 -!- Thireus [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev
09:33 -!- deepcore [~deepcore@2a01:79d:469e:ed94:8e70:5aff:fe5c:ae78] has joined #bitcoin-core-dev
09:40 -!- michagogo [uid14316@wikia/Michagogo] has quit [Ping timeout: 240 seconds]
09:41 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-avugwtnzabxkdvts] has quit [Ping timeout: 240 seconds]
09:44 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-ceultjcinaikhrfz] has joined #bitcoin-core-dev
09:47 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev
09:54 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
10:22 -!- zooko [~user@c-73-217-96-13.hsd1.co.comcast.net] has joined #bitcoin-core-dev
10:37 -!- zooko` [~user@c-73-217-16-2.hsd1.co.comcast.net] has joined #bitcoin-core-dev
10:39 -!- zooko [~user@c-73-217-96-13.hsd1.co.comcast.net] has quit [Ping timeout: 244 seconds]
11:44 -!- zooko` [~user@c-73-217-16-2.hsd1.co.comcast.net] has quit [Quit: ERC Version 5.3 (IRC client for Emacs)]
11:45 -!- zooko [~user@c-73-217-16-2.hsd1.co.comcast.net] has joined #bitcoin-core-dev
12:00 < gmaxwell> dcousens: no, accepted status changes based on adoption in the network.
12:00 < gmaxwell> who gives a crap what some random software repository does?
12:22 -!- zooko [~user@c-73-217-16-2.hsd1.co.comcast.net] has quit [Ping timeout: 246 seconds]
13:42 -!- CodeShark_ [CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev
13:58 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.]
14:35 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
14:35 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Client Quit]
14:40 < phantomcircuit> gmaxwell, the chainwork value in getblockchaininfo 
14:40 < phantomcircuit> lower values means more total work right?
14:43 < phantomcircuit> heh well this certainly shows that a 75% threshold for switch over is a bad idea
14:43 < phantomcircuit> testnet is now 50/50 split between bip65 and !bip65
14:45 < CodeShark_> still? lol
14:50 < phantomcircuit> there's even someone mining version=2 blocks still
14:51 < phantomcircuit> also no bigger numbers == more work
14:56 -!- ParadoxSpiral_ [~ParadoxSp@p508B961F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
15:00 -!- ParadoxSpiral [~ParadoxSp@p508B8237.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
15:01 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
15:04 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Client Quit]
15:04 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
15:04 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Client Quit]
15:04 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
15:15 < GitHub162> [bitcoin] BTCDDev opened pull request #6925: Added zmq flag for owned transactions (master...master) https://github.com/bitcoin/bitcoin/pull/6925
15:21 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
15:46 -!- ParadoxSpiral_ [~ParadoxSp@p508B961F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
16:02 -!- zooko [~user@c-73-217-16-2.hsd1.co.comcast.net] has joined #bitcoin-core-dev
17:00 -!- deepcore [~deepcore@2a01:79d:469e:ed94:8e70:5aff:fe5c:ae78] has quit [Ping timeout: 268 seconds]
17:24 -!- CodeShark [~androirc@cpe-76-167-237-202.san.res.rr.com] has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )]
17:24 -!- CodeShark_ [CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit []
17:24 -!- CodeShark [CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev
18:31 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds]
18:36 -!- zooko [~user@c-73-217-16-2.hsd1.co.comcast.net] has quit [Ping timeout: 250 seconds]
18:40 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has left #bitcoin-core-dev []
19:05 -!- CodeShark [CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 246 seconds]
19:11 -!- zooko [~user@2601:281:8001:26aa:6588:f178:279a:eea8] has joined #bitcoin-core-dev
19:33 -!- ProfMac [~ProfMac@2001:470:b8ac:0:b46d:2b0a:b968:5ef5] has joined #bitcoin-core-dev
19:34 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mukbbbuzallrncty] has quit [Quit: Connection closed for inactivity]
21:16 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
22:15 -!- CodeShark [~androirc@2600:380:744d:171f:9876:15ed:b284:bc4b] has joined #bitcoin-core-dev
22:42 -!- zooko [~user@2601:281:8001:26aa:6588:f178:279a:eea8] has quit [Ping timeout: 240 seconds]