--- Day changed Fri Dec 04 2015
00:06 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer]
00:12 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
00:43 < GitHub164> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5548d9cb11c8...792259278e4f
00:43 < GitHub164> bitcoin/master 6aadc75 Gregory Maxwell: Disconnect on mempool requests from peers when over the upload limit....
00:43 < GitHub164> bitcoin/master 7922592 Wladimir J. van der Laan: Merge pull request #7166...
00:43 < GitHub147> [bitcoin] laanwj closed pull request #7166: Disconnect on mempool requests from peers when over the upload limit. (master...mempool_p2p_when_overlimit) https://github.com/bitcoin/bitcoin/pull/7166
00:45 < GitHub63> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/6ba25d28868146d5d6dbd671881db3a58f549567
00:45 < GitHub63> bitcoin/0.12 6ba25d2 Gregory Maxwell: Disconnect on mempool requests from peers when over the upload limit....
00:45 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
00:51 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 246 seconds]
00:51 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
00:57 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-uxhhczmmeaxalvit] has joined #bitcoin-core-dev
00:58 -!- Amnez777 [~Amnez777@37.157.216.149] has quit [Changing host]
00:58 -!- Amnez777 [~Amnez777@unaffiliated/amnez777] has joined #bitcoin-core-dev
01:42 < jonasschnelli> wumpus: the message header size is always 24 bytes, correct?
01:44 < wumpus> jonasschnelli: I don't know the exact value by heart, let me see
01:44 < jonasschnelli> hmm... another magic number.
01:44 < jonasschnelli> i think i can use CMessageHeader::COMMAND_SIZE, etc.
01:44 < wumpus> CMessageHeader::HEADER_SIZE
01:45 < jonasschnelli> Right! Thanks
01:45 < wumpus> and yes, should be 24
01:48 < wumpus> jonasschnelli: did you forget it for  mapSendBytesPerCmd[std::string(pszCommand)] += nSize; ?
01:50 < jonasschnelli> wumpus: Thanks! right. there it's also required because of nSize = ssSend.size() - CMessageHeader::HEADER_SIZE
01:50 < jonasschnelli> pushed
01:51 < jonasschnelli> I'm also testing it now
01:51 < wumpus> yeah that's where I noticed (verack is outgoing message)
01:51 < wumpus> +also
01:52 -!- baldur [~baldur@pool-173-52-43-219.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
01:53 < jonasschnelli> Yes. Now it's correct. The bytesrecv/bytessent (totals per node) matches now the sum of the aggregated values.
01:54 < wumpus> nice!
01:54 -!- ParadoxSpiral [~ParadoxSp@p508B8B1C.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:58 < wumpus> maybe we want an 'other' catch-all for received commands that we don't recognize otherwise?
01:59 < wumpus> (say someone is bombarding us with large packets that we don't recognize, right now it won't show up in bytesrecv_per_cmd) - of course we have the total already, so this may be unnecessary, I don't know
01:59 < jonasschnelli> wumpus: hmm.. yes. Would be nice... and it would not introduce a mem DOS attack (if combined to one map key "other").
01:59 < wumpus> right :)
02:00 < jonasschnelli> others = total - <sum of aggregated>, ...
02:00 < jonasschnelli> we could just render that in the rpc output.
02:00 < wumpus> but it may be good to report, it's nice if numbers add up
02:01 < wumpus> the problem is that any string up to 12(?) chars can be an actual command name
02:01 < jonasschnelli> Yeah. Sure. Let me add it. I think this number is very helpful to detect strange nodes.
02:02 < wumpus> so is this the command 'other' or ... an other command... lol ok that doesn't matter much I guess, as 'other' would, being an unknown command, also go into the category 'other' . Hmm.
02:02 < jonasschnelli> use "*other*" instead of "other"? or to much magic?
02:03 < wumpus> making it distinct makes sense yes
02:03 < wumpus> I even mean even though *other* is strictly a valid command name, no one is ever actually going to agree on using that
02:04 < wumpus> yes makes sense
02:05 -!- baldur [~baldur@pool-173-52-43-219.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
02:08 < wumpus> this is nice, it allows for doing a (simple kind of, better than looking at subvers) behavioral profiling of peers
02:09 < wumpus> some peers do nothing except connect and ping! :o
02:10 < jonasschnelli> Yes. I wrote this to analyze the traffic before I wrote maxuploadtarget PR.
02:10 < jonasschnelli> And it would allow to do some clever throttling based on this data.
02:22 < wumpus> jonasschnelli: would it be a reasonable compromise to have `logAllowIncomingCmds` available via RPC somewhere (say `getnetworkinfo`)? This avoids having to add empty rows to every peer.
02:23 < jonasschnelli> wumpus: yes. That would be useful and reduce the whole rpc response size.
02:23 < jonasschnelli> getpeerinfo looks after a command that is ideal to poll... so reducing size there is fine
02:24 < wumpus> (and still accomplishes the same, the stats collector can know the total set of messages accepted by the peer)
02:24 < wumpus> right - it makes sense to try to save space there
02:26 < jonasschnelli> wumpus: Okay. Switch to your find("other") approach, but i need to pre-populate "*other*" as well (which is fine): https://github.com/bitcoin/bitcoin/pull/6589/files#diff-9a82240fe7dfe86564178691cc57f2f1R2358
02:28 < wumpus> jonasschnelli: maybe static const std::string NET_COMMAND_OTHER="*other*";   
02:28 -!- Thireus1 [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
02:28 < wumpus> jonasschnelli: then explicitly mapRecvBytesPerCmd[NET_COMMAND_OTHER] = 0;   and use the constant in the other place too
02:28 < jonasschnelli> Yeah. Better. Cleaner.
02:28 < wumpus> jonasschnelli: given how critical it is that it exist, don't think adding it to logAllowIncomingCmds is a good idea, someone may just remove it and crash everything
02:29 < wumpus> jonasschnelli: maybe add an assert(i != mapRecvBytesPerCmd.end()); before the increase just incase :p
02:29 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Ping timeout: 246 seconds]
02:29 < jonasschnelli> Yeah. Good idea.
02:31 < wumpus> (ideally we would have constants for all net commands and use those in the code instead of hardcoded strings, this avoids typos and such, but far out of scope of your pull)
02:33 < jonasschnelli> Indeed
02:41 < jonasschnelli> wumpus: Added a commit that hides the 0 entries... need to add the command list to getnetworkinfo.. will do soon.
02:41  * wumpus must have the craziest multi-stage bitcoind launch command "nice -+19 screen -d -m gdb -x run.gdbscript -args ./bitcoind -datadir=/usb/bitcoin"  (run.gdbscript is http://stackoverflow.com/a/5286038/216357 )
02:42 < jonasschnelli> hah
02:42 < wumpus> maybe I should propose it for #7111 "Recommend how to run bitcoind in a production environment"? *ducks*
02:42 < jonasschnelli> you forgot the while 1 loop (in case it crashes)
02:42 < wumpus> hahahhahaah
02:43 < jonasschnelli> ;-)
02:44 -!- CodeShark_ [~CodeShark@202.171.211.253] has quit [Ping timeout: 260 seconds]
03:15 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev
03:15 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host]
03:15 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
03:24 < wumpus> jonasschnelli: hm I got a "bitcoind: net.cpp:703: bool CNode::ReceiveMsgBytes(const char*, unsigned int): Assertion `i != mapRecvBytesPerCmd.end()' failed."
03:25 < wumpus> jonasschnelli: you're not prepopulating NET_COMMAND_OTHER, either need to re-add it to logAllowIncomingCmds, either add it or (I think preferably) add it explicilty with  mapRecvBytesPerCmd[NET_COMMAND_OTHER] = 0
03:29 -!- Thireus1 [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
03:30 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
03:39 -!- Thireus1 [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
03:42 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Ping timeout: 260 seconds]
04:01 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
04:10 -!- droark [~droark@caraway.whatbox.ca] has quit [Remote host closed the connection]
04:18 < jonasschnelli> wumpus: Fixed (force pushed)
04:26 < GitHub74> [bitcoin] laanwj opened pull request #7170: tests: Disable Tor interaction (master...2015_12_tests_nolistentor) https://github.com/bitcoin/bitcoin/pull/7170
04:26 < GitHub73> [bitcoin] laanwj opened pull request #7171: test: remove necessity to call create_callback_map (master...2015_12_p2p_test_no_cbmap) https://github.com/bitcoin/bitcoin/pull/7171
04:48 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
04:50 < wumpus> jonasschnelli: great
05:09 < wumpus> "bytesrecv_per_cmd": { "reject": 140788, } whoa some nodes send a  lot of reject
05:10 < wumpus> that's a lot for a message we don't use at all
05:12 < tulip> are people setting the "reason" string? 
05:13 < wumpus> I don't know, going to log the contents
05:15 < afk11> hmm, I am getting reject messages this morning using electrum
05:15 < afk11> the one that comes with tails :/ not great. 
05:16 < afk11> "Your transaction was rejected by the network, please upgrade away to > electrum 2.6"
05:16 < wumpus> at least that message is clear on what to do (but I don't believe it has to do with P2P network reject messages)
05:16 < tulip> that's unrelated. 
05:17 < tulip> that'll be to do with low-s signatures, older versions of Electrum generate now-invalid signatures. 
05:20 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 260 seconds]
05:22 < wumpus> we should have made reject messages optional, eg like announce headers, a 'enablerejects' message that has to be received before the node starts sending them
05:22 < wumpus> only a small extract of what nodes are sending: http://www.hastebin.com/imipusiqan.txt 
05:26 < tulip> I'm not sure why the server software doesn't just re-pack the points in the signature, guess there's a good reason. 
05:35 < wumpus> some nodes do that, but it has some other drawbacks, effectively it's malleating transactions
05:39 -!- evoskuil [~evoskuil@202.171.211.253] has joined #bitcoin-core-dev
06:01 < GitHub93> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/f31955d9da152e5e849575f0297f8fe1904cbfbc
06:01 < GitHub93> bitcoin/0.12 f31955d Gregory Maxwell: Replace setInventoryKnown with a rolling bloom filter....
06:43 -!- tulip [~tulip@unaffiliated/tulip] has quit [Ping timeout: 264 seconds]
06:43 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev
06:49 -!- evoskuil [~evoskuil@202.171.211.253] has quit [Ping timeout: 240 seconds]
06:51 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection]
06:58 -!- moley is now known as moli
07:07 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:19 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 250 seconds]
08:57 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
09:03 -!- tripleslash_p [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
09:04 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 245 seconds]
09:04 -!- Thireus1 [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
09:05 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
09:08 -!- tripleslash_p [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 260 seconds]
09:33 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
09:34 < Thireus> I received this a couple of hours ago: "WARNING: check your network connection, 5 blocks received in the last 4 hours (24 expected)" on my full nodes
09:34 < Thireus> there seem to be some TX flood going on, has anyone else been impacted as well?
09:34 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
09:35 < Thireus> c.f. block https://tradeblock.com/bitcoin/block/386689
09:46 -!- ParadoxSpiral_ [~ParadoxSp@p508B9024.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
09:50 -!- ParadoxSpiral [~ParadoxSp@p508B8B1C.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
10:41 -!- tulip [~tulip@unaffiliated/tulip] has quit [Ping timeout: 264 seconds]
10:42 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev
11:26 -!- treehug88 [~textual@108.30.103.59] has joined #bitcoin-core-dev
11:55 < Squidicuz>  Thireus getting the same thing
12:47 < tulip> Thireus: that seems to be buggy. other people have encountered the same thing.
12:58 < Squidicuz> I rebooted the services and it is okay for now :S
12:59 < Squidicuz> what does that message mean though?  I can't be blocks behind when minig O_o
12:59 < Squidicuz> apologies if this is the wrong channel, i just realized where I is.
13:08 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 246 seconds]
13:09 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
13:09 -!- treehug88 [~textual@108.30.103.59] has quit [Quit: Textual IRC Client: www.textualapp.com]
13:14 -!- evoskuil [~evoskuil@202.171.211.253] has joined #bitcoin-core-dev
13:28 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
13:29 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer]
13:29 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection]
13:30 -!- opitka [~0ptika@50.248.81.65] has joined #bitcoin-core-dev
14:08 -!- coco [~cocoBTC__@c-233a71d5.136-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev
14:13 < tulip> Squidicuz: it's probably on topic, if you aren't falling behind triggering that is definitely a bug. someone has encountered that before recently.
14:15 < Squidicuz> the node did not seem behind when i checked on it.  i restarted and havent gotten the messgae since.  the logs shows that bitcoind timed out a few times prior.
14:16 < tulip> timed out?
14:20 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
14:21 < Squidicuz> yes.  my connection to bitcoind timed out, I mean.
14:22 < Squidicuz> for getBlockTemplate
14:25 -!- coco [~cocoBTC__@c-233a71d5.136-1-64736c10.cust.bredbandsbolaget.se] has quit [Quit: Leaving]
15:03 -!- coco [~cocoBTC__@c-233a71d5.136-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev
15:10 -!- coco [~cocoBTC__@c-233a71d5.136-1-64736c10.cust.bredbandsbolaget.se] has quit [Quit: Leaving]
15:38 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Quit: WeeChat 1.4-dev]
15:53 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
16:06 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
16:09 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 260 seconds]
16:11 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev
16:15 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Ping timeout: 245 seconds]
16:16 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev
16:38 -!- fkhan [weechat@gateway/vpn/mullvad/x-ayqkrzoaatioinuf] has quit [Ping timeout: 250 seconds]
16:49 -!- MazrimTaim [~mazrimtai@24.186.139.223] has quit [Quit: Leaving]
16:52 -!- fkhan [weechat@gateway/vpn/mullvad/x-hdxvkwzukfsqsuxc] has joined #bitcoin-core-dev
17:07 -!- raedah [~raedah@172.56.38.178] has joined #bitcoin-core-dev
17:22 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
17:33 -!- raedah [~raedah@172.56.38.178] has quit [Remote host closed the connection]
17:34 -!- raedah [~raedah@172.56.38.178] has joined #bitcoin-core-dev
17:41 -!- evoskuil [~evoskuil@202.171.211.253] has quit [Ping timeout: 240 seconds]
18:00 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-uxhhczmmeaxalvit] has quit [Quit: Connection closed for inactivity]
18:00 -!- JackH [~Jack@host-80-43-143-143.as13285.net] has quit [Ping timeout: 246 seconds]
18:06 < randy-waterhouse> ETA on release candidate for core v0.12?
18:08 < randy-waterhouse> never mind looks I'm already testing with it :) thnx
18:22 -!- raedah [~raedah@172.56.38.178] has quit [Quit: Leaving]
18:33 -!- evoskuil [~evoskuil@202.171.211.253] has joined #bitcoin-core-dev
18:48 -!- Tera2342 [~Tera2342@223.207.200.223] has joined #bitcoin-core-dev
19:44 -!- evoskuil [~evoskuil@202.171.211.253] has quit [Ping timeout: 240 seconds]
20:05 -!- da2ce7_ [~da2ce7@umpqggw.cloudapp.net] has joined #bitcoin-core-dev
20:15 -!- da2ce7_ [~da2ce7@umpqggw.cloudapp.net] has quit [Quit: ZNC - http://znc.in]
20:15 -!- da2ce7_ [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev
20:18 -!- da2ce7_ [~da2ce7@opentransactions/dev/da2ce7] has quit [Client Quit]
20:19 -!- da2ce7_mobile [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev
20:54 < Luke-Jr> hmm, I setup the BitcoindComparisonTool and it works on master, but not 0.11? O.o
21:02 < gmaxwell> randy-waterhouse: 0.12 is a couple months out; so no RC s yet
21:20 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
21:43 -!- CodeShark_ [~CodeShark@202.171.211.253] has joined #bitcoin-core-dev
21:45 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 245 seconds]
22:08 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Quit: .]
22:09 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
22:26 -!- Tera2342 [~Tera2342@223.207.200.223] has quit [Ping timeout: 246 seconds]
23:07 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 246 seconds]
23:19 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 250 seconds]