--- Day changed Mon Dec 07 2015
00:10 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Ping timeout: 246 seconds]
00:22 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
00:25 -!- xiangfu [~xiangfu@202.83.241.113] has joined #bitcoin-core-dev
00:40 -!- Tera2342 [~Tera2342@171.4.232.133] has quit [Ping timeout: 260 seconds]
00:45 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer]
00:47 -!- tulip [~tulip@unaffiliated/tulip] has quit [Ping timeout: 264 seconds]
00:47 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev
00:53 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
00:56 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
00:56 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
00:56 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]
00:58 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
00:58 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
00:58 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
01:07 < dcousens> When was mempool priority broken?
01:07 < dcousens> OOI?
01:15 < Luke-Jr> dcousens: it's "broken" by mempool trimming, because the trimmer ignores it
01:16 < Luke-Jr> re Lightsword's TBV-in-another-thread stuff: any reason not to just fork() and do it that way? seems potentially more efficient
01:16 < dcousens> Luke-Jr: right, but thats only been introduced in the changes for 0.12 right
01:17 < Luke-Jr> dcousens: yes, it's fine in <0.12
01:19 < dcousens> Luke-Jr: so why is it constantly being used as an excuse for restoring priority
01:20 < dcousens> When, the changes which break priority in the first place aren't even in the wild
01:20 < dcousens> for not* restoring prio...
01:20 < Luke-Jr> dcousens: I don't support removing priority, so I'm the wrong person to ask.
01:20 -!- xiangfu [~xiangfu@202.83.241.113] has quit [Ping timeout: 260 seconds]
01:20 < dcousens> I'm personally against restoring priority, but, you can't say "oh we just broke it, guess you can't use it now"
01:21 < Luke-Jr> it's not even that broken really
01:25 -!- tulip [~tulip@unaffiliated/tulip] has quit [Ping timeout: 264 seconds]
01:28 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev
01:35 -!- ParadoxSpiral [~ParadoxSp@p508B92DE.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
03:12 -!- tulip [~tulip@unaffiliated/tulip] has quit [Ping timeout: 264 seconds]
03:12 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev
03:27 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.]
03:32 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
03:33 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
03:33 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]
03:34 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
03:35 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
03:35 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
03:36 < GitHub111> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/82aff880d32f73bae28aa2cc071348ada603159b
03:36 < GitHub111> bitcoin/0.12 82aff88 Matt Corallo: Don't do mempool lookups for "mempool" command without a filter...
03:44 < GitHub147> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/075faaebf2e5...82bcf405f6db
03:44 < GitHub147> bitcoin/master 2f601d2 Wladimir J. van der Laan: test: remove necessity to call create_callback_map...
03:44 < GitHub147> bitcoin/master 82bcf40 Wladimir J. van der Laan: Merge pull request #7171...
03:44 < GitHub17> [bitcoin] laanwj closed pull request #7171: tests: remove necessity to call create_callback_map (master...2015_12_p2p_test_no_cbmap) https://github.com/bitcoin/bitcoin/pull/7171
03:45 < GitHub113> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/b2d7ada3727f026ccd83d3d64c75aab660d8053e
03:45 < GitHub113> bitcoin/0.12 b2d7ada Wladimir J. van der Laan: test: remove necessity to call create_callback_map...
04:20 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ycoquifyrwpgdjew] has quit [Ping timeout: 264 seconds]
04:22 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-recrkoozibopkqsc] has joined #bitcoin-core-dev
04:38 < Luke-Jr> ok, finally getting some usable data on priority in the real world
04:39 < Luke-Jr> back in 2014, it looks like it was about 7% of confirmed transactions
04:39 < Luke-Jr> my node has taken the lock to sync, so it will probably progress slower now
04:39 < Luke-Jr> started it at block 300031
04:49 < Luke-Jr> http://codepad.org/VCZUhPe3 look reasonable?
04:54 < GitHub85> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/82bcf405f6db...dc0305d15aa0
04:54 < GitHub85> bitcoin/master ca188c6 Jonas Schnelli: log bytes recv/sent per command
04:54 < GitHub194> [bitcoin] laanwj closed pull request #6589: log bytes recv/sent per command (master...2015/08/throttle_prework) https://github.com/bitcoin/bitcoin/pull/6589
04:54 < GitHub85> bitcoin/master dc0305d Wladimir J. van der Laan: Merge pull request #6589...
05:09 -!- ParadoxSpiral [~ParadoxSp@p508B92DE.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
05:21 < wumpus> 2015-12-07 13:12:52 peer=37 Reject tx code 66: : hash 57f07d10cc0374656d20746f6e20656566206e696d206c6f6f706d656d170000
05:21 < wumpus> 2015-12-07 13:12:52 peer=37 Reject tx code 66: : hash 3fd496b99b4874656d20746f6e20656566206e696d206c6f6f706d656d170000
05:22 < wumpus> interesting hashes :-)
05:22 < Luke-Jr> O.o
05:22 < Luke-Jr> are those in fact hashes?
05:23 < Luke-Jr> or just other data in place of them?
05:23 < wumpus> no, seems like a message format issue
05:23 < Luke-Jr> ok, good. if those were hashes, it'd be a little too close for comfort :x
05:23 < wumpus> (reason is empty, and part of the reason message ends up in the hash)
05:35 < wumpus> some peers consistently send these corrupted reject messages, but I can't quite figure out a pattern to it
05:45 -!- evoskuil [~evoskuil@202.171.211.253] has joined #bitcoin-core-dev
05:49 < Luke-Jr> wumpus: if it's literally strRejectReason being empty, that's possibly my spam filter(s)
05:49 < wumpus> I found the issue, it's sneaky
05:59 < GitHub92> [bitcoin] laanwj opened pull request #7179: net: Fix sent reject messages for blocks and transactions (master...2015_12_fix_reject_message) https://github.com/bitcoin/bitcoin/pull/7179
06:00 < wumpus> you need that ^ in your -ljr backport release as well, apart from that it is 0.11.99+ only
06:08 -!- evoskuil [~evoskuil@202.171.211.253] has quit [Ping timeout: 240 seconds]
06:16 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
06:17 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
06:19 < GitHub38> [bitcoin] laanwj opened pull request #7180: net: Account for `sendheaders` `verack` messages (master...2015_12_log_sendheaders_verack) https://github.com/bitcoin/bitcoin/pull/7180
06:27 -!- NLNico [~NLNico@unaffiliated/nlnico] has quit [Ping timeout: 260 seconds]
07:02 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:09 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 260 seconds]
07:12 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-imkciojtlmbbmjjp] has quit [Read error: Connection reset by peer]
07:12 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-vqyqhnvddknqgsyy] has joined #bitcoin-core-dev
07:30 < GitHub25> [bitcoin] laanwj opened pull request #7181: net: Add and document network messages in protocol.h (master...2015_12_network_messages) https://github.com/bitcoin/bitcoin/pull/7181
08:23 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
08:50 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
09:31 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev
09:31 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host]
09:31 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
09:37 < GitHub173> [bitcoin] Xekyo opened pull request #7183: Removed obsolete lines of code, broke continuation of loop. (master...Fix-#7182) https://github.com/bitcoin/bitcoin/pull/7183
09:47 -!- ParadoxSpiral_ [~ParadoxSp@p508B9F42.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
09:48 -!- opitka [~0ptika@50.248.81.65] has quit [Quit: Leaving]
09:50 -!- ParadoxSpiral [~ParadoxSp@p508B92DE.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
10:06 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-vqyqhnvddknqgsyy] has quit [Quit: Connection closed for inactivity]
10:14 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Quit: leaving]
10:14 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev
10:16 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Client Quit]
10:17 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev
10:45 < morcos> ok i have some questions about trying to reimplement BIP 68 in a different way.
10:46 < morcos> I don't like skipping over inputs you can't find in CheckLockTime().   That doesn't really seem necessary to me.  Why is the wallet even calling CheckLockTime() anyway.  How does it get in your wallet and not in the mempool in the first place?  I understand it could happen with some very weird reorg? 
10:47 < morcos> But essentially its very very rare to have non-final txs in your wallet, as far as i can tell.   So I propose skipping CheckLockTime() on them.  If we want to clean that up later, then we can call CheckLockTime() on wallet txs that aren't confirmed.
10:48 < morcos> Can someone tell me if this line of thinking is wrong?
11:00 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-znhkgnxspebohoix] has joined #bitcoin-core-dev
11:30 -!- raedah [~raedah@me70536d0.tmodns.net] has joined #bitcoin-core-dev
11:57 < Luke-Jr> wumpus: thanks
12:24 -!- davec [~davec@24.243.251.52] has quit [Read error: Connection reset by peer]
12:25 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
12:36 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]
12:49 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
12:59  * Luke-Jr ponders if he needs to optimise this
12:59 < Luke-Jr> so far it still looks like the priority area is consistently being used
12:59 < Luke-Jr> up to block 304325 now
13:00 < GitHub170> [bitcoin] morcos opened pull request #7184: [WIP] Implement SequenceLocks functions for BIP 68 (master...alternate68) https://github.com/bitcoin/bitcoin/pull/7184
13:04 -!- JackH [~Jack@host-80-43-143-143.as13285.net] has quit [Ping timeout: 245 seconds]
13:12 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev
13:18 -!- ParadoxSpiral_ [~ParadoxSp@p508B9F42.dip0.t-ipconnect.de] has quit [Quit: cya]
13:36 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
13:45 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
14:00 -!- raedah [~raedah@me70536d0.tmodns.net] has quit [Quit: Leaving]
14:30 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
15:16 < jcorgan> set #gnuradio MLOCK +nt
15:22 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 250 seconds]
15:24 < michagogo> The second logs link is broken.
15:40 < jcorgan> eh?
15:40 < jcorgan> did i type in wrong window?
15:58 -!- evoskuil [~evoskuil@202.171.211.253] has joined #bitcoin-core-dev
16:05 -!- xiangfu [~xiangfu@061244112001.ctinets.com] has joined #bitcoin-core-dev
16:11 < phantomcircuit> wumpus, opinion on modifying CONTIBUTORS.md to include "Reviewers should include the id of the commits which they reviewed in their comments."
16:14 < GitHub148> [bitcoin] pstratem opened pull request #7185: Note that reviewers should mention the id of the commits they reviewed. (master...2015-12-07-contributingackcommit) https://github.com/bitcoin/bitcoin/pull/7185
16:14 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection]
16:19 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
16:30 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
16:32 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-recrkoozibopkqsc] has quit [Remote host closed the connection]
17:06 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-pzungfnbfyuwucae] has joined #bitcoin-core-dev
17:08 < GitHub197> [bitcoin] pstratem closed pull request #5989: improve addr/inv trickle logic (master...trickle_fix) https://github.com/bitcoin/bitcoin/pull/5989
17:09 < GitHub36> [bitcoin] pstratem closed pull request #6745: Net: Remove "Address refresh broadcast" logic. (master...addr_known_reset) https://github.com/bitcoin/bitcoin/pull/6745
17:11 -!- bitdevsnyc [~bitdevsny@cpe-158-222-198-108.nyc.res.rr.com] has joined #bitcoin-core-dev
17:13 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
17:14 < Luke-Jr> phantomcircuit: s/id/commithash/
17:15 < phantomcircuit> Luke-Jr, please comment on pr mentioning commithash
17:15  * phantomcircuit runs
17:34 -!- Tera2342 [~Tera2342@223.207.233.146] has joined #bitcoin-core-dev
17:40 -!- bitdevsnyc [~bitdevsny@cpe-158-222-198-108.nyc.res.rr.com] has quit [Remote host closed the connection]
17:41 -!- bitdevsnyc [~bitdevsny@cpe-158-222-198-108.nyc.res.rr.com] has joined #bitcoin-core-dev
17:46 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
17:59 -!- evoskuil [~evoskuil@202.171.211.253] has quit [Ping timeout: 240 seconds]
18:04 -!- xiangfu [~xiangfu@061244112001.ctinets.com] has quit [Ping timeout: 250 seconds]
18:06 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
18:16 -!- evoskuil [~evoskuil@202.171.211.253] has joined #bitcoin-core-dev
18:31 < morcos> phantomcircuit: i apologize for the ultra bikeshed, but isn't it a bit annoying to print out two memory usage stats right next to each other, one 1000-based and one 1024-based
18:48 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
18:48 < phantomcircuit> morcos, fixed
18:49 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
19:17 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-pzungfnbfyuwucae] has quit [Quit: Connection closed for inactivity]
19:29 < Luke-Jr> gmaxwell: for blocks 300031..309685 (excluding outliers), of 2,701,513 total non-generation transactions, approximately 160,289 (5.93%) were mined by priority
19:34 < morcos> Luke-Jr: and how many of those would not have made it in by fee?  (what do you mean excluding outliers?)
19:36 < Luke-Jr> morcos: excluding blocks which my code was unable to determine the priority/fee boundary
19:43 < aj> Luke-Jr: can you tell how much of a discount they got? (ie, delta between the max/avg fee priority txs paid, versus min/avg fee non-priority txs paid)
19:47 -!- xiangfu [~xiangfu@061244112001.ctinets.com] has joined #bitcoin-core-dev
20:08 < dcousens>  Luke-Jr: were those blocks full?
20:09 < Luke-Jr> dcousens: unlikely
20:09 < dcousens> Luke-Jr: so how can you definitively say they wouldn't have been included otherwise?
20:10 < Luke-Jr> dcousens: I can't, and it doesn't seem relevant.
20:10 < dcousens> Luke-Jr: " were mined by
20:10 < dcousens>                  priority"
20:10 < Luke-Jr> if impossible requests are made, I'm just going to go back to "onus of proof is on the remove-priority camp" :P
20:11 < Luke-Jr> dcousens: yes, that's true regardless of whether they would have been included otherwise
20:11 < dcousens> Luke-Jr: haha, agreed that onus on proof is definitely on remove-priority
20:12 < dcousens> simply because, if its being used, then, maybe the altruism is worth keeping
20:31 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]
20:31 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
20:37 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Quit: Lost terminal]
20:37 < gmaxwell> Luke-Jr: I think people are just trying to get clarity on what you measured and now.
20:38 < gmaxwell> how*
20:38 < gmaxwell> 5% certantly sounds like more than just only benefiting old timers!
20:40 -!- bitdevsnyc [~bitdevsny@cpe-158-222-198-108.nyc.res.rr.com] has quit [Remote host closed the connection]
20:41 -!- bitdevsnyc [~bitdevsny@cpe-158-222-198-108.nyc.res.rr.com] has joined #bitcoin-core-dev
20:45 -!- evoskuil [~evoskuil@202.171.211.253] has quit [Ping timeout: 240 seconds]
20:55 < Luke-Jr> gmaxwell: this is specifically the results I am finding from http://codepad.org/VCZUhPe3
21:09 -!- evoskuil [~evoskuil@202.83.241.113] has joined #bitcoin-core-dev
21:52 -!- evoskuil [~evoskuil@202.83.241.113] has quit [Ping timeout: 240 seconds]
21:53 -!- evoskuil [~evoskuil@202.83.241.113] has joined #bitcoin-core-dev
22:07 < GitHub132> [bitcoin] jtimon reopened pull request #7091: Consensus build package (master...consensus-build) https://github.com/bitcoin/bitcoin/pull/7091
22:27 -!- Tera2342 [~Tera2342@223.207.233.146] has quit [Ping timeout: 244 seconds]
22:45 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
22:51 -!- bitdevsnyc [~bitdevsny@cpe-158-222-198-108.nyc.res.rr.com] has quit []
22:52 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-yrwrqxukqqscrqad] has joined #bitcoin-core-dev
23:04 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev
23:04 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host]
23:04 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
23:06 -!- evoskuil [~evoskuil@202.83.241.113] has quit [Ping timeout: 240 seconds]
23:11 -!- evoskuil [~evoskuil@202.83.241.113] has joined #bitcoin-core-dev
23:14 < GitHub171> [bitcoin] luke-jr opened pull request #7186: Backports for 0.10.5 (updated to dc0305d) (0.10...backports-for-0.10.5) https://github.com/bitcoin/bitcoin/pull/7186
23:18 -!- evoskuil [~evoskuil@202.83.241.113] has quit [Ping timeout: 240 seconds]
23:29 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
23:49 -!- JackH [~Jack@host-80-43-143-143.as13285.net] has joined #bitcoin-core-dev
23:54 -!- evoskuil [~evoskuil@202.83.241.113] has joined #bitcoin-core-dev
23:58 -!- JackH [~Jack@host-80-43-143-143.as13285.net] has quit [Ping timeout: 256 seconds]