--- Day changed Sun Jan 03 2016 00:03 -!- Guest28941 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 00:28 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:32 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:32 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mikjxjghvmcoppdt] has joined #bitcoin-core-dev 00:52 -!- alpalp [~alp@104-54-235-28.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 264 seconds] 00:54 -!- Guest28941 [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 264 seconds] 00:59 -!- Guest67149 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 01:16 -!- Guest67149 [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 260 seconds] 01:28 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 01:36 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-pdtzyoppwhbkffqf] has quit [Ping timeout: 276 seconds] 01:38 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-yffwubeuvavaqxzg] has joined #bitcoin-core-dev 01:39 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev 01:41 < tulip> petertodd: "help I removed the sticker and my wallet is empty". 01:51 -!- tulip [~tulip@unaffiliated/tulip] has quit [] 02:02 -!- adam3us [~Adium@141.8.72.43] has quit [Read error: Connection reset by peer] 02:02 -!- adam3us [~Adium@141.8.72.43] has joined #bitcoin-core-dev 02:05 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-yffwubeuvavaqxzg] has quit [Read error: Connection reset by peer] 02:08 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-znyailwkgjqbawxa] has joined #bitcoin-core-dev 02:12 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev 02:14 -!- amiller [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 02:14 -!- amiller is now known as Guest97352 02:16 -!- tulip [~tulip@unaffiliated/tulip] has quit [Client Quit] 02:20 -!- Guest97352 [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 260 seconds] 02:26 -!- amiller_ [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 02:30 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-znyailwkgjqbawxa] has quit [Read error: Connection reset by peer] 02:34 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-lfqxwlltkwlomtbc] has joined #bitcoin-core-dev 02:47 -!- amiller_ [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 276 seconds] 02:48 -!- MarcoFalke [05c7b6cb@gateway/web/cgi-irc/kiwiirc.com/ip.5.199.182.203] has joined #bitcoin-core-dev 03:12 -!- Guest63813 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 03:41 -!- Guest63813 [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 240 seconds] 03:53 -!- amiller_ [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 04:03 -!- amiller_ [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 265 seconds] 04:07 -!- zookolaptop [~user@p5DDBAF2C.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:14 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev 04:14 -!- Guest55022 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 04:30 -!- Guest55022 [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 256 seconds] 04:30 -!- trippysalmon [rob@2001:984:6466:0:51d:b5ab:ab61:bed8] has joined #bitcoin-core-dev 04:30 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 04:31 < dcousens> jonasschnelli: stranger things have happened :P 04:31 < dcousens> But sure, in any case, the intention was clear, I haven't tested it, therefore, utACK, you're right in that it has close-to no meaning in this case, but, its consistent 04:32 < dcousens> anywya. 04:52 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 276 seconds] 05:14 -!- trippysalmon [rob@2001:984:6466:0:51d:b5ab:ab61:bed8] has quit [Ping timeout: 250 seconds] 05:18 -!- Guest27073 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 05:34 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mikjxjghvmcoppdt] has quit [Quit: Connection closed for inactivity] 05:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-gpkzvxtureyuohuv] has joined #bitcoin-core-dev 05:50 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Quit: Lost terminal] 05:51 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 06:16 -!- alpalp [~alp@104-54-235-28.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 06:34 < MarcoFalke> Would it make sense to have a quick-rescan option which only rescans the utxoset? 06:35 < MarcoFalke> I don't care about transactions in 2009, but I want my current balance and only the relevant transactions to spend coins through non-rawtx api. 06:38 < Luke-Jr> MarcoFalke: internally, it would be nice if the UTXO set had a way to iterate over entries.. 06:38 < Luke-Jr> at the very least, we could use that to implement a sweepprivkey 06:38 < sipa> Luke-Jr: agree 06:39 < sipa> MarcoFalke: unsure... i dislike breaking existing invariants in the wallet (that it contains all relevant transactions) 06:50 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 06:55 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 06:56 -!- JackH [~Jack@host-80-43-143-141.as13285.net] has joined #bitcoin-core-dev 07:05 < GitHub158> [bitcoin] MarcoFalke opened pull request #7274: [debian] Bump manpages and only mention -? (master...MarcoFalke-2015-debianManpages) https://github.com/bitcoin/bitcoin/pull/7274 07:15 -!- alpalp [~alp@104-54-235-28.lightspeed.austtx.sbcglobal.net] has quit [Read error: Connection reset by peer] 07:37 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 07:39 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 07:53 < GitHub59> [bitcoin] sipa opened pull request #7276: Report non-mandatory script failures correctly (master...nonmanrep) https://github.com/bitcoin/bitcoin/pull/7276 08:01 -!- Quent1 is now known as Quent 08:08 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev 08:09 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit] 08:34 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Quit: leaving] 08:34 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev 08:36 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev 09:14 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-lfqxwlltkwlomtbc] has quit [Read error: Connection reset by peer] 09:17 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-agmenhtmpdkfqgzv] has joined #bitcoin-core-dev 09:21 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-gpkzvxtureyuohuv] has quit [Read error: Connection reset by peer] 09:22 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-uwixjgxomtvwwowu] has quit [Ping timeout: 240 seconds] 09:22 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-krldpvepevjdrtfq] has joined #bitcoin-core-dev 09:23 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-gxonomuhxjdywufo] has joined #bitcoin-core-dev 09:24 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-agmenhtmpdkfqgzv] has quit [Ping timeout: 245 seconds] 09:26 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-dheidknlxqctpcny] has joined #bitcoin-core-dev 10:03 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.] 10:04 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 10:19 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:32 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Quit: Leaving.] 10:33 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev 10:34 -!- murch [~murch@p4FE3A839.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 10:35 -!- jtoomim [~jtoomim@63.135.62.197] has joined #bitcoin-core-dev 10:38 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has joined #bitcoin-core-dev 10:46 -!- Lightsword [~Lightswor@107.170.253.193] has joined #bitcoin-core-dev 10:47 -!- Guest27073 [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 264 seconds] 10:48 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-dheidknlxqctpcny] has quit [Ping timeout: 256 seconds] 10:50 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-jiedykbaopcksenm] has joined #bitcoin-core-dev 10:53 -!- Guest35587 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 11:06 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 11:16 -!- arubi [~ese168@unaffiliated/arubi] has quit [Quit: Leaving] 11:23 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-jiedykbaopcksenm] has quit [Read error: Connection reset by peer] 11:23 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has quit [Ping timeout: 252 seconds] 11:27 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-djrzzdsuknnkkzzg] has joined #bitcoin-core-dev 11:32 -!- brg4444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has joined #bitcoin-core-dev 11:35 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-krldpvepevjdrtfq] has quit [Ping timeout: 264 seconds] 11:36 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-buzulyspiaqlmdzv] has joined #bitcoin-core-dev 11:44 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 11:59 -!- arubi [~ese168@unaffiliated/arubi] has quit [Ping timeout: 240 seconds] 12:00 -!- jtimon [~quassel@103.red-80-26-235.adsl.dynamic.ccgg.telefonica.net] has joined #bitcoin-core-dev 12:07 -!- jtimon [~quassel@103.red-80-26-235.adsl.dynamic.ccgg.telefonica.net] has quit [Remote host closed the connection] 12:22 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 12:51 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-djrzzdsuknnkkzzg] has quit [Ping timeout: 256 seconds] 12:52 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-rhkypuqgjjjjprsc] has joined #bitcoin-core-dev 12:53 -!- arubi [~ese168@unaffiliated/arubi] has quit [Quit: Leaving] 12:54 -!- c-cex-finch [uid120855@gateway/web/irccloud.com/x-beavigekgmjgdvwe] has joined #bitcoin-core-dev 13:03 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-rhkypuqgjjjjprsc] has quit [Ping timeout: 260 seconds] 13:04 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-njrhthwloirfmmgw] has joined #bitcoin-core-dev 13:19 -!- zookolaptop [~user@p5DDBAF2C.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 13:24 < MarcoFalke> Luke-Jr, I'd rather have no man page instead of some outdated one. 13:24 < MarcoFalke> Note that none of the DEFAULT_ value changes got in there 13:24 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-njrhthwloirfmmgw] has quit [Ping timeout: 240 seconds] 13:24 < MarcoFalke> Not to mention the countless fixes to the help message 13:24 < Luke-Jr> MarcoFalke: note I didn't suggest an outdated one.. 13:25 < Luke-Jr> it shouldn't be that hard to write a Python script that translates -? to a manpage 13:26 < Luke-Jr> hm, do we currently require Python to build? 13:26 -!- cryptopeddler [NSA@gateway/vpn/mullvad/x-mhdgptxxyrbeegqk] has joined #bitcoin-core-dev 13:26 < MarcoFalke> I plan to write a python script that makes travis fail if there are missing args in the help text 13:26 < Luke-Jr> missing args? 13:28 < Luke-Jr> I don't see any Python outside of tests. I guess that's in some ways good, but might complicate manpage generation 13:28 < MarcoFalke> > missing args? 13:28 < MarcoFalke> -rpccookiefile, et al 13:29 -!- zookolaptop [~user@p5DDBAF2C.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 13:29 -!- zookolaptop [~user@p5DDBAF2C.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 13:29 < MarcoFalke> I guess someone needs to run the Python from time to time... Or place it in the debian folder and mention it in the Readme? 13:30 -!- zookolaptop [~user@p5DDBAF2C.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 13:31 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev 13:37 < Luke-Jr> would be nicer to generate it during the build 13:38 -!- tulip [~tulip@unaffiliated/tulip] has quit [] 13:42 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-buzulyspiaqlmdzv] has quit [Ping timeout: 255 seconds] 13:45 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-gxonomuhxjdywufo] has quit [Ping timeout: 250 seconds] 13:45 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-yosnvfcqceztiali] has joined #bitcoin-core-dev 13:49 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-xzfkkbcdkqtkzihe] has joined #bitcoin-core-dev 14:01 -!- dagurval [~dagurval@188.166.108.147] has joined #bitcoin-core-dev 14:57 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-xzfkkbcdkqtkzihe] has quit [Ping timeout: 240 seconds] 15:00 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-yosnvfcqceztiali] has quit [Ping timeout: 272 seconds] 15:02 -!- bsm1175321 [~mcelrath@static-108-21-236-13.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 15:09 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-lmrtxkclofavzkqu] has joined #bitcoin-core-dev 15:09 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hzawfbzdvvkyzgsm] has joined #bitcoin-core-dev 15:16 -!- Guest35587 [~socrates1@li175-104.members.linode.com] has quit [Changing host] 15:16 -!- Guest35587 [~socrates1@unaffiliated/socrates1024] has joined #bitcoin-core-dev 15:16 -!- Guest35587 is now known as amiller 15:24 -!- c-cex-finch [uid120855@gateway/web/irccloud.com/x-beavigekgmjgdvwe] has quit [Quit: Connection closed for inactivity] 15:25 -!- zookolaptop [~user@p5DDBAF2C.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 15:56 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .] 15:56 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 16:01 -!- murch [~murch@p4FE3A839.dip0.t-ipconnect.de] has quit [Quit: Leaving.] 16:30 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 16:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hzawfbzdvvkyzgsm] has quit [Quit: Connection closed for inactivity] 16:54 -!- brg4444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has quit [Ping timeout: 252 seconds] 16:59 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-lmrtxkclofavzkqu] has quit [Quit: Connection closed for inactivity] 17:03 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-pzvdwcplsqlazteq] has joined #bitcoin-core-dev 17:07 < GitHub128> [bitcoin] MarcoFalke opened pull request #7280: [travis] Fail when documentation is outdated (master...MarcoFalke-2015-travisDoc) https://github.com/bitcoin/bitcoin/pull/7280 17:25 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Quit: Leaving.] 17:31 -!- MarcoFalke [05c7b6cb@gateway/web/cgi-irc/kiwiirc.com/ip.5.199.182.203] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 17:52 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev 18:29 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Ping timeout: 255 seconds] 18:31 -!- Tera2342 [~Tera2342@171.5.157.102] has joined #bitcoin-core-dev 18:31 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev 18:31 -!- Tera2342 [~Tera2342@171.5.157.102] has quit [Read error: Connection reset by peer] 18:36 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 18:37 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 19:00 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving] 19:40 -!- p15 [~p15@42.91.145.64.client.static.strong-tk2.bringover.net] has joined #bitcoin-core-dev 19:48 < dcousens> Hey all, I'm submitting a TX to a bitcoind instance and getting back a mandatory-script-verify-flag-failed (unknown error) back, which, best I can tell, is an exception being thrown? Anyone have an insight into if I can find out more without recompiling the instance with some logging to determine more? 20:04 < dcousens> k, now i'm getting 'No error' :/ bah, haha 20:05 < dcousens> (64: non-mandatory-script-verify-flag (No error)) 20:05 < dcousens> Previous error code was related to OP_CHECKSIGVERIFY being used instead of OP_CHECKSIG at the end of a script 20:17 < dcousens> k, pop_stack was throwing a runtime error, should that be mentioned in the error code? 20:18 < dcousens> If I made a PR for that as an error code, should be fine? 20:19 -!- jtoomim [~jtoomim@63.135.62.197] has quit [Ping timeout: 265 seconds] 20:22 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Remote host closed the connection] 20:23 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 20:27 -!- dermoth [~thomas@dsl-66-36-128-107.mtl.aei.ca] has quit [Read error: Connection reset by peer] 20:28 -!- dermoth [~thomas@dsl-66-36-128-107.mtl.aei.ca] has joined #bitcoin-core-dev 20:40 < GitHub20> [bitcoin] petertodd opened pull request #7281: Improve CheckInputs() comment about sig verification (master...2016-01-improve-checkinputs-comment) https://github.com/bitcoin/bitcoin/pull/7281 20:48 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has left #bitcoin-core-dev [] 20:48 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 21:00 -!- dermoth [~thomas@dsl-66-36-128-107.mtl.aei.ca] has quit [Read error: Connection reset by peer] 21:00 -!- dermoth [~thomas@dsl-66-36-128-107.mtl.aei.ca] has joined #bitcoin-core-dev 21:03 < petertodd> dcousens: link to PR? 21:03 < dcousens> Haven't made it, was asking if its worth making 21:04 < petertodd> dcousens: ah, yeah, might as well - I'm not sure I yet understand the issue 100% :) 21:04 < dcousens> tl;dr https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L62 is swallowed by https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L959-L962 21:04 < dcousens> and it'd be nice to get that information in the form a serror code 21:04 < dcousens> IMHO 21:05 < petertodd> dcousens: oh! that's not good, what called popstack() 21:05 < petertodd> ? 21:05 < dcousens> CHECKSIGVERIFY 21:05 < petertodd> odd, that shouldn't be possible? we should check the stack above 21:06 < dcousens> it only checks for 2 21:06 < dcousens> but if the opcode is verify, it pops3 21:06 < dcousens> ref: https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L822-L823 21:06 < petertodd> right, put we push to the stack just prior to that popstack 21:06 < dcousens> good point. 21:07 < dcousens> then how the... I'll investigate further, just re-IBDing my testnet so I could test it properly 21:07 < petertodd> yeah, there's something quite wrong if that's what's happening 21:08 < dcousens> well, I'm getting a "No error" upon changing the script, so, something is still wrong :S 21:08 < dcousens> I'll let you know when I find out more 21:08 < petertodd> thanks! 21:12 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev 21:41 < CodeShark> dcousens, I've rebased #6747 21:42 < CodeShark> I had stopped working on it because of versionbits...but I'm now having second thoughts about versionbits in light of the new extensibility ideas unleashed by segwit 21:42 < CodeShark> but I'm sure about decoupling soft fork activation logic from the rest of the consensus code and #6747 is a good step in that direction, IMHO 21:43 < dcousens> CodeShark: I'll have to re-ACK it later :), forgot to include my previously reviewed commit hash so diff isn't a 1-step :( 21:44 < dcousens> SegWit won't always be possible via the segwit method though? I guess it does cover a lot of the cases though 21:45 < CodeShark> we can still use block version numbers to signal basic stuff (i.e. a new fork is about to activate)...but we're no longer limited to just the version number to provide specific information 21:45 < CodeShark> we can commit to hashes of BIP specs, i.e. 21:45 < CodeShark> in a block header witness 21:46 < CodeShark> completely eliminates bit assignment and collision issues 21:47 < CodeShark> without requiring a lot of extra bandwidth nor storage since all that needs to be transmitted is the diff (and recently used stuff can be cached) 21:47 < dcousens> true 21:58 -!- tulip [~tulip@unaffiliated/tulip] has quit [] 22:02 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev 22:14 -!- Thireus1 [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 22:14 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection] 22:15 -!- tulip [~tulip@unaffiliated/tulip] has quit [] 22:20 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev 22:23 < dcousens> petertodd: "non-minimally encoded script number 22:24 < dcousens> is what was throwing, but not being shown in a error code ;) 22:24 < dcousens> and that combined with the check2 fix by sipa is why it was showing "no error" 22:24 -!- tulip [~tulip@unaffiliated/tulip] has quit [Client Quit] 22:36 < CodeShark> I'm a little confused about the script num spec. we have these op codes OP_1 through OP_16 that push the literal value on the stack. But we can also perform the same operation using two bytes where the first indicates a one byte push, right? 22:36 < CodeShark> or... 22:38 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer] 22:38 < dcousens> CodeShark: indeed, I guess it saves a byte 22:38 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:40 < CodeShark> but at the cost of needing extra rules 22:40 < dcousens> yup 22:40 < CodeShark> and consuming 16 op codes 22:41 < dcousens> Just 1 more reason for SegWit and maybe an eventual soft-fork removal of *everything* else? :P 22:43 < CodeShark> if we're consensus-enforcing minimal encodings, then technically we should always be using OP_1 through OP_16 whenever we can 22:44 < CodeShark> so 0x0101 should fail, i.e. 22:46 < dcousens> I think it does 22:46 < dcousens> Hell, it is for me atm 22:47 < dcousens> but, I might be doing something wrong, only just started debugging it 22:50 < dcousens> nvm :), agreed it can be confusing 22:57 < dcousens> petertodd: thoughts on adding more error codes for the CheckLockTime, setting a serror for the nomatch/toearly/nonfinal cases respectively? 22:57 < dcousens> (I'll happily do it, just figured I'd ask if there was a reason not too) 22:57 < dcousens> s/too/to 22:58 < dcousens> if the idea was to keep the method encapsulated, maybe 0 for success, then <0 for the various errors and we set the error in the EvalScript respectively? 23:14 -!- c-cex-finch [uid120855@gateway/web/irccloud.com/x-cvocleuykvlagkox] has joined #bitcoin-core-dev 23:40 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 23:54 -!- jannes [~jannes@092-111-146-044.static.chello.nl] has joined #bitcoin-core-dev 23:54 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev