--- Day changed Thu Jan 14 2016
00:13 < jonasschnelli> Luke-Jr: re: removing univalue subtree:
00:13 < jonasschnelli> I guess UniValue is not available over pkg managers, so people need to install the dependency by checking out the git repo and compile?
00:15 -!- jtimon [~quassel@37.134.31.126] has joined #bitcoin-core-dev
00:16 -!- guest21333 [~02@6e.17.01a8.ip4.static.sl-reverse.com] has joined #bitcoin-core-dev
00:19 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev
00:19 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host]
00:19 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
00:33 -!- guest21333 [~02@6e.17.01a8.ip4.static.sl-reverse.com] has quit [Ping timeout: 264 seconds]
00:44 -!- jtimon [~quassel@37.134.31.126] has quit [Ping timeout: 272 seconds]
00:46 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
01:07 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
01:09 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]
01:14 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Ping timeout: 255 seconds]
01:43 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Ping timeout: 240 seconds]
01:44 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev
01:51 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Ping timeout: 240 seconds]
02:02 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:39 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Quit: leaving]
02:49 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection]
03:26 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
03:58 -!- Naphex [~naphex@unaffiliated/naphex] has quit [Ping timeout: 240 seconds]
04:01 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
04:03 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
04:09 -!- jtimon [~quassel@126.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
04:46 < GitHub176> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c079d79c9a9c...2be4bb51f37c
04:46 < GitHub176> bitcoin/master 3503a78 Cory Fields: release: remove libc6 dependency from the osx signing descriptor...
04:46 < GitHub176> bitcoin/master 2be4bb5 Wladimir J. van der Laan: Merge pull request #7342...
04:46 < GitHub199> [bitcoin] laanwj closed pull request #7342: release: remove libc6 dependency from the osx signing descriptor (master...gitian-quickfix) https://github.com/bitcoin/bitcoin/pull/7342
04:47 < GitHub96> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/fbea2f64e23487636f2e490b6b0067c41545cd39
04:47 < GitHub96> bitcoin/0.12 fbea2f6 Cory Fields: release: remove libc6 dependency from the osx signing descriptor...
04:56 < GitHub64> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2be4bb51f37c...e1060c56cca7
04:56 < GitHub64> bitcoin/master fa989fb MarcoFalke: [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5)
04:56 < GitHub64> bitcoin/master e1060c5 Wladimir J. van der Laan: Merge pull request #7334...
04:57 < GitHub186> [bitcoin] laanwj closed pull request #7334: [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (master...Mf1601-qt55Workaround) https://github.com/bitcoin/bitcoin/pull/7334
05:02 -!- berndj [~berndj@azna.co.za] has quit [Ping timeout: 240 seconds]
05:07 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
05:10 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
05:15 -!- berndj [~berndj@azna.co.za] has joined #bitcoin-core-dev
05:15 -!- berndj [~berndj@azna.co.za] has quit [Excess Flood]
05:16 -!- berndj [~berndj@azna.co.za] has joined #bitcoin-core-dev
05:21 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
05:58 -!- Chris_Stewart_5 [~Chris_Ste@173-26-115-141.client.mchsi.com] has joined #bitcoin-core-dev
06:01 -!- jtimon [~quassel@126.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 265 seconds]
06:02 -!- jonasschnelli [~jonasschn@2a01:4f8:200:7025::2] has quit [Ping timeout: 250 seconds]
06:10 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev
06:23 -!- p15 [~p15@34.91.145.64.client.static.strong-tk2.bringover.net] has quit [Ping timeout: 250 seconds]
06:39 -!- Chris_Stewart_5 [~Chris_Ste@173-26-115-141.client.mchsi.com] has quit [Ping timeout: 256 seconds]
06:41 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
06:47 < sdaftuar> i was just looking over the release notes for 0.12 -- am i right in thinking we should highlight chainstate obfuscation and discuss downgrade issues that coudl result?
06:48 < sdaftuar> (i'm not that familiar with the topic but vaguely recall people talking about it before)
06:52 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev
06:54 < Luke-Jr> jonasschnelli: or depends/ would presumably also work fine
06:54 < Luke-Jr> sdaftuar: agree
06:54 < jonasschnelli> Luke-Jr: you mean for univalue?
06:55 < Luke-Jr> jonasschnelli: yes, or any other dependency
06:55 < jonasschnelli> Yes. But it would be the first dependency that would require self-compiling.
06:55 < Luke-Jr> only until package managers pick it up *shrug*
06:56 < Luke-Jr> and only in the case of the user compiling in the first place :p
07:00 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt]
07:16 < Luke-Jr> cfields: test_bitcoin: key.cpp:305: void ECC_Start(): Assertion `secp256k1_context_sign == __null' failed.
07:16 < Luke-Jr> O.o
07:40 < jgarzik> Luke-Jr, Bloq (my newco) will be submitting Fedora and Debian packages upstream for univalue
07:40 < jgarzik> that's a long process though, maybe a year 
07:40 < jgarzik> before it trickles down to a stable release
07:40 < Luke-Jr> jgarzik: cool
07:41 < jgarzik> It's not consensus critical so it makes sense as a package rather than subtree in the long term, IMO
07:42 < Luke-Jr> yeah, and we have a package manager bundled anyway
07:43 < Luke-Jr> in the meantime, here's a full stack trace with line numbers for the free bug http://codepad.org/bKXLXqia
07:45 < jgarzik> Luke-Jr, this is for a tree that is up to date with jgarzik/univalue master?
07:45 < Luke-Jr> no, this is 1.0.1
07:49 < jgarzik> Luke-Jr, any chance with http://codepad.org/u89EfIeE ?
07:49 < jgarzik> *change
07:51 < Luke-Jr> I don't have an easy way to test changes in univalue right now, so it will be a bit to answer
08:04 -!- jtimon [~quassel@126.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
08:05 < jonasschnelli> I'm fine with keeping it at jgarzik/univalue ... I think we have moved it because we wanted to get a PR merged? not sure although.
08:05 < jonasschnelli> jgarzik: nice that you try to get upstream packages!
08:09 < jgarzik> jonasschnelli, basic open source upstreaming policy :)
08:10 < Luke-Jr> #10 0xf7fca7ca in UniValue::setNumStr (this=0xffffd348, val_=…) at lib/univalue.cpp:118
08:10 < Luke-Jr> 118         val = val_;
08:11 < Luke-Jr> prior to this, val is:
08:11 < Luke-Jr> (gdb) print val
08:11 < Luke-Jr> $4 = {static npos = <optimized out>, _M_dataplus = {<std::allocator<char>> = {<__gnu_cxx::new_allocator<char>> = {<No data fields>}, <No data fields>}, 
08:11 < Luke-Jr>     _M_p = 0x567d93d4 ""}}
08:12 < jonasschnelli> ^^
08:13 < Luke-Jr> in this case the error is:
08:13 < Luke-Jr> ⁂ glibc detected ⁂ /home/ubuntu/bitcoin/src/bitcoin-cli: free(): invalid pointer: 0x567d93c8 ⁂
08:18 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
08:23 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
08:27 -!- SmiteMeSmith__ [~SmiteMeSm@WLLDON1606W-LP140-02-1279535220.dsl.bell.ca] has quit [Ping timeout: 255 seconds]
08:32 < cfields> Luke-Jr: i see that pretty often, iirc it happens if something goes wrong during startup
08:45 -!- SmiteMeSmith__ [~SmiteMeSm@WLLDON1606W-LP140-02-1279535220.dsl.bell.ca] has joined #bitcoin-core-dev
08:45 -!- SmiteMeSmith__ [~SmiteMeSm@WLLDON1606W-LP140-02-1279535220.dsl.bell.ca] has quit [Read error: Connection reset by peer]
09:09 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
09:12 -!- ryitpm [~ryitpm@87.121.52.41] has quit [Remote host closed the connection]
09:15 -!- ryitpm [~ryitpm@87.121.52.41] has joined #bitcoin-core-dev
09:18 -!- zookolaptop [~user@50.141.118.228] has joined #bitcoin-core-dev
09:20 -!- zookolaptop [~user@50.141.118.228] has quit [Read error: Connection reset by peer]
09:22 -!- zookolaptop [~user@50.141.118.228] has joined #bitcoin-core-dev
09:23 -!- zookolaptop is now known as zooko
09:23 -!- jtimon [~quassel@126.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]
09:26 < cfields> Luke-Jr: mind doing a quick check on #7322 ?
09:27 -!- zooko` [~user@50.141.118.228] has joined #bitcoin-core-dev
09:27 -!- zooko [~user@50.141.118.228] has quit [Read error: Connection reset by peer]
09:28 < Luke-Jr> testing
09:28 -!- zooko` is now known as zooko
09:30 < cfields> thanks
09:30 -!- zooko [~user@50.141.118.228] has quit [Read error: Connection reset by peer]
09:32 -!- zooko [~user@50.141.118.228] has joined #bitcoin-core-dev
09:35 < cfields> <sdaftuar> i was just looking over the release notes for 0.12 -- am i right in thinking we should highlight chainstate obfuscation and discuss downgrade issues that coudl result?
09:35 < cfields> ^^ yes
09:35 < cfields> i accidentally ran an obfuscated chainstate on an older version, didn't go well
09:38 < Luke-Jr> it didn't just immediately fail? :x
09:39 < cfields> Luke-Jr: of course, but to a casual user the "why" wouldn't be obvious
09:39 < Luke-Jr> ah
09:48 -!- adam3us [~Adium@c-98-234-64-218.hsd1.ca.comcast.net] has quit [Quit: Leaving.]
09:49 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
09:52 -!- adam3us [~Adium@c-24-4-96-213.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:57 < cfields> Luke-Jr: aha, i didn't notice the beginning of that stacktrace. facepalm.
09:57 -!- jtimon [~quassel@126.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
09:59 < Luke-Jr> ?
10:00 < cfields> Luke-Jr: it's gone off the rails already in main()
10:01 < cfields> Luke-Jr: $1 says if you build univalue static, travis passes
10:02 < Luke-Jr> cfields: that doesn't fix the problem :p
10:02 < cfields> Luke-Jr: sure, just trying to narrow it down
10:03  * Luke-Jr stabs Ubuntu for valgrind not working
10:04 < cfields> Luke-Jr: btw, you can test on travis much quicker if you delete the other builders in your .travis file
10:04 < cfields> i've resorted to that once or twice
10:05 < Luke-Jr> I have it reproduced in a gitian VM :P
10:05 < cfields> oh, great
10:07 < Luke-Jr> making univalue static in bitcoin-cli results in bitcoind crashing instead
10:07 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has joined #bitcoin-core-dev
10:07 < Luke-Jr> so you're probably right
10:08 < cfields> init order issue?
10:09 -!- MarcoFalke [c3523fc8@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.200] has joined #bitcoin-core-dev
10:15 < cfields> Luke-Jr: maybe there's an issue with cmdline args being parsed via univalue at startup? do you know what the passed-in args are?
10:18 < Luke-Jr> it doesn't seem to matter
10:19 < cfields> any args cause a crash?
10:20 < Luke-Jr> no, it needs at least rpcpassword and a method
10:20 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
10:25 < Luke-Jr> cfields: http://paste.ubuntu.com/14497754/ fixes it. :|
10:25 < cfields> wha?
10:26 < cfields> so something's assuming that it has a string value without checking it, i suppose?
10:27 < Luke-Jr> I was given this idea from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=31368
10:29 < Luke-Jr> using : val() is a crash again
10:32 < GitHub11> [bitcoin] MarcoFalke opened pull request #7345: [0.12]  	Add backwards-compatibility issues (chainstate obfuscation) to release notes (0.12...Mf1601-docObfuscation) https://github.com/bitcoin/bitcoin/pull/7345
10:37 < Luke-Jr> cfields: : val("") also crashes
10:39 -!- maaku [~quassel@botbot.xen.prgmr.com] has joined #bitcoin-core-dev
10:39 -!- maaku [~quassel@botbot.xen.prgmr.com] has left #bitcoin-core-dev ["http://quassel-irc.org - Chat comfortably. Anywhere."]
10:41 < cfields> Luke-Jr: can you build with -O0 and do a 'bt full' in gdb?
10:41 < cfields> i'm really curious now :\
10:42 < Luke-Jr> http://codepad.org/P3a2sD7h
10:43 < Luke-Jr> cfields: moving the constructor definition to the lib rather than inline, also seems to work
10:43 < cfields> Luke-Jr: yes, i was just about to suggest that
10:44 < cfields> Luke-Jr: i'm afraid it has to do with compile differences or locales
10:44 < Luke-Jr> ?
10:45 < Luke-Jr> crash remains with --disable-glibc-back-compat FWIW
10:45 < cfields> oh wait
10:59 < Luke-Jr> ?
11:00 -!- kangx [18cd8958@gateway/web/freenode/ip.24.205.137.88] has joined #bitcoin-core-dev
11:00 < cfields> i'm re-reading the _GLIBCXX_DEBUG docs, trying to see if there are issues passing objects in/out of shared libs
11:00 -!- devrando2 [6c1e673b@gateway/web/freenode/ip.108.30.103.59] has joined #bitcoin-core-dev
11:01 < cfields> Luke-Jr: can you verify that bitcoin-cli.cpp is built with those flags?
11:01 < Luke-Jr> which flags?
11:01 < btcdrak> meeting in #bitcoin-dev now
11:06 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
11:13 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
11:33 < MarcoFalke> :( Looks like travis doesn't like the nightly builds. Can someone after the meeting check https://blog.travis-ci.com/2014-05-12-why-is-my-build-not-running/
11:33 < MarcoFalke> nightly is running for 2:20 h. (2 h is the max, iirc)
11:35 < GitHub142> [bitcoin] luke-jr opened pull request #7346: 0.12 release notes: Mining Policy Changes (0.12...0.12-release-notes-mining) https://github.com/bitcoin/bitcoin/pull/7346
11:36 < Luke-Jr> cfields: what flags?
11:47 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has quit [Ping timeout: 252 seconds]
11:50 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
11:53 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev
11:56 -!- tulip [~tulip@unaffiliated/tulip] has left #bitcoin-core-dev []
11:57 -!- zooko` [~user@c-24-9-79-61.hsd1.co.comcast.net] has joined #bitcoin-core-dev
11:59 -!- zooko [~user@50.141.118.228] has quit [Ping timeout: 276 seconds]
12:13 < GitHub181> [bitcoin] morcos opened pull request #7347: Release notes about mining code changes (0.12...rnfixes2) https://github.com/bitcoin/bitcoin/pull/7347
12:13 -!- adam3us [~Adium@c-24-4-96-213.hsd1.ca.comcast.net] has quit [Quit: Leaving.]
12:17 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has joined #bitcoin-core-dev
12:19 < Luke-Jr> morcos: what's this nonsense about removal of priority code?
12:23 < Luke-Jr> I guess it predates your PR
12:23  * Luke-Jr fixes in #7346
12:24 < Luke-Jr> morcos: in any case, please rebase 7347 on top of that
12:26 -!- devrando2 [6c1e673b@gateway/web/freenode/ip.108.30.103.59] has quit [Ping timeout: 252 seconds]
12:27 < morcos> Luke-Jr: I did not add that.  I reworded what already was in the release notes that were merged.  I think if you read my changes, you'll agree they did not change meaning.
12:28 < Luke-Jr> morcos: yes, noticed that [20:23:38] <Luke-Jr> I guess it predates your PR
12:28 < morcos> oh, sorry, skipped over that
12:29 < Luke-Jr> sorry for having jumped to conclusions at first
12:30 -!- zooko` is now known as zooko
12:31 < morcos> Well as you know I think that is what we should do, but I wouldn't have suggested to put it in there without clearly pointing it out, as I know there is not complete consensus on it
12:38 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]
12:38 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
12:38 -!- zooko [~user@c-24-9-79-61.hsd1.co.comcast.net] has quit [Ping timeout: 255 seconds]
12:38 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
12:39 < Luke-Jr> sigh.. reddit.. downvoted for telling people not to use a literally random yum repository for Bitcoin Core ..
12:42 < paveljanik> and the answer was do not trust the source, read it first? ;-)
13:00 -!- MarcoFalke [c3523fc8@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.200] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
13:01 -!- MarcoFalke [c3523fc8@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.200] has joined #bitcoin-core-dev
13:15 -!- adam3us [~Adium@c-24-4-96-213.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:21 -!- BashCo [~BashCo@unaffiliated/bashco] has quit []
13:22 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
13:22 -!- murch [~murch@p4FE39FE7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
13:51 -!- [1]evoskuil [~evoskuil@c-73-225-134-208.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
13:53 -!- evoskuil [~evoskuil@c-73-225-134-208.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds]
13:53 -!- [1]evoskuil is now known as evoskuil
14:01 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
14:08 -!- brg444_ [415ce066@gateway/web/freenode/ip.65.92.224.102] has joined #bitcoin-core-dev
14:09 -!- brg444_ [415ce066@gateway/web/freenode/ip.65.92.224.102] has quit [Client Quit]
14:10 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has quit [Ping timeout: 252 seconds]
14:11 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has joined #bitcoin-core-dev
14:24 -!- MarcoFalke [c3523fc8@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.200] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
14:36 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
14:52 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
15:15 -!- murch [~murch@p4FE39FE7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
15:15 -!- murch [~murch@p4FE39FE7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
15:15 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has joined #bitcoin-core-dev
15:33 < PRab> I'm getting "cannot stat ‘base-trusty-amd64’: No such file or directory" when trying to run gbuild. Any ideas?
15:33 < Luke-Jr> cfields: http://paste.ubuntu.com/14499832/ also fixes the problem
15:33 < Luke-Jr> PRab: you need to build a trusty VM base
15:34 < PRab> Luke-Jr: How? I don't see that mentioned in https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#perform-gitian-builds
15:34 < cfields> Luke-Jr: so it's being instantiated two different ways?
15:35 < Luke-Jr> cfields: no, it seems to be a libstdc++ bug https://gcc.gnu.org/ml/libstdc++/2006-01/msg00162.html
15:36 < cfields> Luke-Jr: we don't use a custom string type, though?
15:36 < Luke-Jr> cfields: it doesn't seem to be restricted to only custom ones :/
15:36 < Luke-Jr> at least in this old version
15:36 < Luke-Jr> PRab: https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#installing-gitian
15:37 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has quit [Ping timeout: 252 seconds]
15:37 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds]
15:38 < Luke-Jr> cfields: maybe bitcoin-cli is so simple that it doesn't instantise std::string sufficiently on its own
15:38 < cfields> Luke-Jr: i still suspect that it has to do with the STDCXX debug option on a shared lib, when compiled differently
15:39 < PRab> Luke-Jr: Thanks. I didn't realize I would need to redo any of that. In the past I was able to get away with just following the release-process instructions. I'm guessing it used an older version of ubuntu before.
15:39 < Luke-Jr> I don't understand what that means. I am compiling them the same afaik
15:39 < Luke-Jr> PRab: yes
15:40 < Luke-Jr> jgarzik: so it seems this issue is probably unrelated to univalue, so 1.0.2 tag seems good to go IMO?
15:40 < cfields> Luke-Jr: apparently libstdc++ uses a single address to notate that a string is "empty", and avoids freeing it in that case. If the addresses end up being different, an empty string allocated on the bitcoin side would attempt to be freed by the lib
15:41 < cfields> which would also explain why avoiding the assignment in the header would "fix" the issue
15:41 < Luke-Jr> cfields: hmm
15:41 < Luke-Jr> how is that single address determined? :x
15:41 < cfields> Luke-Jr: you use -fPIC and our hardening opts to build the lib?
15:42 < cfields> (and visibility)
15:42 < Luke-Jr> probably not.. those shouldn't affect ABI though :|
15:42 < cfields> PIC certainly does
15:42 < cfields> though visibility would get ugly, since univalue doesn't handle it
15:43 < Luke-Jr> well, libs are going to be PIC
15:43 < JackH> hi now that we are in bitcoin-core-dev channel, can I suggest something to the core dev's openly
15:43 < Luke-Jr> that last pastebin doesn't make sense with your theory, does it?
15:44 < Luke-Jr> jgarzik: actually, maybe the std::string workaround ought to be in univalue.h?
15:44 < cfields> Luke-Jr: i must admit that one makes no sense to me
15:44 < cfields> unless it's just avoiding them being defined differently
15:46 < cfields> Luke-Jr: i'm going to see if i can reproduce locally
15:46 < Luke-Jr> cfields: want me to just open my VM to you over the net?
15:46 < cfields> oh, sure. that'd be even easier :)
15:47 < cfields> Luke-Jr: not doubting the fix, just trying to understand what's going on
15:47 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
15:48 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
15:53 < Luke-Jr> cfields: I'm currently testing the idea of putting that line in the univalue.h fwi
15:53 < Luke-Jr> fwiw
15:54 < cfields> Luke-Jr: won't that cause nasty link problems?
15:55 < Luke-Jr> I guess we'll find out <.<
15:55 < Luke-Jr> might make the compile much slower though? :/
15:55 < Luke-Jr> perhaps moving the constructors to the lib is the best option
15:56 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
15:56 -!- kangx [18cd8958@gateway/web/freenode/ip.24.205.137.88] has quit [Ping timeout: 252 seconds]
15:56 < Luke-Jr> certainly feels like this build is slower..
15:57 < Luke-Jr> cfields: ok, back to vanilla univalue; all yours
15:57 < Luke-Jr> in case you missed it, the rpc test passed with the template hack
15:58 < cfields> hmm, ok
15:58 < Luke-Jr> (Ctrl-A Esc to use pgup/pgdown keys to scroll in screen)
15:59 < Luke-Jr> (note it freezes the screen until you hit Esc again)
16:01 < cfields> yea, forgot my scrollpad doesn't play nice with a default shell config
16:02 < Luke-Jr> is there a way to configure the shell to work nicer? :o
16:03 -!- zookolaptop [~user@73.229.199.227] has joined #bitcoin-core-dev
16:03 < cfields> hmm, don't remember what i did to make it play nice
16:06 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
16:07 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has left #bitcoin-core-dev []
16:50 -!- murch [~murch@p4FE39FE7.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
17:00 < Luke-Jr> cfields: back for a bit - anything interesting?
17:00 < cfields> Luke-Jr: no, got distracted by something else. probably won't poke at it any more tonight
17:04 < Luke-Jr> cfields: did you look further into that -static-stdc++ difference?
17:04 < Luke-Jr> or should I check that/
17:04 < cfields> Luke-Jr: yea, linked without that. still crashed
17:04 < Luke-Jr> hmm
17:04 < cfields> oh wait, sec
17:07 < cfields> nm, that fixed :)
17:07 < cfields> i forgot to re-link the test binary
17:07 < Luke-Jr> >_<
17:11 < Luke-Jr> so I guess the solution is something like: 1) use static univalue in Travis/depends/releases (until the entire build uses shared libs); and 2) don't use -static-libstdc++ when building for the system
17:11 < jgarzik> Luke-Jr, ACK 1.0.2 tag
17:12 < cfields> Luke-Jr: all depends are static
17:13 < cfields> it was a bug to have it shared anyway, i just didn't say anything because the crash looked like something worth fixing
17:17 < Luke-Jr> cfields: so that solution sounds good?
17:18 < Luke-Jr> jgarzik: 1.0.2 tag when? ;)
17:19 < cfields> Luke-Jr: i don't see the point of having it in depends, personally
17:19 < Luke-Jr> cfields: 1) easy install for users; 2) needed for Travis/gitian
17:20 < cfields> Luke-Jr: eh? both of those are easier as it is now
17:20 < Luke-Jr> cfields: as it is now is just plain broken
17:20 < cfields> Luke-Jr: to clarify, in-tree seems fine to me
17:21 < Luke-Jr> cfields: to clarify, in-tree is a bug
17:21 < cfields> Luke-Jr: i don't really care strongly, but until distros are shipping it and it's easy to apt-get/emerge/yum, moving it out would be premature
17:22 < Luke-Jr> no, it's just good software development practice
17:23 < cfields> Luke-Jr: good practice is modularizing your code base and creating new upstreams. check. bad practice is making life hard for compilers by making them jump through hoops until those upstreams are rooted.
17:23 < Luke-Jr> 1 extra step does not make life hard
17:24 < cfields> Luke-Jr: i can clone a huge number of codebases and ./configure && make. anything more than that and my interest plummets quickly.
17:24 < cfields> i'm sure i'm not alone
17:24 < Luke-Jr> …
17:25 < cfields> anything more being: digging through docs, c/p cmdlines, foreign scripts, etc
17:26 < Luke-Jr> we already require more
17:28 < cfields> ?
17:29 < Luke-Jr> apt-get install or equivalent
17:29 < Luke-Jr> which you need to read docs to figure out
17:31 < Luke-Jr> cfields: how do you get the build to use depends/ without changing the prefix btw?
17:31 < cfields> yes, but more likely you'll just ./configure and i'll yell "you need openssl"
17:32 < cfields> Luke-Jr: i think that's the only trick that works.
17:33 < Luke-Jr> :/
17:33 < cfields> er wait, there's an env var
17:33 < midnightmagic> d/w 61
17:33 < cfields> CONFIG_SITE
17:33 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev
17:34 < cfields> CONFIG_SITE=depends/foo/share/config.site ./configure
17:34 < droark> Is there a reason why the OSX deterministic build notes recommend Xcode 6.1.1 and not 6.2 when grabbing the SDK? Looks like 6.2 is the last version to support Mavericks.
17:34 < cfields> should do it, i think
17:34 < cfields> droark: the sdk corresponds to the clang version we use
17:35 < Luke-Jr> cfields: I wonder if it makes sense to add a --with-depends option to set up the paths
17:35 < droark> Okay. Looks like there's a minor revision in there. I thought it wouldn't be a problem but I guess it is, or at least, it's not but 6.1.1 gets everybody on the same page. Correct?
17:36 < cfields> Luke-Jr: maybe
17:37 < cfields> droark: hmm?
17:37 < droark> https://en.wikipedia.org/wiki/Xcode#Toolchain_versions
17:38 < droark> Looks like 6.1.1 and 6.2 are almost the same unless I'm missing something.
17:38 < cfields> droark: we don't use apple's clang
17:38 < cfields> (6.2 might be fine. more likely, it just wasn't out yet last time we bumped)
17:39 < cfields> once our travis build works on Trusty, we can do another toolchain bump
17:39 < cfields> (should be in the next two weeks)
17:39 < droark> Cool. Was just curious.
17:40 < cfields> also, in the apple world, there's no such thing as a "minor revision". they break things whenever they feel like it :)
17:40 < droark> Touché.
17:41 < cfields> iirc 10.0.2 (or something like that) changed signing rules in a big way
17:41 < cfields> er, 10.10.2
17:42 < droark> I think it was 10.9.5, or maybe there were multiple changes? Anyway....
17:43 < cfields> sure, that sounds good too :)
17:44 < Luke-Jr> cfields: correct way to resolve a relative path to absolute, in configure.ac? :p
17:45 < GitHub63> [bitcoin] dcousens opened pull request #7348: MOVE ONLY: move rpc* to rpc/ (master...master) https://github.com/bitcoin/bitcoin/pull/7348
17:45 < cfields> Luke-Jr: i believe that one's always voodoo
17:46 < Luke-Jr> :|
17:47 -!- adam3us [~Adium@c-24-4-96-213.hsd1.ca.comcast.net] has quit [Quit: Leaving.]
18:08 < Luke-Jr> cfields: `make -C depends HOST=i686-pc-linux-gnu libevent` does not populate depends/i686-pc-linux-gnu/ - any idea why?
18:08 < cfields> Luke-Jr: what's with the libevent target?
18:09 < Luke-Jr> cfields: I only want libevent built/installed
18:09 < cfields> Luke-Jr: heh, depends weren't made to work that way :)
18:09 < Luke-Jr> :/
18:10 < Luke-Jr> trivial to make it work that way?
18:11 < cfields> Luke-Jr: the result is meant to be deterministic, so each package is built in its own staging area, then all packages are installed into the prefix at the end
18:11 < cfields> not really :\
18:12 < cfields> only option would be something like the NO_QT or NO_WALLET options
18:12 < cfields> but i don't like that, it's kinda abusing the system
18:13 < Luke-Jr> ok, so depends basically only makes sense for travis/gitian :/
18:13 < cfields> yes, it was designed to be a means of reproducing release build conditions reliably
18:16 < jgarzik> Luke-Jr, v1.0.2 passed local univalue travis
18:18 < Luke-Jr> thanks
18:18 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-sqqdojcnesouwuls] has quit [Quit: Connection closed for inactivity]
18:23 < dcousens> when does cs_main need to be locked?
18:24 < dcousens> (is there a reference for that?)
18:24 < dcousens> (I have a rough idea)
18:26 < dcousens> also, whats the difference between EXCLUSIVE_LOCKS_REQUIRED and just using AssertLockHeld?
18:26 -!- adam3us [~Adium@c-24-4-96-213.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:27 -!- adam3us [~Adium@c-24-4-96-213.hsd1.ca.comcast.net] has quit [Client Quit]
18:27 -!- adam3us [~Adium@c-24-4-96-213.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:49 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]
18:49 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
18:50 -!- p15 [~p15@122.91.145.64.client.static.strong-tk2.bringover.net] has joined #bitcoin-core-dev
19:22 -!- wallet42 [~wallet42@119.252.121.18] has joined #bitcoin-core-dev
19:22 < GitHub94> [bitcoin] luke-jr opened pull request #7349: Build against system UniValue when available (master...sys_univalue_opt) https://github.com/bitcoin/bitcoin/pull/7349
19:22 < GitHub199> [bitcoin] luke-jr closed pull request #7340: Replace univalue subtree with proper dependency on external UniValue (master...sys_univalue) https://github.com/bitcoin/bitcoin/pull/7340
19:26 -!- wallet42 [~wallet42@119.252.121.18] has quit [Client Quit]
19:30 -!- jtimon [~quassel@126.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds]
19:46 -!- zookolaptop [~user@73.229.199.227] has quit [Ping timeout: 272 seconds]
19:53 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has joined #bitcoin-core-dev
20:16 -!- jcorgan|away is now known as jcorgan
20:51 < Luke-Jr> cfields: ok to destroy that VM?
20:51 < cfields> sure
20:56 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 250 seconds]
20:57 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has joined #bitcoin-core-dev
21:03 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Ping timeout: 240 seconds]
21:16 < GitHub170> [bitcoin] luke-jr opened pull request #7350: Banlist updates (master...20150703_banlist_updates) https://github.com/bitcoin/bitcoin/pull/7350
21:25 -!- adam3us [~Adium@c-24-4-96-213.hsd1.ca.comcast.net] has quit [Quit: Leaving.]
21:27 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has quit [Ping timeout: 252 seconds]
21:32 -!- adam3us [~Adium@c-98-234-64-218.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:55 < dcousens> Luke-Jr: interesting, but how can I review that merge in any reasonable way?  How do I know you haven't just injected some malicious code in there?
21:56 < dcousens> I guess I could manually verify it by checking the diffs locally with my own merge?
21:56 < Luke-Jr> or just view the diff on github?
21:56 < Luke-Jr> but yeah, locally checking is the best way
21:56 < Luke-Jr> https://github.com/bitcoin/bitcoin/pull/7350/files <-- works fine
21:57 < dcousens> Assuming the merge was sane (its diff won't appear regardless)
21:58 < Luke-Jr> …
21:58 < dcousens> nvm
22:01 < dcousens> Been so long since I've used merges... forgot the semantics lol
22:01 < dcousens> well, more to the point, non-fast-forward merges
22:31 -!- jcorgan is now known as jcorgan|away
22:44 -!- MarcoFalke [c3523fc8@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.200] has joined #bitcoin-core-dev
23:01 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 246 seconds]
23:02 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
23:03 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-yzdgiprfoabrcvta] has joined #bitcoin-core-dev
23:38 -!- gmaxwell [greg@wikimedia/KatWalsh/x-0001] has joined #bitcoin-core-dev
23:44 -!- MarcoFalke [c3523fc8@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.200] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]