--- Day changed Mon Jan 18 2016
00:05 < phantomcircuit> wangchun, not even enough to buy a candy bar :P
00:10 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xllkhodregpcvmla] has joined #bitcoin-core-dev
00:11 -!- AtashiCon [arnavion@unaffiliated/arnavion] has quit [Quit: AtashiCon]
00:14 -!- murch [~murch@p4FDB723D.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:15 -!- AtashiCon [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev
00:17 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Disconnected by services]
00:17 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev
00:22 -!- JackH [~Jack@host-80-43-140-62.as13285.net] has quit [Remote host closed the connection]
00:24 -!- cjcj [82ebca3a@gateway/web/freenode/ip.130.235.202.58] has joined #bitcoin-core-dev
00:26 -!- wumpus [~wladimir@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
00:45 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
00:46 -!- wallet42 [~wallet42@otwbsc05.hicv.net] has joined #bitcoin-core-dev
00:47 -!- MarcoFalke [c3523fc9@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.201] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
00:47 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer]
00:47 -!- wallet42 [~wallet42@otwbsc05.hicv.net] has quit [Read error: Connection reset by peer]
00:48 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
01:02 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
01:06 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
01:08 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Client Quit]
01:09 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
01:11 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Client Quit]
01:12 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
01:15 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Client Quit]
01:15 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
01:21 < adnn_> The Classic fork will be successful. This is looking like the end.
01:21 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Quit: Leaving.]
01:22 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
01:22 -!- mode/#bitcoin-core-dev [+o wumpus] by ChanServ
01:23 -!- mode/#bitcoin-core-dev [+b *!*@cpe-158-222-198-108.nyc.res.rr.com] by wumpus
01:23 -!- adnn_ was kicked from #bitcoin-core-dev by wumpus [this is a propaganda free zone]
01:27 < GitHub91> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fd9356ba4eb5...f2cf071e702f
01:27 < GitHub91> bitcoin/master 4d10d2e Suhas Daftuar: Eliminate race condition in mempool_packages test
01:27 < GitHub91> bitcoin/master f2cf071 Wladimir J. van der Laan: Merge pull request #7368...
01:27 < GitHub95> [bitcoin] laanwj closed pull request #7368: [Tests] Eliminate race condition in mempool_packages.py (master...fix-package-test) https://github.com/bitcoin/bitcoin/pull/7368
01:27 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Quit: Leaving.]
01:28 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
01:30 < GitHub135> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/1488fc8eac3ab8ed58d84c6bd61b5295b01de295
01:30 < GitHub135> bitcoin/0.12 1488fc8 Suhas Daftuar: Eliminate race condition in mempool_packages test...
01:30 < GitHub191> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f2cf071e702f...2350ab28fb8c
01:30 < GitHub191> bitcoin/master bd34174 Prayag Verma: Update license year range to 2016
01:30 < GitHub191> bitcoin/master 2350ab2 Wladimir J. van der Laan: Merge pull request #7363...
01:30 < GitHub8> [bitcoin] laanwj closed pull request #7363: Update license year range to 2016 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7363
01:31 < GitHub8> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/098fcb56945fa6e445f8585890cf935825ffd079
01:31 < GitHub8> bitcoin/0.12 098fcb5 Prayag Verma: Update license year range to 2016...
01:32 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Client Quit]
01:32 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
01:32 < GitHub12> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/098fcb56945f...8b7a0f88cb91
01:32 < GitHub12> bitcoin/0.12 2e552b0 Suhas Daftuar: Mention mempool chain limits in release notes
01:32 < GitHub12> bitcoin/0.12 8b7a0f8 Wladimir J. van der Laan: Merge pull request #7367...
01:32 < GitHub144> [bitcoin] laanwj closed pull request #7367: Mention mempool chain limits in release notes (0.12...update-release-notes) https://github.com/bitcoin/bitcoin/pull/7367
01:36 < GitHub121> [bitcoin] laanwj closed pull request #7347: Release notes about mining code changes (0.12...rnfixes2) https://github.com/bitcoin/bitcoin/pull/7347
01:36 < GitHub21> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/8b7a0f88cb91...b0cb0556737b
01:36 < GitHub21> bitcoin/0.12 5cacb8f Alex Morcos: Add comment about mining changes and more about priority
01:36 < GitHub21> bitcoin/0.12 b0cb055 Wladimir J. van der Laan: Merge pull request #7347...
01:37 < GitHub94> [bitcoin] laanwj pushed 8 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/b0cb0556737b...1709cc5cb0e5
01:37 < GitHub50> [bitcoin] laanwj closed pull request #7338: Backports for 0.12.0 (updated to e289807) (0.12...backports-for-0.12.0) https://github.com/bitcoin/bitcoin/pull/7338
01:37 < GitHub94> bitcoin/0.12 6092ff2 Suriyaa Kudo: Set link from http:// to https://...
01:37 < GitHub94> bitcoin/0.12 6307beb Patrick Strateman: Note that reviewers should mention the commit hash of the commits they reviewed....
01:37 < GitHub94> bitcoin/0.12 6191a9b Jonas Schnelli: [RPC-Tests] add option to run rpc test over QT clients...
01:38 -!- p15 [~p15@27.91.145.64.client.static.strong-tk2.bringover.net] has quit [Read error: Connection reset by peer]
01:39 < GitHub33> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/1709cc5cb0e5...d04525a065ae
01:39 < GitHub33> bitcoin/0.12 fa8c497 MarcoFalke: [doc] backwards-compatibility issues due to chainstate obfuscation
01:39 < GitHub168> [bitcoin] laanwj closed pull request #7345: [0.12]  	Add backwards-compatibility issues (chainstate obfuscation) to release notes (0.12...Mf1601-docObfuscation) https://github.com/bitcoin/bitcoin/pull/7345
01:39 < GitHub33> bitcoin/0.12 d04525a Wladimir J. van der Laan: Merge pull request #7345...
01:41 -!- p15 [~p15@52.91.145.64.client.static.strong-tk2.bringover.net] has joined #bitcoin-core-dev
01:41 < GitHub153> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2350ab28fb8c...a8bd616fea62
01:41 < GitHub153> bitcoin/master 9d263bd Chris Wheeler: Typo fixes in comments
01:41 < GitHub153> bitcoin/master a8bd616 Wladimir J. van der Laan: Merge pull request #7329...
01:41 < GitHub44> [bitcoin] laanwj closed pull request #7329: Trivial: fix typo (master...typofix) https://github.com/bitcoin/bitcoin/pull/7329
01:45 < GitHub182> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a8bd616fea62...5e00147838b0
01:45 < GitHub182> bitcoin/master 0331aa3 calebogden: Fixing typos on security-check.py and torcontrol.cpp
01:45 < GitHub182> bitcoin/master 5e00147 Wladimir J. van der Laan: Merge pull request #7313...
01:45 < GitHub58> [bitcoin] laanwj closed pull request #7313: [trivial] fixing multiple typos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7313
01:46 < GitHub151> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e00147838b0...3ec5bb0a6e2c
01:46 < GitHub151> bitcoin/master 7777994 MarcoFalke: [qa] Fix pyton syntax in rpc tests
01:46 < GitHub151> bitcoin/master 3ec5bb0 Wladimir J. van der Laan: Merge pull request #7335...
01:46 < GitHub161> [bitcoin] laanwj closed pull request #7335: [qa] Fix pyton syntax in rpc tests (master...Mf1601-rpcSyntax) https://github.com/bitcoin/bitcoin/pull/7335
01:47 < GitHub0> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/d8b062d752838aa0d7141355a1341768d4c4064c
01:47 < GitHub0> bitcoin/0.12 d8b062d MarcoFalke: [qa] Fix pyton syntax in rpc tests...
01:47 -!- mode/#bitcoin-core-dev [-b *!*@cpe-158-222-198-108.nyc.res.rr.com] by wumpus
01:47 -!- blur3d [~blur3d@d114-78-45-177.rdl805.qld.optusnet.com.au] has joined #bitcoin-core-dev
01:50 < GitHub88> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/3ec5bb0a6e2c...b8f485c47284
01:50 < GitHub88> bitcoin/master fa4f4b6 MarcoFalke: Add clang-format-diff.py from the LLVM svn...
01:50 < GitHub88> bitcoin/master fa074a6 MarcoFalke: [contrib] Prepare clang-format-diff for usage
01:50 < GitHub88> bitcoin/master b8f485c Wladimir J. van der Laan: Merge pull request #7304...
01:50 < GitHub71> [bitcoin] laanwj closed pull request #7304: [contrib] Add clang-format-diff.py (master...Mf1601-clang-format-diff) https://github.com/bitcoin/bitcoin/pull/7304
01:50 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 265 seconds]
01:50 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
01:56 < GitHub156> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b8f485c47284...d3dfc6d7e18e
01:56 < GitHub156> bitcoin/master fa1cb1a MarcoFalke: [qa] Test walletpassphrase timeout
01:56 < GitHub156> bitcoin/master d3dfc6d Wladimir J. van der Laan: Merge pull request #7320...
01:56 < GitHub88> [bitcoin] laanwj closed pull request #7320: [qa] Test walletpassphrase timeout (master...Mf1601-rpcWalletPass) https://github.com/bitcoin/bitcoin/pull/7320
01:56 < GitHub119> [bitcoin] laanwj closed pull request #7060: build: Make networking work inside LXC builder in gitian-building.md (master...2015_11_gitian_building) https://github.com/bitcoin/bitcoin/pull/7060
01:57 < GitHub39> [bitcoin] laanwj reopened pull request #7060: build: Make networking work inside LXC builder in gitian-building.md (master...2015_11_gitian_building) https://github.com/bitcoin/bitcoin/pull/7060
02:18 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:22 < GitHub69> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3dfc6d7e18e...c851d8d71b2e
02:22 < GitHub69> bitcoin/master fac11ea MarcoFalke: [init] Fix error message of maxtxfee invalid amount
02:22 < GitHub69> bitcoin/master fa6ab96 MarcoFalke: [init] Add missing help for args
02:22 < GitHub69> bitcoin/master faa572a MarcoFalke: [init] Help Msg: Use Params(CBaseChainParams::MAIN)
02:22 < GitHub129> [bitcoin] laanwj closed pull request #7290:  [init] Add missing help for args  (master...Mf1601-doc) https://github.com/bitcoin/bitcoin/pull/7290
02:27 -!- MarcoFalke [81bbe594@gateway/web/cgi-irc/kiwiirc.com/ip.129.187.229.148] has joined #bitcoin-core-dev
02:32 -!- adnn [~adnn@cpe-158-222-198-108.nyc.res.rr.com] has joined #bitcoin-core-dev
02:37 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Read error: Connection reset by peer]
02:39 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
02:45 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.]
02:56 < GitHub71> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c851d8d71b2e...47c5ed19f3ba
02:56 < GitHub71> bitcoin/master 64360f1 Wladimir J. van der Laan: Make max tip age an option instead of chainparam...
02:56 < GitHub71> bitcoin/master 47c5ed1 Wladimir J. van der Laan: Merge pull request #7208...
02:56 < GitHub60> [bitcoin] laanwj closed pull request #7208: Make max tip age an option instead of chainparam (master...2015_12_maxtipage) https://github.com/bitcoin/bitcoin/pull/7208
03:11 < michagogo> wumpus: I don't suppose you have any clue why the OS X gitian build is failing so spectacularly?
03:11 < MarcoFalke> michagogo. 0.11.2 works fine?
03:12 < michagogo> Yep, I build 0.11.2 on this setup and 0.12.0rc1 windows and Linux are fine
03:12 < michagogo> And fanquake also had the same failure
03:12 < michagogo> built*
03:20 < GitHub177> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/47c5ed19f3ba...ae20172941ff
03:20 < GitHub177> bitcoin/master 94bdd71 Gregory Sanders: Added help text for chainwork value
03:20 < GitHub177> bitcoin/master ae20172 Wladimir J. van der Laan: Merge pull request #7232...
03:20 < GitHub101> [bitcoin] laanwj closed pull request #7232: [RPC] getblock: Added help text for chainwork value (master...getblockhelp) https://github.com/bitcoin/bitcoin/pull/7232
03:21 < GitHub56> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/c0d2382170962ecae72fd90d4830fcadd4c2ed30
03:21 < GitHub56> bitcoin/0.12 c0d2382 Gregory Sanders: Added help text for chainwork value...
03:22 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Quit: Leaving.]
03:22 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
03:24 < GitHub54> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae20172941ff...e4e77ee55d8a
03:24 < GitHub54> bitcoin/master 16d4fce James O'Beirne: Add assert_is_hex_string and assert_is_hash_string to RPC test utils.
03:24 < GitHub54> bitcoin/master 4745636 James O'Beirne: Add RPC documentation for getblockheader[chainwork].
03:24 < GitHub54> bitcoin/master 135d6ec James O'Beirne: Add RPC tests for getblockheader.
03:24 < GitHub73> [bitcoin] laanwj closed pull request #7194: Fix help, add RPC tests for getblockheader (master...test_getblockheader) https://github.com/bitcoin/bitcoin/pull/7194
03:26 < GitHub99> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/351ffd8482ff812e6b464c870bb4b0bff85e3884
03:26 < GitHub99> bitcoin/0.12 351ffd8 James O'Beirne: Fix help, add RPC tests for getblockheader...
03:26 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
03:26 < michagogo> wumpus: Yeah, that's not it. It's the build itself that's crashing and burning, not the signer.
03:27 < michagogo> It looks like it might be happening at the qt stage -- deps build seems fine until that point, but then something breaks in a really weird way
03:29 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Client Quit]
03:31 -!- tin_ [7da567c2@gateway/web/freenode/ip.125.165.103.194] has joined #bitcoin-core-dev
03:32 < MarcoFalke> Can you downgrade gitian-builder to something older (e.g. 29c406e1174) and test again?
03:32 < MarcoFalke> (Needs new base images)
03:33 <@wumpus> MarcoFalke, it's just the OSX build that is failing, if it was a base image problem wouldn't all the builds fail?
03:33 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
03:34 < MarcoFalke> wumpus have you been using the latest gitian builder version for the OSX build?
03:34 <@wumpus>  michagogo: no, no clue, I had some problems with LXC myself hence https://github.com/bitcoin/bitcoin/pull/7060 , but haven't heard anyone else about it (and shouldn't be macosx specific either)
03:34 <@wumpus> MarcoFalke, yes
03:34 <@wumpus> but I use KVM, not LXC
03:36 -!- tin_ [7da567c2@gateway/web/freenode/ip.125.165.103.194] has quit [Quit: Page closed]
03:38 < michagogo> wumpus: fanquake was having the same issue, also using LXC, and also only on the OS X build
03:38 -!- adnn [~adnn@cpe-158-222-198-108.nyc.res.rr.com] has quit []
03:39 <@wumpus> so yes I also have issues with LXC all the time
03:41 < michagogo> wumpus: and also, that PR is for networking, I'm preseeding the cache as mentioned in release-process
03:41 < michagogo> wumpus: idk, it mostly works for me, until something weird happens like this
03:41 < michagogo> Definitely not "all the time"
03:42 <@wumpus> the PR is not only networking, it also adds some packages that I needed
03:42 <@wumpus> (or maybe those are only networking related, I dunno)
03:43 <@wumpus> do you have a log of what goes wrong?
03:43 < michagogo> ca-certificates is definitely only networking
03:43 < michagogo> that's toget the deps over https
03:43 < michagogo> and, er...
03:43 < michagogo> the image should already have *python*... 
03:44 < michagogo> yeah, it's in scrollback
03:44 < michagogo> one sec
03:45 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
03:45 < michagogo> wumpus: so somehow build.log is being truncated:
03:45 < michagogo> https://www.dropbox.com/s/9jqnexeyvb0u1g6/build2.log?dl=0
03:46 < michagogo> I used `script` to capture a tailf of the log: https://www.dropbox.com/s/uwdejt9rczbywuq/macbuild.log?dl=0
03:47 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
03:49 <@wumpus> /usr/bin/env: python: No such file or directory
03:49 <@wumpus> make: *** [dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt] Error 127
03:49 <@wumpus> what did you say about python? :p
03:51 < michagogo> ...what.
03:51 <@wumpus> I don't think python is part of the LXC image at all, and it's necesary for macosx build
03:51 < michagogo> um.
03:52 < michagogo> What changed between 0.11 and 0.12 to make it necessary?
03:52 < michagogo> one sec, lemme run on-target dpkg -l | grep python
03:52 <@wumpus> ... or maybe it's just not part of the LXC iimage as 'python', but e.g. python2? 
03:52 <@wumpus> in most places we explicitly call it python2
03:53 <@wumpus> but I don't think that's the problem, package 'python' installs python 2
03:53 < michagogo> http://paste.ubuntu.com/14566590/
03:53 < michagogo> Looks like we only have python3
03:54 < michagogo> But that leaves 2 questions. First, why is it only needed for OS X and not for Linux or Windows?
03:54 < michagogo> And second, why is it required in 0.12 when it isn't in 0.11?
03:54 < michagogo> The descriptor diff doesn't look like it could be related
03:54  * michagogo checks the depends/ diff
03:55 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Quit: Leaving.]
03:57 < michagogo> Okay, lets try...
03:58 < michagogo> wumpus: btw, why does that PR add python to all the descriptors?
03:59 -!- MarcoFalke [81bbe594@gateway/web/cgi-irc/kiwiirc.com/ip.129.187.229.148] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
04:00 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
04:01 -!- drnet [~drnett@178.115.130.140.wireless.dyn.drei.com] has joined #bitcoin-core-dev
04:21 -!- viderizer [~viderizer@qux.fi] has joined #bitcoin-core-dev
04:21 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
04:29 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt]
04:51 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Quit: Leaving.]
05:07 < GitHub176> [bitcoin] MarcoFalke opened pull request #7370: [0.12] Doc: Wallet & Pruning  (0.12...Mf1601-docWalletPrune) https://github.com/bitcoin/bitcoin/pull/7370
05:07 -!- MarcoFalke [c3523fc9@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.201] has joined #bitcoin-core-dev
05:14 -!- jtimon [~quassel@126.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:25 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has quit [Quit: Later.]
05:26 < GitHub152> [bitcoin] MarcoFalke opened pull request #7371: [0.12] backports (0.12...Mf1601-012Backports) https://github.com/bitcoin/bitcoin/pull/7371
05:33 -!- drnet [~drnett@178.115.130.140.wireless.dyn.drei.com] has quit [Quit: Leaving]
05:44 -!- fkhan [weechat@gateway/vpn/mullvad/x-xcvwpsyzrbvpfexu] has joined #bitcoin-core-dev
06:10 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
06:13 <@wumpus> michagogo, never narrowed it down further
06:19 < GitHub126> [bitcoin] laanwj closed pull request #7360: Fix osslsigncode patch url (master...doc-fix) https://github.com/bitcoin/bitcoin/pull/7360
06:21 < GitHub27> [bitcoin] MarcoFalke opened pull request #7372: Trivial: [qa] wallet: Print maintenance (master...Mf1601-qaWalletPrint) https://github.com/bitcoin/bitcoin/pull/7372
06:22 -!- blur3d [~blur3d@d114-78-45-177.rdl805.qld.optusnet.com.au] has quit [Quit: blur3d]
06:23 -!- guest21333 [~02@a.06.01a8.ip4.static.sl-reverse.com] has joined #bitcoin-core-dev
06:24 -!- guest21333 [~02@a.06.01a8.ip4.static.sl-reverse.com] has quit [Client Quit]
06:25 < GitHub186> [bitcoin] sdaftuar opened pull request #7373: [Tests] Fix error in blockchain.py introduced in merge (master...fix-blockchain-py) https://github.com/bitcoin/bitcoin/pull/7373
06:30 < MarcoFalke> travis is overheating. Could someone nuke https://travis-ci.org/bitcoin/bitcoin/builds/103104813 & https://travis-ci.org/bitcoin/bitcoin/builds/103103829 ?
06:32 -!- Chris_Stewart_5 [~Chris_Ste@173-26-115-141.client.mchsi.com] has joined #bitcoin-core-dev
06:34 < MarcoFalke> or maybe just cancel  all running pulls other than the one from sdaftuar. They will fail anyway
06:34 < MarcoFalke> wumpus ?
06:35 <@wumpus> is there a big red button to just cancel everything?
06:36 < MarcoFalke> idk
06:37 < MarcoFalke> It is only the 4 running on https://travis-ci.org/bitcoin/bitcoin/pull_requests
06:41 <@wumpus> cool, travis has a command line tool 
06:42 < MarcoFalke> Nice, but you canceled https://travis-ci.org/bitcoin/bitcoin/builds/103118874
06:42 < MarcoFalke> This one should run ;)
06:42 < MarcoFalke> or get merged
06:42 <@wumpus> yes I'm cancelling everything, as said
06:46 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
06:47 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
06:51 -!- MarcoFalke [c3523fc9@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.201] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
06:52 -!- MarcoFalke [c3523fc9@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.201] has joined #bitcoin-core-dev
06:53 -!- brg444 [18257df2@gateway/web/freenode/ip.24.37.125.242] has joined #bitcoin-core-dev
07:00 -!- BananaLotus [~BananaLot@54.186.186.141] has quit [Remote host closed the connection]
07:00 -!- guruvan [~guruvan@unaffiliated/guruvan] has quit [Remote host closed the connection]
07:01 < GitHub101> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4e77ee55d8a...e2ed57e61e44
07:01 < GitHub101> bitcoin/master 4a04879 Suhas Daftuar: Fix error in blockchain.py introduced in merge
07:01 < GitHub101> bitcoin/master e2ed57e Wladimir J. van der Laan: Merge pull request #7373...
07:01 < GitHub56> [bitcoin] laanwj closed pull request #7373: [Tests] Fix error in blockchain.py introduced in merge (master...fix-blockchain-py) https://github.com/bitcoin/bitcoin/pull/7373
07:02 < GitHub166> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/51af87f0786d3a0c9fbff84a9648781138ab84c3
07:02 < GitHub166> bitcoin/0.12 51af87f Suhas Daftuar: Fix error in blockchain.py introduced in merge...
07:09 -!- jtimon_ [~quassel@126.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
07:09 -!- jtimon [~quassel@126.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds]
07:24 < GitHub133> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e2ed57e61e44...21376af183ff
07:24 < GitHub133> bitcoin/master facd288 MarcoFalke: [qa] wallet: Print maintenance
07:24 < GitHub133> bitcoin/master 21376af Wladimir J. van der Laan: Merge pull request #7372...
07:24 < GitHub182> [bitcoin] laanwj closed pull request #7372: Trivial: [qa] wallet: Print maintenance (master...Mf1601-qaWalletPrint) https://github.com/bitcoin/bitcoin/pull/7372
07:31 < GitHub117> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/51af87f0786d...cda064caa13e
07:31 < GitHub117> bitcoin/0.12 fa31133 MarcoFalke: [Doc] Wallet & Pruning
07:31 < GitHub95> [bitcoin] laanwj closed pull request #7370: [0.12] Doc: Wallet & Pruning  (0.12...Mf1601-docWalletPrune) https://github.com/bitcoin/bitcoin/pull/7370
07:31 < GitHub117> bitcoin/0.12 cda064c Wladimir J. van der Laan: Merge pull request #7370...
07:36 -!- zookolaptop [~user@2601:281:8000:9414:94f2:18b7:e802:caac] has joined #bitcoin-core-dev
07:42 < PRab> FYI, I've been running 0.12RC1 and maxuploadtarget appears to be working.
07:43 < PRab> I think thats a great improvement over the previous QOS setup I had.
07:44 < MarcoFalke> but maxuploadtarget isn't doing qos
07:45 < PRab> Its not, but my goal is to limit it to ~50 GB per month. I don't really care about bursts very much.
07:51 < GitHub190> [bitcoin] sdaftuar reopened pull request #7222: [WIP] RPC: Indicate which transactions are signaling opt-in RBF (master...add-optin-info) https://github.com/bitcoin/bitcoin/pull/7222
08:12 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
08:28 -!- zookolaptop [~user@2601:281:8000:9414:94f2:18b7:e802:caac] has quit [Ping timeout: 250 seconds]
08:48 -!- fkhan [weechat@gateway/vpn/mullvad/x-xcvwpsyzrbvpfexu] has quit [Ping timeout: 240 seconds]
08:52 -!- zookolaptop [~user@c-98-245-94-106.hsd1.co.comcast.net] has joined #bitcoin-core-dev
09:00 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
09:01 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 240 seconds]
09:02 -!- fkhan [weechat@gateway/vpn/mullvad/x-vzdymkrfijrhaskm] has joined #bitcoin-core-dev
09:03 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
09:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
09:18 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
09:23 -!- fkhan [weechat@gateway/vpn/mullvad/x-vzdymkrfijrhaskm] has quit [Ping timeout: 260 seconds]
09:25 < Luke-Jr> can we get *explicit* ACKs on #7300? otherwise someone has to go make sure the authors actually contributed the code themselves :/
09:28 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
09:33 -!- drnet [~drnett@178.115.130.140.wireless.dyn.drei.com] has joined #bitcoin-core-dev
09:34 < MarcoFalke> Luke-Jr, only sipa is missing
09:35 < MarcoFalke> need to ping when back online
10:12 -!- fkhan [~weechat@unaffiliated/loteriety] has joined #bitcoin-core-dev
10:16 < Luke-Jr> MarcoFalke: lots of people just posted stupid "ACK everything I contribute" which doesn't really help
10:16 < Luke-Jr> because git doesn't track who contributed things, only who wrote them
10:20 < MarcoFalke> They are legally responsible if they commit copyfraud, how is this our problem? Or asking the other way: How would it help us to get "explicit ACKs" in case a copyfraud is detected and legally pursued?
10:25 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 256 seconds]
10:37 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Read error: Connection reset by peer]
10:38 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
10:41 -!- zookolaptop [~user@c-98-245-94-106.hsd1.co.comcast.net] has quit [Ping timeout: 256 seconds]
11:17 -!- rsx [~dummy@host-188-174-215-120.customer.m-online.net] has joined #bitcoin-core-dev
11:31 -!- drnet [~drnett@178.115.130.140.wireless.dyn.drei.com] has quit [Quit: Leaving]
11:43 -!- rsx [~dummy@host-188-174-215-120.customer.m-online.net] has quit [Quit: rsx]
11:48 < GitHub58> [bitcoin] MarcoFalke opened pull request #7374: [init] Rework transaction fee warnings (master...Mf1601-init-fee-warn) https://github.com/bitcoin/bitcoin/pull/7374
12:21 -!- Chris_Stewart_5 [~Chris_Ste@173-26-115-141.client.mchsi.com] has quit [Ping timeout: 265 seconds]
12:24 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
12:24 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Read error: Connection reset by peer]
12:25 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
12:28 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Client Quit]
12:29 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
12:29 -!- drnet [~drnett@178.115.130.140.wireless.dyn.drei.com] has joined #bitcoin-core-dev
12:33 < Luke-Jr> MarcoFalke: it's not copyfraud necessarily
12:33 < Luke-Jr> MarcoFalke: what if I PR some code from your repo, for example?
12:33 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev
12:33 < Luke-Jr> MarcoFalke: you didn't contribute it, but you wrote it and git attributes it to you
12:33 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 260 seconds]
12:34 -!- Chris_Stewart_5 [~Chris_Ste@108.61.228.93] has joined #bitcoin-core-dev
12:40 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Quit: Leaving.]
12:44 -!- drnet [~drnett@178.115.130.140.wireless.dyn.drei.com] has quit [Quit: Leaving]
12:52 -!- GAit [~GAit@2.230.161.158] has joined #bitcoin-core-dev
13:00 -!- MarcoFalke [c3523fc9@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.201] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
13:01 -!- MarcoFalke [c3523fc9@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.201] has joined #bitcoin-core-dev
13:07 -!- brg444 [18257df2@gateway/web/freenode/ip.24.37.125.242] has quit [Quit: Page closed]
13:09 -!- zookolaptop [~user@c-73-217-16-2.hsd1.co.comcast.net] has joined #bitcoin-core-dev
13:20 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
13:28 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Read error: No route to host]
13:29 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev
13:29 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host]
13:29 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
13:33 < GitHub73> [bitcoin] toby opened pull request #7376: Payments: Allow zero value OP_RETURN in PaymentRequests (master...zeropayments) https://github.com/bitcoin/bitcoin/pull/7376
13:33 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
13:48 -!- MarcoFalke [c3523fc9@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.201] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
13:50 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-yszvbzkjamupxhwt] has quit [Quit: Connection closed for inactivity]
13:53 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has joined #bitcoin-core-dev
14:04 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
14:09 -!- adnn [~adnn@cpe-158-222-198-108.nyc.res.rr.com] has joined #bitcoin-core-dev
14:10 < michagogo> wumpus: btw, I can confirm that adding python to the os x descriptor fixes it
14:17 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
14:30 -!- adnn [~adnn@cpe-158-222-198-108.nyc.res.rr.com] has quit [Read error: Connection reset by peer]
14:31 -!- adnn [~adnn@cpe-158-222-198-108.nyc.res.rr.com] has joined #bitcoin-core-dev
14:37 -!- GAit [~GAit@2.230.161.158] has quit [Read error: Connection reset by peer]
14:38 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
14:46 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt]
14:47 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Quit: Leaving.]
14:49 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev
14:52 -!- lpersona [18630a99@gateway/web/freenode/ip.24.99.10.153] has joined #bitcoin-core-dev
14:58 < lpersona> quick question for devs as I was reviewing the 0.12 RC: has the combination of auto setting the min relay fee and RBF enabled a possible attack vector?
14:59 < lpersona> I've posted the concern here and want to see if this possibility was considered before doing further research: https://www.reddit.com/r/Bitcoin/comments/41kaxq/autosetting_min_relay_fee_rbf_possible_attack/
15:00 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
15:10 -!- lpersona [18630a99@gateway/web/freenode/ip.24.99.10.153] has quit [Ping timeout: 252 seconds]
15:13 -!- lpersona [63cfa628@gateway/web/freenode/ip.99.207.166.40] has joined #bitcoin-core-dev
15:23 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
15:24 < Luke-Jr> lpersona: replied there
15:26 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has quit [Ping timeout: 252 seconds]
15:33 -!- zookolaptop [~user@c-73-217-16-2.hsd1.co.comcast.net] has quit [Remote host closed the connection]
15:33 -!- T23WS [~textual@45.56.159.23] has joined #bitcoin-core-dev
15:37 -!- zookolaptop [~user@c-73-217-16-2.hsd1.co.comcast.net] has joined #bitcoin-core-dev
15:55 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
15:55 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
15:59 -!- zookolaptop [~user@c-73-217-16-2.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds]
16:10 -!- Evel-Knievel [~Evel-Knie@81.82.247.68] has joined #bitcoin-core-dev
16:22 -!- ronbo [~ronbo@c-73-30-230-54.hsd1.pa.comcast.net] has joined #bitcoin-core-dev
16:32 < sdaftuar> lpersona: the way rbf works is that a new transaction must pay more in total fee than all the transactions it evicts
16:33 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has joined #bitcoin-core-dev
16:36 < lpersona> sdaftuar: tks - i'm trying to find on the code where the sum of descendant fees is kept to be used by RBF, and also check if it's only for immediate descendants or if it keeps the entire tree of descendants - is it part of txmempool?
16:37 < sdaftuar> in main.cpp, see AcceptToMemoryPoolWorker
16:38 < sdaftuar> while each transaction in the mempool caches its fee with descendants, for RBF purposes we walk the descendants of all the transactions that are conflicted, so that we don't double count
16:38 < sdaftuar> (ie in situations where a child transaction has 2 parents, both of which are being replaced)
16:40 -!- wumpus [~wladimir@pdpc/supporter/professional/wumpus] has quit [Ping timeout: 240 seconds]
16:52 -!- wumpus [~wladimir@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
17:02 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Quit: Leaving.]
17:12 < sdaftuar> cfields: around?
17:13 -!- ronbo [~ronbo@c-73-30-230-54.hsd1.pa.comcast.net] has left #bitcoin-core-dev []
17:15 -!- jtimon_ [~quassel@126.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]
17:16 < cfields> hi
17:16 -!- murch [~murch@p4FDB723D.dip0.t-ipconnect.de] has quit [Quit: Leaving.]
17:17 -!- T23WS [~textual@45.56.159.23] has quit [Quit: Textual IRC Client: www.textualapp.com]
17:17 -!- T23WS [~textual@45.56.159.23] has joined #bitcoin-core-dev
17:18 < sdaftuar> if you have a few minutes i was hoping to get some help with a build issue i'm having in #7222
17:18 < sdaftuar> (sorry to bother you with this, i'm sure i'm doing something silly)
17:19 < cfields> sdaftuar: sure. looking
17:19 < sdaftuar> somehow i broke the qt build when i took some code out of rpcblockchain.cpp
17:20 < cfields> sdaftuar: do you see the error locally too? or just on travis?
17:20 < sdaftuar> yeah i see it locally as well
17:20 < sdaftuar> i added a new file, policy/rbf.h and policy/rbf.cpp
17:21 < sdaftuar> the functions added were previously used in both rpcblockchain.cpp and wallet/rpcwallet.cpp
17:21 < sdaftuar> and linking was fine
17:21 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Ping timeout: 256 seconds]
17:21 < sdaftuar> when i deleted the code that invoked it from rpcblockchain.cpp, linking bitcoin-qt broke
17:21 < sdaftuar> i assume i screwed up the makefile?
17:22 < cfields> ah, some dependency thing then. i'll pull it down and build
17:22 < cfields> sdaftuar: probably created some circular dep
17:24 < sdaftuar> ah, ok if the makefile is fine, then i can probably track down my circular dependency.  <embarrassed>
17:25 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
17:26 < cfields> sdaftuar: nm, not that. i don't see where it was moved from (different commit?), but looks like you need rbf.cpp in a lib other than _server
17:27 < sdaftuar> yeah i force pushed (too quickly it seems!), blew away the commit where it was building
17:27 < sdaftuar> is there a simple fix to the Makefile?
17:28 < cfields> building now. i'm not familiar with what's changing here, so i'll have to poke around for a min
17:30 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
17:32 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
17:33 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 276 seconds]
17:34 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-yqgsfefmesitqprk] has joined #bitcoin-core-dev
17:35 -!- zookolaptop [~user@c-73-217-16-2.hsd1.co.comcast.net] has joined #bitcoin-core-dev
17:36 < sdaftuar> hmm, moving policy/rbf.cpp from libbitoin_server to libbitcoin_wallet appears to make the build work, with the wallet and without
17:39 < cfields> sdaftuar: right, i'm seeing the same. so turns out there is a circular dep between wallet and server
17:40 < sdaftuar> ah, is that something i introduced?
17:40 < cfields> hmm, maybe not circular. bitcoind links with the order jumbled around...
17:40 < cfields> let me see if everything links this way
17:42 -!- adnn [~adnn@cpe-158-222-198-108.nyc.res.rr.com] has quit [Ping timeout: 245 seconds]
17:42 -!- adnn [adnn@gateway/vpn/mullvad/x-dkkbtomzspxitlyc] has joined #bitcoin-core-dev
17:48 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xllkhodregpcvmla] has quit [Quit: Connection closed for inactivity]
17:51 -!- T23WS [~textual@45.56.159.23] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
17:52 < cfields> sdaftuar: still trying to understand. i don't see how this is altering the wallet's deps
17:52 < sdaftuar> well, rpcwallet.cpp depends on policy/rbf.cpp
17:53 < sdaftuar> and nothing else does now
17:53 < cfields> sdaftuar: yea, but wallet depends on tons of other stuff from server
17:53 < sdaftuar> somehow does that cause libbitcoin_server to optimize it out?
17:53 < cfields> (unless i'm missing somehting obvious?)
17:54 < sdaftuar> no, that's what i understand too!
17:55 < sdaftuar> is it crazy for me to put policy/rbf.cpp in libbitcoin_wallet?  it looks funny, though it seems to work...
17:57 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
18:00 < cfields> sdaftuar: mm, i'd prefer to figure out what make it different
18:00 < cfields> still poking
18:01 < sdaftuar> i see what you mean about the library order being different for qt than for bitcoind
18:04 < sdaftuar> if i rearrange the library order for qt, i think that also solves the problem.  testing a bit more
18:04 < cfields> well the wallet order is tangled anyway. worth fixing even without this issue
18:06 -!- zookolaptop [~user@c-73-217-16-2.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds]
18:08 < sdaftuar> no, looks like that change i made to the qt build didn't actually fix it
18:11 < cfields> heh, built with a stale .a? i did that :)
18:11 < sdaftuar> yeah i think so :)
18:13 < sdaftuar> uh, i'm not sure how i overlooked this.  bitcoind also doesn't compile. this qt stuff is a red herring.
18:13 < sdaftuar> er
18:14 < sdaftuar> bitcoind doesn't link i mean
18:15 < phantomcircuit> sdaftuar, git clean -fdx
18:15 < cfields> sdaftuar: right. it was the same on travis
18:15 < cfields> i've been playing with bitcoind here
18:15 < cfields> sdaftuar: i'm pretty sure this is building up to a facepalm. i just don't see what sets this apart.
18:18 < cfields> rpcwallet locks cs_main ffs. it's obviously not a new dep.
18:29 < cfields> sdaftuar: ok, here we go
18:30 < sdaftuar> cfields: solution?
18:30 -!- p15 [~p15@52.91.145.64.client.static.strong-tk2.bringover.net] has quit [Excess Flood]
18:31 < cfields> sdaftuar: yes. let me build clean before i spout more dumb stuff though.
18:31 < cfields> sdaftuar: ok, you were right a long time ago
18:31 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
18:31 < sdaftuar> when i said i probably did something silly?
18:31 < sdaftuar> :)
18:32 < cfields> <sdaftuar> somehow does that cause libbitcoin_server to optimize it out?
18:32 < cfields> looks like if an object isn't use at all in the lib, it'll leave it out
18:33 < cfields> which also doesn't make any sense, but one step at a time :)
18:33 < sdaftuar> wow, okay. i really don't understand computers, because i would have thought that the whole point was you don't know if something linking against your library might use it?
18:33 < cfields> if(!OptInRBF(CTransaction())) return false;
18:34 < cfields> throw that in main.cpp somewhere, and it'll link
18:34 < sdaftuar> hm.  so where does that leave us?  are we building the libraries the wrong way somehow?
18:34 < cfields> er, fix the func name. I nuked the "Signal" cause i thought the preprocessor might've been screwing with it
18:35 < cfields> sdaftuar: still investigating.
18:36 < sdaftuar> oh interesting, somehow referencing just one function must pull in teh whole file?
18:36 -!- p15 [~p15@52.91.145.64.client.static.strong-tk2.bringover.net] has joined #bitcoin-core-dev
18:42 -!- drnet [~drnett@178.115.130.140.wireless.dyn.drei.com] has joined #bitcoin-core-dev
18:42 < cfields> sdaftuar: still not making any sense. playing around.
18:45 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 240 seconds]
19:14 < sdaftuar> cfields: i'm going to call it a night soon.  i've pushed up a temporary hack (just moved rbf.cpp -> libbitcoin_wallet) to make travis happy for now while we figure out the right way to solve this
19:14 < sdaftuar> cfields: Thanks for diving into this, sorry if I sucked away your evening!
19:15 < cfields> sdaftuar: np. i'm not sure there's much of a fix. our libs don't work how libs usually do, they're all inter-connected...
19:16 < cfields> they're supposed to be listed from most to least dependent, and the linker makes a note of what syms are needed along the way...
19:18 < cfields> but in our case, they need eachother. so there's no ordering where the linker can sanely mark unresolved deps along the way. i suppose we just happen to be inter-connected enough to trick it into working :)
19:18 < sdaftuar> that is more than a little disturbing :)
19:21 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving]
19:23 -!- s1w [~s1w@unaffiliated/someoneweird] has quit [Ping timeout: 265 seconds]
19:26 -!- s1w [~s1w@128.199.100.16] has joined #bitcoin-core-dev
19:26 -!- s1w is now known as Guest50070
19:29 -!- NLNico [~NLNico@unaffiliated/nlnico] has joined #bitcoin-core-dev
19:34 -!- drnet [~drnett@178.115.130.140.wireless.dyn.drei.com] has quit [Quit: Leaving]
19:44 < PRab> I think I found a bug with the RC's Banned peers display.
19:45 < PRab> I had a peer that was supposed to be unbanned about an hour ago, but it is still showing up there.
19:45 < PRab> Should I report this as an issue on github?
19:45 < Luke-Jr> PRab: probably
19:46 < PRab> I wonder if it doesn't refresh until the gui is closed and reopened. Testing...
19:46 < PRab> Nope, still there.
19:49 < PRab> I think I got the relevant details in https://github.com/bitcoin/bitcoin/issues/7377
19:58 -!- zoltan1 [~zoltan@104.254.90.195] has joined #bitcoin-core-dev
20:06 -!- Chris_Stewart_5 [~Chris_Ste@108.61.228.93] has quit [Ping timeout: 240 seconds]
20:13 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has joined #bitcoin-core-dev
20:18 -!- zoltan1 [~zoltan@104.254.90.195] has quit [Quit: WeeChat 1.4]
20:46 -!- NLNico [~NLNico@unaffiliated/nlnico] has quit [Ping timeout: 240 seconds]
21:45 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
21:48 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
21:51 -!- adnn_ [adnn@gateway/vpn/mullvad/x-kejkdkmomxrsvlsb] has joined #bitcoin-core-dev
21:54 -!- adnn [adnn@gateway/vpn/mullvad/x-dkkbtomzspxitlyc] has quit [Ping timeout: 240 seconds]
22:02 -!- wallet42 [~wallet42@98.147.125.124] has joined #bitcoin-core-dev
22:08 -!- NLNico [~NLNico@unaffiliated/nlnico] has joined #bitcoin-core-dev
22:22 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev
22:22 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host]
22:22 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
22:47 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Ping timeout: 276 seconds]
22:56 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mcnsceyagcmhrebw] has joined #bitcoin-core-dev
22:58 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev
23:04 -!- cjcj [82ebca3a@gateway/web/freenode/ip.130.235.202.58] has quit [Quit: Page closed]
23:10 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev