--- Day changed Tue Apr 19 2016
00:13 -!- xiangfu_ [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev
00:18 -!- xiangfu_ [~xiangfu@111.198.29.53] has quit [Ping timeout: 260 seconds]
00:18 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
00:19 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
00:22 < gmaxwell> something intresting...
00:22 < gmaxwell> $ grep 'received: notfound' ~/.bitcoin/debug.log | cut -d' ' -f1 | sort | uniq -c | sort -n
00:23 < gmaxwell>     145 2016-04-12
00:23 < gmaxwell>     296 2016-04-13
00:23 < gmaxwell>     728 2016-04-15
00:23 < gmaxwell>     938 2016-04-16
00:23 < gmaxwell>    1155 2016-04-17
00:23 < gmaxwell>    1384 2016-04-14
00:23 < gmaxwell>    1863 2016-04-19
00:23 < gmaxwell>    2832 2016-04-18
00:23 < gmaxwell> 19 is low because we're only 7.5 hours into the day.
00:23 < gmaxwell> but it's on track to be over 5000 based on that.
00:26 < gmaxwell> Anyone else seeing this?
00:28 < gmaxwell> anyone have debugnet logs going back betore the 11th? 
00:48 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rpmcqczmxjdabtsd] has joined #bitcoin-core-dev
00:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rpmcqczmxjdabtsd] has quit [Ping timeout: 276 seconds]
00:58 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-axbjeawdgphiiech] has joined #bitcoin-core-dev
01:02 -!- adam3us [~adam3us@unaffiliated/adam3us] has quit [Ping timeout: 276 seconds]
01:03 -!- adam3us [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev
01:07 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev
01:24 < GitHub26> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d28995018003...fc9e3346e674
01:24 < GitHub26> bitcoin/master a3310b4 Wladimir J. van der Laan: txdb: Fix assert crash in new UTXO set cursor...
01:24 < GitHub26> bitcoin/master fc9e334 Wladimir J. van der Laan: Merge #7904: txdb: Fix assert crash in new UTXO set cursor...
01:24 < GitHub13> [bitcoin] laanwj closed pull request #7904: txdb: Fix assert crash in new UTXO set cursor (master...2016_04_fix_utxo_iterator) https://github.com/bitcoin/bitcoin/pull/7904
01:25 < GitHub161> [bitcoin] laanwj closed pull request #7894: [Qt] Use CURRENCY_UNIT for BitcoinUnits. (master...currency-unit) https://github.com/bitcoin/bitcoin/pull/7894
01:26 < GitHub160> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fc9e3346e674...fa9d86f8c4f4
01:26 < GitHub160> bitcoin/master fa05e22 MarcoFalke: [qa] pull-tester: Don't mute zmq ImportError
01:26 < GitHub160> bitcoin/master faa4f22 MarcoFalke: [qa] pull-tester: Exit early when no tests are run
01:26 < GitHub160> bitcoin/master fae1f4e MarcoFalke: [qa] rpc-tests: Fix link in comment and label error msg
01:27 < GitHub131> [bitcoin] laanwj closed pull request #7851: [qa] pull-tester: Don't mute zmq ImportError (master...Mf1604-qaUnmuteError) https://github.com/bitcoin/bitcoin/pull/7851
01:45 < GitHub170> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa9d86f8c4f4...4205ad7ca2b1
01:45 < GitHub170> bitcoin/master 87049e8 mrbandrews: Speed up getchaintips.
01:45 < GitHub170> bitcoin/master 4205ad7 Wladimir J. van der Laan: Merge #7827: Speed up getchaintips....
01:45 < GitHub49> [bitcoin] laanwj closed pull request #7827: Speed up getchaintips. (master...ba-fix-chaintips) https://github.com/bitcoin/bitcoin/pull/7827
01:50 < GitHub49> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/4205ad7ca2b1...187186b0fe03
01:50 < GitHub49> bitcoin/master de39c95 Wladimir J. van der Laan: test: move accounting_tests and rpc_wallet_tests to wallet/test...
01:50 < GitHub49> bitcoin/master f4eae2d Wladimir J. van der Laan: test: Create test fixture for wallet...
01:50 < GitHub49> bitcoin/master a25a4f5 Wladimir J. van der Laan: wallet_ismine.h → script/ismine.h...
01:50 < GitHub112> [bitcoin] laanwj closed pull request #7905: test: move accounting_tests and rpc_wallet_tests to wallet/test (master...2016_04_accounting_tests_to_wallet) https://github.com/bitcoin/bitcoin/pull/7905
01:51 < wumpus> gmaxwell: no, don't have netdebug logs, but wow that's a huge increase
01:51 < wumpus> that's the number of notfounds sent or received?
01:52 < gmaxwell> thats recieved.
01:53 < gmaxwell> my sending went up too... but I don't know if my sending counts are representative since I'm running #7840.
01:53 -!- xiangfu_ [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev
01:53 < gmaxwell>    1236 2016-04-11
01:53 < gmaxwell>    3469 2016-04-12
01:53 < gmaxwell>    2961 2016-04-13
01:53 < gmaxwell>    5494 2016-04-14
01:53 < gmaxwell>    6788 2016-04-15
01:53 < gmaxwell>   14933 2016-04-16
01:53 < gmaxwell>   10706 2016-04-17
01:53 < gmaxwell>   10018 2016-04-18
01:54 < gmaxwell>    5225 2016-04-19
02:19 < phantomcircuit> gmaxwell: that's kind of weird
02:19 < phantomcircuit> also
02:19 < phantomcircuit> how did you notice this?
02:19 < phantomcircuit> :)
02:23 < wumpus> if it's anything like how I notice these things he just saw a lot of notfounds in his log, wondered what, and then decided to do statistics on them
02:24 < gmaxwell> yea, I normally have debug logs scrolling by, and when I sense a glitch in the matrix I run stats.
02:24 < wumpus> could be a few strangely-behaved peers, it's not sudden enough for a code change
02:24 < gmaxwell> I'm seeing it on two nodes though the pattern is pretty different.
02:24 < wumpus> (e.g. if we had suddenly started waiting longer before requesting a transaction inved to us, you'd see more of a sudden jump)
02:25 < gmaxwell> it could be a side effect of some kind of denial of service happening to peers.
02:26 < gmaxwell> but ... pretty huge delay to see notfounds. It also could be some party trying to deanonymize the network graph by doing some mutually exclusive propagation stunts.
02:26 < sipa> are the tx or block notfounds?
02:26 < gmaxwell> tx.
02:27 < sipa> i don't understand... *your* are the one running 7840
02:27 < gmaxwell> I think it's unrelated to 7840.
02:27 < gmaxwell> On the _sending_ not founds, that could be due to 7840. But recieving, no.
02:27 < sipa> ah
02:28 < gmaxwell> also I've been running 7840 for a while; and this seems to have ramped.
02:30 < gmaxwell> e.g. for deanon, step 1 give all nodes except two nodes TX A while giving those nodes node A'.  Then step 2. create B which is a derivative of A', and give to one of them, and you'll learn if they're directly connected.
02:30 < gmaxwell> and I'm sure there are lots of other variations on that, including more efficient ones, regardless, they'll likely cause a lot of NOTFOUNDS.
02:31 < gmaxwell> Also, because GETDATA since the introduction of the mempool RPC will return things that aren't in the relay pool, someone could be using GETDATA to bypass inv delays.
02:31 < gmaxwell> (man, that mempool message is the privacy leak that keeps on giving)
02:33 < sipa> so you think this is a deanonymization technique?
02:36 < gmaxwell> maybe, seeing if I can get more or less evidence for that.
02:41 < GitHub199> [bitcoin] laanwj closed pull request #7625: Bugfix: Check for bench_bitcoin being enabled where needed, and skip UniValue dependency when unused (master...bugfix_bench_checks) https://github.com/bitcoin/bitcoin/pull/7625
02:44 < gmaxwell> I really can't tell, the highest notfound sending peers I have claim to be 0.11.x.
02:44 < gmaxwell> but it's not confined to a few peers.
02:44 < gmaxwell> notfounds could also be cause by blocks which are mining many doublespends.
02:45 < gmaxwell> since the block will evict the transactions from mempools.
02:50 -!- mrkent_ [~textual@unaffiliated/mrkent] has quit []
03:02 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:03 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-axbjeawdgphiiech] has quit [Quit: Connection closed for inactivity]
03:18 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
03:20 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-bmpnhqaakgixaksd] has joined #bitcoin-core-dev
03:28 -!- fengling [~fengling@111.198.29.53] has quit [Quit: WeeChat 1.4]
03:56 -!- xiangfu_ [~xiangfu@111.198.29.53] has quit [Ping timeout: 244 seconds]
04:45 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
04:47 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
04:55 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Remote host closed the connection]
04:55 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has joined #bitcoin-core-dev
04:55 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has quit [Changing host]
04:55 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
05:06 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev
05:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:17 -!- jtimon [~quassel@18.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:20 -!- assder [82ebca3a@gateway/web/freenode/ip.130.235.202.58] has quit [Ping timeout: 250 seconds]
05:20 -!- cjcj [2e3b026a@gateway/web/freenode/ip.46.59.2.106] has quit [Ping timeout: 250 seconds]
05:23 -!- jtimon [~quassel@18.29.134.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer]
05:42 -!- assder [82ebca3a@gateway/web/freenode/ip.130.235.202.58] has joined #bitcoin-core-dev
05:43 -!- jtimon [~quassel@18.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:45 -!- galileopy [~galileopy@181.121.64.244] has quit [Ping timeout: 276 seconds]
05:59 < GitHub84> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/187186b0fe03...0e6fd5e4af31
05:59 < GitHub84> bitcoin/master fa942c7 Joao Fonseca: Move method to check matches within arrays on util.py
05:59 < GitHub84> bitcoin/master 5d217de Joao Fonseca: Add test to check spendable and unspendable UTXO on RPC listunspent
05:59 < GitHub84> bitcoin/master 0e6fd5e Wladimir J. van der Laan: Merge #7822: Add listunspent() test for spendable/unspendable UTXO...
05:59 < GitHub40> [bitcoin] laanwj closed pull request #7822: Add listunspent() test for spendable/unspendable UTXO (master...support/add-test-listunspent) https://github.com/bitcoin/bitcoin/pull/7822
06:32 -!- Amnez777 [~Amnez777@37.157.216.145] has quit [Ping timeout: 244 seconds]
06:39 -!- cryptapus_ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
06:39 -!- cryptapus_ is now known as cryptapus
06:45 < GitHub37> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e6fd5e4af31...a1eb344ba8f4
06:45 < GitHub37> bitcoin/master de821d5 Jonas Schnelli: [ZMQ] refactor message string
06:45 < GitHub37> bitcoin/master 0b25a9f Jonas Schnelli: [ZMQ] append a message sequence number to every ZMQ notification
06:45 < GitHub37> bitcoin/master a1eb344 Wladimir J. van der Laan: Merge #7762: [ZMQ] append a message sequence number to every ZMQ notification...
06:45 < GitHub76> [bitcoin] laanwj closed pull request #7762: [ZMQ] append a message sequence number to every ZMQ notification (master...2016/03/zmq_seq) https://github.com/bitcoin/bitcoin/pull/7762
06:47 -!- murch [~murch@p4FE3A064.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
06:50 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:51 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
06:52 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds]
06:58 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
06:59 -!- zooko [~user@2601:281:8000:8387:16d:780a:2574:fcc8] has joined #bitcoin-core-dev
06:59 -!- cryptapus [~cyptapus@66.119.84.15] has joined #bitcoin-core-dev
06:59 -!- cryptapus [~cyptapus@66.119.84.15] has quit [Changing host]
06:59 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
07:09 -!- galileopy [~galileopy@181.121.64.244] has joined #bitcoin-core-dev
07:11 < GitHub29> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1eb344ba8f4...04a29373571d
07:11 < GitHub29> bitcoin/master fabbf80 MarcoFalke: [ui] Move InitError, InitWarning, AmountErrMsg
07:11 < GitHub29> bitcoin/master fa10ce6 MarcoFalke: Move ui_interface.cpp to libbitcoin_server_a_SOURCES...
07:11 < GitHub29> bitcoin/master 04a2937 Wladimir J. van der Laan: Merge #7787: [Moveonly] Create ui_interface.cpp...
07:11 < GitHub145> [bitcoin] laanwj closed pull request #7787: [Moveonly] Create ui_interface.cpp (master...Mf1604-move-ui-helpers) https://github.com/bitcoin/bitcoin/pull/7787
07:20 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
07:22 -!- mkarrer [~mkarrer@224.red-83-50-56.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
07:34 < NicolasDorier> I was investigating https://github.com/sipa/bitcoin/issues/73
07:34 < NicolasDorier> it seems the error does not come from the segwit branch, but is a current bug
07:34 < NicolasDorier> basically, sendtoaddress is called in rpc
07:35 < NicolasDorier> between the call to CWallet::CreateTransaction and CWallet::CommitTransaction, there can be a reorg resulting in a smaller chain
07:35 < NicolasDorier> if it happens, the CommitTransaction will fails because of nLockTime
07:35 -!- galileopy [~galileopy@181.121.64.244] has quit [Ping timeout: 276 seconds]
07:35 < NicolasDorier> however, when the next block is found the "failed transaction" get broadcasted
07:36 < NicolasDorier> this may result in people sending twice the money by mistake.
07:36 < NicolasDorier> I noticed that CreateTransaction use chainActive without holding cs_main
07:36 < sipa> ho!
07:37 < NicolasDorier> nor any parent, it seems
07:37 < NicolasDorier> relevant link : https://github.com/bitcoin/bitcoin/blob/d28995018003db699b0b528f5e97e9002c3feeb9/src/wallet/rpcwallet.cpp#L365
07:39 < NicolasDorier> I think the way to fix this bug is to lock the chain at the caller method
07:40 < NicolasDorier> which is SendMoney (https://github.com/bitcoin/bitcoin/blob/d28995018003db699b0b528f5e97e9002c3feeb9/src/wallet/rpcwallet.cpp#L365)
07:40 < NicolasDorier> however, ::CommitTransaction get the lock. I don't know if we can lock two times cs_main in the same thread.
07:41 < sipa> yes, we can
07:41 < sipa> it's a recursive lock
07:42 < NicolasDorier> ok so that should do it. I'll try that and ask T909 to try again
07:44 < NicolasDorier> mmmh no I'm wrong
07:44 < NicolasDorier> the lock is taken in the top rpc method
07:45 < NicolasDorier> so not that :/
07:50 < NicolasDorier> mmh, https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2012
07:50 < NicolasDorier> there is one chance on 100 that the transaction is not final it seems
07:50 < NicolasDorier> ah no...
07:51 < NicolasDorier> since it should be included in next block seems I'm wrong on the cause 
07:57 -!- Amnez777 [~Amnez777@37.157.216.176] has joined #bitcoin-core-dev
07:58 < sipa> NicolasDorier: where does this 1 in 100 number come from?
07:58 < NicolasDorier> sipa: https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2019
07:59 < NicolasDorier> in the case of the bug we got 0
08:00 < sipa> that branch has a chance of 1 in 100 to trigger
08:00 < sipa> so there is a chance of 90.1%
08:00 < sipa> that nLocktime equals the current height
08:00 -!- zooko [~user@2601:281:8000:8387:16d:780a:2574:fcc8] has quit [Remote host closed the connection]
08:00 < sipa> and in that case it should still be acceptable to the mempool (which uses chainactive+1 to finality check)
08:01 < NicolasDorier> oh yes indeed... ok I continue searching... 
08:02 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 260 seconds]
08:03 < morcos> gmaxwell: i took a look at 4 different nodes, i didn't see much consistency in how many notfounds i received.  3 of the nodes were generally quite small, a few hundred a day.
08:05 < morcos> gmaxwell: one of the nodes received several thousand a day and 19k on 4-16, but still received 6-7k on 4-10 and 4-11, so it seems more variance than a clear increase
08:05 < morcos> might be interesting to understand what causes more of them
08:06 -!- murch [~murch@p4FE3A064.dip0.t-ipconnect.de] has quit [Quit: Leaving.]
08:06 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev
08:08 -!- SteveTaylor [~staylor@cpe-72-181-158-116.tx.res.rr.com] has joined #bitcoin-core-dev
08:08 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev
08:14 -!- cryptapus [~cyptapus@87.254.202.136] has joined #bitcoin-core-dev
08:14 -!- cryptapus [~cyptapus@87.254.202.136] has quit [Changing host]
08:14 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
08:20 < NicolasDorier> btw, I think it is risky to add a transaction to the wallet before it has been accepted by the mempool (https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2285)
08:21 < sipa> i agree
08:22 -!- galileopy [~galileopy@190.104.131.47] has joined #bitcoin-core-dev
08:23 < GitHub10> [bitcoin] sipa opened pull request #7910: Segregated witness (master...segwit-master) https://github.com/bitcoin/bitcoin/pull/7910
08:23 < morcos> NicolasDorier: sipa: why is that necessarily risky?  it seems to me we should move the other direction.  separating wh
08:23 < morcos> woo hoo!
08:23 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit []
08:23 < morcos> (continued) ether a tx is broadcast or in the mempool from its inclusion in your wallet.  And then having some way of informing the wallet of its status
08:23 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev
08:24 < GitHub166> [bitcoin] jonasschnelli closed pull request #7404: [WIP] Segregated Witness (0.12...segwit) https://github.com/bitcoin/bitcoin/pull/7404
08:25 < jonasschnelli> \o/
08:25 < sipa> ugh, github messes up the commit list
08:25 < NicolasDorier> morcos: there is this bug https://github.com/sipa/bitcoin/issues/73, I'll find out what happen later, but the problem is that the transaction is rejected by mempool but still added to wallet transactions. Then after one block, the transaction is rebroadcasted but this time accepted to mempool. The caller of sendtoaddress got an error and thought the money
08:25 < NicolasDorier> was not sent, and retried the command, resulting in sending money two times
08:26 < sipa> morcos: i guess it could be 1) "probe" the mempool whether it would be accepted 2) add to wallet 3) broadcast
08:26 < morcos> sipa: awesome work on segwit, i guess i know where i'm spending my time this week
08:26 < NicolasDorier> "probing the mempool" could be also useful for verifytransaction
08:27 < sipa> i'm not sure whether i should maintain both the 0.12 and master branch independently now, or just work on master, get that review, and then backport again
08:27 < morcos> NicolasDorier: ah, ok so i agree, that we need to clean up the behavior, hadn't read that issue before.  but it definitely shouldn't be ambigious whether a tx is broadcast or not.
08:28 < morcos> sipa: do you have both branches ready now?
08:28 < sipa> yes
08:28 < morcos> i kind of think we should have as much of a merge freeze as possible and just all buckle down to review segwit
08:28 < morcos> so that would speak to getting both branches out now
08:29 -!- galileopy [~galileopy@190.104.131.47] has quit [Ping timeout: 252 seconds]
08:29 < morcos> it would be nice if the 0.12 branch got some review from fresh eyes, instead of people just trying to verify its a correct backport.  with this much code thats prone to failure
08:29 < sipa> the reasoning against two branches is that it has a higher chance of resulting in unreviewed mistakes in 0.12
08:30 < sipa> the reasoning against just master-based review is that it may interfere with for example the py3 changes
08:31 < morcos> personally i think it makes sense if some of us concentrate review on 0.12 and then take a look at master to see if we think its a proper forward port, and some of us work in the opposite direction.
08:31 < morcos> whenever a bug is found or a change made in one..  then you can port it to the other
08:31 < morcos> but it should really be up to you and wumpus i guess to figrue out how to best do this
08:32 < morcos> merging other stuff in the middle, just seems like a mistake though...  lets get segwit merged
08:32 -!- cryptocoder [~cryptocod@cpe-76-90-140-31.socal.res.rr.com] has joined #bitcoin-core-dev
08:33 < sipa> open question: do i "fake" the author dates of the commits to make github show it in the correct order?
08:34 < morcos> sipa: meh
09:10 < instagibbs> sipa, you doubled the "Since github shows" statement
09:11 < sipa> instagibbs: thanks, fixed
09:12 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection]
09:12 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev
09:13 < instagibbs> really glad to see this pull 
09:24 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:27 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
09:27 -!- Guyver2_ is now known as Guyver2
09:29 -!- cryptocoder [~cryptocod@cpe-76-90-140-31.socal.res.rr.com] has quit [Quit: cryptocoder]
09:34 -!- cryptocoder [~cryptocod@cpe-76-90-140-31.socal.res.rr.com] has joined #bitcoin-core-dev
09:39 -!- amiller_ [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 276 seconds]
09:39 < btcdrak> nice work sipa!
09:41 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:41 -!- Guest87203 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev
09:45 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
09:45 -!- Guyver2_ is now known as Guyver2
09:47 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
09:48 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
09:49 < Chris_Stewart_5> ^^^^\
09:54 < instagibbs> can someone share their segnet node ip/seed?
09:55 < instagibbs> also, how to run segnet regtest?
09:55 < sipa> bitcoin.sipa.be is a node, and run with -segnet
09:56 < instagibbs> oh nevermind, it managed to find peers after a bit
09:56 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
10:03 -!- Amnez777 [~Amnez777@37.157.216.176] has quit [Ping timeout: 268 seconds]
10:08 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
10:08 -!- Amnez777 [~Amnez777@37.157.216.175] has joined #bitcoin-core-dev
10:17 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev
10:17 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host]
10:17 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
10:24 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
10:54 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev
11:00 -!- zooko [~user@c-73-217-16-2.hsd1.co.comcast.net] has joined #bitcoin-core-dev
11:05 -!- galileopy [~galileopy@181.121.64.244] has joined #bitcoin-core-dev
11:11 -!- cryptapus__ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
11:15 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 276 seconds]
11:16 -!- cryptapus__ is now known as cryptapus
11:19 -!- d_t [~textual@195.52.242.214] has joined #bitcoin-core-dev
11:20 -!- cryptapus__ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
11:23 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 246 seconds]
11:24 -!- cryptapus__ is now known as cryptapus
11:30 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection]
11:31 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Quit: Conversation terminated!]
11:31 -!- cryptapus [~cyptapus@87.254.202.136] has joined #bitcoin-core-dev
11:31 -!- cryptapus [~cyptapus@87.254.202.136] has quit [Changing host]
11:31 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
11:33 -!- cryptapus__ [~cyptapus@87.254.202.136] has joined #bitcoin-core-dev
11:33 -!- cryptapus__ [~cyptapus@87.254.202.136] has quit [Changing host]
11:33 -!- cryptapus__ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
11:36 -!- cryptapus_ [~cyptapus@87.254.202.136] has joined #bitcoin-core-dev
11:36 -!- cryptapus_ [~cyptapus@87.254.202.136] has quit [Changing host]
11:36 -!- cryptapus_ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
11:36 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 276 seconds]
11:37 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]
11:37 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
11:39 -!- cryptapus__ [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds]
11:41 < GitHub181> [bitcoin] theuni opened pull request #7911: leveldb: integrate leveldb into our buildsystem (master...leveldb-integration) https://github.com/bitcoin/bitcoin/pull/7911
11:48 -!- d_t [~textual@195.52.242.214] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:49 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
11:54 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 260 seconds]
12:00 -!- zooko [~user@c-73-217-16-2.hsd1.co.comcast.net] has quit [Ping timeout: 250 seconds]
12:06 -!- roasbeef_ is now known as roasbeef
12:08 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 240 seconds]
12:26 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection]
12:27 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
12:29 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds]
12:32 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
12:35 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds]
12:37 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev
12:38 -!- cryptapus_ is now known as cryptapus
12:50 < sdaftuar> Should BIP61 be interpreted to mean that reject messages with code 0x01 (REJECT_MALFORMED) should NOT have a hash payload, even if the message that triggered the reject is "block" or "tx"?
12:57 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
13:04 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 268 seconds]
13:04 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds]
13:11 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
13:16 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:23 -!- mrkent_ [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev
13:36 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev
13:36 < GitHub79> [bitcoin] sdaftuar opened pull request #7912: Tests: Fix deserialization of reject messages (master...fix-mininode-reject) https://github.com/bitcoin/bitcoin/pull/7912
13:55 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving]
14:02 -!- mrkent__ [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev
14:02 -!- mrkent_ [~textual@unaffiliated/mrkent] has quit [Ping timeout: 250 seconds]
14:07 < GitHub192> [bitcoin] yurizhykin opened pull request #7913: Fix for incorrect locking in GetPubKey() (keystore.cpp) (master...getpubkey-locking-fix) https://github.com/bitcoin/bitcoin/pull/7913
14:08 -!- zooko [~user@2601:281:8000:8387:8800:5967:f290:947e] has joined #bitcoin-core-dev
14:13 -!- mrkent_ [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev
14:16 -!- mrkent__ [~textual@unaffiliated/mrkent] has quit [Ping timeout: 252 seconds]
14:22 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
14:30 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection]
14:33 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
14:54 -!- harding [~harding@mail.dtrt.org] has quit [Ping timeout: 246 seconds]
14:55 -!- harding [~harding@mail.dtrt.org] has joined #bitcoin-core-dev
15:05 -!- grimescapes [~user@46.166.188.223] has joined #bitcoin-core-dev
15:15 -!- xabbix__ [~xabbix@bzq-79-178-143-35.red.bezeqint.net] has quit [Ping timeout: 268 seconds]
15:19 -!- Guest87203 [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 276 seconds]
15:19 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:26 -!- xabbix__ [~xabbix@bzq-79-176-76-221.red.bezeqint.net] has joined #bitcoin-core-dev
15:26 -!- Guest53522 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev
15:29 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev
15:47 -!- lightningbot [supybot@2400:8900::f03c:91ff:fedf:3a06] has quit [Ping timeout: 250 seconds]
15:48 -!- aj [aj@106.187.51.212] has quit [Ping timeout: 250 seconds]
15:48 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Ping timeout: 276 seconds]
15:54 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection]
15:55 -!- Thireus1 [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
15:55 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection]
16:00 -!- Guest53522 [~socrates1@li175-104.members.linode.com] has quit [Changing host]
16:00 -!- Guest53522 [~socrates1@unaffiliated/socrates1024] has joined #bitcoin-core-dev
16:00 -!- Guest53522 is now known as amiller
16:04 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 250 seconds]
16:05 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev
16:08 -!- lightningbot [supybot@2400:8900::f03c:91ff:fedf:3a06] has joined #bitcoin-core-dev
16:09 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
16:11 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
16:33 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev
17:13 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has joined #bitcoin-core-dev
17:13 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has quit [Changing host]
17:13 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:54 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
17:54 < kanzure> sipa: there is some minor doubled text at the start of your issue comment, https://github.com/bitcoin/bitcoin/pull/7910#issuecomment-211998958
17:55 < kanzure> well, nearly.
18:13 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-bmpnhqaakgixaksd] has quit [Quit: Connection closed for inactivity]
18:18 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection]
18:29 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev
18:30 -!- dermoth_ [~thomas@dial-216-221-42-131.mtl.aei.ca] has quit [Read error: Connection reset by peer]
18:31 -!- dermoth_ [~thomas@dial-216-221-42-131.mtl.aei.ca] has joined #bitcoin-core-dev
18:42 < kanzure> "The must be at least one output whose scriptPubKey is a single 36-byte push" word missing?
18:45 -!- aquentson1 [~aquentson@unaffiliated/aquentson] has joined #bitcoin-core-dev
18:47 -!- aquentson [~aquentson@unaffiliated/aquentson] has quit [Ping timeout: 246 seconds]
18:56 -!- shangzhou [uid156782@gateway/web/irccloud.com/x-kdcphlsduhkauquu] has joined #bitcoin-core-dev
18:58 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
18:58 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
18:58 < phantomcircuit> sipa: there three preparation commits in 7910 seem like they could be separe pr's
18:59 < phantomcircuit> (and appear to be trivial to review as such)
18:59 < phantomcircuit> as well as the "don't check genesis block" commit
18:59 < phantomcircuit> any reason they aren't proposed as separate pr's?
19:07 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds]
19:07 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.]
19:22 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
19:27 -!- mrkent_ [~textual@unaffiliated/mrkent] has quit []
19:34 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
19:45 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
19:45 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
19:48 -!- jtimon [~quassel@18.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 250 seconds]
19:58 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
19:58 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
20:14 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 252 seconds]
20:22 -!- arubi [~ese168@unaffiliated/arubi] has quit [Ping timeout: 276 seconds]
20:22 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
20:23 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
20:26 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev
20:39 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 260 seconds]
20:52 -!- nhancm [~nhancm@14.161.4.70] has joined #bitcoin-core-dev
20:54 -!- nhancm_ [~nhancm@14.161.4.70] has joined #bitcoin-core-dev
20:57 -!- nhancm [~nhancm@14.161.4.70] has quit [Ping timeout: 268 seconds]
21:02 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
21:03 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
21:08 -!- shangzhou [uid156782@gateway/web/irccloud.com/x-kdcphlsduhkauquu] has quit [Quit: Connection closed for inactivity]
21:10 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer]
21:11 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 264 seconds]
21:11 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
21:11 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
21:12 -!- isis [~isis@149.154.159.149] has quit [Ping timeout: 250 seconds]
21:15 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
21:18 -!- nhancm__ [~nhancm@14.161.4.70] has joined #bitcoin-core-dev
21:19 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev
21:22 -!- nhancm_ [~nhancm@14.161.4.70] has quit [Ping timeout: 250 seconds]
21:28 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
21:29 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
21:44 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
21:44 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
21:45 -!- nhancm_ [~nhancm@14.161.4.70] has joined #bitcoin-core-dev
21:48 -!- nhancm__ [~nhancm@14.161.4.70] has quit [Ping timeout: 240 seconds]
22:24 -!- cryptocoder [~cryptocod@cpe-76-90-140-31.socal.res.rr.com] has quit [Quit: cryptocoder]
22:28 -!- cryptocoder [~cryptocod@cpe-76-90-140-31.socal.res.rr.com] has joined #bitcoin-core-dev
22:32 -!- xabbix_ [~xabbix@bzq-79-182-11-18.red.bezeqint.net] has joined #bitcoin-core-dev
22:33 -!- xabbix__ [~xabbix@bzq-79-176-76-221.red.bezeqint.net] has quit [Ping timeout: 276 seconds]
22:35 < NicolasDorier> question: during a sync headers first. chainActive is updated to the last block first when it received the header chain then rewinded if a block is incorrect, or does chainActive is updated as blocks are verified ?
22:40 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
22:46 -!- mrkent_ [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev
22:55 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
22:58 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
23:00 -!- dermoth_ [~thomas@dial-216-221-42-131.mtl.aei.ca] has quit [Read error: Connection reset by peer]
23:01 -!- dermoth_ [~thomas@dial-216-221-42-131.mtl.aei.ca] has joined #bitcoin-core-dev
23:01 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
23:10 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
23:42 -!- mrkent_ [~textual@unaffiliated/mrkent] has quit []
23:48 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tzszmypelosumhsf] has joined #bitcoin-core-dev