--- Day changed Fri Apr 22 2016 00:01 < wumpus> gmaxwell: that worked, thanks! 00:04 -!- amiller_ [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 276 seconds] 00:04 < GitHub186> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/76176823ba6a...90653bc91d39 00:04 < GitHub186> bitcoin/master 5770449 Kaz Wesley: CBase58Data::SetString: cleanse the full vector... 00:04 < GitHub186> bitcoin/master 90653bc Wladimir J. van der Laan: Merge #7922: CBase58Data::SetString: cleanse the full vector... 00:05 < GitHub105> [bitcoin] laanwj closed pull request #7922: CBase58Data::SetString: cleanse the full vector (master...cleanse-fully) https://github.com/bitcoin/bitcoin/pull/7922 00:13 -!- Guest84297 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 00:16 < GitHub139> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/90653bc91d39...351abf9e0355 00:16 < GitHub139> bitcoin/master a4625ac Cory Fields: leveldb: integrate leveldb into our buildsystem... 00:16 < GitHub139> bitcoin/master 351abf9 Wladimir J. van der Laan: Merge #7911: leveldb: integrate leveldb into our buildsystem... 00:17 < GitHub133> [bitcoin] laanwj closed pull request #7911: leveldb: integrate leveldb into our buildsystem (master...leveldb-integration) https://github.com/bitcoin/bitcoin/pull/7911 00:17 < jonasschnelli> wumpus: https://github.com/bitcoin/bitcoin/pull/7911#issuecomment-212439612 00:17 < jonasschnelli> where is the DEFAULT_INCLUDES defined? 00:18 < wumpus> it's part of the automake system itself 00:20 < wumpus> the path to the config.h is added thre 00:22 < jonasschnelli> Okay. I see. Thanks. 00:24 < GitHub99> [bitcoin] laanwj opened pull request #7925: qt: Fix out-of-tree GUI builds (master...2016_04_qt_out_of_tree_build) https://github.com/bitcoin/bitcoin/pull/7925 00:35 -!- Guest84297 [~socrates1@li175-104.members.linode.com] has quit [Changing host] 00:35 -!- Guest84297 [~socrates1@unaffiliated/socrates1024] has joined #bitcoin-core-dev 00:35 -!- Guest84297 is now known as amiller 00:40 < phantomcircuit> this is without a doubt a terrible framework 00:40 * phantomcircuit goes back to the drawing board 00:48 -!- zlover [uid34185@gateway/web/irccloud.com/x-etuiwgtpcgmqgedc] has joined #bitcoin-core-dev 00:49 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:06 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 276 seconds] 01:13 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has joined #bitcoin-core-dev 01:13 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has quit [Changing host] 01:13 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:17 < phantomcircuit> first step in fuzzing serializer... use serializer 01:24 -!- Thireus1 [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection] 01:25 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 01:36 -!- most [54c95fe9@gateway/web/freenode/ip.84.201.95.233] has joined #bitcoin-core-dev 01:48 -!- lightningbot [supybot@2400:8900::f03c:91ff:fedf:3a06] has quit [Ping timeout: 250 seconds] 01:49 < wumpus> yes, e.g. deserialize a block passed in on stdin, or a transaction, or network packet, or anything else 01:49 < wumpus> what is a terrible framework, afl? I found it a breeze to use, at least compared to previous, more academic instrumented fuzzing frameworks 01:50 < wumpus> no need to use a patched LLVM/clang etc a tleast 01:51 -!- aj [aj@cerulean.erisian.com.au] has quit [Ping timeout: 260 seconds] 01:51 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Ping timeout: 244 seconds] 01:51 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Remote host closed the connection] 01:52 -!- lightningbot [lightningb@cerulean.erisian.com.au] has joined #bitcoin-core-dev 01:58 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection] 01:58 -!- lightningbot [lightningb@cerulean.erisian.com.au] has quit [Remote host closed the connection] 01:58 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 01:58 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection] 01:58 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 02:00 < phantomcircuit> wumpus, no im trying to build a framework for doing this that does things like de-serializes a CScript object from stdin 02:08 < wumpus> oh right 02:09 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 02:10 < phantomcircuit> wumpus, it's a pita 02:10 < phantomcircuit> it's 2016 02:10 < phantomcircuit> why can't i just do std::vector.pop() 02:10 < phantomcircuit> :| 02:12 -!- Thireus1 [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 02:12 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection] 02:12 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Remote host closed the connection] 02:14 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev 02:14 < wumpus> I don't know, use a sane language instead of c++? :-) 02:15 < wumpus> c and derivatives are, in a way, like living in the 80's, with a few modern niceties bolted on in surprising and artful ways 02:16 -!- lightningbot [supybot@2400:8900::f03c:91ff:fedf:3a06] has joined #bitcoin-core-dev 02:17 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 02:19 -!- aj_ [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 02:21 < phantomcircuit> wumpus, heh 02:22 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Quit: Leaving] 02:23 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has joined #bitcoin-core-dev 02:32 < GitHub197> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/351abf9e0355...f604bf63211f 02:32 < GitHub197> bitcoin/master f59dceb Wladimir J. van der Laan: qt: Fix out-of-tree GUI builds... 02:32 < GitHub197> bitcoin/master f604bf6 Wladimir J. van der Laan: Merge #7925: qt: Fix out-of-tree GUI builds... 02:32 < GitHub26> [bitcoin] laanwj closed pull request #7925: qt: Fix out-of-tree GUI builds (master...2016_04_qt_out_of_tree_build) https://github.com/bitcoin/bitcoin/pull/7925 02:34 < most> hi everyone. i'm currently playing around with the watch-only-feature to archive the balance of adresses. therefore i've used: importadress 1CC6eBM579riyXRVkrBtPtRcmy8C4mpqw2 "test" true 02:37 < most> after successfully rescanning the blockchain, i had look into the balance by using >>getbalance "test" 0 true<< and the balance differs to the one i've actually expected 02:37 < most> as >>listtransactions "test" 1000 0 true<< just show up all the received transactions, but not the send-related ones 02:39 < sipa> most: accounts are virtual bean counters that all share the same wallet coins... they don't have any relation to the blockchain 02:40 < sipa> most: the wallet does not have a way to give you a so-called address balance 02:40 < most> hmm, ok, so i have to get summarize the debits and credits by myself? 02:41 < sipa> it will show you sends and receives by using listtransactions 02:41 < sipa> if you specify an account name to listtransactions, it will only list transactions associated with that account 02:41 < wumpus> listunspent, with filter by address, can give you the unspent outputs, you can sum them up and get an 'address balance'. For whatever that's worth. 02:42 < most> yeah, i saw the sends in listtransactions, but the account-field equals to "" 02:42 < most> whereas in a received transaction the account-field states "test", which was the account i imported the address into 02:42 < wumpus> it usually indicates you're doing something wrong, like reusing addresses 02:42 < sipa> most: that's correct; sends are always associated with "" unless you use the sendfrom command 02:42 < sipa> most: again, accounts have nothing to do with the actual coins 02:43 < wumpus> better forget about using accounts, except as a convenient label for a group of addresses 02:44 < most> yeah, even as the "accounting-feature" is been dropped somewhere in the future 02:44 < wumpus> the account balance feature, apart from being deprecated, is not useful for what you're trying to do 02:44 < wumpus> right 02:45 < most> ok, so i will have a look into listunspend. thank you very much 02:47 < sipa> listunspent only gives you the remaining coins and their value 02:47 < sipa> not any history 02:47 < most> i guess for my purpose it should be fine 02:48 < wumpus> which is enough if you just want to compute the balance 02:48 < most> i'm just looking for current balance of an address 02:48 < wumpus> if you want the history per address you can look at listtranscations, and bucket per receiving address 02:50 < most> no, just the balance is fine. i'm regulary checking the balance. and if drops compared to the last one (which is stored in a db or somewhere else) i'll send a notice 02:54 < most> anyway, thanks for the help 02:56 < sipa> MarcoFalke: i'm not going to rebase until there has been more review, but i'll modify the last commit with your binascii/hex/bytes changes 02:58 -!- zlover [uid34185@gateway/web/irccloud.com/x-etuiwgtpcgmqgedc] has quit [Quit: Connection closed for inactivity] 02:58 < GitHub82> [bitcoin] MarcoFalke closed pull request #7918: [qa] mininode: Use hexlify wrapper from util (master...Mf1604-qaMininodeHexlify) https://github.com/bitcoin/bitcoin/pull/7918 02:58 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev 03:07 -!- amiller [~socrates1@unaffiliated/socrates1024] has quit [Ping timeout: 240 seconds] 03:17 < wumpus> jonasschnelli: Q: in your lmdb benchmarks, were you using a VM or otherwise a filesystem mounted from a file instead of block device? I'm seeing some very slow behavior, hanging for ages in fdatasync when I benchmark in a VM 03:22 -!- amiller_ [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 03:29 -!- amiller_ [~socrates1@li175-104.members.linode.com] has quit [Quit: ZNC - http://znc.sourceforge.net] 03:31 -!- jtimon [~quassel@18.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 03:32 -!- amiller_ [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 03:36 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 03:39 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 240 seconds] 03:52 -!- nickler [~nickler@185.12.46.130] has joined #bitcoin-core-dev 04:17 < jonasschnelli> wumpus: No. I was testing on a non-VM system with physical wired SSD. 04:17 < wumpus> ok 04:17 < jonasschnelli> Though I can give it a testrun on a VM on the same system. 04:17 < jonasschnelli> s/can/could 04:19 < sipa> wumpus: was your benchmark on an ssd? 04:19 < wumpus> jonasschnelli: not necessary, just trying to figure out what is different between your and gmaxwell's benchmark 04:20 < wumpus> sipa: I didn't time any full syncs with it 04:21 < sipa> here is a theory: lmdb uses mmap, and we use bulk writes often. this means that the OS can do a better job of scheduling the necessary writes to disk than the single-threaded, linear, synchronous approach used by leveldb 04:21 < sipa> if your latency for disk writes is low, that perhaps means that the benefit from lmdb is smaller 04:21 < wumpus> jonasschnelli: it would be interesting to see if in your case most time is also spent in fdatasync 04:21 < sipa> as on an ssd a random write isnas fast as a linear 04:22 < jonasschnelli> wumpus: how did you measure the time-spent-in-what-function? Did you add some benchmark logs or ran with a time profiler? 04:22 < wumpus> jonasschnelli: no, worse, just break into the debugger when I see it hangin the log 04:23 < wumpus> you can find out the same with a profiler, ofc :) 04:23 < jonasschnelli> hah. Okay. Yes. 04:23 < jonasschnelli> I think we should add a debug=lmbd in your branch. 04:23 < jonasschnelli> Otherwise this will be a myst forever 04:23 < wumpus> sipa: yes that sounds convincing 04:28 < jonasschnelli> sipa: btw: the basic reindex with you new PR took ~24min. (2016-04-20 14:25:30 Reindexing block file blk00000.dat... 2016-04-20 14:49:28 Reindexing finished) 04:31 < jonasschnelli> But then I got "UpdateTips" untill 2016-04-20 19:05:21 (~4h15'). 04:33 < wumpus> yes, that's the idea, it splits the reindex into two phases, which in total should be faster than the whole process was before 04:33 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 04:33 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 04:35 < sipa> jonasschnelli: yes, that's expected... how long was a reindex beforehand? 04:36 < jonasschnelli> sipa: not sure. But somewhere around 5h IIRC (need to check the IRC logs). 04:36 * jonasschnelli checking logs... 04:36 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 04:36 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 04:39 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 04:39 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 04:40 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 04:40 < jonasschnelli> can find it anymore. 04:40 * jonasschnelli checking the log 04:44 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 04:44 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 04:44 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 04:45 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 04:47 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 04:47 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 04:47 -!- murch [~murch@p4FE38B85.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:50 -!- murch1 [~murch@p4FE398A0.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:52 -!- murch [~murch@p4FE38B85.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds] 05:05 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 05:08 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 05:15 -!- cryptapus_afk is now known as cryptapus 05:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:20 -!- most [54c95fe9@gateway/web/freenode/ip.84.201.95.233] has quit [Quit: Page closed] 05:26 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 05:26 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 05:30 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 05:31 -!- BCBot [~BCBot@42.90.62.81.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 05:39 -!- shesek [~shesek@bzq-84-110-109-203.cablep.bezeqint.net] has quit [Ping timeout: 240 seconds] 05:39 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:41 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:43 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 05:46 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 246 seconds] 05:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 05:54 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 06:00 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Ping timeout: 260 seconds] 06:05 -!- BCBot [~BCBot@55.107.196.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 06:07 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:18 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev 06:21 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 06:43 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 06:50 -!- d_t [~textual@195.52.242.214] has joined #bitcoin-core-dev 06:50 -!- d_t [~textual@195.52.242.214] has quit [Client Quit] 06:56 -!- earlest [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev 07:00 -!- bysherper [~denetrabu@96.93.57.150] has quit [Ping timeout: 260 seconds] 07:30 -!- jtimon [~quassel@18.29.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 07:46 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 07:56 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 08:00 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Ping timeout: 246 seconds] 08:11 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has quit [Remote host closed the connection] 08:17 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has joined #bitcoin-core-dev 08:43 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!] 08:51 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 08:51 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 08:51 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 09:08 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:13 -!- bysherper [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev 09:16 -!- earlest [~denetrabu@96.93.57.150] has quit [Ping timeout: 246 seconds] 09:25 -!- murch1 [~murch@p4FE398A0.dip0.t-ipconnect.de] has quit [Quit: Leaving.] 09:25 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev 09:26 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 09:27 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:31 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Ping timeout: 252 seconds] 09:39 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 246 seconds] 09:44 -!- fkhan [weechat@gateway/vpn/mullvad/x-vprqvrwqgiypphjo] has joined #bitcoin-core-dev 10:07 < sipa> cfields: any problems getting the flag from travis? 10:10 -!- RoyceX [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 10:11 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 10:12 -!- Amnez777 [~Amnez777@37.157.216.175] has quit [Ping timeout: 244 seconds] 10:13 -!- lecusemble [~lecusembl@104.233.76.133] has quit [Ping timeout: 244 seconds] 10:15 -!- lecusemble [~lecusembl@104.233.76.133] has joined #bitcoin-core-dev 10:15 -!- zooko [~user@2601:281:8301:1f00:5522:b6ce:1c7a:811d] has joined #bitcoin-core-dev 10:16 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 10:20 -!- Amnez777 [~Amnez777@37.157.216.175] has joined #bitcoin-core-dev 10:39 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 10:43 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 10:47 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Ping timeout: 250 seconds] 10:55 -!- earlest [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev 10:59 -!- bysherper [~denetrabu@96.93.57.150] has quit [Ping timeout: 246 seconds] 11:15 -!- mrkent_ [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 11:23 < GitHub6> [bitcoin] instagibbs opened pull request #7926: [RPC] push back getaddednodeinfo dead value (master...getaddedpushbackmaster) https://github.com/bitcoin/bitcoin/pull/7926 11:31 -!- amiller_ [~socrates1@li175-104.members.linode.com] has quit [Changing host] 11:31 -!- amiller_ [~socrates1@unaffiliated/socrates1024] has joined #bitcoin-core-dev 11:31 -!- amiller_ is now known as amiller 11:33 -!- bysherper [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev 11:36 -!- muuqwaul [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev 11:36 -!- earlest [~denetrabu@96.93.57.150] has quit [Ping timeout: 246 seconds] 11:38 -!- bysherper [~denetrabu@96.93.57.150] has quit [Ping timeout: 246 seconds] 11:42 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 11:47 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 276 seconds] 11:48 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 11:54 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-kzgjlbnaaaoyqmfu] has quit [Read error: Connection reset by peer] 11:56 -!- CodeShark_ [sid126576@gateway/web/irccloud.com/x-dvxarrwpzbcurkwj] has joined #bitcoin-core-dev 11:57 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-wbvrxdzqntmvdohi] has quit [Ping timeout: 264 seconds] 11:57 -!- CodeShark_ is now known as CodeShark 11:57 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-bjdibxeepsrzmnmb] has joined #bitcoin-core-dev 12:11 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 12:11 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:16 -!- zooko [~user@2601:281:8301:1f00:5522:b6ce:1c7a:811d] has quit [Ping timeout: 276 seconds] 12:21 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 12:37 -!- d_t [~textual@195.52.242.214] has joined #bitcoin-core-dev 12:39 -!- d_t [~textual@195.52.242.214] has quit [Client Quit] 12:55 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 13:07 -!- Don_John [~Don@249-223-114-134.nat.resnet.nau.edu] has joined #bitcoin-core-dev 13:09 -!- Don_John [~Don@249-223-114-134.nat.resnet.nau.edu] has quit [Remote host closed the connection] 13:30 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 13:33 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 13:46 -!- xabbix__ [~xabbix@bzq-79-178-81-151.red.bezeqint.net] has joined #bitcoin-core-dev 13:48 -!- xabbix_ [~xabbix@bzq-79-182-11-18.red.bezeqint.net] has quit [Ping timeout: 260 seconds] 13:50 -!- paveljanik [~paveljani@ip-86-49-127-111.net.upcbroadband.cz] has joined #bitcoin-core-dev 13:50 -!- paveljanik [~paveljani@ip-86-49-127-111.net.upcbroadband.cz] has quit [Changing host] 13:50 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 13:54 -!- PRab [~chatzilla@c-68-34-102-231.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 13:56 -!- earlest [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev 13:59 -!- muuqwaul [~denetrabu@96.93.57.150] has quit [Ping timeout: 246 seconds] 14:09 < cfields> sipa: I never heard back this time. It was going too smoothly... 14:26 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 14:43 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 250 seconds] 14:49 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 14:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:52 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 15:13 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 15:21 -!- JackH [~Jack@79-73-185-113.dynamic.dsl.as9105.com] has quit [Read error: Connection reset by peer] 15:22 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 15:23 -!- mrkent_ [~textual@unaffiliated/mrkent] has quit [] 15:25 -!- mrkent_ [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 15:29 < gmaxwell> sdaftuar: I have a patch that removes the feerate, and also takes it out of acceptmempool, but sipa would have killed me if I expanded the scope of that PR any further. 15:29 < gmaxwell> but as soon as that goes in I will PR it. 15:32 -!- cryptapus is now known as cryptapus_afk 15:33 -!- Kexkey [~kexkey@184.75.213.131] has joined #bitcoin-core-dev 15:42 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 15:52 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 16:02 -!- belcher [~user@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 16:02 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 16:02 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 16:05 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 16:07 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 16:09 < phantomcircuit> gmaxwell, is there anything wrong with this line https://github.com/pstratem/bitcoin-public/commit/7cb528af0fe0eea0f3219d280d7e3c043981f94a#diff-1db7f2ace9b759d046ca652e1465b95aR45 16:10 < phantomcircuit> it's doing crazy things when built against afl on fedora 23 16:24 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:25 < gmaxwell> what does crazy things mean? 16:25 < gmaxwell> also, turn up warnings. 16:27 < phantomcircuit> gmaxwell, segfaults 16:46 -!- zooko [~user@c-73-229-199-227.hsd1.co.comcast.net] has joined #bitcoin-core-dev 17:00 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 17:01 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 17:17 < sdaftuar> gmaxwell: hah, i made the same patch myself to see how big the changes were, then figured out that this must be exactly what sipa meant about the ever-expanding scope of that PR 17:21 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 17:43 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-qcbtnaytdcienvce] has quit [Quit: Connection closed for inactivity] 17:53 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving] 18:04 -!- mrkent_ [~textual@unaffiliated/mrkent] has quit [Ping timeout: 260 seconds] 18:12 -!- Kexkey [~kexkey@184.75.213.131] has quit [Remote host closed the connection] 18:34 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 18:35 -!- ebfull [~sean@73.34.119.0] has joined #bitcoin-core-dev 18:35 -!- ebfull [~sean@73.34.119.0] has quit [Client Quit] 18:35 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 18:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 18:58 < gmaxwell> sdaftuar: I do feel kinda bad that it takes a mempool lock now several times for each transaction in the queue, but it's negligble. It could be easily optimized later, e.g. to have a function that took the set and populated a vector of {hash, depth, feerate} and dropped evicted transactions, all under a single lock acquisition. But that can be done another day... 18:58 < gmaxwell> the improvement from this for propagation of dependant transactions is really substantial, and I'd rather not delay it. 19:16 -!- river__ [uid155689@gateway/web/irccloud.com/x-huycjoqzanlskihp] has joined #bitcoin-core-dev 19:36 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 19:39 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 19:51 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:52 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:19 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:19 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 20:20 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:31 -!- zooko [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Remote host closed the connection] 20:33 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 20:35 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:36 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:58 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 21:20 -!- river__ [uid155689@gateway/web/irccloud.com/x-huycjoqzanlskihp] has quit [Quit: Connection closed for inactivity] 21:21 -!- p15x [~p15x@162.91.145.64.unassigned.bringover.net] has joined #bitcoin-core-dev 22:02 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 22:06 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:07 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:17 -!- grassass [grass@gateway/vpn/mullvad/x-vjjgdoqysrfdvlew] has joined #bitcoin-core-dev 22:24 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 22:24 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 22:44 < phantomcircuit> wumpus, currently have fuzzing of CDataStream >> CBlock working 22:45 < wumpus> great! 22:45 < phantomcircuit> i figured that would exercise the most of the serialization stuff in one go 22:46 < phantomcircuit> also discovered that combining std::copy with violation of the strict aliasing rule is a bad idea 22:46 < phantomcircuit> (on the latest gcc at least) 22:47 < gmaxwell> violating aliasing rules is always a bad idea. :) 22:47 -!- dermoth_ [~thomas@dsl-66-36-157-105.mtl.aei.ca] has quit [Ping timeout: 268 seconds] 22:51 < phantomcircuit> gmaxwell, i wasn't expecting it to violate the rule though 22:51 < phantomcircuit> (and there's no warning about it) 22:51 < phantomcircuit> ie thought it was char* 22:52 < gmaxwell> ah, no you were copying a vector, no? 22:52 < phantomcircuit> copying from std::vector to uint32_t* 22:52 < gmaxwell> yea... not quite. :) 22:52 < gmaxwell> Have you tried introducing a bug and verifying that it finds it? 22:53 < phantomcircuit> currently im trying to identify which exceptions i should catch as "that's expected" 23:06 < phantomcircuit> gmaxwell, huh memcpy is void* 23:06 < phantomcircuit> i guess this is *also* violating sa 23:11 < phantomcircuit> it seems like catching std::ios_base::failure is enough 23:12 < gmaxwell> phantomcircuit: it isn't the protype that can violate SA, its whats done inside, if you implemented your own memcpy and did your accesses via char pointers you'd be fine. 23:13 < phantomcircuit> gmaxwell, i wonder if glibc memcpy is char* internally or not 23:13 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 23:14 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 23:22 < sipa> phantomcircuit: i assume it's written in asm :) 23:23 < gmaxwell> "lol" 23:33 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 23:33 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 23:34 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 23:49 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 23:50 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev