--- Day changed Mon Apr 25 2016
00:12 < GitHub136> [bitcoin] pstratem opened pull request #7936: CDataStream::ignore Throw exception instead of assert on negative nSize. (master...2016-04-24-cdatastream-ignore) https://github.com/bitcoin/bitcoin/pull/7936
00:16 < phantomcircuit> luke-jr, -Wall -pedantic will tell you if you're using c++11 isms
00:16 < phantomcircuit> (sometimes)
00:16 < phantomcircuit> it'll also complain about lots of random irrelevant stuff
00:19 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 250 seconds]
00:19 < gmaxwell> libsecp256k1 builds completely clean with -Wall -Wextra -std=c89 -pedantic (plus a few more warning flags that aren't turned on by extra). (well, excepting the -Wno-long-long is used so it doesn't whine about use of long long, -Wno-unused-function because pieter didn't like me peppering the code with ifdefs to kill the last unused functions in some builds, and -Wno-overlength-strings to work aro
00:19 < gmaxwell> und a clang bug)
00:41 -!- grassass [grass@gateway/vpn/mullvad/x-vjjgdoqysrfdvlew] has quit [Remote host closed the connection]
00:43 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev
00:51 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has joined #bitcoin-core-dev
00:51 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has quit [Changing host]
00:51 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:05 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 268 seconds]
01:06 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
01:20 -!- lightningbot [supybot@2400:8900::f03c:91ff:fedf:3a06] has quit [Ping timeout: 276 seconds]
01:20 -!- abritoid [~abritoid@46.16.193.99] has joined #bitcoin-core-dev
01:20 -!- aj_ [aj@cerulean.erisian.com.au] has quit [Ping timeout: 260 seconds]
01:21 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Ping timeout: 252 seconds]
01:21 -!- sipa [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev
01:31 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:32 -!- lightningbot [lightningb@cerulean.erisian.com.au] has joined #bitcoin-core-dev
01:32 < wumpus> speaking of c++11, it's Monday, any news from Travis cfields?
01:33 < wumpus> sorry for the impatience <:
01:33 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev
01:36 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
01:54 -!- lightningbot [lightningb@cerulean.erisian.com.au] has quit [Remote host closed the connection]
01:55 -!- aj [aj@cerulean.erisian.com.au] has quit [Ping timeout: 250 seconds]
01:56 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Ping timeout: 276 seconds]
01:58 -!- lightningbot [supybot@2400:8900::f03c:91ff:fedf:3a06] has joined #bitcoin-core-dev
02:00 < phantomcircuit> gmaxwell, afl-cmin -C isn't finding any crashes but afl-fuzz reports them in the curses ui
02:00 < phantomcircuit> thoughts?
02:01 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
02:02 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev
02:03 < sipa> wumpus: at least wait until the business day is over :)
02:03 < sipa> wumpus: seems travis is baser on germany, so we don't need to wait another 9 hours
02:04 < luke-jr> phantomcircuit: https://www.youtube.com/watch?v=XGM6sHIJuho
02:04 < phantomcircuit> luke-jr, something something florida man?
02:07 -!- ebfull [~sean@73.34.119.0] has quit [Quit: Konversation terminated!]
02:12 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
02:21 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:27 -!- abritoid [~abritoid@46.16.193.99] has quit [Quit: O.o]
02:28 < btcdrak> wumpus: it's still not Monday in some parts of the world yet .-.
02:29 < phantomcircuit> btcdrak, it's technically monday where cfields is
02:29 < phantomcircuit> but only in a very technical sense
02:35 < sipa> phantomcircuit: correct, but utterly irrelevant
02:35 < sipa> as the monday eta was given by travis, not cory :)
02:38 < phantomcircuit> oh
02:43 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 250 seconds]
02:44 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
02:47 < GitHub179> [bitcoin] laanwj closed pull request #6821: Avoid duplicate getheaders requests (master...no-duplicate-getheaders) https://github.com/bitcoin/bitcoin/pull/6821
03:07 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 276 seconds]
03:11 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev
03:16 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:20 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
03:20 -!- Guyver2_ is now known as Guyver2
03:26 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Ping timeout: 244 seconds]
03:28 -!- cryptapus_afk is now known as cryptapus
03:38 -!- pmienk [~pmienk@c-71-227-177-179.hsd1.wa.comcast.net] has quit [Ping timeout: 276 seconds]
03:39 -!- pmienk [~pmienk@c-71-227-177-179.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
03:47 < GitHub121> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/f604bf63211f...f9c2ac72327e
03:47 < GitHub121> bitcoin/master 74f7b12 Wladimir J. van der Laan: dbwrapper: Remove throw keywords in function signatures...
03:47 < GitHub121> bitcoin/master 878bf48 Wladimir J. van der Laan: dbwrapper: Remove CDBWrapper::GetObfuscateKeyHex...
03:47 < GitHub121> bitcoin/master b69836d Wladimir J. van der Laan: dbwrapper: Pass parent CDBWrapper into CDBBatch and CDBIterator...
03:47 < GitHub160> [bitcoin] laanwj closed pull request #7927: Minor changes to dbwrapper to simplify support for other databases (master...2016_04_dbwrapper_modernization) https://github.com/bitcoin/bitcoin/pull/7927
03:52 -!- gevs [~greg@ip-81-11-204-218.dsl.scarlet.be] has joined #bitcoin-core-dev
03:52 -!- gevs [~greg@ip-81-11-204-218.dsl.scarlet.be] has quit [Changing host]
03:52 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev
03:55 -!- abritoid [~abritoid@46.16.193.99] has joined #bitcoin-core-dev
04:00 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev
04:03 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]
04:03 -!- fengling [~fengling@111.198.29.53] has quit [Quit: WeeChat 1.4]
04:32 < GitHub158> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/f9c2ac72327e...c4e8390047a1
04:32 < GitHub158> bitcoin/master c907f4d Wladimir J. van der Laan: doc: Update release process...
04:32 < GitHub158> bitcoin/master 182bec4 Wladimir J. van der Laan: contrib: remove hardcoded version from verify.sh...
04:32 < GitHub158> bitcoin/master f154470 MarcoFalke: [contrib] Remove reference to sf and add doc to verify.sh
04:32 < GitHub161> [bitcoin] laanwj closed pull request #7881: Update release process (master...2016_04_update_release_process) https://github.com/bitcoin/bitcoin/pull/7881
04:43 -!- pmienk [~pmienk@c-71-227-177-179.hsd1.wa.comcast.net] has quit [Ping timeout: 250 seconds]
04:48 -!- NotAnNSAgent [~NotAnNSAg@46.166.137.205] has joined #bitcoin-core-dev
04:49 -!- ebfull [~sean@73.34.119.0] has joined #bitcoin-core-dev
04:50 < NotAnNSAgent> This is obviously going to offend you, but I have to ask... Is the not only poor, but grossly *misleading* documentation deliberately so? I mean, maybe you don't want Bitcoin to be easy to implement to ensure job security or something? I've seriously begun asking myself if that could be the case. Again, though, I understand that this is both very difficult stuff, and you can't change things directly as individuals without first talking 
04:50 < NotAnNSAgent> to a bunch of people, but still. The documentation just seems... nonexistent in practice?
04:51 < NotAnNSAgent> (It's worth adding that I feel the same thing about Let's Encrypt and many other projects.)
04:51 < NotAnNSAgent> I eventually figured out how to use LE, though.
04:51 < wumpus> have you seen https://bitcoin.org/en/developer-documentation ? I think it's pretty okay
04:52 < wumpus> note that no one is being paid to write documentation, so if you want to spend time contributing on improving the documenttion you're very welcome
04:53 < wumpus> if not I suggest you leave, this is an open source project, there is no customer support and complaining won't get you anywhere
04:56 < assder> This looks very good for those wanting to start developing: https://en.bitcoin.it/wiki/Bitcoin_Core_0.11_(ch_1):_Overview. Haven't checked it out in depth myself.
04:58 < wumpus> interesting
04:58 < assder> wumpus: Is there a big difference in the architecture of Core between 0.11 and 0.12, such that one should wait until that gets updated to start studying it?
04:59 < wumpus> assder: no, it's still the same on a high level
05:00 -!- pmienk [~pmienk@c-71-227-177-179.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
05:02 < wumpus> the P2P code and initialization didn't change much since then
05:02 < wumpus> the RPC server changed quite a lot from 0.11 to master (e.g. switching from boost::asio to libevent, amongst other things) but I see that page isn't even there
05:04 -!- jtimon [~quassel@79.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:06 < NotAnNSAgent> wumpus: I'm talking about the API to talk to bitcoind. Which seems to be explained (messily) at https://bitcoin.org/en/developer-reference#bitcoin-core-apis , but that documentation is full of dangerously outdated information.
05:06 < NotAnNSAgent> And has "not been reviewed by Bitcoin developers", which makes no sense to me.
05:06 < instagibbs> NotAnNSAgent, bitcoin-cli help ?
05:06 < wumpus> NotAnNSAgent: the best documentation for the API is in bitcoind itself, using bitcoin-cli help
05:06 < wumpus> right, as instagibbs says
05:07 < NotAnNSAgent> That is the same as sending "help" as an RPC call, right?
05:07 < NotAnNSAgent> (I don't have bitcoin-cli binary)
05:07 < wumpus> yes, help with an optional method name
05:07  * NotAnNSAgent fires up his shutdown server and tries that
05:07 < wumpus> how do you manage to not get the bitcoin-cli binary?
05:10 < da2ce7_mobile> hello, I wish to copy the blocks from one PC to another, what is the minimum I need to copy? It If I just copy the blk0xxx files it overwrites the files.  If I include the rev00xxx files bitcoin throws an assertion. I suppose it has something to do with the chainstate obfuscation.
05:10 < da2ce7_mobile> I'm using Bitcoin 0.12.1
05:10 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 276 seconds]
05:10 < wumpus> you want to copy just the block data or also the databases?
05:11 < wumpus> the minimum is copying just blk*.dat then running -reindex
05:11 < wumpus> the other option is to copy blocks/ and chainstate/ entirely
05:11 < sipa> or either of them separately, as long as the result is a chainstate/ that is not ahead of blocks/
05:11 < wumpus> which will be faster as you don't need a reindex. Be sure to do that while bitcoind is not running.
05:11 < da2ce7_mobile> ahh. so it won't automatically detect without -reindex. 
05:11 < da2ce7_mobile> ok.
05:12 < sipa> it will
05:12 < sipa> you can copy the blocks, and delete the chainstate
05:12 < sipa> in which case it will rebuild it
05:12 < sipa> (though due to a bug, that's currently much slower than just reindexing)
05:13 < da2ce7_mobile> I will try again, I was seeing a different result.
05:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:13 < wumpus> don't include the revXXXX files if you don't copy the chainstate though, they're undo files for the chainstate and have no use without it
05:16 < da2ce7_mobile> Ok, I have just the blkXXX files, and a wallet.dat file. Will load bitcoin.
05:16 < wumpus> (although I don't understand why you'd get an assertion error, they should just be ignored on reindex)
05:16 < sipa> best is to start with -reindex in that case
05:17 < sipa> it will only work without -reindex if you also have blocks/index/ already
05:17 < da2ce7_mobile> ahh ok.
05:17 < da2ce7_mobile> that explains the result.
05:17 < sipa> blocks/ > blocks/index/ > chainstate/
05:17 < sipa> (> meaning 'must be ahead of')
05:17 < sipa> i guess >= is a better symbol
05:18 < wumpus> right
05:19 < da2ce7_mobile> ok. I get the expected result now "reindexing blocks on disk"; thank! :)
05:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]
05:20 < GitHub61> [bitcoin] laanwj closed pull request #7792: depends: mac deploy Py3 compatibility (fixes macosx gitian build) (master...2016_04_fix_macosx_gitian) https://github.com/bitcoin/bitcoin/pull/7792
05:25 -!- gevs [~greg@ip-81-11-204-218.dsl.scarlet.be] has joined #bitcoin-core-dev
05:25 -!- gevs [~greg@ip-81-11-204-218.dsl.scarlet.be] has quit [Changing host]
05:25 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev
05:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:26 < NotAnNSAgent> Okay, so at least the "help blabla" stuff mentions "DEPRECATED" in the output, but it still lists <account> and all that.
05:27 < NotAnNSAgent> wumpus: I manage to not get the bitcoin-cli binary because I only installed bitcoin-daemon because why would I want the -cli thing?
05:27 < NotAnNSAgent> I searched the online manual for "label", but found no way to set/get this. How is it set/get?
05:27 < wumpus> you still have to use the account API for that right now
05:28 < NotAnNSAgent> That is, any label I need for my own reference to know which "account" (not the deprecated Bitcoin concept of "accounts") it belongs to.
05:28 < wumpus> this is the label API that will replace it: https://github.com/bitcoin/bitcoin/pull/7729  ... note that this is mostly just a subset of the account functionality, the only thing that will disappear is the account balance
05:28 < NotAnNSAgent> wumpus: Are you saying that the "account" concept is deprecated and about to be removed, and the "label" concept is so new it's not implemented properly?
05:29 < wumpus> that's why it's deprecated, not removed
05:29 < NotAnNSAgent> So I have to use "account" for now, then closely follow the project and change my code when the service is actually in production to reflect the "label" concept?
05:29 < wumpus> feel free to help testing the label API pull request
05:29 < wumpus> in general there is very little interest in that part of the code, so any help is welcome
05:29 < NotAnNSAgent> Why not just keep the account concept, then?
05:29 < wumpus> because it is broken in multiple ways
05:30 < NotAnNSAgent> There is very little interest in making it possible to have any idea who owns a given address in a "Bitcoin bank" (wallet)?
05:30 < wumpus> I suggest you read https://github.com/bitcoin/bitcoin/issues/3816
05:31 < wumpus> no, using accounts to group addresses is fine, but the account balance functionality (as well as the 'move' call) will be removed
05:31 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
05:31 < NotAnNSAgent> Confusing part: "Users are used to seemingly-odd practices of transferring imaginary money from a dummy account, to eliminate a negative number in some cases."
05:31 < NotAnNSAgent> Hmm.
05:31 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit []
05:32 < NotAnNSAgent> wumpus: Where were you yesterday? :O)
05:32 < wumpus> I expect the account calls, even after adding the label API and remvoing account balances, will be kept as aliases for the *label* RPCs for backwards compatiblity for some time
05:32 < wumpus> on sunday?
05:32 < NotAnNSAgent> wumpus: When you say it's "fine" to use accounts to "group" addresses, are you saying that it will be easy for me to just change some string later when the accounts are removed, or that the syntax will be kept (but not documented/encouraged) in the future, allowing me to keep running it like that?
05:33 < wumpus> well, doing other stuff at least :p
05:33 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds]
05:33 < wumpus> NotAnNSAgent: probably.
05:33  * NotAnNSAgent is slightly less pissed off now.
05:33 < NotAnNSAgent> Quite a bit, actually.
05:33 < wumpus> NotAnNSAgent: there are no guarantees for anything in the future, especially not regarding thewallet, and for every *major* release you should read the release notes carefully
05:34 < NotAnNSAgent> Yes, but how many people actually do that? It's like reading EULAs.
05:34 < wumpus> bitcoin core is not something you should upgrade without paying attention, especially if you use it in production and there's actual money involved
05:34 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has joined #bitcoin-core-dev
05:34 < sipa> NotAnNSAgent: if you're running your bank using, i think it may make sense to actually do it
05:34 < NotAnNSAgent> I didn't even read the entire PHP 7 announcement, even though I'm heavily invested in PHP and the change from 5.6 to 7 felt like a major surgery.
05:35 < NotAnNSAgent> Hmm. I guess.
05:35 < sipa> NotAnNSAgent: we also maintain bugfixes for the previous major release, and critical bugfixes for the one before
05:35 < sipa> so it's not like an API change will hit you without resort
05:36 < wumpus> you're taking a risk by not doing so, you can decide for yourself whether it's acceptable, but most serious companies have careful upgrade practices (like running parallel servers with a new version for a while) for anything that directly affects their bottom line
05:36 < NotAnNSAgent> Backwards compatibility should be of utmost importance in this context, though.
05:36 < wumpus> backwards priority is a concern, but you don't decide our priorities, sorry
05:37 < wumpus> compatibility*
05:37 < sipa> NotAnNSAgent: that's why accounts haven't been removed outright, and there is a long discussion going on about it
05:37 < wumpus> right, they've been deprecated for ages, it's not as if it was removed from one version to the other
05:37 < wumpus> but the RPC API can change in non-backwards compatible ways between *major* releases
05:38 < sipa> also, i thought you had realized that accounts were not what you needed?
05:40 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
05:47 < GitHub91> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c4e8390047a1...46880ed2fd96
05:47 < GitHub91> bitcoin/master c3932b3 Pieter Wuille: List solvability in listunspent output and improve help
05:47 < GitHub91> bitcoin/master 46880ed Wladimir J. van der Laan: Merge #7688: List solvability in listunspent output and improve help...
05:47 < GitHub66> [bitcoin] laanwj closed pull request #7688: List solvability in listunspent output and improve help (master...helpspendsolv) https://github.com/bitcoin/bitcoin/pull/7688
05:48 < MarcoFalke> wumpus, I think it makes sense to merge https://github.com/bitcoin/bitcoin/pull/7811#issuecomment-212380135 now
05:49 < wumpus> MarcoFalke: ok, go ahead :)
05:55 < phantomcircuit> NotAnNSAgent, you've been unbanned from #bitcoin please move your discussion there
05:59 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Ping timeout: 268 seconds]
06:00 -!- xabbix__ [~xabbix@bzq-79-178-81-151.red.bezeqint.net] has quit [Ping timeout: 268 seconds]
06:00 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 268 seconds]
06:00 < GitHub46> [bitcoin] MarcoFalke closed pull request #7811: [0.12.2] qa Backports (0.12...Mf1604-qa012) https://github.com/bitcoin/bitcoin/pull/7811
06:00 < GitHub133> [bitcoin] MarcoFalke pushed 12 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/9779e1e1f320...89ae85484c8b
06:00 < GitHub133> bitcoin/0.12 d89fbfe MarcoFalke: [qa] rpc-test: Normalize assert()...
06:00 < GitHub133> bitcoin/0.12 ad8c743 MarcoFalke: [qa] Extend tests...
06:00 < GitHub133> bitcoin/0.12 6aae129 MarcoFalke: [qa] wallet: Print maintenance...
06:00 -!- jtimon [~quassel@79.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 268 seconds]
06:00 -!- dermoth [~thomas@dsl-66-36-157-105.mtl.aei.ca] has quit [Ping timeout: 268 seconds]
06:00 -!- phantomcircuit [~phantomci@192.241.205.97] has quit [Ping timeout: 268 seconds]
06:01 -!- jtimon [~quassel@79.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
06:01 -!- Squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has quit [Ping timeout: 268 seconds]
06:02 -!- go1111111 [~go1111111@104.200.154.86] has quit [Ping timeout: 250 seconds]
06:03 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev
06:04 -!- go1111111 [~go1111111@104.200.154.86] has joined #bitcoin-core-dev
06:05 -!- phantomcircuit [~phantomci@192.241.205.97] has joined #bitcoin-core-dev
06:06 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
06:07 -!- xabbix__ [~xabbix@bzq-79-178-81-151.red.bezeqint.net] has joined #bitcoin-core-dev
06:08 -!- murch [~murch@p4FE3B6BC.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
06:10 -!- dirtynewshoes [~dirtynews@sydnns0115w-047054250089.dhcp-dynamic.FibreOP.ns.bellaliant.net] has quit [Ping timeout: 250 seconds]
06:10 -!- dirtynewshoes [~dirtynews@sydnns0115w-047054250089.dhcp-dynamic.FibreOP.ns.bellaliant.net] has joined #bitcoin-core-dev
06:11 -!- dermoth [~thomas@dsl-66-36-157-105.mtl.aei.ca] has joined #bitcoin-core-dev
06:19 -!- Greybits [~Greybits@unaffiliated/greybits] has joined #bitcoin-core-dev
06:33 < Chris_Stewart_5> Why does the public key in this test case fail? http://pastebin.com/eR9ZHyRF
06:33 < Chris_Stewart_5> Is it becuse it is not properly encoded as per https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L202
06:37 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
06:37 < NotAnNSAgent> Alright.
06:37 < jl2012> the public key is 0
06:39 < Chris_Stewart_5> is the 'first public key is invalid' i'm guesing that refers to them being consumed off of the top of the stack?
06:39 < sipa> 0 is a correctly-encoded but invalid public key
06:39 < NotAnNSAgent> Just one more note, since sipa isn't in ##bitcoin: yes, I learned what "accounts" actually are in Bitcoin, but I also learned that the labels stuff is not stable/finished either, and that I can use "accounts" as a form of label until things stabilize, but I cannot use them to segregate money in the way I first thought was possible.
06:40 -!- TomMc [~tom@unaffiliated/tommc] has quit [Read error: Connection reset by peer]
06:40 < sipa> NotAnNSAgent: aye, indeed, thanks for clearing that up
06:41 < sipa> Chris_Stewart_5: as the checkmultisig requires 2 valid signatures, but it only gets one, the checkmultisig fails, the NOT after is inverts that result
06:41 < Chris_Stewart_5> sipa: That seems to directly contradict the comments  "2-of-2 CHECKMULTISIG NOT with the first pubkey invalid, and both signatures validly encoded."
06:42 < sipa> seems correct to me
06:42 < Chris_Stewart_5> Also, how could 0 be a validly encoded public key, doesn't it trivially fail this https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L66
06:43 < sipa> Chris_Stewart_5: nope, https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L189
06:44 < sipa> eh, i'm confusing pubkeys with signatures
06:44 < sipa> let me re-read what you said
06:44 < Chris_Stewart_5> sipa: You said "requires 2 valid signatures, but only gets one" - the comment says "both signatures validly encoded". Are you talking about being the correct key?
06:45 < sipa> right... so there are 2 correctly-encoded signatures there, and a valid and an invalid pubkey
06:45 < sipa> pubkeys are not subject to any encoding rules
06:46 < sipa> (except when STRICTENC is on, but that's only for mempool validation, not in blocks)
06:46 < Chris_Stewart_5> So "CheckPubKeyEncoding" is a misnomer? :-)
06:46 < sipa> no
06:47 < sipa> it just only has an effect when STRICTENC is on
06:48 < Chris_Stewart_5> I don't think that is only relevant inside of the mempool - https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L940 
06:48 < Chris_Stewart_5> But like you said, it would trivially pass if STRICTENC is not set
06:49 < sipa> STRICTENC is only set when inside the mempool
06:49 < sipa> we don't use two separate interpreters
06:50 < Chris_Stewart_5> Oh, interesting. Didn't realize that. 
06:50 < sipa> it's even documented: https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.h#L38
06:50 < sipa> not used or intended as a consensus rule
06:51 < sipa> DERSIG is a subset of STRICTENC, which is set when BIP66 is active
06:51 < Chris_Stewart_5> Is DERSIG
06:53 < Chris_Stewart_5> Interesting, I never really understood the difference between the two - or why we have two flags 
06:54 < sipa> STRICTENC is much older, and is just policy to prevent stupid encodings of data
06:54 < sipa> but STRICTENC may not be something we want in consensus code, as it can change over time
06:55 < GitHub177> [bitcoin] MarcoFalke opened pull request #7938: [0.12.2] Backports (0.12...Mf1604-012backp) https://github.com/bitcoin/bitcoin/pull/7938
06:55 < Chris_Stewart_5> sipa: So is strictenc in a certain way part of relay policy? and just to be crystal clear, DERSIG is absolutely consensus critical correct?
06:55 < sipa> yes
06:57 < Chris_Stewart_5> Thanks :-) 
07:03 < phantomcircuit> NotAnNSAgent, you've been unbanned from #bitcoin please move your discussion there
07:05 < GitHub25> [bitcoin] laanwj opened pull request #7939: qt: Make it possible to show details for multiple transactions (master...2016_04_qt_multiple_transaction_details) https://github.com/bitcoin/bitcoin/pull/7939
07:14 -!- NotAnNSAgent [~NotAnNSAg@46.166.137.205] has quit [Remote host closed the connection]
07:14 -!- NotAnNSAgent [~NotAnNSAg@gateway/vpn/privateinternetaccess/notannsagent] has joined #bitcoin-core-dev
07:52 -!- zooko [~user@c-73-217-96-13.hsd1.co.comcast.net] has joined #bitcoin-core-dev
07:55 -!- xiangfu [~xiangfu@119.90.18.65] has joined #bitcoin-core-dev
07:57 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has quit [Ping timeout: 244 seconds]
07:58 < NotAnNSAgent> phantomcircuit: Thanks. As mentioned, I only said that to sipa because he asked a question to me in here and he isn't in there.
07:58 < NotAnNSAgent> (Or wasn't when I sent the message.)
08:03 -!- zooko` [~user@50.141.117.77] has joined #bitcoin-core-dev
08:04 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has joined #bitcoin-core-dev
08:05 -!- zooko [~user@c-73-217-96-13.hsd1.co.comcast.net] has quit [Ping timeout: 252 seconds]
08:05 -!- earlest [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
08:08 -!- muuqwaul [~denetrabu@96.93.57.150] has quit [Ping timeout: 260 seconds]
08:13 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
08:14 -!- bysherper [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
08:17 < arubi> why are the expansions of op_cltv and op_csv done in different ways in 'script.h'?  https://github.com/bitcoin/bitcoin/blob/master/src/script/script.h#L165-L168
08:17 -!- earlest [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
08:22 < GitHub117> [bitcoin] pstratem opened pull request #7940: [WIP] Fuzzing framework (master...2016-04-20-fuzzing-framework) https://github.com/bitcoin/bitcoin/pull/7940
08:25 -!- zooko`` [~user@c-73-217-96-13.hsd1.co.comcast.net] has joined #bitcoin-core-dev
08:27 -!- zooko` [~user@50.141.117.77] has quit [Ping timeout: 246 seconds]
08:30 -!- earlest [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
08:31 -!- zooko``` [~user@c-73-217-16-2.hsd1.co.comcast.net] has joined #bitcoin-core-dev
08:32 -!- zooko`` [~user@c-73-217-96-13.hsd1.co.comcast.net] has quit [Ping timeout: 240 seconds]
08:33 -!- bysherper [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
08:33 < Chris_Stewart_5> arubi: Guessing it was just happen stance, I don't think there is any functional difference
08:37 < sipa> agree
08:39 -!- xiangfu [~xiangfu@119.90.18.65] has quit [Remote host closed the connection]
08:40 < arubi> doesn't seem like there is, just wanted to make sure.  thanks.
08:48 -!- abritoid [~abritoid@46.16.193.99] has quit [Ping timeout: 276 seconds]
08:54 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev
09:05 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
09:06 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 252 seconds]
09:06 -!- cryptapus_ [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
09:06 -!- cryptapus_ [~cryptapus@jupiter.osmus.org] has quit [Changing host]
09:06 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
09:06 -!- Samdney [~Samdney@dyn-ant666999.hawo.ipv6.uni-erlangen.de] has joined #bitcoin-core-dev
09:10 < GitHub173> [bitcoin] Christewart opened pull request #7941: Fixing comment in script_test.json test case (master...fix_script_test_comment) https://github.com/bitcoin/bitcoin/pull/7941
09:14 -!- zooko``` [~user@c-73-217-16-2.hsd1.co.comcast.net] has quit [Ping timeout: 268 seconds]
09:14 -!- cryptapus_ is now known as cryptapus
09:18 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev
09:22 -!- zooko [~user@c-73-217-16-2.hsd1.co.comcast.net] has joined #bitcoin-core-dev
09:29 -!- cryptocoder [~cryptocod@cpe-76-90-140-31.socal.res.rr.com] has quit [Quit: cryptocoder]
09:37 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 260 seconds]
09:38 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev
09:38 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
09:40 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
09:40 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #bitcoin-core-dev
10:09 -!- jtimon [~quassel@79.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds]
10:09 -!- bysherper [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
10:13 -!- earlest [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
10:19 -!- JackH [~Jack@79-73-185-113.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev
10:27 -!- zooko [~user@c-73-217-16-2.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds]
10:45 -!- earlest [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
10:48 -!- bysherper [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
10:54 -!- [\\\] [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
10:59 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
11:05 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 244 seconds]
11:06 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
11:07 -!- girino [~girino@vps1.girino.org] has joined #bitcoin-core-dev
11:10 -!- girino [~girino@vps1.girino.org] has left #bitcoin-core-dev ["Once you know what it is you want to be true, instinct is a very useful device for enabling you to know that it is"]
11:14 -!- bysherper [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
11:17 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
11:17 -!- earlest [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
11:19 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
11:21 -!- earlest [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
11:22 -!- cryptocoder [~cryptocod@cpe-76-90-140-31.socal.res.rr.com] has joined #bitcoin-core-dev
11:24 -!- bysherper [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
12:08 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
12:12 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]
12:35 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
12:36 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
12:41 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
12:44 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
12:44 -!- Guyver2_ is now known as Guyver2
12:47 -!- bysherper [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
12:50 -!- earlest [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
12:52 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-jauuklmdfarjmiwo] has quit [Remote host closed the connection]
12:53 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #bitcoin-core-dev
13:08 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-uzgrvgsiwgipcarf] has quit [Remote host closed the connection]
13:17 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev
13:17 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]
13:33 -!- earlest [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
13:36 -!- bysherper [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
13:47 -!- bysherper [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
13:50 -!- earlest [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
13:51 -!- xabbix__ [~xabbix@bzq-79-178-81-151.red.bezeqint.net] has quit [Ping timeout: 246 seconds]
13:51 -!- xabbix__ [~xabbix@bzq-79-178-11-33.red.bezeqint.net] has joined #bitcoin-core-dev
13:53 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
13:57 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has joined #bitcoin-core-dev
13:58 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer]
13:59 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
14:07 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev
14:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
14:10 < kanzure> how often should testnet nodes be receiving pings?
14:10 < kanzure> er, from a well-behaving peer node
14:11 -!- sipa [~pw@unaffiliated/sipa1024] has quit [Ping timeout: 250 seconds]
14:11 -!- sipa [~pw@2a02:348:86:3011::1] has joined #bitcoin-core-dev
14:11 -!- sipa is now known as Guest32930
14:18 -!- earlest [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
14:21 -!- bysherper [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
14:22 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving]
14:23 -!- bysherper [~denetrabu@96.93.57.150] has joined #bitcoin-core-dev
14:26 -!- earlest [~denetrabu@96.93.57.150] has quit [Ping timeout: 240 seconds]
14:35 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
14:38 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
14:38 -!- Guyver2_ is now known as Guyver2
14:49 -!- cryptapus_ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
14:50 -!- cryptapus is now known as cryptapus_afk
14:52 -!- JackH [~Jack@79-73-185-113.dynamic.dsl.as9105.com] has quit [Remote host closed the connection]
14:53 -!- cryptapus_ [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 246 seconds]
14:58 < Guest32930> kanzure: bitcoin core at most pings once per minute, i think
14:58 -!- Guest32930 is now known as sipa
14:58 < kanzure> have a strange peer doing it once a second.. they seem really eager to know if this node vanishes.
14:58 -!- sipa is now known as Guest98871
14:59 -!- Guest98871 is now known as sipa_
14:59 < sipa_> kanzure: what is the user agent?
15:00 < kanzure> /bitcoinj:0.15-SNAPSHOT/
15:00 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 240 seconds]
15:00 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]
15:01 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has quit [Read error: Connection reset by peer]
15:01 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
15:03 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 246 seconds]
15:03 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection]
15:04 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 246 seconds]
15:04 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
15:04 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host]
15:04 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
15:04 -!- Madars_ [~null@unaffiliated/madars] has quit [Ping timeout: 246 seconds]
15:05 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
15:05 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
15:06 < sipa_> kanzure: i think bitcoinj has always had insane ping frequency
15:06 < kanzure> weird.
15:06 < kanzure> thanks.
15:07 -!- hsmiths2 [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has quit [Read error: Connection reset by peer]
15:07 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has joined #bitcoin-core-dev
15:20 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:26 < achow101> what does the hex of the version for the upcoming soft fork look like?
15:27 -!- xabbix__ [~xabbix@bzq-79-178-11-33.red.bezeqint.net] has quit [Quit: Leaving]
15:27 < sipa_> 02000001
15:28 -!- sipa_ [~pw@2a02:348:86:3011::1] has quit [Changing host]
15:28 -!- sipa_ [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev
15:29 < achow101> thanks
15:46 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-bdjsuzcdfltiidak] has joined #bitcoin-core-dev
15:52 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
16:03 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kxnoxrntcdzxchfq] has joined #bitcoin-core-dev
16:04 -!- Samdney [~Samdney@dyn-ant666999.hawo.ipv6.uni-erlangen.de] has left #bitcoin-core-dev ["Verlassend"]
16:10 -!- belcher [~user@unaffiliated/belcher] has quit [Read error: Connection reset by peer]
16:21 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 250 seconds]
16:23 -!- jtimon [~quassel@79.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
16:24 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
16:29 -!- petertod1 is now known as petertodd
16:29 -!- petertodd is now known as Guest48555
16:56 -!- murch [~murch@p4FE3B6BC.dip0.t-ipconnect.de] has quit [Quit: Leaving.]
17:03 -!- Madars_ [~null@unaffiliated/madars] has joined #bitcoin-core-dev
17:06 -!- sipa_ is now known as sipa
17:13 -!- jtimon [~quassel@79.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]
17:31 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kxnoxrntcdzxchfq] has quit [Quit: Connection closed for inactivity]
18:01 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 250 seconds]
18:04 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
18:19 < GitHub160> [bitcoin] kazcw opened pull request #7942: lock cs_main for State/Misbehaving/chainActive (master...locking) https://github.com/bitcoin/bitcoin/pull/7942
18:42 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.]
18:58 < achow101> zmq notifications don't seem to be working in windows
18:59 -!- Greybits [~Greybits@unaffiliated/greybits] has quit [Remote host closed the connection]
19:28 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
19:29 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
19:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
19:37 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has quit [Read error: Connection reset by peer]
19:38 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has joined #bitcoin-core-dev
19:44 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer]
19:54 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 244 seconds]
19:58 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev
20:01 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]
20:05 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
20:06 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
20:21 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
20:21 -!- Squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
20:22 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
20:54 -!- NotAnNSAgent [~NotAnNSAg@gateway/vpn/privateinternetaccess/notannsagent] has quit [Quit: NotAnNSAgent]
20:57 < btcdrak> sipa: looks like a typo
21:01 < gmaxwell> kanzure: it's intentional incompetence in bitcoinj... it used to be worse, google up the bitcoin-dev logs for this lovely conversation
21:01 < gmaxwell> 09:04 < gmaxwell> BlueMatt: someone was saying in here that bitcoinj used a ping interval of 200ms the other day? is that so?
21:01 < gmaxwell> 09:05 < gmaxwell> (200ms * 124 peers = 620 pps = about 400kbit/sec before adding in whatever the ping itself takes)
21:02 < gmaxwell> 09:12 < TD> a ping every 200msec is not even going to stress a pocket calculator, but yeah, i'll see what's going on there
21:02 < gmaxwell> ...
21:02 < gmaxwell> 09:19 < TD> how about making the default 1 second. 44 bytes once a second is trivial compared to the cost of running a full node, even if you have a large number of peers.
21:03 < gmaxwell> 09:21 < gmaxwell> TD: Any reason it needs to be that fast? The network radius is many seconds now. I was thinking of conferring DOS when pings come faster than once per second, so actually sending at once per second would be right on the wire.
21:03 < gmaxwell> 09:24 < TD> because responsiveness matters, a ton. it's trying to figure out which of the peers it was able to find can shovel it the chain fastest, ie, is not overloaded
21:03 < gmaxwell> 09:25 < TD> pings are super cheap. if we go up to even a pathetic level of traffic like 5-6 transactions per second, invs will be far more expensive bandwidth and cpu wise
21:03 < gmaxwell> 09:30 < gmaxwell> TD: nothing on the network happens within a one second time frame. The time it takes to get a message across the network is multiple seconds. Any sane peer has multiple connections. 1 second is still on the order of (20+28+12+32)*8*125 = 92kbit/sec for a node with 125 peers.
21:03 < gmaxwell> 09:31 < gmaxwell> I do not think this is reasonable in the general case.
21:03 < gmaxwell> 09:32 < gmaxwell> esp unlike blocks and such, pings are not reduced by recieving one first from another peer.
21:04 < gmaxwell> 09:36 < gmaxwell> TD: it's also as much as we'll spend transmitting the blockchain on average when all our peers are full nodes.
21:04 < gmaxwell> 09:36 < gmaxwell> (or at least within a small factor of it)
21:05 < gmaxwell> yadda yadda.
21:18 < btcdrak> maybe andreas would be willing to dial that down a bit.
21:19 < luke-jr> wouldn't have a choice if we release code that bans misbehaving peers <.<
21:20 < luke-jr> but yeah, probably better to try the polite approach first
21:31 -!- cryptocoder [~cryptocod@cpe-76-90-140-31.socal.res.rr.com] has quit [Quit: cryptocoder]
21:33 < gmaxwell> I wrote code a while back that banned when it got a new ping less than a second after the last pong response, and it immediately banned all bitcoinj peers, which is what started that discussion.
21:34 < gmaxwell> even with bitcoinj backed off, and the banning backed off, it still had false positives due to nodes continuing to send pings when they hadn't had a response, resulting in a backlog... and so whenever the network burped a bunch of pings would come in a burst.
21:34 < gmaxwell> so I think banning can't be done unless we also specify that a peer shall not have multiple pings in flight.
21:42 -!- cryptocoder [~cryptocod@cpe-76-90-140-31.socal.res.rr.com] has joined #bitcoin-core-dev
21:42 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
21:43 < cfields> sipa: still around, by chance?
21:43 < gmaxwell> I hope not.
21:43 < cfields> heh, I never know what continent he's on
21:45 < cfields> the switch is flipped travis-side. I'm working on getting everything to turn green so that we can merge the Trusty change. Until then, things will be wonky. I might have to disable qt on a few builds, seems to take longer to build on Trusty. We can re-enable after some experimentation
21:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
21:46 < gmaxwell> \O/
21:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
21:55 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
21:59 -!- cjcj [2e3b026a@gateway/web/freenode/ip.46.59.2.106] has quit [Quit: Page closed]
22:18 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]
22:18 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
22:21 < sipa> cfields: \o/
22:21 -!- xiangfu [~xiangfu@124.205.70.162] has joined #bitcoin-core-dev
22:22  * gmaxwell looks at the clock
22:23  * luke-jr replaces gmaxwell's clock with a tonal one
22:24 < cfields> sipa: almost ready, maybe 1 more hour
22:26 < gmaxwell> luke-jr: your tonal time is useless to me since there is no such thing as tonal atomic time.
22:26 < luke-jr> :<
22:31 < cfields> luke-jr: btw, you might want to keep an eye on https://github.com/travis-ci/travis-build/pull/706, since you use a similar hack iirc
22:32 < cfields> (and ignore my stupid first comment, I didn't realize at first that the change is being made specifically for us :p)
22:34 < luke-jr> cfields: I don't suppose you know a way to get GCC to link to a library from a specific directory btw?
22:34 < luke-jr> without knowing the library filenames which vary by platform :/
22:35 < sipa> specify the .a directly as a source file?
22:36 < luke-jr> sipa: .so, except sometimes it's .dll, and sometimes it has a lib prefix and sometimes it has a -NNN suffix etc
22:37 < luke-jr> oh, and don't forget Cygwin where it's a "cyg" prefix :x
22:38 < cfields> luke-jr: ac_search_libs :(
22:38 < luke-jr> :x
22:38 < luke-jr> hmm
22:47 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #bitcoin-core-dev
22:49 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-otfvkmwvititjjxc] has joined #bitcoin-core-dev
22:52 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 244 seconds]
23:00 -!- dermoth [~thomas@dsl-66-36-157-105.mtl.aei.ca] has quit [Read error: Connection reset by peer]
23:01 -!- dermoth [~thomas@dsl-66-36-157-105.mtl.aei.ca] has joined #bitcoin-core-dev
23:05 < luke-jr> cfields: AC_SEARCH_LIBS doesn't seem to have a way to get the filename?
23:07 < cfields> luke-jr: no, not really. But using it with [foo foo-NNN etc] would get you part of the way there, since that will also take care of .so/.dll
23:09 < luke-jr> cfields: it won't tell me the .so/.dll, so not really
23:09  * luke-jr ponders
23:09 < cfields> luke-jr: you actually need the filename? Or you just need it to link against one of the possibilities?
23:09 -!- murch [~murch@p4FE39266.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
23:10 < luke-jr> cfields: well, I don't know how to get GCC to do it without the absolute filename
23:10 < luke-jr> problem is it's using -L/usr/local/lib for -lbase58, and the latter -L for libblkmaker is ignored because and older libblkmaker is in /usr/local/lib also
23:10 < luke-jr> I could reverse the order of the lib stuff, but then it'd have the problem in the opposite situation
23:11 < cfields> luke-jr: pkg-config ?
23:12 < luke-jr> cfields: this is with pkg-config
23:12 < luke-jr> -L/usr/local/lib -lbase58 from libbase58.pc, and -L/path/to/other/lib -lblkmaker from libblkmaker.pc
23:14 < cfields> luke-jr: doesn't libblkmaker depend on libbase58?
23:15 < luke-jr> cfields: yep
23:15 < luke-jr> both /usr/local/lib/libblkmaker and /path/to/other/lib/libblkmaker use /usr/local/lib/libbase58
23:16 < cfields> luke-jr: i'm missing something then. It seems like libbase58 should be private in the .pc's, and not added to the linker path since it's an indirect dep
23:17 < cfields> luke-jr: can you point me to what's linking them both in?
23:17 < luke-jr> cfields: BFGMiner also directly depends on both
23:18 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
23:20 < cfields> luke-jr: ah. Not sure what to tell you, then :\
23:21  * luke-jr would have thought libtool and pkg-config solved this by now :\
23:21 < cfields> luke-jr: well i'm pretty sure you don't actually need to link against libblkmaker, since the syms will be resolved recursively at runtime
23:22 < cfields> er sorry, link against libbase58
23:22 < luke-jr> 3hmm
23:23 < cfields> but i'm not sure if ld will whine about unresolved symbols, assuming you're handling visibility
23:27 < cfields> sipa: is it possible to reduce the secp256k1 test runs for 32bit? They take several minutes for travis
23:30 -!- cjcj [2e3b026a@gateway/web/freenode/ip.46.59.2.106] has joined #bitcoin-core-dev
23:30 < sipa> cfields: i think so
23:37 < cfields> sipa: ah, it takes a count arg :)
23:39 < gmaxwell> cfields: yes, though the count might not really get it low enough, due to imbalances.
23:43 < cfields> imbalances?
23:45 < sipa> gmaxwell: but there is also a really huge count of tests run
23:45 < sipa> cfields: is this for the secp repo, or the tests ran inside the bitcoind repo?
23:46 < cfields> sipa: in the bitcoin repo. They're pretty redundant, I should think
23:47 < sipa> at least there no huge number of different test combinations is tried
23:47 < gmaxwell> cfields: we should not disable tests, since differences in build configuration are meaningful, but their count could be cut down. 
23:48 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
23:49 < cfields> gmaxwell: we could make sure the bitcoin configs are covered in the downstream matrix, but yea, I suppose it's best to keep them running in case we get out of sync
23:49 < gmaxwell> cfields: it's not even the same code, so---- 
23:50 < cfields> gmaxwell: well i sure hope the code that's coming in via merge points has been tested at least once :)
23:50 < cfields> but sure, point taken
23:51 < sipa> gmaxwell: how do you mean it is not the same code?
23:52 < gmaxwell> sipa: I mean upstream moves ahead.
23:59 -!- abritoid [~abritoid@46.16.193.99] has joined #bitcoin-core-dev