--- Day changed Thu May 26 2016 00:10 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 00:13 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 00:13 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:24 -!- jtimon [~quassel@253.110.132.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 00:29 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 00:30 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 00:36 < jtimon> so, phantomcircuit, can we decide with respect to #8077 vs #7985 vs #7947 before deciding about #8087 vs #7310 (or whatever number my next attempt at a "moveonly + doc + trivial fixes" gets)? 00:37 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 00:41 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 264 seconds] 00:50 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 01:05 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 01:05 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:08 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 260 seconds] 01:10 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:16 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 01:29 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 01:32 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 01:41 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Ping timeout: 240 seconds] 01:55 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 01:56 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 01:56 -!- xiangfu [~xiangfu@58.135.95.136] has quit [Ping timeout: 264 seconds] 01:59 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 250 seconds] 01:59 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 02:00 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 02:04 -!- xiangfu [~xiangfu@58.135.95.136] has joined #bitcoin-core-dev 02:22 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 02:22 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 02:24 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 260 seconds] 02:31 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has joined #bitcoin-core-dev 02:36 -!- xiangfu [~xiangfu@58.135.95.136] has quit [Remote host closed the connection] 02:48 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 02:50 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 258 seconds] 02:52 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has quit [Quit: Leaving] 02:53 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has joined #bitcoin-core-dev 02:53 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has quit [Client Quit] 02:54 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has joined #bitcoin-core-dev 03:14 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 03:17 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 260 seconds] 03:24 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Ping timeout: 276 seconds] 03:31 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [] 03:35 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 03:38 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 03:40 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 03:43 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 244 seconds] 04:06 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 04:09 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 246 seconds] 04:25 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Ping timeout: 252 seconds] 04:25 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 04:29 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev 04:30 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has quit [Quit: Textual IRC Client: www.textualapp.com] 04:30 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-opvpdgejmklfzkpp] has quit [Read error: Connection reset by peer] 04:31 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-evjmxdnvhkukhkbm] has joined #bitcoin-core-dev 04:32 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 04:33 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 04:36 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 04:37 -!- jtimon [~quassel@253.110.132.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 04:44 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 04:44 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 04:49 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 252 seconds] 04:52 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 252 seconds] 04:53 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev 05:00 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 05:02 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 240 seconds] 05:03 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 05:04 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 05:05 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 05:08 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Ping timeout: 260 seconds] 05:10 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 05:10 -!- cryptapus_afk is now known as cryptapus 05:11 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 05:24 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 05:26 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 05:27 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 05:32 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:36 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:42 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 05:45 -!- C0SS1N [~wth@24-226-234-110.tr.cgocable.ca] has joined #bitcoin-core-dev 05:51 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 05:54 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 05:55 -!- BCBot [~BCBot@46.101.246.115] has joined #bitcoin-core-dev 06:02 < GitHub106> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6fc6325f77ee...c028c7b7557d 06:02 < GitHub106> bitcoin/master 581ddff Wladimir J. van der Laan: net: Add fRelayTxes flag... 06:02 < GitHub106> bitcoin/master 1ab1dc3 Wladimir J. van der Laan: rpc: Add `relaytxes` flag to `getnetworkinfo`... 06:02 < GitHub106> bitcoin/master c028c7b Pieter Wuille: Merge #8049: Expose information on whether transaction relay is enabled in `getnetwork`... 06:02 < GitHub121> [bitcoin] sipa closed pull request #8049: Expose information on whether transaction relay is enabled in `getnetwork` (master...2016_05_rpc_relaytxes) https://github.com/bitcoin/bitcoin/pull/8049 06:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 06:03 -!- ghounds [~gabriel@69.74.59.115] has joined #bitcoin-core-dev 06:04 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:07 -!- fuc [~fuc@190.112.223.117] has joined #bitcoin-core-dev 06:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 06:15 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 06:19 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 06:20 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 240 seconds] 06:20 -!- zooko [~user@2601:281:8000:8387:d0b5:5157:2fee:6215] has joined #bitcoin-core-dev 06:22 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 06:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:33 -!- C0SS1N [~wth@24-226-234-110.tr.cgocable.ca] has quit [] 06:37 -!- zooko [~user@2601:281:8000:8387:d0b5:5157:2fee:6215] has quit [Ping timeout: 260 seconds] 06:43 -!- ghounds [~gabriel@69.74.59.115] has quit [Ping timeout: 244 seconds] 06:46 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 06:49 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 06:53 -!- ghounds [~gabriel@69.74.59.115] has joined #bitcoin-core-dev 06:54 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:55 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 07:02 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 07:07 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 07:11 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 07:12 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 07:14 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 07:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 07:18 -!- robs [uid165609@gateway/web/irccloud.com/x-nrkkjrnzxbhalorv] has joined #bitcoin-core-dev 07:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:30 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev 07:36 < CodeShark> sipa: wumpus: We should disable mining by default on nonrelease branches as discussed earlier. I started working on this idea: https://github.com/CodeShark/bitcoin/commit/34ec9e8af22f40abdcc49c32e7e153a050613ee1 07:37 < CodeShark> the IsDevelopmentBranch() method should check whether it is a release branch or not rather than just whether it's the master branch 07:37 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 07:38 < CodeShark> is there a simple way we can determine this? 07:40 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 07:42 -!- sanada` [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [] 07:42 -!- sanada [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 07:43 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 07:43 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:48 -!- tom2 [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 07:48 -!- tom2 is now known as TomMc 07:52 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer] 07:54 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 07:59 -!- ghounds [~gabriel@69.74.59.115] has quit [Ping timeout: 252 seconds] 08:00 -!- ghounds [~gabriel@69.74.59.115] has joined #bitcoin-core-dev 08:02 < luke-jr> CodeShark: IMO mining is the least problematic use of dev branches.. 08:02 < luke-jr> miners are used to patching and overriding stuff anyway 08:03 < luke-jr> might make more sense to disable wallet and/or bloom 08:04 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 08:04 < CodeShark> luke-jr: the goal is to make it safer to merge consensus changes before releasing 08:04 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 08:04 < CodeShark> if the changes are merged into master they will get more tested 08:07 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 08:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 08:08 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 276 seconds] 08:11 -!- Amnez777 [~Amnez777@37.157.216.175] has quit [Ping timeout: 250 seconds] 08:23 -!- zooko [~user@c-24-9-79-61.hsd1.co.comcast.net] has joined #bitcoin-core-dev 08:25 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:30 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 08:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 08:34 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 08:35 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:39 < GitHub162> [bitcoin] CodeShark opened pull request #8101: Disable mining on nonrelease branches. (master...disable_mining_on_nonrelease_branches) https://github.com/bitcoin/bitcoin/pull/8101 08:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 08:52 < sipa> sdaftuar: what type is 'f' in the deserialize methods in mininode? 08:52 < sipa> or more specifically, can i test whether there are more bytes to read? 08:52 < sdaftuar> f? 08:52 < sdaftuar> oph 08:53 < sipa> i'm adding a test that fRelayTxes in version is correct (because it's currently broken in master, and no test detected it) 08:53 < sipa> but fRelayTxes is currently not deserialized 08:53 < sipa> and it's optional per bip37 08:53 < sdaftuar> ah ok 08:54 < sdaftuar> i assume it's possible to tell if there are more bytes to read but i don't know how off the top of my head. f is a BytesIO i think? 08:54 < sipa> i am going to guess it has a eof() method 08:57 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 08:59 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 09:01 < sdaftuar> doesn't seem to? docs i'm reading suggest you just call read() and see if you don't get anything back 09:01 < sipa> yup 09:09 -!- raedah [~x@172.58.41.91] has quit [Remote host closed the connection] 09:10 -!- raedah [~x@172.58.41.91] has joined #bitcoin-core-dev 09:10 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 09:14 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 09:16 -!- ghounds [~gabriel@69.74.59.115] has quit [Ping timeout: 264 seconds] 09:18 * sipa curses extensively at python 09:18 < btcdrak> sipa: it needs feeding. 09:23 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 09:24 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 09:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:26 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 09:31 -!- Amnez777 [~Amnez777@37.157.216.175] has joined #bitcoin-core-dev 09:35 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 09:40 -!- raedah [~x@172.58.41.91] has quit [Remote host closed the connection] 09:41 < CodeShark> sipa: throw a mouse at it 09:42 -!- raedah [~x@172.58.41.91] has joined #bitcoin-core-dev 09:43 < sipa> sdaftuar: so the bug is that a connecting node currently never sets fRelayTxes... and it seems we have not a single test for that 09:43 < sipa> sdaftuar: the p2p tests only connect a testnode to a real node, and not the other way around 09:44 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 09:47 < GitHub39> [bitcoin] sipa opened pull request #8102: Bugfix: use global ::fRelayTxes instead of CNode in version send (master...oopsrelay) https://github.com/bitcoin/bitcoin/pull/8102 09:49 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 09:49 < sipa> sdaftuar: is that possible, or am i missing an extra condition that makes this harder to test? 09:52 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 09:52 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 09:56 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 250 seconds] 09:59 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has joined #bitcoin-core-dev 10:08 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 10:10 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has quit [Quit: laurentmt] 10:11 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 10:11 -!- ghounds [~gabriel@69.74.59.115] has joined #bitcoin-core-dev 10:13 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:15 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 10:15 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 10:16 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 10:16 -!- ghounds [~gabriel@69.74.59.115] has quit [Ping timeout: 240 seconds] 10:19 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 10:21 < sdaftuar> sipa: you're right that in the testing framework, testnodes connect out to real nodes and not the other way around. 10:21 < sdaftuar> i'm taking a look at 8102 10:22 < btcdrak> sdaftuar: is the list of cfpf related pulls #7600, #7960 and #7292? am i missing any? 10:23 < sdaftuar> btcdrak: just #7600 and #7598. 7598 is a refactor of CreateNewBlock; 7600 builds off it 10:27 < sdaftuar> sipa: i'm baffled that this breakage wasn't caught in our existing RPC tests. surely anywhere we call sync_mempools() we would have seen a test failure? 10:29 < sipa> sdaftuar: perhaps there are more requirements before this triggers 10:30 < sipa> i saw this bug when syncing over thr internet... perhaps the rpc tests run fast enough 10:30 < sipa> it is related to responses to version messages 10:31 < wumpus> I'm not going to be able to attend the meeting today probably 10:32 -!- ghounds [~gabriel@69.74.59.115] has joined #bitcoin-core-dev 10:33 < sipa> wumpus: ok 10:35 -!- Cory [~C@unaffiliated/cory] has joined #bitcoin-core-dev 10:37 < sdaftuar> sipa: aha, we do have a travis issue. 10:38 < sdaftuar> check this out: https://travis-ci.org/bitcoin/bitcoin/jobs/129694378 10:38 < sdaftuar> looks like the tests hung, and then at some much later point the instance shut down(!) 10:38 < sdaftuar> and no failure was reported 10:40 < sipa> ugh 10:41 < sdaftuar> i've been meaning to fix up the sync_() functions in util.py to be more robust for a while now. we can do that at the least. 10:41 < sdaftuar> separately we should also figure out what's going on with travis here 10:42 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 10:44 < btcdrak> sipa: could you please restart the two error jobs on https://travis-ci.org/bitcoin/bitcoin/builds/133144138 10:45 < sipa> will do when i get home in 15 min 10:45 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 10:45 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 10:50 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Ping timeout: 272 seconds] 11:03 < sipa> btcdrak: won't work, master is broken 11:03 < btcdrak> oh 11:03 < sipa> merging 8102 now 11:03 < sdaftuar> sipa: 11:03 < sdaftuar> 8102, you default fRelayTxes to false in mininode 11:03 < sdaftuar> shouldn't that be true? 11:03 < sipa> sdaftuar: good point! 11:03 < sdaftuar> otherwise p2p tests that test receiving tx inv's would break 11:04 < sdaftuar> we might not have any though (yet) 11:04 < sipa> let me merge that without the mininode changes 11:04 < sdaftuar> ok sounds good 11:08 -!- gabridome [~gabridome@host220-49-dynamic.55-79-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 11:09 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has quit [Quit: Later.] 11:12 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 11:15 < GitHub132> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c028c7b7557d...425278d17bd0 11:15 < GitHub132> bitcoin/master 52b02ec Pieter Wuille: Use global ::fRelayTxes instead of CNode one 11:15 < GitHub132> bitcoin/master 425278d Pieter Wuille: Merge #8102: Bugfix: use global ::fRelayTxes instead of CNode in version send... 11:15 < GitHub160> [bitcoin] sipa closed pull request #8102: Bugfix: use global ::fRelayTxes instead of CNode in version send (master...oopsrelay) https://github.com/bitcoin/bitcoin/pull/8102 11:16 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 11:24 -!- gabridome1 [~gabridome@host220-49-dynamic.55-79-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 11:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 11:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:27 -!- ghounds [~gabriel@69.74.59.115] has quit [Ping timeout: 244 seconds] 11:30 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Ping timeout: 272 seconds] 11:31 -!- gabridome2 [~gabridome@5.90.75.79] has joined #bitcoin-core-dev 11:34 -!- gabridome2 [~gabridome@5.90.75.79] has quit [Read error: Connection reset by peer] 11:34 -!- gabridome1 [~gabridome@host220-49-dynamic.55-79-r.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 11:35 -!- gabridome1 [~gabridome@host220-49-dynamic.55-79-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 11:40 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 11:41 < GitHub124> [bitcoin] sdaftuar opened pull request #8104: Tests: add timeout to sync_blocks() and sync_mempools() (master...improve-rpc-sync) https://github.com/bitcoin/bitcoin/pull/8104 11:44 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 264 seconds] 11:44 -!- gabridome1 [~gabridome@host220-49-dynamic.55-79-r.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 11:45 -!- gabridome1 [~gabridome@host220-49-dynamic.55-79-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 11:49 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev 11:50 -!- cjcj [2e3b026a@gateway/web/freenode/ip.46.59.2.106] has joined #bitcoin-core-dev 11:51 -!- gabridome2 [~gabridome@5.90.75.79] has joined #bitcoin-core-dev 11:54 -!- gabridome1 [~gabridome@host220-49-dynamic.55-79-r.retail.telecomitalia.it] has quit [Ping timeout: 272 seconds] 12:00 < sipa> meetink? 12:02 < jonasschnelli> Yes. 12:03 < CodeShark> let's do it 12:03 < sipa> waiting for some more people 12:03 * btcdrak raises hand 12:03 < cfields_> here 12:04 < paveljanik> here 12:05 < cfields_> sipa: interestingly: on the net refactor branch I'm rebasing, it magically quit working after rebasing to (this morning's) master. after nabbing your fix, all is good now 12:05 < sdaftuar> here 12:05 < sipa> kanzure, sdaftuar, luke-jr, morcos, jl2012, gmaxwell, nickler, instagibbs, jtimon, petertodd: ping 12:05 < sipa> !beginmeeting 12:05 < gribble> Error: "beginmeeting" is not a valid command. 12:05 < sipa> !meetingbegin 12:05 < gribble> Error: "meetingbegin" is not a valid command. 12:05 < sipa> !meetingstart 12:05 < gribble> Error: "meetingstart" is not a valid command. 12:05 < sdaftuar> startmeeting i think? 12:06 < btcdrak> # startmeeting 12:06 < sipa> !startmeeting 12:06 < gribble> Error: "startmeeting" is not a valid command. 12:06 < btcdrak> without the space 12:06 < sipa> #startmeeting 12:06 < lightningbot> Meeting started Thu May 26 19:06:07 2016 UTC. The chair is sipa. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:06 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:06 < sipa> yay 12:06 < sipa> topics? 12:06 < kanzure> zurich transcript coming soon 12:06 < btcdrak> sipa was wardialing 12:06 -!- ghounds [~gabriel@69.74.59.115] has joined #bitcoin-core-dev 12:06 < btcdrak> kanzure: I can push it now if you like 12:06 < kanzure> we can copy-paste topics from zurich for follow-up 12:06 < kanzure> btcdrak: sure let's do that 12:07 < sipa> i have a topic: segwit vs netrefactor 12:07 < kanzure> i believe the conclusion from zurich was that sipa promised everyone tree sigs and poly sigs within 4 days 12:07 < btcdrak> kanzure: zurich meeting notes https://bitcoincore.org/logs/2016-05-zurich-meeting-notes.txt 12:08 < kanzure> ouch no anchor links. well, okay. 12:08 < kanzure> btw i heard from someone that they were surprised that libconsensus refactoring was considered lower priority than segwit 12:08 < kanzure> just some interesting feedback. 12:08 < btcdrak> kanzure: could be arranged. 12:08 < btcdrak> sipa: ack 12:09 < cfields_> sipa: sure. Though i suspect the (my, anyway) answer will be "segwit comes first, hands-down" 12:09 < sipa> cfields_: ok, settled :) 12:09 < sipa> kanzure: good feedback... i think it's mostly that segwit has much more buy-in as a roadmap (but i'm biased here) 12:09 < btcdrak> was that even a question. segwit first. 12:10 < cfields_> sipa: for sure. I'm working on it in parallel, but I have no desire to slow segwit down for it in any way 12:10 < kanzure> right, right. it's more of a long-term note--- but eventually we will have to bite the bullet and absorb the pain of the refactor impacting everyone's branches. 12:10 < CodeShark> libconsensus is strategically at least as important as segwit - but the coordination issues required are considerable 12:10 < wumpus> what do segwit and net refactor compete on? 12:10 < sipa> wumpus: code :) 12:10 < wumpus> which parts? does net refactor give you significantly more trouble rebasing? 12:10 < CodeShark> also, libconsensus isn't as glitsy :) 12:11 < sipa> probably not 12:11 < kanzure> what is the status of net refactor things? 12:11 < btcdrak> where does compact blocks fit in? 12:11 < sipa> libconsensus refactoring worked well in the 0.10 window, because it seemed there was a clear goal (getting script exposed) and a clear way to do it... further refactors seem to be more one-person shows (not that i blame those people, but if we want them to happen, i think we'll need to agree on a plan beforehand) 12:11 < wumpus> well I can understand how libconsensus conflicts with segwit 12:11 < kanzure> wasn't aware of previous concerns about libconsensus plan synchronization, good to know 12:12 < sipa> libconsensus conflicts with everything :) 12:12 < wumpus> there's also some network changes for segwit, but they're at a message level 12:12 < wumpus> whereas cfields' network refactor is at a lower level 12:12 < sipa> yeah, network refactor probably hurts compact blocks more than it hurts segwit 12:12 < cfields_> kanzure: see #8085. I addressed wumpus's notes from Zurich, but that made it rough to read. I'm working on another version of the same thing with a clean history, done by tomorrow for sure 12:12 < CodeShark> as much as it pains me to sacrifice on architecture, I think holding up segwit right now is much more costly in terms of the public's goodwill 12:13 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:13 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 12:13 < jcorgan> +1 12:13 < wumpus> I agree progress in the protocol is more important, I think segwit even affects the proposed libconsensus API 12:13 < sipa> worse, it affects the current libconsensus API :) 12:14 < sipa> ok, other topics? 12:14 < sipa> i have a few more 12:14 < sipa> CPFP will also need to go in at some point, and also conflicts with many in-flight things 12:15 < sipa> and a whole range of relay improvement 12:15 < wumpus> libconsensus feels more like some checkbox people want checked than something that will actually have a lot of users but feel free to prove me wrong 12:15 < sdaftuar> if we think segwit will be backported to 0.12, then probably CPFP should wait until afterward? 12:15 < wumpus> it should be done but unless someone has a clear example of an application using it and contributes to it it has not much priority 12:15 < sipa> when i talk about libconsensus i mean "abstracting out consensus logic"... not so much an actual API exposure 12:15 < sdaftuar> to avoid dealing with the CNB refactor in 0.12 12:16 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 12:16 < wumpus> sipa: that's what I mean right, I'm not sure other people talkinga bout it mean the same thing 12:16 < wumpus> at some point it becomes just a buzzword... :) 12:16 < sipa> maybe i should formulate the question this way: segwit, compact blocks, CPFP... all for 0.13? 12:16 < wumpus> that's a bit much 12:17 < wumpus> for just before the feature freeze 12:17 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 12:17 < sdaftuar> sipa: yes! 12:17 < wumpus> (2016-06-16) 12:18 < sipa> i would very much like to have at least compact blocks in before segwit, to alleviate the extra relay latency 12:18 < wumpus> I don't think we should make a habit of merging such big things just before a release 12:18 < sdaftuar> segwit is clearly the heaviest lift here to review... i think the otherw two things can be knocked out very quickly 12:18 < wumpus> segwit is obvious 12:19 < sdaftuar> but that's the thing where it's not clear to me if it'll be sufficiently reviewed by 6/16 12:19 < wumpus> yes that'st he thing what counts 12:19 < btcdrak> compact blocks would be good in 0.13 12:19 < wumpus> segwit should be merged soon so that we can do 0.12.1 before 0.13 12:20 < CodeShark> on that topic... 12:20 < sipa> we can merge segwit with no softfork defined for it on mainnet 12:20 < wumpus> we've already moved the release for 0.13 with a month so I'd really like to not move it again 12:20 < sdaftuar> sipa: interesting! i hadn't considered that 12:20 < CodeShark> sipa: indeed! 12:21 < CodeShark> and even once we do add the segwit softfork we can disable mining on it until release 12:21 < sipa> #idea merge segwit without defined softfork 12:21 < cfields_> hmm 12:22 < wumpus> sure 12:22 < sdaftuar> i guess the thing to worry about is if we have testing gaps, things might break without anyone noticing? 12:22 < wumpus> just to have the code in? 12:22 -!- gabridome2 [~gabridome@5.90.75.79] has quit [Ping timeout: 276 seconds] 12:22 < luke-jr> need vb gbt before segwit tho..? maybe not if left undefined, unsure 12:22 < sipa> luke-jr: yup 12:22 < sipa> luke-jr: will look at that 12:23 < wumpus> sdaftuar: well the tests need to cover it 12:23 < wumpus> if there's a testing gap it should not be merged in any case 12:23 < sipa> all the segwit tests use regtest 12:23 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer] 12:23 < wumpus> right 12:23 < wumpus> for that it doesn't matter whether a softfork is defined on mainnet 12:24 < sipa> indeed 12:24 < sipa> and for script/tx tests, the softfork is not relevant 12:24 < luke-jr> sipa: should I look into merging vbgbt w segwit? 12:24 < achow101> what benefit would there be to not define the softfork when mergin segwit 12:24 < sipa> achow101: segwit conflicts with a lot of code, having it in would simplify further development on the branch 12:24 < btcdrak> sipa: we should merge without mainnet, because it will allow people to test on testnet now (it's already been activated in testnet). 12:24 < wumpus> achow101: to have the code in, so that development happens on top 12:25 < wumpus> achow101: and so that people acn use it on the regtest/testnet network 12:25 < sipa> btcdrak: another good reason, indeed 12:25 < wumpus> btw: should we keep the segnet? 12:25 < sipa> no, i want to drop it 12:25 < btcdrak> wumpus: no segnet should go 12:25 < sipa> unless there is a good reason to keep it 12:25 < wumpus> ok 12:25 < wumpus> (no opinion either way just wondering whether that's supposed to end up in master) 12:26 < btcdrak> sipa: there's no need to drop it in merge to master right away imo, but certainly before we add parameters to mainnet. 12:26 < wumpus> yes as it has been triggered on testnet 12:26 < sipa> i will prioritize the testnet dns seed filtering, vb/gbt changes, and doing another batch 12:26 < kanzure> merging segwit without activation might lessen the pressure on reviewers 12:26 < kanzure> which might be a negative side effect 12:26 < sdaftuar> kanzure: agree 12:27 < wumpus> anyhow if the segnet network helps testing I don't have problems with temporarily having it in master, as long as it is clearly communicated that people shouldn't rely on it 12:27 < sipa> i wasn't planning on including it in master 12:28 < wumpus> well playing psychological meta-tricks on reviewers doesn't play much of a role imo, we should do whatever is practical 12:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 12:28 < wumpus> if merging segwit helps make progress on other fronts so that 0.13 can be a better release 12:28 < wumpus> we should do that 12:29 < wumpus> also having it merged in master usually means it gets more testing and review, not less 12:29 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 12:29 < sipa> i'll do one more batch, and if there are some ACKs then, i'll squash 12:29 < kanzure> so it would be active in testnet segnet and regtest when merged, but not mainnet, and letting others maintain segwit for other 0.13 changes? 12:29 < sipa> kanzure: don't understand the last part 12:30 < sipa> if there are changes necessary to the code post-merge but pre-release, they can just go in master 12:30 < kanzure> the ideal of merging soon is to let others maintain segwit for possibly conflicting 0.13 changes? 12:30 < wumpus> there's not *that* much time left for 0.13, it's good to decide now what we still want to have in and focus on that 12:30 < sipa> kanzure: to let others rebase their own patches on top 12:30 < wumpus> well not 'maintain segwit' but work on top, yes 12:30 < btcdrak> kanzure: the only difference is not having activation params on mainnet. it would really help by not holding up other work. 12:31 < sdaftuar> sipa: would you still plan to backport to 0.12? 12:31 < sipa> sdaftuar: yes, but after merge in master 12:31 < sipa> (but before defining activation) 12:31 < sdaftuar> ok 12:32 < sipa> ok, other topics? 12:32 < gmaxwell> The non-merged status of segwit has kinda been holding up other work, unfortunately. 12:32 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:32 < kanzure> maybe bip151 things? 12:33 < sipa> status bip151: waiting for implementation 12:33 < sipa> i'd say :) 12:33 < instagibbs> sdaftuar, is that list of testing gaps public somewhere? 12:33 < kanzure> ok 12:33 < instagibbs> (sorry, backtracking) 12:33 < kanzure> https://gist.github.com/sdaftuar/0469a2583f33989cf8196d2f26d99114 12:33 < sdaftuar> instagibbs: yes, now :) 12:34 < luke-jr> lol 12:34 < instagibbs> not really my meaning, but ok ;P 12:34 < petertodd> re: bip151, I mentioned it today at the conf I was at to some cryptographers, and their response to it not being an off the shelf standard was horror :) might be a pr issue 12:35 < sipa> petertodd: it's openssh's chacha20-poly1305 exactly 12:35 < kanzure> were they horrified about the current implementation at all 12:35 < petertodd> sipa: good, we should make that 110% clear then 12:35 < sipa> petertodd: maybe that needs to be made more clear 12:35 < gmaxwell> it's pretty clear in the BIP now, I thought. 12:35 < gmaxwell> maybe it could be moved up to the top. 12:36 < petertodd> gmaxwell: yeah, move it to the top - I just looked at it and didn't see that 12:36 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 12:36 < sipa> #action jonasschnelli make it more clean that bip151 uses openssh's chacha20-poly1305 standard 12:36 < btcdrak> ok make that an action point for the logs 12:36 -!- kxie [2f2168ed@gateway/web/freenode/ip.47.33.104.237] has joined #bitcoin-core-dev 12:36 < sipa> jinx 12:37 < petertodd> make it clear that the standard *describes* a subset of openssh's standard, and that bitcoin's use of it is identical and can reuse the existing code 12:37 < kanzure> pus or minus licensing issues? 12:37 < kanzure> *plus 12:38 < jonasschnelli> Ack. Will do 12:38 < petertodd> kanzure: https://github.com/openssh/openssh-portable/blob/05855bf2ce7d5cd0a6db18bc0b4214ed5ef7516d/LICENCE <- looks like BSD at least, no GPL code 12:38 < sipa> the actual cipher is public domain code 12:38 < sipa> the glue into openssh is BSD 12:39 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 12:40 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 12:41 < kanzure> petertodd: thanks for checking 12:42 < sipa> anything else? 12:42 < sipa> (mental note: type #topic next time) 12:42 < btcdrak> no just #topic 12:42 < kanzure> child-pays-for-parent? 12:43 < kanzure> and wasn't there something activating soon that we were looking at 12:43 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:43 < sdaftuar> happy to talk about CPFP, are there any questions? 12:43 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:43 < sipa> #topic child pay for parent 12:44 < sipa> i think the blocker is just the refactor for CNB 12:44 < sipa> which will conflict with segwit 12:44 < sdaftuar> right 12:45 < luke-jr> so maybe target 0.14 12:45 < luke-jr> ? 12:45 < sipa> at the latest, i'd say 12:45 < kanzure> oh i forgot about the testing infrastructure stuff for sdaftuar 12:45 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 12:45 < kanzure> sdaftuar: something i mentioned in person a few days ago, https://www.terraform.io/ 12:45 < sipa> but yes, it may miss 0.13 12:45 < sdaftuar> i will be sad if it is necessary to push it back that far 12:45 < sipa> me too 12:46 < sdaftuar> has anyone tried to test or review #7600? 12:47 < sipa> i started looking at it, but not in detail 12:47 < sdaftuar> alright, well no point in talking about blockers until it's been reviewed 12:48 < gmaxwell> I beleive I applied it to a node and started it. (but then switched out of it to test something else) It's on my list. 12:50 < sipa> other topics? 12:50 < CodeShark> sipa: your suggestion seems superior to 8101 :p 12:50 < CodeShark> at least for now 12:50 < CodeShark> I was going to bring that up...but perhaps we can defer that discussion 12:50 < luke-jr> sdaftuar: I'll be sad too: it's been waiting since like 0.4 :p 12:51 < sipa> luke-jr: well, feel free to help review/test 7600 already 12:51 < gmaxwell> I will be sad to not get CPFP in soon if that happens, especially considering all the work that it's taken to get it this far. 12:52 < sipa> so i would encourage people to review 12:52 < sipa> #endmeeting 12:52 < lightningbot> Meeting ended Thu May 26 19:52:53 2016 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:52 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2016/bitcoin-core-dev.2016-05-26-19.06.html 12:52 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2016/bitcoin-core-dev.2016-05-26-19.06.txt 12:52 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2016/bitcoin-core-dev.2016-05-26-19.06.log.html 12:52 < gmaxwell> [OT] There appears to be an emergent effort to flood reddit with recursive posts about BIP 151: http://imgur.com/xId5scH 12:53 < luke-jr> bbiab 12:53 < petertodd> gmaxwell: you guys suck at mixnets 12:54 < gmaxwell> adam's post is the best so far https://www.reddit.com/r/Bitcoin/comments/4l74p5/jameson_lopp_lukejr_gregory_maxwell_eragmus/ 12:54 < btcdrak> LMAO 12:57 < sipa> i for one welcome the new recursively compressing overlords 12:57 < sipa> s/compressing/encrypting/ 12:58 < petertodd> I for one welcome sipa's welcoming nature 12:58 < btcdrak> +1 12:59 < petertodd> C-C-C-C-C-C-C-Combo Breaker! 13:08 -!- zooko [~user@c-24-9-79-61.hsd1.co.comcast.net] has quit [Ping timeout: 240 seconds] 13:12 < gmaxwell> sipa: why didn't warnings save us from the global aliasing bug you fixed today? 13:14 < sipa> gmaxwell: #8105 13:14 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 13:14 < sipa> and travis didn't warn because of #8103 13:15 < gmaxwell> LOL 13:16 < sipa> "oh, machine shutdown 13:16 < sipa> "oh, machine shutdown... ALL TESTS PASS" 13:16 < gmaxwell> Perhaps we need to make sure all commiters have access to super fast machines, and make running the full tests part of the merge script? 13:16 < gmaxwell> sipa: "No failures detected." 13:16 < cfields_> hmm, we've seen that before. thought it was fixed on their end. 13:16 < cfields_> checking 13:17 < sipa> fair enough, that's a subtle but relevant distinction 13:17 < cfields_> one thing we could do is add the rpc-tests to 'make check' 13:18 < cfields_> especially once the java blocktester is replaced in python, that'll make it so that travis would basically just be running 'make check', same as what everyone could do manually 13:18 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 13:19 < sipa> cfields_: ack 13:19 < cfields_> sdaftuar: how's that replacement coming, btw? 13:19 < sipa> together with parallel checking, it's even not that painful anymore 13:21 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 13:22 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 13:23 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 13:28 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 13:30 -!- mkarrer [~mkarrer@224.red-83-50-56.dynamicip.rima-tde.net] has quit [] 13:33 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 260 seconds] 13:34 -!- VonBlume [~re@62.43.180.137.dyn.user.ono.com] has joined #bitcoin-core-dev 13:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:48 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: WeeChat 0.4.3] 13:52 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 13:56 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 13:57 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 13:58 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Client Quit] 14:00 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 14:01 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Client Quit] 14:02 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 14:05 -!- VonBlume [~re@62.43.180.137.dyn.user.ono.com] has quit [Quit: Konversation terminated!] 14:13 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 14:14 -!- ghounds [~gabriel@69.74.59.115] has quit [Ping timeout: 264 seconds] 14:16 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds] 14:20 -!- ghounds [~gabriel@69.74.59.115] has joined #bitcoin-core-dev 14:22 -!- spudowiar is now known as saleemrashid 14:22 -!- saleemrashid is now known as spudowiar 14:39 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: WeeChat 0.4.3] 14:41 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 14:46 -!- ghounds [~gabriel@69.74.59.115] has quit [Ping timeout: 258 seconds] 14:58 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 258 seconds] 15:04 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 15:06 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 15:16 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 15:16 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 15:18 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 15:21 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 272 seconds] 15:36 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 15:39 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 15:40 -!- cryptapus is now known as cryptapus_afk 15:49 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 15:55 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 16:17 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 16:21 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 16:55 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Quit: ChatZilla 0.9.92 [Firefox 46.0.1/20160502172042]] 16:58 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 17:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-evjmxdnvhkukhkbm] has quit [Quit: Connection closed for inactivity] 17:01 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 17:02 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 17:04 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 17:09 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 276 seconds] 17:17 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 17:22 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 17:23 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Ping timeout: 258 seconds] 17:49 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 18:16 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 18:19 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 18:53 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 18:57 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 244 seconds] 19:41 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 19:45 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 19:46 < GitHub117> [bitcoin] yurizhykin opened pull request #8107: bench: Added base58 encoding/decoding benchmarks (master...benchmarks) https://github.com/bitcoin/bitcoin/pull/8107 19:47 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Quit: Leaving] 19:57 -!- dermoth__ [~thomas@dsl-216-221-55-197.mtl.contact.net] has joined #bitcoin-core-dev 20:00 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has quit [Ping timeout: 240 seconds] 20:01 -!- dermoth_ [~thomas@dsl-216-221-51-30.mtl.aei.ca] has quit [Ping timeout: 272 seconds] 20:03 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 20:06 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.] 20:07 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 20:12 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 20:41 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 20:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 20:46 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 260 seconds] 20:59 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 21:03 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 21:06 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has joined #bitcoin-core-dev 21:44 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 21:52 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 21:55 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 22:17 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 22:20 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 22:29 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 22:33 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 258 seconds] 22:34 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 22:37 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 22:39 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 22:41 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 22:42 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 22:43 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 22:45 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 22:50 < GitHub166> [bitcoin] paveljanik opened pull request #8108: Trivial: Remove unused local variable shadowing upper local (master...20160527_trivial_sighash_tests) https://github.com/bitcoin/bitcoin/pull/8108 23:04 < GitHub57> [bitcoin] paveljanik opened pull request #8109: Do not shadow member variables (master...20160527_shadow_httpserver) https://github.com/bitcoin/bitcoin/pull/8109 23:05 -!- MrHodl [~fuc@190.112.223.117] has joined #bitcoin-core-dev 23:05 -!- fuc [~fuc@190.112.223.117] has quit [Read error: Connection reset by peer] 23:09 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 23:12 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 23:13 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 23:22 < GitHub90> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/425278d17bd0...06bd4f637f15 23:22 < GitHub90> bitcoin/master fa57b0c MarcoFalke: [qa] test_framework: Append portseed to tmpdir... 23:22 < GitHub90> bitcoin/master 06bd4f6 MarcoFalke: Merge #8098: [qa] test_framework: Append portseed to tmpdir... 23:22 < GitHub20> [bitcoin] MarcoFalke closed pull request #8098: [qa] test_framework: Append portseed to tmpdir (master...Mf1605-qatmpdir) https://github.com/bitcoin/bitcoin/pull/8098 23:37 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 23:40 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Ping timeout: 252 seconds] 23:49 < GitHub193> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/06bd4f637f15...a80de1511316 23:49 < GitHub193> bitcoin/master 13c4558 Pavel Janík: Remove unused local variable shadowing upper local 23:49 < GitHub193> bitcoin/master a80de15 MarcoFalke: Merge #8108: Trivial: Remove unused local variable shadowing upper local... 23:49 < GitHub95> [bitcoin] MarcoFalke closed pull request #8108: Trivial: Remove unused local variable shadowing upper local (master...20160527_trivial_sighash_tests) https://github.com/bitcoin/bitcoin/pull/8108 23:50 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev