--- Day changed Tue Jun 07 2016
00:31 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
00:31 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
00:31 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
00:31 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
00:34 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
00:34 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
00:35 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
00:36 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
00:37 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
00:37 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
00:45 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
00:45 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
00:48 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
00:49 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
00:54 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
00:55 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
00:56 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Ping timeout: 272 seconds]
00:57 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev
00:57 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
01:04 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev
01:04 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev
01:07 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
01:08 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds]
01:08 -!- adiabat [~adiabat@159.203.193.74] has quit [Quit: Leaving.]
01:10 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Ping timeout: 250 seconds]
01:11 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
01:12 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
01:34 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 244 seconds]
01:36 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
01:44 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
01:53 -!- PatBoy [xyz@192.99.249.215] has quit [Ping timeout: 276 seconds]
01:54 -!- PatBoy [xyz@192.99.249.215] has joined #bitcoin-core-dev
02:18 < GitHub147> [bitcoin] jpdffonseca opened pull request #8158: Simplify calls to retrieve credit and balance (master...enhancement/unification-wallet-balance) https://github.com/bitcoin/bitcoin/pull/8158
02:45 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
02:48 < MarcoFalke> jonasschnelli: VNULL is already a valid type
02:48 < MarcoFalke> Let's not change its meaning to VANY just for checkObj
02:49 < MarcoFalke> I could change it to a cpp union but it will still be a wrapper, I assume
02:49 < jonasschnelli> MarcoFalke: yes. Fair enought...
02:50 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Ping timeout: 258 seconds]
03:00 -!- ozanyurt [~ozanyurt@78.185.248.35] has quit [Read error: Connection reset by peer]
03:00 -!- ozanyurt_ [~ozanyurt@78.185.248.35] has joined #bitcoin-core-dev
03:02 -!- molz [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]
03:02 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
03:09 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has joined #bitcoin-core-dev
03:10 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
03:13 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
03:15 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
03:16 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
03:17 -!- G1lius [~stefangil@109.201.143.91] has joined #bitcoin-core-dev
03:22 -!- Amnez777 [~Amnez777@37.157.216.151] has quit [Ping timeout: 260 seconds]
03:26 -!- Amnez777 [~Amnez777@37.157.216.151] has joined #bitcoin-core-dev
03:29 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
03:46 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
03:52 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Ping timeout: 250 seconds]
04:19 -!- Samdney [~Samdney@nat-wlan2.rrze.uni-erlangen.de] has joined #bitcoin-core-dev
04:20 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds]
04:24 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has quit [Quit: Textual IRC Client: www.textualapp.com]
04:37 -!- molly is now known as moli
04:38 -!- cryptapus [~cyptapus@87.254.202.254] has joined #bitcoin-core-dev
04:38 -!- cryptapus [~cyptapus@87.254.202.254] has quit [Changing host]
04:38 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
04:48 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
04:52 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Ping timeout: 244 seconds]
04:55 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has joined #bitcoin-core-dev
05:35 < GitHub9> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cfc6da0b1b81...9b6a48c2e996
05:35 < GitHub9> bitcoin/master bd0f413 Jonas Nick: Reduce unnecessary hashing in signrawtransaction
05:35 < GitHub9> bitcoin/master 9b6a48c Wladimir J. van der Laan: Merge #8118: Reduce unnecessary hashing in signrawtransaction...
05:35 < GitHub145> [bitcoin] laanwj closed pull request #8118: Reduce unnecessary hashing in signrawtransaction (master...faster-signraw) https://github.com/bitcoin/bitcoin/pull/8118
05:49 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
05:53 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Ping timeout: 264 seconds]
06:05 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
06:06 -!- Samdney [~Samdney@nat-wlan2.rrze.uni-erlangen.de] has left #bitcoin-core-dev ["Verlassend"]
06:07 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
06:26 < GitHub75> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b6a48c2e996...22e0b3567623
06:26 < GitHub75> bitcoin/master 8b78486 Jonas Schnelli: Log/report in 10% steps during VerifyDB
06:26 < GitHub75> bitcoin/master 22e0b35 Wladimir J. van der Laan: Merge #8136: Log/report in 10% steps during VerifyDB...
06:26 < GitHub153> [bitcoin] laanwj closed pull request #8136: Log/report in 10% steps during VerifyDB (master...2016/06/init_checkblocks) https://github.com/bitcoin/bitcoin/pull/8136
06:27 -!- grassass [grass@gateway/vpn/mullvad/x-qtcodeaifkizgjlp] has quit [Ping timeout: 260 seconds]
06:31 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
06:40 < GitHub104> [bitcoin] jmcorgan reopened pull request #8148: Backport leveldb build integration to 0.12 (0.12...0.12) https://github.com/bitcoin/bitcoin/pull/8148
06:40 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:42 -!- grassass [~grass@2605:e000:2414:200:ea03:9aff:fe81:c55a] has joined #bitcoin-core-dev
06:50 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
06:50 < GitHub146> [bitcoin] iblis17 opened pull request #8159: PR demo (master...iblis-demo) https://github.com/bitcoin/bitcoin/pull/8159
06:50 < GitHub50> [bitcoin] iblis17 closed pull request #8159: PR demo (master...iblis-demo) https://github.com/bitcoin/bitcoin/pull/8159
06:53 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:55 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Ping timeout: 272 seconds]
06:57 < sipa> wumpus: what do you think about including arm-linux-gnueabihf binaries in the distribution?
06:59 < wumpus> sipa: yes we should definitely have ARMHF and ARM64 binary tarballs
07:00 < wumpus> there was a pull doing this, but it was closed at some point (because it was the wrong way to do it) and no one picked it up
07:01 < wumpus> hm I can't find it, may have been confused with something else, in any case it'd be welcome
07:03 < wumpus> ah https://github.com/bitcoin/bitcoin/pull/7659
07:21 < wumpus> created an issue for ithttps://github.com/bitcoin/bitcoin/issues/8162
07:29 -!- zooko [~user@209.49.240.226] has joined #bitcoin-core-dev
07:31 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev
07:32 < jonasschnelli> wumpus: mind taking a look at https://github.com/bitcoin/bitcoin/pull/7957? Would be nice to have this merged. Simplifies RBF testing. :)
07:39 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection]
07:40 < wumpus> sure
07:44 -!- zooko [~user@209.49.240.226] has quit [Ping timeout: 244 seconds]
07:45 < wumpus> jonasschnelli: should there be a test in src/test/data/bitcoin-util-test.json for the new -tx behavior?
07:45 < jonasschnelli> wumpus: wasn't aware of a test script bit bitcoin-tx... i'll have a look
07:46 < wumpus> yes not many people realize that :) it gets executed with `make test`
07:46 < wumpus> eh make check
07:46 < wumpus> by bitcoin-util-test.py
07:46 < sipa> but only make check in the root, not make check in src/
07:50 < sipa> i'd like to see some review on #8084 and #8065
07:50 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
07:50 < sipa> #8065 should be easy to test by monitoring fails added to addrman, and disconnecting your network cable
07:50 -!- zooko [~user@209.49.240.226] has joined #bitcoin-core-dev
07:55 -!- raedah [~x@172.58.41.91] has quit [Remote host closed the connection]
07:55 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Ping timeout: 260 seconds]
07:57 -!- raedah [~x@172.58.41.91] has joined #bitcoin-core-dev
08:03 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 258 seconds]
08:06 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
08:07 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
08:11 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
08:16 -!- zooko [~user@209.49.240.226] has quit [Ping timeout: 260 seconds]
08:18 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
08:18 -!- G1lius [~stefangil@109.201.143.91] has quit [Ping timeout: 276 seconds]
08:30 -!- ozanyurt_ [~ozanyurt@78.185.248.35] has quit [Read error: Connection reset by peer]
08:30 -!- ozanyurt [~ozanyurt@78.185.248.35] has joined #bitcoin-core-dev
08:33 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
08:35 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
08:40 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds]
08:40 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
08:44 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Ping timeout: 250 seconds]
08:48 -!- Guest26338 [~mcelrath@38.121.165.30] has quit [Ping timeout: 276 seconds]
08:55 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
08:58 < jonasschnelli> sipa: was the seeder flag check correct (if (id >= 0 && (idToInfo[id].services & requestedFlags) == requestedFlags) {)?
08:58 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
08:58 < jonasschnelli> https://github.com/sipa/bitcoin-seeder/pull/36#discussion_r65778140
08:58 < jonasschnelli> haven't double checked
08:59 < sipa> jonasschnelli: no, i don't understand why it can be correct
08:59 < sipa> i'm fixing it now
09:00 < sipa> (but maybe i'm missing something)
09:00 < sipa> so feel free to explain why you think it is
09:00 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Ping timeout: 260 seconds]
09:04 < paveljanik> jonasschnelli, wumpus: in src/rpc, we shadow global tableRPC by the same-named argument to all Register*RPCCommands(CRPCTable &table). Before changing all names (by adding underscore), do we really want to pass the global in and then shadow it by the same named argument? What about removing the argument instead?
09:04 < sipa> how about renaming the global? :)
09:05 < paveljanik> there are millions of use of it outside the register part...
09:06 < sipa> well, in an ideal world there would not be a global (or at least not one that's commonly used)
09:06 < jonasschnelli> sipa: right. It should be the same like this line: https://github.com/sipa/bitcoin-seeder/pull/36/files#diff-623e3fd6da1a45222eeec71496747b31R185
09:07 < jonasschnelli> Tell me if you want me to PR
09:07 < sipa> i'll do it
09:07 < jonasschnelli> thanks!
09:09 < paveljanik> sipa, I prefer to rename argument names
09:09 < sipa> paveljanik: ok
09:09 < paveljanik> to e.g. t ;-)
09:09 < paveljanik> to save a lot of bytes ;-)
09:12 < sipa> paveljanik: an alternative is making the tableRPC global static (and not exposed from rpc/server.cpp), and instead add a function that just calls tableRPC.appendCommand
09:12 < sipa> it's not shadowing if the global isn't visible
09:13 < paveljanik> this can't work: qt/rpcconsole.cpp:        UniValue result = tableRPC.execute(
09:14 < sipa> ok, a wrapper for that too :)
09:14 < paveljanik> and now clang-fu it ;-)
09:16 < wumpus> sipa: well the idea is to make it possible to have multiple rpc tables
09:17 < wumpus> sipa: that's why tablerpc is an argument to Register* in the first place
09:17 < paveljanik> yes
09:17 < wumpus> this makes it possible to have multiple RPC entry points, at some point
09:17 < jonasschnelli> Yes. The idea of the register is to avoid a superglobal dispatch table.
09:17 < wumpus> probably it shouldn't be a global though
09:17 < wumpus> agree with that
09:18 < wumpus> but please don't hardcode tablerpc
09:18 < jonasschnelli> The table itself should be a rpc-server object.
09:18 < jonasschnelli> Modules should "register" callbacks.
09:18 < paveljanik> I'm most inclned to rename arguments to t...
09:19 < wumpus> in any case, let's not entangle this with the refactor to remove shadowing
09:19 < sipa> paveljanik: whatever is easiest
09:19 < sipa> indeed, they're orthogonal improvements
09:20 -!- adiabat [~adiabat@159.203.193.74] has joined #bitcoin-core-dev
09:20 < paveljanik> sure
09:20 < paveljanik> will do
09:20 < paveljanik> this as one PR.
09:21 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev
09:25 < GitHub19> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/22e0b3567623...79004d4ae671
09:25 < GitHub19> bitcoin/master a946bb6 Jonas Schnelli: [RPC] createrawtransaction: add option to set the sequence number per input
09:25 < GitHub19> bitcoin/master e59336f Jonas Schnelli: [bitcoin-tx] allow to set nSequence number over the in= command
09:25 < GitHub19> bitcoin/master ae357d5 Jonas Schnelli: [Bitcoin-Tx] Add tests for sequence number support
09:25 < GitHub140> [bitcoin] laanwj closed pull request #7957: [RPC][Bitcoin-TX] Add support for sequence number (master...2016/04/rbf_base) https://github.com/bitcoin/bitcoin/pull/7957
09:26 -!- zooko [~user@208.70.31.231] has joined #bitcoin-core-dev
09:27 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev
09:40 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev
09:41 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
09:46 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Ping timeout: 244 seconds]
09:52 < GitHub110> [bitcoin] paveljanik opened pull request #8163: Do not shadow global RPC table variable (tableRPC) (master...20160607_shadowing_rpc) https://github.com/bitcoin/bitcoin/pull/8163
09:54 < sipa> jonasschnelli: https://github.com/sipa/bitcoin-seeder/pull/40/files
09:55 < jonasschnelli> sipa: should we not provide a default whitelist?
09:55 < sipa> jonasschnelli: there is one
09:55 < jonasschnelli> Ah.. right
09:55 < sipa> line 148
09:55 < jonasschnelli> 1,5,9,13... hmm..
09:56 < sipa> also, servicebits were already printed in dnsseed.dump
09:56 < jonasschnelli> You don't want to add NODE_GETUTXO to the WL?
09:56 < sipa> no
09:57 < jonasschnelli> Okay. Right. Not by default.
09:57 < sipa> you can enable it if you need it
09:58 < jonasschnelli> ack
10:00 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Ping timeout: 252 seconds]
10:06 -!- zooko [~user@208.70.31.231] has quit [Ping timeout: 260 seconds]
10:07 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 244 seconds]
10:09 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has joined #bitcoin-core-dev
10:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
10:19 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev
10:21 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev
10:22 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
10:31 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds]
10:34 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
10:35 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has quit [Quit: laurentmt]
10:37 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
10:39 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
10:40 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
10:42 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
10:43 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
10:43 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
10:44 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
10:48 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Ping timeout: 264 seconds]
10:53 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
10:56 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
11:02 < GitHub40> [bitcoin] jonasschnelli opened pull request #8164: [Tests] fix missing test fixtures in Makefile.test.include (master...2016/04/rbf_base) https://github.com/bitcoin/bitcoin/pull/8164
11:02 < jonasschnelli> Travis is currently failing.
11:02 < jonasschnelli> Was my fault... sorry.
11:02 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/8164 should fix it.
11:11 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds]
11:13 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
11:18 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 244 seconds]
11:20 -!- cryptapus [~cyptapus@87.254.202.254] has joined #bitcoin-core-dev
11:20 -!- cryptapus [~cyptapus@87.254.202.254] has quit [Changing host]
11:20 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
11:22 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
11:24 -!- cryptapus_ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
11:25 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 252 seconds]
11:27 -!- cryptapus__ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
11:31 -!- cryptapus_ [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 264 seconds]
11:32 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
11:32 -!- cryptapus__ is now known as cryptapus
11:48 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
11:51 < jonasschnelli> Hmm.. is this not 32bit save? uint32_t nSequenceIn=std::numeric_limits<unsigned int>::max();
11:52 < jonasschnelli> https://travis-ci.org/bitcoin/bitcoin/jobs/135941357#L1909
11:52 < jonasschnelli> (seems to fail on travis 32bit)
11:52  * jonasschnelli is booting up 32bit linux
11:55 < jonasschnelli> Ah.. i'm using atoi() for uint32_t,... not good.
11:55 < sipa> on all our supported platforms int is 32 bit
11:57 < jonasschnelli> sipa: Yes. But I guess atoi() throws away the unsigned? Does always use signed int IMO.
11:58 < jonasschnelli> Trying now with std::stoul() 
12:02 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 240 seconds]
12:05 -!- Danco_ [Dan_@gateway/shell/elitebnc/x-tkdlxuodkyhztyne] has joined #bitcoin-core-dev
12:05 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev
12:05 < Danco_> Hello may i make a GPU question here?
12:06 < jonasschnelli> Danco_: depends if its bitcoin-core-dev relevant... but shoot!
12:06 < Danco_>  Hello, i have a hardware  question about my GPU capacita, I have an AMD 4870x2, and i want to know how many Mhash/s could i make with it. I found in this link: https://en.bitcoin.it/wiki/Non-specialized_hardware_comparison its  between 180.6 and 203 Mhash... But i'm not quite sure,  But in this link : https://litecoin.info/Mining_hardware_comparison#AMD_.28ATI.29 its just 142kH/s, so i'm pretty confused.
12:06 < Danco_> There it is
12:06 < jonasschnelli> I guess the only way is by trying it yourself. :)
12:06 < jonasschnelli> But GPU mining is history? right?
12:07 < jonasschnelli> (at least on the bitcoin blockchain)
12:07 < Danco_> For Litecoin is still useful.
12:08 < btcdrak> Danco_: it's probably a question for #bitcoin-dev or #bitcoin. this channel is specifically for Bitcoin Core development.
12:08 < Danco_> Ok ok i'll make it there :D thanks.
12:08 -!- Danco_ [Dan_@gateway/shell/elitebnc/x-tkdlxuodkyhztyne] has left #bitcoin-core-dev ["Chao."]
12:20 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
12:21 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving]
12:25 < GitHub70> [bitcoin] paveljanik opened pull request #8166: src/test: Do not shadow local variables (master...20160607_shadowing_tests) https://github.com/bitcoin/bitcoin/pull/8166
12:25 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
12:26 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
12:31 -!- adiabat [~adiabat@159.203.193.74] has quit [Remote host closed the connection]
12:32 -!- adiabat [~adiabat@159.203.193.74] has joined #bitcoin-core-dev
12:36 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
12:42 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
12:59 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
13:02 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
13:02 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
13:14 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
13:14 -!- molz [~molly@unaffiliated/molly] has quit [Quit: Leaving]
13:17 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 276 seconds]
13:20 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
13:25 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit []
13:39 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has quit [Ping timeout: 244 seconds]
13:39 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
13:41 -!- raedah [~x@172.58.41.91] has quit [Ping timeout: 276 seconds]
13:43 -!- raedah [~x@172.58.41.91] has joined #bitcoin-core-dev
13:47 < jonasschnelli> cfields_: https://github.com/bitcoin/bitcoin/pull/8164/files/86efa30ae3fd36aa77b19ff0f70bb89be9ec308e#r66149475
13:48 < jonasschnelli> Why use strtoll instead of std::stoul?
13:48 -!- zooko [~user@208.70.31.231] has joined #bitcoin-core-dev
13:49 < cfields_> jonasschnelli: typo. stoll would work, i was just making the point that i think it needs to be a long long to be completely safe
13:50 < sipa> oh, i didn't know about stoll!
13:51 < cfields_> jonasschnelli: feel free to ignore, I'm not familiar enough there to know if it's necessary to be paranoid there.
13:51 < cfields_> - a "there"
13:51 < jonasschnelli> cfields_: yeah. Me too. :)
13:52 < cfields_> sipa: c++11's full of surprises :)
13:52 < jonasschnelli> But I guess there are other placed in bitcoin-tx where we do not check for overflows (like vout, etc.)
13:52 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has joined #bitcoin-core-dev
13:52 < jonasschnelli> Travis is currently failing on master.
13:52 < jonasschnelli> So a quick review and merge of https://github.com/bitcoin/bitcoin/pull/8164 would be great.
13:52 < cfields_> jonasschnelli: right, probably low on the list of real concerns
13:54 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
13:54 -!- raedah [~x@172.58.41.91] has quit [Remote host closed the connection]
13:55 < cfields_> jonasschnelli: sec, i'm looking up the actual failure. I'd hate mask real bugs there.
13:55 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
13:55 -!- raedah [~x@172.58.41.91] has joined #bitcoin-core-dev
14:01 -!- raedah [~x@172.58.41.91] has quit [Ping timeout: 264 seconds]
14:04 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
14:16 < cfields_> jonasschnelli: ok, just tested. It's pretty easy to screw that up, especially if you're typing a seq by hand and add one too many digits. Silently inserting the wrong value is pretty nasty.
14:16 < cfields_> jonasschnelli: http://pastebin.com/raw/Yz18syyR
14:24 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
14:27 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
14:27 -!- raedah [~x@172.58.41.91] has joined #bitcoin-core-dev
14:34 -!- zooko [~user@208.70.31.231] has quit [Ping timeout: 264 seconds]
14:43 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
15:12 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit []
15:23 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
15:25 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection]
15:26 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
15:52 -!- blur3d [~blur3d@49.187.26.218] has joined #bitcoin-core-dev
16:37 < sipa> luke-jr: good thing BIP8 was never assigned https://en.wikipedia.org/wiki/BIP-8 (image what would happen if something related to error correction or checksums got that...)
17:00 < gmaxwell> Funny that.
17:00  * gmaxwell checks to see if he created that article. no, surprising!
17:03  * luke-jr assigns it to sipa's next proposal. jk
17:45 -!- hoihut [4208d74c@gateway/web/freenode/ip.66.8.215.76] has joined #bitcoin-core-dev
17:51 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-nxfabflynovjfgfy] has quit [Quit: Connection closed for inactivity]
18:12 < adiabat> Hey, wondering if anyone is working on the idea of the "Bloom Filter Digest", like if there's a BIP in the works or anything
18:12 < adiabat> there was a post in the mailing list about a month ago
18:14 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
18:17 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
18:23 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
18:24 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
18:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]
18:35 -!- dermoth [~thomas@dial-216-221-43-121.mtl.aei.ca] has quit [Read error: Connection reset by peer]
18:35 -!- dermoth [~thomas@dial-216-221-43-121.mtl.aei.ca] has joined #bitcoin-core-dev
18:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:58 < Chris_Stewart_5> If I specify a -datadir when launching an instnce of bitcoind, does my bitcoind instance look for a bitcoin.conf inside of my datadir, or ~/.bitcoin/bitcoin.conf?
19:01 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
19:02 -!- skyraider [uid41097@gateway/web/irccloud.com/x-pswqlyngjglnzvrw] has joined #bitcoin-core-dev
19:03 < achow101> Chris_Stewart_5: it looks for it in your specified datadir
19:04 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
19:07 < Chris_Stewart_5> achow101: Thanks 
19:12 -!- hoihut [4208d74c@gateway/web/freenode/ip.66.8.215.76] has quit [Ping timeout: 250 seconds]
19:36 -!- justanot1eruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
19:36 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer]
19:42 -!- adiabat [~adiabat@159.203.193.74] has quit [Quit: Leaving.]
19:46 < phantomcircuit> cfields_, travis appears to be borked
19:47 < cfields_> phantomcircuit: https://github.com/bitcoin/bitcoin/pull/8164 ?
19:47 < cfields_> or something else?
19:48 < cfields_> yea, same problem
19:48 < phantomcircuit> https://github.com/bitcoin/bitcoin/pull/8152
19:48 -!- assgrass [grass@gateway/vpn/mullvad/x-vwhgguvishvwxuze] has joined #bitcoin-core-dev
19:48 < phantomcircuit> the no-wallet test fails and that pr is only touching wallet code
19:48 < phantomcircuit> so it's definitely a travis failure
19:49 < cfields_> phantomcircuit: see 8164. master's currently borked, so that will need to be fixed first
19:49 -!- assgrass [grass@gateway/vpn/mullvad/x-vwhgguvishvwxuze] has quit [Read error: Connection reset by peer]
19:49 < phantomcircuit> jonasschnelli, also i can swap the order of the commits in 8152 such that there's never a performance regression even within the pr
19:49 -!- assgrass [grass@gateway/vpn/mullvad/x-lpdujycdgzzfvyja] has joined #bitcoin-core-dev
19:50 < phantomcircuit> ah ok
19:50 -!- assgrass [grass@gateway/vpn/mullvad/x-lpdujycdgzzfvyja] has quit [Read error: Connection reset by peer]
19:51 -!- grassass [~grass@2605:e000:2414:200:ea03:9aff:fe81:c55a] has quit [Ping timeout: 250 seconds]
19:51 -!- xiangfu [~xiangfu@58.135.95.136] has joined #bitcoin-core-dev
19:58 < cfields_> wumpus: for backlog, ^^ please check out 8164 when you're around if jonasschnelli doesn't beat you to it :)
19:58 -!- Kexkey [~kexkey@94.242.219.42] has joined #bitcoin-core-dev
20:08 -!- Cory [~C@unaffiliated/cory] has quit [Ping timeout: 276 seconds]
20:11 -!- Kexkey [~kexkey@94.242.219.42] has quit [Remote host closed the connection]
20:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds]
20:16 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev
20:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
20:32 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Quit: Leaving]
20:37 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
20:41 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
20:41 -!- Cory [~C@unaffiliated/cory] has joined #bitcoin-core-dev
20:42 < GitHub141> [bitcoin] theuni opened pull request #8167: gitian: Ship debug tarballs/zips with debug symbols (master...split-debug) https://github.com/bitcoin/bitcoin/pull/8167
20:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
20:43 -!- raedah [~x@172.58.41.91] has quit [Quit: WeeChat 1.5]
20:43 -!- xiangfu [~xiangfu@58.135.95.136] has quit [Ping timeout: 246 seconds]
20:47 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
20:48 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
20:51 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev
20:54 -!- fengling [~fengling@58.135.95.134] has quit [Client Quit]
21:01 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
21:05 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
21:06 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
21:11 -!- justanot1eruser is now known as justanotheruser
21:13 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit []
21:39 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
21:40 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
21:51 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
21:53 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
21:55 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
22:00 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
22:01 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
22:01 -!- skyraider [uid41097@gateway/web/irccloud.com/x-pswqlyngjglnzvrw] has quit [Quit: Connection closed for inactivity]
22:04 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds]
22:07 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Ping timeout: 244 seconds]
22:08 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev
22:17 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 250 seconds]
22:28 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Ping timeout: 258 seconds]
22:41 -!- Squidicc [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again]
22:48 -!- ozanyurt [~ozanyurt@78.185.248.35] has quit [Ping timeout: 252 seconds]
22:57 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Ping timeout: 250 seconds]
23:00 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev
23:04 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hgnnnqixfhtduefi] has joined #bitcoin-core-dev
23:26 -!- blur3d [~blur3d@49.187.26.218] has quit [Quit: blur3d]
23:37 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has quit [Read error: Connection reset by peer]