--- Day changed Tue Jul 12 2016 00:22 -!- whphhg [whphhg@gateway/vpn/mullvad/x-viozegiruadozmtl] has joined #bitcoin-core-dev 00:30 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 00:38 -!- frankenmint [~frankenmi@174-25-9-165.ptld.qwest.net] has quit [Read error: Connection reset by peer] 00:38 -!- frankenmint [~frankenmi@174-25-9-165.ptld.qwest.net] has joined #bitcoin-core-dev 00:49 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 00:54 -!- murch [~murch@p4FDB78D7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:58 -!- DigiByteDev [~JT2@128.90.108.115] has joined #bitcoin-core-dev 01:15 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has quit [Ping timeout: 240 seconds] 01:16 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 01:17 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 01:24 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Ping timeout: 240 seconds] 01:25 -!- xinxi [~xinxi@116.86.156.222] has quit [Remote host closed the connection] 01:34 -!- asoltys [~bitcoinco@23.94.96.232] has quit [Ping timeout: 272 seconds] 01:37 -!- xinxi [~xinxi@116.86.156.222] has joined #bitcoin-core-dev 01:38 -!- xinxi [~xinxi@116.86.156.222] has quit [Remote host closed the connection] 01:40 -!- asoltys [~bitcoinco@23.94.96.232] has joined #bitcoin-core-dev 01:49 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:53 -!- tucenaber [~tucenaber@o144.231.lokis.net.pl] has joined #bitcoin-core-dev 01:53 -!- tucenaber [~tucenaber@o144.231.lokis.net.pl] has quit [Changing host] 01:53 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has joined #bitcoin-core-dev 01:58 -!- whphhg_ [whphhg@gateway/vpn/mullvad/x-ajneybrtsveaxlea] has joined #bitcoin-core-dev 02:01 -!- whphhg [whphhg@gateway/vpn/mullvad/x-viozegiruadozmtl] has quit [Ping timeout: 260 seconds] 02:06 -!- DigiByteDev [~JT2@128.90.108.115] has quit [Quit: DigiByteDev] 02:07 -!- fengling [~fengling@58.135.95.137] has quit [Ping timeout: 240 seconds] 02:12 -!- mkarrer [~mkarrer@241.red-83-47-85.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 02:12 -!- mkarrer [~mkarrer@241.red-83-47-85.dynamicip.rima-tde.net] has quit [Read error: Connection reset by peer] 02:12 -!- mkarrer [~mkarrer@241.red-83-47-85.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 02:20 -!- ebfull [~sean@c-50-170-183-94.hsd1.co.comcast.net] has joined #bitcoin-core-dev 02:23 -!- whphhg_ is now known as whphhg 02:25 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 02:45 -!- frankenmint [~frankenmi@174-25-9-165.ptld.qwest.net] has quit [Remote host closed the connection] 02:47 < GitHub97> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/4831a16223dbb42da3091e616c47eeb01f53f73b 02:47 < GitHub97> bitcoin/master 4831a16 Wladimir J. van der Laan: qt: periodic translation update... 02:49 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 02:55 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 250 seconds] 02:57 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:57 -!- mkarrer [~mkarrer@241.red-83-47-85.dynamicip.rima-tde.net] has quit [Ping timeout: 276 seconds] 03:00 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 03:02 -!- mkarrer [~mkarrer@190.red-81-35-195.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 03:03 -!- go1111111 [~go1111111@104.200.154.24] has quit [Ping timeout: 276 seconds] 03:09 -!- mkarrer [~mkarrer@190.red-81-35-195.dynamicip.rima-tde.net] has quit [] 03:12 -!- mkarrer [~mkarrer@190.red-81-35-195.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 03:17 -!- davidlj95 [~davidlj95@deic-dyn-232.uab.es] has left #bitcoin-core-dev [] 03:27 -!- xinxi [~xinxi@116.86.156.222] has joined #bitcoin-core-dev 03:33 -!- AaronvanW [~ewout@220pc230.sshunet.nl] has joined #bitcoin-core-dev 03:33 -!- AaronvanW [~ewout@220pc230.sshunet.nl] has quit [Changing host] 03:33 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:34 -!- fengling [~fengling@58.135.95.137] has joined #bitcoin-core-dev 03:39 -!- fengling [~fengling@58.135.95.137] has quit [Ping timeout: 240 seconds] 03:54 < GitHub74> [bitcoin] kholbekj opened pull request #8335: update inline copyright notices (master...update-inline-copyright) https://github.com/bitcoin/bitcoin/pull/8335 03:55 -!- Giszmo [~leo@80.31.9.48] has joined #bitcoin-core-dev 04:05 -!- arubi [~ese168@unaffiliated/arubi] has quit [Quit: Leaving] 04:06 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 04:07 -!- Giszmo [~leo@80.31.9.48] has quit [Quit: Leaving.] 04:11 -!- Giszmo [~leo@80.31.9.48] has joined #bitcoin-core-dev 04:20 -!- Giszmo [~leo@80.31.9.48] has quit [Quit: Leaving.] 04:31 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:35 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 04:36 -!- fengling [~fengling@58.135.95.137] has joined #bitcoin-core-dev 04:41 -!- fengling [~fengling@58.135.95.137] has quit [Ping timeout: 240 seconds] 04:54 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:57 -!- arubi [~ese168@unaffiliated/arubi] has quit [Quit: Leaving] 04:57 < GitHub72> [bitcoin] jonasschnelli closed pull request #8335: update inline copyright notices (master...update-inline-copyright) https://github.com/bitcoin/bitcoin/pull/8335 04:57 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 04:59 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 05:06 -!- YOU-JI [~youyouyou@q047133.dynamic.ppp.asahi-net.or.jp] has joined #bitcoin-core-dev 05:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 05:27 -!- jannes [~jannes@178.132.211.90] has quit [Remote host closed the connection] 05:36 -!- arubi [~ese168@unaffiliated/arubi] has quit [Ping timeout: 252 seconds] 05:37 -!- fengling [~fengling@58.135.95.137] has joined #bitcoin-core-dev 05:39 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 05:42 -!- fengling [~fengling@58.135.95.137] has quit [Ping timeout: 240 seconds] 05:50 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 05:58 -!- G1lius [~stefangil@10.216-245-81.adsl-dyn.isp.belgacom.be] has joined #bitcoin-core-dev 06:15 -!- arubi [~ese168@unaffiliated/arubi] has quit [Quit: Leaving] 06:16 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 06:22 -!- JackH [~Jack@79-73-186-51.dynamic.dsl.as9105.com] has quit [Read error: Connection reset by peer] 06:34 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 06:35 -!- YOU-JI [~youyouyou@q047133.dynamic.ppp.asahi-net.or.jp] has quit [Quit: Leaving...] 06:39 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 06:39 -!- fengling [~fengling@58.135.95.137] has joined #bitcoin-core-dev 06:41 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 06:44 -!- fengling [~fengling@58.135.95.137] has quit [Ping timeout: 240 seconds] 06:53 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:53 -!- zooko [~user@68.233.157.2] has joined #bitcoin-core-dev 06:55 -!- lysobit- [~musalbas@2001:bc8:30c2::] has joined #bitcoin-core-dev 06:56 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 06:56 -!- musalbas- [~musalbas@2001:bc8:30c2::] has joined #bitcoin-core-dev 07:01 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 07:01 -!- baldur [~baldur@pool-72-69-25-42.nycmny.fios.verizon.net] has quit [Ping timeout: 276 seconds] 07:10 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 07:12 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 246 seconds] 07:13 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 07:15 -!- BCBot [~BCBot@46.101.246.115] has quit [Read error: Connection reset by peer] 07:18 -!- fifth_ [~fifth@3.46-14-84.ripe.coltfrance.com] has joined #bitcoin-core-dev 07:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:26 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 07:27 < michagogo> Has anyone looked into packaging Bitcoin Core into a snap? 07:27 < michagogo> (Ubuntu's new packaging format) 07:27 -!- murch [~murch@p4FDB78D7.dip0.t-ipconnect.de] has quit [Quit: Leaving.] 07:28 < michagogo> I haven't gotten a chance to look at it closely (and I don't know if I'd really understand it), but it sounds like it's an Ubuntu-supported way for devs to package apps in self-contained packages that can update independently of the distro 07:29 < michagogo> Which sounds like it would solve a lot of the problems we've had with Bitcoin being packaged in the Ubuntu repos 07:29 < michagogo> (i.e. it _might_ let us sanely get Bitcoin Core into Ubuntu) 07:29 < sipa> sounds interesting 07:31 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 07:32 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 07:39 < jonasschnelli> sounds good... the current PPA is maintained by thebluematt, maybe he's interested 07:40 -!- fengling [~fengling@58.135.95.137] has joined #bitcoin-core-dev 07:45 -!- fengling [~fengling@58.135.95.137] has quit [Ping timeout: 240 seconds] 08:01 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 08:05 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:15 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 08:17 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 08:22 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 08:23 -!- fifth_ [~fifth@3.46-14-84.ripe.coltfrance.com] has quit [Remote host closed the connection] 08:25 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 08:47 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 09:35 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:44 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 09:49 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 09:56 -!- G1lius [~stefangil@10.216-245-81.adsl-dyn.isp.belgacom.be] has quit [] 09:59 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 10:33 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 10:45 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 10:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 10:50 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 10:54 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 11:03 < xinxi> I've herd there is slack group for Bitcoin core dev. Who can tell me the URL? 11:07 < btcdrak> xinxi: slack.bitcoincore.org 11:07 < eragmus> xinxi: https://slack.bitcoincore.org -- However, it is not really focused on Core development. It's a general purpose community with nearly 2,000 members who discuss all manner of topics. 11:07 < btcdrak> but it's more a community slack. 11:07 < xinxi> thank you. 11:15 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:16 < xinxi> Oh, messages sent on slack cannot be seen here. 11:16 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: gaming brah] 11:20 < Chris_Stewart_5> Is there some weird semantics with TransactionMessage on the p2p network that are different than BlockMessage? Besides switching MsgBlock to MsgTx 11:20 < Chris_Stewart_5> I keep getting a NotFound message response, when I know the tx exists 11:20 < sipa> Chris_Stewart_5: you can't just request any transaction 11:20 < sipa> only things that have been advertized to you 11:21 < sipa> (reasons for this are 1) there is no full index for all transactions in the chain 2) there is a privacy leak if you allow peers to check whether you have seen a particular transaction already) 11:22 -!- adamg [~akg@50.242.93.33] has quit [Ping timeout: 260 seconds] 11:23 < Chris_Stewart_5> so what does -reindex allows you to easily search by header id then? And can you elaborate more on 2)? Does that allow them withold honest txs from you if you are being sybil attacked? 11:24 < sipa> Chris_Stewart_5: the network tries to hide where a transaction originates 11:24 < sipa> for that, transactions are relayed with random delays between them, and in different order for different peers 11:25 < sipa> if i could query whether you have a transaction that i know about, but you haven't told me about, i can bypass that mechanism 11:25 < sipa> Chris_Stewart_5: -reindex just throws away the database and builds a new one 11:25 < Chris_Stewart_5> Sorry i meant -txindex 11:25 < sipa> yes, that's for local consumption 11:26 < sipa> not exposed to the network 11:26 -!- adamg [~akg@50.242.93.33] has joined #bitcoin-core-dev 11:26 < Chris_Stewart_5> Ok. So if I am understanding you correctly we allow arbitrary block querying because 1.) we need it to sync nodes on the network, 2.) You can't tell where a tx originates from once it is included in the block 11:27 < Chris_Stewart_5> What file is the code in wrt to transaction propogation? main.cpp? net.cpp? 11:27 < sipa> both 11:32 < Chris_Stewart_5> sipa: Is this section in the developer reference wrong then? Under the heading 'Transaction response' https://bitcoin.org/en/developer-reference#tx 11:32 < sipa> no 11:32 < Chris_Stewart_5> I interpreted it as you build a getdata message, send it and then get a tx message response 11:33 < sipa> it could be clarified 11:33 < sipa> but it's not wrong that a tx is sent as response to getdata TX 11:34 < sipa> but i agree it's a bit misleading 11:34 < Chris_Stewart_5> sipa: With the caveat being that the node has already broadcasted the txid to that node requesting the tx with a getdata right? 11:37 < sipa> or through the bip35 mempool command 11:38 < Chris_Stewart_5> gotcha, thanks. 11:40 < sipa> also, after relay, you only have a finite amount of time to getdata 11:40 < sipa> i think 15 minutes by default 11:42 < Chris_Stewart_5> Seems like that could have interesting consequences if the hash rate where to suddenly drop significantly. Tx propogation could stagnate couldn't it? 11:42 < sipa> tx propagation has nothing to do with blocks 11:46 < Chris_Stewart_5> True, I guess the scenario I was envisioning in my head would only happen if nodes were constantly being shut off and turned on at an alarming rate 11:46 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 11:49 -!- gitju [~Welcome@p57AD0BB1.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:50 -!- gitju [~Welcome@p57AD0BB1.dip0.t-ipconnect.de] has left #bitcoin-core-dev ["Verlassend"] 11:51 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 12:01 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 12:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:14 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 12:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:25 -!- ryan`c [~ryan@znc.rya.nc] has joined #bitcoin-core-dev 12:29 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 12:30 -!- ryan`c [~ryan@znc.rya.nc] has quit [K-Lined] 12:35 -!- ryan`c [~ryan@znc.rya.nc] has joined #bitcoin-core-dev 12:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 12:45 -!- ryan-c [~ryan@srv1.turboslow.net] has quit [Quit: ZNC - http://znc.sourceforge.net] 12:46 -!- ryan`c is now known as ryan-c 12:48 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 12:53 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 12:54 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:55 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:55 -!- go1111111 [~go1111111@104.232.116.217] has joined #bitcoin-core-dev 12:56 -!- frankenmint [~frankenmi@174-25-9-165.ptld.qwest.net] has joined #bitcoin-core-dev 12:56 -!- JackH [~Jack@79-73-186-51.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 13:02 < bsm117532> My transactions spending segwit outputs are being rejected by sendrawtransaction... 13:03 < sipa> what code? 13:03 < bsm117532> Do I understand correctly that it's normal behavior for the segwit input scripts have a leftover element on the stack? 13:03 < sipa> indeed 13:03 < bsm117532> 64: non-mandatory-script-verify-flag (Script evaluated without error but finished with a false/empty top stack element) 13:04 < bsm117532> The transaction is https://www.zerobin.net/?d2c7842e69b63293#PUa9xa3YL9B3N2dwSlbcmfLVMSxyeaUvWJ4YLtp9cEQ= 13:04 < sipa> that likely means your signature is incorrect 13:04 < bsm117532> Hmmm ok 13:09 -!- frankenmint [~frankenmi@174-25-9-165.ptld.qwest.net] has quit [Remote host closed the connection] 13:10 < bsm117532> I tried to create a spend of a P2WPKH transaction, with the signature and pubkey as the two elements in the witness data. But signrawtransaction is giving me a txinwitness that contains a signature and a 65 byte-blob. Is this second value an uncompressed pubkey or something? 13:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 13:19 < bsm117532> Here's a decoding of a segwit spend generated by sendrawtransaction and one by me: https://www.zerobin.net/?9964fec796427a47#3Y2hZLaVTUV03Qx+vEG7i0NYtiDdhVAnM/BE5tEIXFI= 13:20 < bsm117532> Can someone explain the difference in what sendrawtransaction is putting as the second element of the witness data? 13:20 < sipa> yup, that looks like an uncompressed pubkey 13:21 < bsm117532> Are uncompressed pubkeys required? AFAICT that's the only difference between the two. 13:21 < sipa> no 13:21 < sipa> they're even discouraged and no modern bitcoin core wallet will use them by default 13:21 < sipa> but if you have a very old wallet file or have imported uncompressed keys, there is no choice 13:22 < sipa> *won't use them by default 13:23 < bsm117532> Ok so if sendrawtransaction is using uncompressed pubkeys, it could be a bug, and if segwit script validation is rejecting compressed pubkeys, it could be a bug...I'll dig. 13:23 < sipa> i can guarantee you that compressed pubkeys work 13:23 < sipa> i suspect that you're just signing the incorrect signature hash 13:24 < bsm117532> That's entirely possible. 13:24 < sipa> (that's just from experience of other people seeing fail there) 13:25 < bsm117532> Ok I'll dig there first. But I'm also working on a wallet-functionality patch for core. My node shouldn't be generating uncompressed pubkeys, though I do run --with-incompatible-bdb, other than that all keys should be new. 13:25 < sipa> did you import keys, ever? 13:27 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 13:28 < bsm117532> Hmmm...possibly. 13:28 < bsm117532> Should I recreate my wallet then? 13:29 < sipa> imported keys have a flag that says whether the corresponding pubkey is to compressed or not (otherwise the address is not well defined) 13:29 < sipa> i wouldn't bother 13:29 < bsm117532> Hmm maybe I just got unlucky with the chosen input. 13:29 -!- zooko [~user@68.233.157.2] has quit [Ping timeout: 240 seconds] 13:32 * bsm117532 beats on BIP 143. I knew it was unlikely that my sighash was correct... 13:42 * bsm117532 sees now...BIP 143 isn't even remotely close to the pre-segwit algorithm. 13:43 < sipa> nope 13:43 < sipa> it's still more or less the same order of data, but all 'over all inputs' or 'over all outputs' things are first aggregated into an intermediary hash 13:43 < bsm117532> In my defense, I wrote in the python-bitcoinlib PR that I didn't implement this yet! ;-) 13:50 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 13:54 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 14:01 < bsm117532> In BIP 143, this line: if (!(nHashType & SIGHASH_ANYONECANPAY) && (nHashType & 0x1f) != SIGHASH_SINGLE && (nHashType & 0x1f) != SIGHASH_NONE) { 14:01 < bsm117532> Isn't it simpler to just say: if(nHashType | SIGHASH_ALL) ? 14:02 < bsm117532> errr.... if(nHashType & SIGHASH_ALL) 14:04 < sipa> that would not be the same, i think? 14:05 < bsm117532> I think it's the same unless there are more than 4 SIGHASH_* types 14:07 < sipa> there are 6 combinations 14:08 < sipa> but the sighash byte can have 256 values 14:08 < sipa> all of which map to one of those 6 formulas 14:10 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:11 < bsm117532> I see. I thought it was just a bitmap. 14:12 < bsm117532> Reference implementation is easy to translate to python, I'll stop trying to "improve" it. ;-) 14:14 < sipa> https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/test_framework/script.py#L908 14:15 < bsm117532> Thanks! 14:17 -!- Avinty-L_ [~quassel@46.13.156.92] has joined #bitcoin-core-dev 14:18 < bsm117532> Sorry I hadn't realized this was so close to petertodd's repo. 14:19 * bsm117532 diffs. 14:19 < sipa> i think it forked off a long time ago 14:20 < sipa> it's a forked, stripped, and then extended version just for tests 14:20 < bsm117532> makes sense. 14:24 -!- bustd_soket [weechat@gateway/vpn/mullvad/x-zcpozxvgrtbfplny] has quit [Ping timeout: 260 seconds] 14:25 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 14:25 < sipa> but feel free to steal/donate code of course 14:25 < bsm117532> Thanks, I'll attribute what I steal. 14:26 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 14:32 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 14:35 -!- Avinty-L_ [~quassel@46.13.156.92] has quit [Read error: Connection reset by peer] 14:36 -!- bustd_soket [weechat@gateway/vpn/mullvad/x-xxhrhwprbjkymvdp] has joined #bitcoin-core-dev 14:37 -!- Avinty_L_ [~quassel@46.13.156.92] has joined #bitcoin-core-dev 14:37 -!- Avinty_L_ [~quassel@46.13.156.92] has quit [Client Quit] 14:43 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 272 seconds] 14:45 -!- Avinty_L_ [~quassel@46.13.156.92] has joined #bitcoin-core-dev 14:47 -!- Avinty_L_ [~quassel@46.13.156.92] has quit [Read error: Connection reset by peer] 14:51 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 14:56 -!- TomMc [~tom@gateway/vpn/privateinternetaccess/tommc] has joined #bitcoin-core-dev 14:56 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 15:09 -!- Avinty_L [~quassel@46.13.156.92] has joined #bitcoin-core-dev 15:13 -!- Avinty_L [~quassel@46.13.156.92] has quit [Read error: Connection reset by peer] 15:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:24 < midnightmagic> sipa (or anyone really): When a node hears about a sibling block to its current valid head, it ignores it, correct? Or does it hold it until it discovers which fork the miners settle on? 15:24 < midnightmagic> I thought it sits on it so long as it is also valid and does not represent less work than the current head? 15:28 < bsm117532> midnightmagic: It's my understanding that it doesn't *relay* it, but does track its chain tip, in case its PoW becomes larger. 15:41 -!- arubi [~ese168@unaffiliated/arubi] has quit [Ping timeout: 258 seconds] 15:51 < sipa> midnightmagic: we keep track of the headers 15:52 < sipa> midnightmagic: but only actively try to fetch the blocks if they're overtaking our best chain 15:52 < sipa> under certain circumstances we do accept unsolicited blocks 15:53 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 15:55 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 15:57 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 15:59 < midnightmagic> sipa: can you give me an example of one of those edge cases? I don't need gritty details.. 16:00 < sipa> midnightmagic: not edge case; it's very intentional... for example, nodes connected to the (old) relay network would get blocks pushed directly to them 16:00 < sipa> it would be silly to not accept those 16:02 < midnightmagic> sipa: So an old-style block chatter is still accepted wholesale and validation proceeds (and then stored but still not considered canonical head until Y+1 indicates the fork has overtaken X.) 16:02 < sipa> midnightmagic: well in almost all cases the new block is not a reorg 16:02 < sipa> but we don't know that in advance 16:03 < bsm117532> petertodd: I notice in python-bitcoinlib that CScript treats OP_0 as an empty data push b''. It's used as the segwit version number. Is there good reason to treat OP_0 as an empty data push over a small integer with value 0? 16:03 -!- deego [~user@unaffiliated/deego] has joined #bitcoin-core-dev 16:03 < sipa> bsm117532: you can't change the semantics of the scripting language... 16:03 < sipa> OP_0 by definition pushes the byte sequence '' 16:03 < bsm117532> Is that changing the semantics? 16:03 < sipa> yes 16:04 < sipa> if you would compare it to the empty string later, it has to succeed 16:04 < midnightmagic> sipa: Is the strict difficulty of the block hash now considered in terms of deciding validity of head? I know you guys were thinking of doing that instead of just the difficulty target of the block itself.. 16:04 < sipa> bsm117532: the script language stack only has one data type, byte array 16:04 < sipa> some operators treat the elements as numbers, but that's not relevant 16:05 < bsm117532> sipa: okay, I'm comparing to your bip141 which writes scriptPubKey as: 0 <20-byte-key-hash>, but obviously b'' <20-byte-key-hash> is equivalent. 16:05 < sipa> no 16:05 < sipa> it's OP_0 and then a 20-byte push 16:06 < sipa> oh, that's what you mean 16:06 < sipa> why can't you use OP_0 ? 16:06 < bsm117532> Yes. python-bitcoinlib treats it as an empty byte array push, followed by a 20-byte push. 16:06 < sipa> that's correct 16:06 < bsm117532> It doesn't give me OP_0. It decodes OP_1...OP_16 but does not decode OP_0. 16:07 < bsm117532> This is to do with the __iter__ method of CScript, which parses it. 16:07 < sipa> that sounds like a bug 16:07 < bsm117532> That's why I asked. ;-) 16:07 < sipa> but i don't know python-bitcoinlib 16:08 < bsm117532> Maybe petertodd will happen by ;-) 16:11 < bsm117532> There are two iterators, a "raw" iterator, for people who want to tell the difference between PUSHDATA* and a "cooked" iterator which is supposed to be "intuitive" or something. I'll put the difference into the "cooked" iterator. 16:11 -!- deego [~user@unaffiliated/deego] has left #bitcoin-core-dev ["ty"] 16:12 < bsm117532> so now I get: CScript([OP_0, x('a87e6d173860ff1dfc8849f2638182aa36058389')]) 16:37 -!- harrymm [~wayne@223.204.247.243] has quit [Ping timeout: 240 seconds] 16:43 -!- Cory [~C@unaffiliated/cory] has quit [Ping timeout: 264 seconds] 16:53 -!- harrymm [~wayne@37.58.59.81] has joined #bitcoin-core-dev 16:54 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 16:59 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 17:06 -!- Cory [~C@unaffiliated/cory] has joined #bitcoin-core-dev 17:15 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving] 17:23 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 17:30 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:36 -!- Cory [~C@unaffiliated/cory] has quit [Ping timeout: 244 seconds] 17:39 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 17:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 276 seconds] 17:44 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 17:53 < phantomcircuit> sipa, i want to (optinally) save the mempool and sigcache 17:53 < phantomcircuit> on shutdown 17:53 < phantomcircuit> where's the right place to put that? 17:54 < gmaxwell> don't save the sigcache. the reload of the mempool from disk will repopulate it. 17:54 < gmaxwell> the stuff that doesn't get repopulated shouldn't be there in any case. 17:58 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 17:59 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:03 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: Leaving.] 18:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:12 < phantomcircuit> gmaxwell, yes but repopulating the mempool will take forever without saving the sigcache 18:15 < gmaxwell> phantomcircuit: 300mb of validation isn't ~that~ big a deal. 18:16 < gmaxwell> at least so long as it reloads the mempool in the background. 18:16 < gmaxwell> okay, perhaps worse than I'm thinking due to the fact that the signature validation isn't parallel 18:18 < gmaxwell> but even if the 300mbytes is alll txins, thats 145 bytes per signature, or about 2 million signatures, which even on a single moderately fast core should only be about 121 cpu seconds. 18:19 < gmaxwell> well whatever, 30% slower since I'm assuming libsecp256k1 with performance features we're not using yet. 18:24 < phantomcircuit> gmaxwell, it's quite a bit more than 300MiB on my system :) 18:25 < gmaxwell> phantomcircuit: having a mempool much larger than typical shouldn't increase your hitrate much and if you're mining may cause your to mine poorly propagated crap. 18:27 < phantomcircuit> it wont improve the hitrate for sigcache or compact blocks very much 18:27 < phantomcircuit> i dont see how it can result in you mining poorly propagated things though? 18:30 < gmaxwell> say someone advertises a txn with a very low feerate, it doesn't enter or quickly falls out of most nodes mempools. 18:30 < Chris_Stewart_5> If I add a different version of boost to my /usr/include I end up getting errors with core not being able to find it, is there some where I need to reference a newer version? 18:30 < Chris_Stewart_5> cfields: 18:30 < gmaxwell> phantomcircuit: but not yours... later, the network runs low on transactions in the pool or CPFP ranks that straggler up. now you mine it. And it's a surprise to everyone. 18:35 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rsvvmawbpoovtsay] has quit [Quit: Connection closed for inactivity] 18:47 -!- TomMc [~tom@gateway/vpn/privateinternetaccess/tommc] has quit [Ping timeout: 258 seconds] 18:57 < petertodd> bsm117532: for consensus critical applications, you're going to need to use the raw iterator, and even worse, follow the byte-level tests in the segwit codebase exactly 19:05 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 19:22 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 19:23 -!- go1111111 [~go1111111@104.232.116.217] has quit [Quit: Leaving] 19:25 -!- DigiByteDev [~JT2@128.90.108.132] has joined #bitcoin-core-dev 19:26 -!- DigiByteDev [~JT2@128.90.108.132] has quit [Client Quit] 19:33 -!- DigiByteDev [~JT2@101.78.224.202] has joined #bitcoin-core-dev 19:33 -!- DigiByteDev [~JT2@101.78.224.202] has quit [Client Quit] 19:34 -!- DigiByteDev [~JT2@101.78.224.202] has joined #bitcoin-core-dev 19:39 -!- Cory [~C@unaffiliated/cory] has joined #bitcoin-core-dev 20:04 < phantomcircuit> gmaxwell, true 20:04 < phantomcircuit> i think that is generally not easily solved though 20:04 < phantomcircuit> indeed unless you have the exact same limit as the entire rest of the network 20:04 < phantomcircuit> you're screwed there 20:04 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 272 seconds] 20:05 < phantomcircuit> otoh my brain is on fire so maybe im wrong 20:09 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has quit [Quit: END OF LINE] 20:18 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has joined #bitcoin-core-dev 20:22 -!- cryptapus_ [~cryptapus@199.47.67.51] has joined #bitcoin-core-dev 20:22 -!- cryptapus_ [~cryptapus@199.47.67.51] has quit [Changing host] 20:22 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 20:31 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 264 seconds] 20:42 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 20:51 -!- cryptapus_ [~cryptapus@199.47.67.51] has joined #bitcoin-core-dev 20:51 -!- cryptapus_ [~cryptapus@199.47.67.51] has quit [Changing host] 20:51 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 20:55 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 21:06 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 21:11 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 21:17 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds] 21:20 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 21:34 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 21:40 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 22:11 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 252 seconds] 22:12 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 22:25 -!- frankenmint [~frankenmi@174-25-9-165.ptld.qwest.net] has joined #bitcoin-core-dev 22:30 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 22:43 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 22:44 -!- frankenmint [~frankenmi@174-25-9-165.ptld.qwest.net] has quit [] 22:49 -!- fengling_ [~fengling@58.135.95.137] has joined #bitcoin-core-dev 22:50 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 22:56 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 23:07 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 23:08 -!- morcos [~morcos@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 258 seconds] 23:08 -!- zxzzt [~prod@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 264 seconds] 23:09 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 23:09 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 23:10 -!- DigiByteDev [~JT2@101.78.224.202] has quit [Quit: DigiByteDev] 23:11 -!- go1111111 [~go1111111@104.200.154.97] has joined #bitcoin-core-dev 23:12 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 250 seconds] 23:13 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 23:39 -!- Michail1 [~michail@michail.com] has quit [Quit: Outta here] 23:40 -!- davidlj95 [~davidlj95@deic-dyn-232.uab.es] has joined #bitcoin-core-dev 23:47 -!- assder [82eb8819@gateway/web/freenode/ip.130.235.136.25] has joined #bitcoin-core-dev 23:56 -!- bustd_soket [weechat@gateway/vpn/mullvad/x-xxhrhwprbjkymvdp] has quit [Ping timeout: 258 seconds]