--- Day changed Tue Jul 19 2016 00:32 -!- slackircbridge [~slackircb@45.55.41.36] has quit [Remote host closed the connection] 00:32 -!- nohup [288d2f3a@gateway/web/freenode/ip.40.141.47.58] has joined #bitcoin-core-dev 00:32 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 00:34 -!- whphhg [~whphhg@unaffiliated/whphhg] has quit [Quit: Leaving] 00:37 -!- whphhg [whphhg@gateway/vpn/mullvad/x-xshgsqltironqvsb] has joined #bitcoin-core-dev 00:37 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer] 00:37 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 00:52 -!- NicLin [~textual@14.100.136.154] has joined #bitcoin-core-dev 01:13 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 01:14 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 01:15 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 01:23 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-uefecpeazkuppbfq] has joined #bitcoin-core-dev 01:27 < jonasschnelli> luke-jr: how do you mean not the default? Per default core 0.13 will generate hd wallets (when starting a new wallet). 01:44 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:47 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 01:47 < MarcoFalke> Also you can't do -walletupgrade to get an HD wallet 01:53 -!- pedrobranco [~pedrobran@89-180-65-159.net.novis.pt] has joined #bitcoin-core-dev 01:58 -!- mn3monic [~guido@176.9.68.68] has quit [Ping timeout: 240 seconds] 01:58 < jonasschnelli> Yes. That would not work. HD can only be enabled during creation. 01:58 < jonasschnelli> (for now) 02:07 -!- pedrobranco [~pedrobran@89-180-65-159.net.novis.pt] has quit [Remote host closed the connection] 02:07 -!- pedrobranco [~pedrobran@89.180.65.159] has joined #bitcoin-core-dev 02:08 -!- pedrobranco [~pedrobran@89.180.65.159] has quit [Remote host closed the connection] 02:09 -!- pedrobranco [~pedrobran@89.180.65.159] has joined #bitcoin-core-dev 02:12 -!- NicLin [~textual@14.100.136.154] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 02:12 -!- pedrobranco [~pedrobran@89.180.65.159] has quit [Remote host closed the connection] 02:12 -!- pedrobranco [~pedrobran@89.180.65.159] has joined #bitcoin-core-dev 02:12 -!- go1111111 [~go1111111@104.200.154.64] has quit [Ping timeout: 240 seconds] 02:16 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:24 -!- foo1 [~foo@104.196.34.217] has quit [Quit: WeeChat 1.4] 02:27 -!- go1111111 [~go1111111@104.232.116.217] has joined #bitcoin-core-dev 02:30 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds] 02:30 -!- pedrobranco [~pedrobran@89.180.65.159] has quit [Read error: Connection reset by peer] 02:30 -!- pedrobranco [~pedrobran@89.180.65.159] has joined #bitcoin-core-dev 02:33 -!- pedrobra_ [~pedrobran@78.130.27.109.rev.optimus.pt] has joined #bitcoin-core-dev 02:35 -!- pedrobranco [~pedrobran@89.180.65.159] has quit [Ping timeout: 258 seconds] 02:57 < GitHub114> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/37269105c881...a07c8a032c0d 02:57 < GitHub114> bitcoin/0.13 df85463 Pieter Wuille: Some 0.13 release notes about p2p changes 02:57 < GitHub114> bitcoin/0.13 a07c8a0 Wladimir J. van der Laan: Merge #8361: Some 0.13 release notes about p2p changes... 02:57 < GitHub99> [bitcoin] laanwj closed pull request #8361: Some 0.13 release notes about p2p changes (0.13...relnotes-0.13) https://github.com/bitcoin/bitcoin/pull/8361 03:09 < GitHub70> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e3557b8e363...ca7550e128a3 03:09 < GitHub70> bitcoin/master 2c06bae Suhas Daftuar: Rename "block cost" to "block weight" 03:09 < GitHub70> bitcoin/master ca7550e Wladimir J. van der Laan: Merge #8363: Rename "block cost" to "block weight"... 03:09 < GitHub19> [bitcoin] laanwj closed pull request #8363: Rename "block cost" to "block weight" (master...cost-to-weight) https://github.com/bitcoin/bitcoin/pull/8363 03:10 -!- nohup [288d2f3a@gateway/web/freenode/ip.40.141.47.58] has quit [Quit: Page closed] 03:10 < GitHub24> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/fca1a415cec6b7655448ce8b30778784ab4c181e 03:10 < GitHub24> bitcoin/0.13 fca1a41 Suhas Daftuar: Rename "block cost" to "block weight"... 03:13 < GitHub123> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca7550e128a3...045106b4f13c 03:13 < GitHub123> bitcoin/master a4f137f Jonas Schnelli: [Wallet] Ensure <0.13 clients can't open HD wallets 03:13 < GitHub123> bitcoin/master 045106b Wladimir J. van der Laan: Merge #8367: [Wallet] Ensure <0.13 clients can't open HD wallets... 03:13 < GitHub41> [bitcoin] laanwj closed pull request #8367: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion_014) https://github.com/bitcoin/bitcoin/pull/8367 03:14 -!- Samdney [~Samdney@nat-wlan2.rrze.uni-erlangen.de] has joined #bitcoin-core-dev 03:14 < GitHub48> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/fca1a415cec6...24f117ef05f5 03:14 < GitHub48> bitcoin/0.13 3b38a6a Jonas Schnelli: [Wallet] Ensure <0.13 clients can't open HD wallets 03:14 < GitHub68> [bitcoin] laanwj closed pull request #8366: [0.13] [Wallet] Ensure <0.13 clients can't open HD wallets (0.13...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8366 03:14 < GitHub48> bitcoin/0.13 24f117e Wladimir J. van der Laan: Merge #8366: [0.13] [Wallet] Ensure <0.13 clients can't open HD wallets... 03:16 -!- pedrobra_ [~pedrobran@78.130.27.109.rev.optimus.pt] has quit [Remote host closed the connection] 03:18 < MarcoFalke> rc1 time? *.* 03:18 -!- pedrobranco [~pedrobran@78.130.27.109.rev.optimus.pt] has joined #bitcoin-core-dev 03:19 < MarcoFalke> wait what about 8362? 03:22 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 03:22 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 03:23 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 03:24 < GitHub184> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/ec8f5fc8b5f68ddf7fed0d74a5ec82e6b03f7f92 03:24 < GitHub184> bitcoin/0.13 ec8f5fc Wladimir J. van der Laan: doc: Add list of pulls and authors to release notes 03:25 < GitHub184> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/ec8f5fc8b5f6...d6bb231a9fa9 03:25 < GitHub184> bitcoin/0.13 ded0599 Wladimir J. van der Laan: doc: Add a few items to release notes... 03:25 < GitHub126> [bitcoin] laanwj closed pull request #8360: doc: Add a few items to release notes (0.13...2016_07_release_notes) https://github.com/bitcoin/bitcoin/pull/8360 03:25 < GitHub184> bitcoin/0.13 d6bb231 Wladimir J. van der Laan: Merge #8360: doc: Add a few items to release notes... 03:36 < wumpus> going to tag rc1 in a bit 03:37 < wumpus> anything that really still needs to go in? last chance 03:39 < jonasschnelli> wumpus: what about TheBlueMatts concern about FEATURE_HD? 03:39 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 03:39 < jonasschnelli> I have worked out a PR that can support a set of strings (features). 03:39 < wumpus> I don't see it as a large problem 03:39 < jonasschnelli> But probably to late for 0.13 03:39 < sipa> i think string-based features can wait until later 03:40 < wumpus> over time, HD wallets are probably going to be the default anyway, and the at-least-0.13 requirement is not a big issue 03:40 < jonasschnelli> The only concern is, that if we introduce another feature (lets say KEY_ORIGIN_FLAGS [there is a PR]) that this feature would require 0.13 even if it would be compatible with < 0.13. 03:40 < wumpus> I think how you handled the transfer period is fine 03:40 < MarcoFalke> Jup, we can just make -upgradewallet take care of this 03:40 < MarcoFalke> There is plenty of time till .14 03:40 < wumpus> jonasschnelli: I don't see that as a big problem honestly 03:40 < jonasschnelli> Yes. Agree. 03:40 < jonasschnelli> But let me PR the set-of-strings feature work for later usage 03:40 < wumpus> yes, we need a better feature system for the wallet, but it's not urgent 03:41 < sipa> string-based features is a much more clean solution... but the current one works fine as long as versioning is completely serial 03:41 < jonasschnelli> Yes. The optional HDness made it a bit more complex. 03:41 < wumpus> I don't see the-next-feature-will-require-at-least-0.13 as a problem, as that'd likely be the case anyway 03:41 < wumpus> it doesn't force actually using HD does it? 03:41 < sipa> indeed 03:42 < MarcoFalke> Also we don't do feature backports, so it should be easy 03:42 < wumpus> right 03:42 < sipa> wumpus: there is still time for release notes, right? 03:42 < jonasschnelli> If we add another feature, we cannot go bellow FEATURE_HD. So all new features will require HD support. 03:42 < wumpus> #8362 is lacking a rationale: what bug is fixed there? 03:42 < jonasschnelli> We could no longer add features that run with <0.13 03:42 < wumpus> sipa: yes, there is no need to do that before rc1 03:43 < wumpus> jonasschnelli: they require hd *support*, they don't require the wallet to be hd 03:43 < wumpus> jonasschnelli: the latter I would see as a problem, but not this 03:43 < jonasschnelli> Sure. The point is only, that we can't add optional features that would run on 0.12 and below. 03:44 < MarcoFalke> We don't do that? 03:44 < wumpus> we could. Just don't increase the wallet min version? 03:44 < sipa> i'd also like to see 8365 in... but it needs more review/discussion than we can do at this point, i'm afraid 03:44 < jonasschnelli> wumpus: Yes. But you would need to increase it over FEATURE_HD. 03:44 < MarcoFalke> I guess 8365 is not a blocker for rc1? 03:44 < wumpus> jonasschnelli: why? 03:45 < wumpus> you can give it any value, depending on the first version that would be able to cope with it. But aren't features always introduced in the future? 03:45 -!- pedrobranco [~pedrobran@78.130.27.109.rev.optimus.pt] has quit [Remote host closed the connection] 03:45 < sipa> MarcoFalke: i think we've neglected fixing #8079 for some reason, and i don't like needing to say now "sorry, we didn't care enough to fix this bug we accidentally introduced" 03:45 * jonasschnelli is caught in the corner 03:46 < jonasschnelli> I think your right.. 03:46 -!- pedrobranco [~pedrobran@78.130.27.109.rev.optimus.pt] has joined #bitcoin-core-dev 03:47 < jonasschnelli> Yes. Its not a problem. Indeed. 03:47 < wumpus> phew :) 03:47 < wumpus> we shouldn't add any new blockers for rc1 03:47 < wumpus> I'm sure rc2 will be necessary anyhow 03:47 < wumpus> major releases always have long rc cycles 03:47 < wumpus> the sooner we start testing, the better 03:48 < jonasschnelli> Yes. 03:48 < MarcoFalke> agree. There is so much to test 03:48 < wumpus> unless there is a really a critical this-will-crash-everything or security issue, of course 03:48 < MarcoFalke> Neither 8365 nor 8362 are critical 03:50 -!- pedrobranco [~pedrobran@78.130.27.109.rev.optimus.pt] has quit [Ping timeout: 250 seconds] 03:50 < sipa> i think 8362 has actually 0 effect in practice 03:51 < sipa> as GBT does not report the coinbase's sigops, and the 'generateblocks' call ignores it 03:53 -!- sdaftuar_ [uid164573@gateway/web/irccloud.com/x-qmjggnfmzghxpdoy] has joined #bitcoin-core-dev 03:53 < MarcoFalke> ERROR: src/leveldb is not a subtree 03:53 < MarcoFalke> https://travis-ci.org/bitcoin/bitcoin/jobs/145713130 03:53 -!- mn3monic [~guido@176.9.68.68] has joined #bitcoin-core-dev 03:54 < MarcoFalke> weird 03:58 < wumpus> MarcoFalke: travis issue or repository issue? 03:58 < MarcoFalke> Likely a travis issue 03:59 < wumpus> this is git-subtree-check.sh failing on something? 04:01 < wumpus> * [new tag] v0.13.0rc1 -> v0.13.0rc1 04:03 < sipa> $ ./contrib/devtools/git-subtree-check.sh src/leveldb 04:03 < sipa> src/leveldb in HEAD was last updated to upstream commit 20ca81f08fb7fa108923a091668e447dcf5c6b9d (tree 1c185cba2ddcb6a77ece1094bc22aea072db84d1) 04:03 < sipa> src/leveldb in HEAD currently refers to tree 1c185cba2ddcb6a77ece1094bc22aea072db84d1 04:04 < sipa> GOOD 04:04 -!- NicLin [~textual@116.87.237.152] has joined #bitcoin-core-dev 04:05 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:09 * sipa dusts off his gitian skills 04:12 * MarcoFalke googles "release process bitcoin" and copies the commands 04:13 < sipa> should i rebuild base image? 04:14 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [] 04:14 < MarcoFalke> Gitian should handle this? 04:14 < jonasschnelli> Not sure. 04:15 < jonasschnelli> When did we update to Trusty? I guess sipa hasn't used gitian since the 0.12 release. :) 04:15 < sipa> i have a trusty image already 04:15 < sipa> but it's old 04:15 < MarcoFalke> Mine is from Dec 13 04:15 < jonasschnelli> Give it a try. :) 04:15 < sipa> i assume there have been point releases? 04:15 < sipa> already deleted the old one 04:16 < jonasschnelli> Jan 6 2016 base-trusty-amd64.qcow2 04:16 < sipa> hmm qcow2 04:16 < sipa> mine does not have any extension 04:17 < jonasschnelli> No idea why... :) 04:17 < jonasschnelli> https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/ 04:21 < sipa> do i need the mac thing? 04:22 < jonasschnelli> Yes. 04:23 < jonasschnelli> sipa: I'll open you an URL. 04:23 < jonasschnelli> https://bitcoin.jonasschnelli.ch/MacOSX10.11.sdk.tar.gz 04:23 < jonasschnelli> (don't tell Tim Cook) 04:24 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 04:24 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 04:25 -!- achow101 [~achow101@pool-108-2-58-173.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 04:27 < sipa> should i use lxc or not? 04:27 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 04:27 < GitHub180> [bitcoin] jonasschnelli opened pull request #8369: [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" (master...2016/07/wallet_features) https://github.com/bitcoin/bitcoin/pull/8369 04:27 < jonasschnelli> sipa: I use KVM. Never got warm with LXC 04:28 < achow101> yay gitian building 04:28 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 04:28 < sipa> jonasschnelli: the gitian-building.md guide says use lxn 04:28 < sipa> lxc 04:29 < jonasschnelli> Its because wumpus uses LXC and write the doc. :) 04:29 < jonasschnelli> *wrote 04:29 < sipa> ah 04:29 < jonasschnelli> But I think its good if we have build of both worlds. 04:29 < jonasschnelli> *builds 04:29 < sipa> so it should work and result in identical builds? 04:29 < jonasschnelli> Yes. (I hope). 04:29 < jonasschnelli> I always uses KVM and had the same hashes 04:31 -!- AaronvanW [~ewout@28pc230.sshunet.nl] has joined #bitcoin-core-dev 04:31 -!- AaronvanW [~ewout@28pc230.sshunet.nl] has quit [Changing host] 04:31 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:32 < jonasschnelli> MarcoFalke: what do I need to pass to gbuild to use parallelism? I now pass "-j2 --memory 3000" (had crashed with -j5)... but a tripple build takes >80mins. 04:32 < wumpus> yes, KVM and LXC both work, and yield indentical results 04:32 < MarcoFalke> j is default 2 04:32 < jonasschnelli> Okay. I uses -j5 without -memory 3000 in the past... maybe this was the issue. 04:32 < jonasschnelli> There are no other arguments? 04:32 < wumpus> I use LXC because I don't like nesting qemus 04:32 < MarcoFalke> but memory default is 2000, I think 04:33 < MarcoFalke> ./gbuild -help 04:33 < wumpus> I have KVM on an older machine though and last time the gitian build just worked with it 04:33 < jonasschnelli> We should really extend gitian-builder to support ECDSA and add a binary verified to Qt 04:34 < wumpus> LXC is somewhat harder to set up though 04:34 < jonasschnelli> *binary verifier 04:34 < MarcoFalke> wumpus: Why nest. Run it on metal? 04:34 < jonasschnelli> metal? 04:34 < MarcoFalke> no virtual cpu 04:34 < MarcoFalke> the actual hardware 04:35 < jonasschnelli> ah 04:35 < wumpus> MarcoFalke: meh, too much bother - the big machine i have runs tons of VMs, and I don't really want to install anything in the top level 04:35 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 04:37 < MarcoFalke> I wonder how long it would take on my machine if I was using the nested approach 04:37 < wumpus> (of course it would be possible to dual-boot it into something else, for example with an external harddisk, but that means shutting down all other things) 04:37 < sipa> wumpus: you don't use VirtualBox? 04:38 < wumpus> I use virsh (from libvirt), inside there I have a debian VM, and inside that runs LXC with the builder 04:38 < MarcoFalke> But I always populate caches, so it runs quick on the actual tag 04:39 < wumpus> virsh is a bit unwieldy to set up, but nice and efficient if you have lots of VM instances 04:39 < wumpus> it doesn't have a nice user interface like virtualbox 04:40 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 04:40 < achow101> what about vmware? 04:41 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 04:41 < jonasschnelli> achow101: vmware, who knows whats running inside the VM then... :-) 04:41 < jonasschnelli> (or on the host) 04:42 < jonasschnelli> But I have to admit, I'm also using VMWare on my local mac. But for gitian it won't work I guess (at least not with significant fiddling). 04:42 < wumpus> I don't know anything about vmware, last time I used it must be some time in the 90's :) 04:43 < wumpus> but in principle you can run LXC inside *any* kind of virtualization 04:44 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:44 < sipa> ah, kvm does not work inside virtualbox? 04:44 < wumpus> as it simply uses linux' namespacing to keep processes contained, instead of virtualizing actual hardware, it doesn't need any special CPU bits either 04:44 < jonasschnelli> sipa: no. 04:44 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:44 < jonasschnelli> But in VM ware 04:44 < wumpus> sipa: I don't think so; or only with special cpus 04:44 < sipa> jonasschnelli: knowing that would have saved me a lot of time :) 04:44 < jonasschnelli> sipa: AFAIK VirtualBox has no native KVM support 04:45 < jonasschnelli> sipa: you didn't asked. :) 04:45 < wumpus> there is something as 'nested virtualization' , but I have no idea what supports it 04:45 < sipa> i was just following the guide, and you said KVM worked fine :) 04:45 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 04:45 < wumpus> you can also disable the CPU virtualization completely and use x86 emulation, but then compiling will likely take a year or so :-) 04:45 < jonasschnelli> sipa: I just run gitian-builder on my host 04:46 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 04:46 < jonasschnelli> I don't care about running in host mode because it's in a remote servercenter anyways. 04:47 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 04:48 < achow101> if anyone cares, here's a script I made for gitian building: https://gist.github.com/achow101/1bdd85cd4934b61a373d 04:49 < jonasschnelli> achow101: nice. I won't publish mine. It's a hell of a mess! 04:50 < wumpus> yes it looks better than my set of hacks too :) 04:50 < jonasschnelli> I had to add some html / apaxy hacks to get the html pages up: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/ 04:50 < jonasschnelli> Also it copies around the build.log, etc. 04:51 < jonasschnelli> achow101 looks pretty nice. You could also add support for building a PR and optional disable platforms... 04:51 < wumpus> especially copying the result immediately after the build can avoid a lot of annoyance, is my experience 04:52 < achow101> jonasschnelli: how does building from a PR work? 04:52 < wumpus> my script does automatically copy files which should be uploaded (and rename where necessary), and creates a SHA256SUMS. Although this will need to be updated for 0.13, with the new naming for the linux files, thinking of it. 04:53 < jonasschnelli> achow101: my scripts does something like: /bin/gbuild "+gbuildadd+" --commit signature="+VERSIONCOMMIT+" 04:53 < sipa> wumpus: ah, yes, i'll need to update my script as well... 04:53 < jonasschnelli> stuff like: --url bitcoin="+giturl+" 04:53 * sipa thinks we should ship such a script inside contrib/ ... 04:53 < jonasschnelli> *me agrees with sipa 04:53 * jonasschnelli looks over to achow101 04:54 < wumpus> yes possibly, mine is too hacky and specific to my setup to upload though 04:54 < wumpus> e.g. I don't have the GPG keys on the machine that builds, for example 04:54 -!- harrymm [~wayne@178.162.214.48] has quit [Remote host closed the connection] 04:55 < jonasschnelli> achow101: also check: https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#building-an-alternative-repository 04:56 < achow101> jonasschnelli: thanks. 04:56 < wumpus> the rest is pretty much just copy/paste from the release notes. So at some point the script needs to be customized that much before it's useful, that providing an example isn't much more useful than just pointing at the release notes :) 04:56 < wumpus> yes --url bitcoin=${URI} --commit bitcoin=${COMMIT} can be very useful. You can also use local paths. 04:59 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 05:03 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 05:06 -!- YOU-JI [~youyouyou@FL1-125-195-44-154.chb.mesh.ad.jp] has joined #bitcoin-core-dev 05:08 < jonasschnelli> linux build complete: hashes to compare: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/ 05:09 < jonasschnelli> 19499e5a569d5d8685a043bf3e5cf9d34450733333295b636af84d7a2589d881 bitcoin-0.13.0-x86_64-linux-gnu.tar.gz 05:09 < jonasschnelli> all: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/bitcoin-linux-0.13-build.assert 05:09 < wumpus> all match with my build, even the ARM ones 05:15 < wumpus> windows build: http://www.hastebin.com/luwelodopa 05:19 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 05:20 < achow101> how big should I make -j and -m to make it build faster? 05:22 < sipa> -j: not more than you have cpu cores 05:22 < sipa> -m: something like 1500 times the number you pass to j 05:22 < sipa> but -m also not more than the physical memory you have in your vm 05:26 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 05:28 < kinlo> -j should be a bit higher then cores right? you usually end up with processes waiting for disk and not utilizing cpu, so oversubscribing a bit should increase speed 05:29 < sipa> i've tried various numbers between 5 and 10 (i have 4 core, 8 threads), but it doesn't seem to matter much for overall compilation speed 05:29 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 05:31 < wumpus> kinlo: I usually use cores+1 for that reason, but haven't benchmarked wether it is any faster 05:32 < sipa> my gitian build scripts seems to use -j 4 -m 8000 05:32 < sipa> but no idea how those numbers came about 05:32 < wumpus> compiling bitcoin is quite CPU intensive, so the i/o overhead may be very little in comparison, it may not be the same for every project 05:33 < wumpus> e.g. for a project such as tor with tons of C files that compile very quickly, I think using -j >> cores will achieve more, as all those gcc's spend a relatively large part of their lifespan accessing disk 05:35 < kinlo> I usually only compile the kernel, noticed speedups there but indeed, makes sense... 05:36 < wumpus> kernel is similar 05:37 < achow101> I set my -j to double the cores I have. I don't know whether that makes a significant difference though 05:37 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 05:42 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 05:45 < jonasschnelli> match with wumpuses windows hashes: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/bitcoin-win-0.13-build.assert 05:47 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 05:51 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 06:01 -!- sdaftuar_ [uid164573@gateway/web/irccloud.com/x-qmjggnfmzghxpdoy] has quit [Quit: Connection closed for inactivity] 06:05 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 06:19 -!- face_ [~face@mail.hmel.org] has joined #bitcoin-core-dev 06:21 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:22 -!- NicLin [~textual@116.87.237.152] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 06:28 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:31 < achow101> linux build finally done. Matches wumpus and jonasschnelli hashes 06:32 < jonasschnelli> Nice! 06:32 < sipa> still going here... 06:35 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 06:38 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 06:39 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 06:41 < btcdrak> isnt -m deprecated and ignored now? 06:41 < sipa> on lxc it has no effect i think 06:41 < btcdrak> according to man pages it's ignored 06:41 < btcdrak> (GNU Make 4.0) 06:42 < sipa> it's a parameter to gbuild 06:42 < btcdrak> ah 06:44 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 06:48 -!- YOU-JI [~youyouyou@FL1-125-195-44-154.chb.mesh.ad.jp] has quit [Quit: Leaving...] 06:57 < GitHub182> [bitcoin] jonasschnelli opened pull request #8371: [Qt] Add out-of-sync modal info layer (master...2016/07/UI-out-of-sync) https://github.com/bitcoin/bitcoin/pull/8371 06:58 < MarcoFalke> looks neat 07:00 -!- NicLin [~textual@116.87.237.152] has joined #bitcoin-core-dev 07:01 < jonasschnelli> would be cool if this modal info layer would have two sliders: one for dbcache mem, one for CPU (-par) 07:03 < MarcoFalke> how come the mac mismatches? 07:03 < MarcoFalke> https://github.com/bitcoin-core/gitian.sigs/pull/359#issue-166339496 07:05 < MarcoFalke> three builders, three different bitcoin-0.13.0-osx-unsigned.tar.gz 07:05 < achow101> that's a problem isn't it 07:07 < jonasschnelli> hmm.. 07:08 < jonasschnelli> Yes. OSX build are non-deterministic... 07:08 * jonasschnelli ringing the cfields alarm bell 07:10 < jonasschnelli> Hmm.. on my end I have some strange Qt5.5 packages: https://github.com/bitcoin-core/gitian.sigs/blob/master/0.13.0rc1-osx-unsigned/jonasschnelli/bitcoin-osx-0.13-build.assert#L808 07:10 < jonasschnelli> maybe issue with the cache 07:11 < MarcoFalke> Is it due to my depends faketime patch? 07:12 -!- NicLin [~textual@116.87.237.152] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 07:14 < jonasschnelli> MarcoFalke: could be. But I think more likely my Qt5.6 PKGConfig hacking patch 07:15 -!- NicLin [~textual@116.87.237.152] has joined #bitcoin-core-dev 07:21 < MarcoFalke> but bdb is a mismatch as well? You didn't fiddle with this 07:24 -!- NicLin [~textual@116.87.237.152] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 07:25 < jonasschnelli> I guess mismatches are okay in the packages... 07:27 < MarcoFalke> right 07:31 -!- haakonn [~haakonn@pdpc/supporter/active/haakonn] has quit [Max SendQ exceeded] 07:31 -!- so [~so@unaffiliated/so] has quit [Max SendQ exceeded] 07:31 -!- trippysalmon [~trippy@cyberdynesys.org] has quit [Max SendQ exceeded] 07:31 -!- limpkin [sid20909@gateway/web/irccloud.com/x-yyqdngnvlzgfnwqi] has quit [Max SendQ exceeded] 07:31 -!- dirtynewshoes [~dirtynews@sydnns0115w-156057252148.dhcp-dynamic.FibreOp.ns.bellaliant.net] has quit [Max SendQ exceeded] 07:31 -!- helo [~helo@unaffiliated/helo] has quit [Max SendQ exceeded] 07:31 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Max SendQ exceeded] 07:31 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Max SendQ exceeded] 07:31 -!- Cory [~C@unaffiliated/cory] has quit [Max SendQ exceeded] 07:31 -!- BonyM [~BonyM-I@ua-83-227-211-4.cust.bredbandsbolaget.se] has quit [Max SendQ exceeded] 07:31 -!- helo [~helo@unaffiliated/helo] has joined #bitcoin-core-dev 07:31 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-pembnhmtevagqsfy] has quit [Max SendQ exceeded] 07:31 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Max SendQ exceeded] 07:31 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has quit [Max SendQ exceeded] 07:32 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Max SendQ exceeded] 07:32 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-umprapwslhdrzvbw] has quit [Max SendQ exceeded] 07:32 -!- zxzzt [~prod@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Max SendQ exceeded] 07:32 -!- sanada [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [Max SendQ exceeded] 07:32 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 07:32 -!- Arnavion [~Arnavion@unaffiliated/arnavion] has quit [Max SendQ exceeded] --- Log closed Tue Jul 19 07:32:41 2016 --- Log opened Tue Jul 19 07:33:16 2016 07:33 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 07:33 -!- Irssi: #bitcoin-core-dev: Total of 131 nicks [0 ops, 0 halfops, 0 voices, 131 normal] 07:33 -!- sanada [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 07:33 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 07:33 -!- binns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev 07:33 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Ping timeout: 260 seconds] 07:33 -!- squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 07:33 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:33 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 07:33 -!- AtashiCon [~Arnavion@unaffiliated/arnavion] has quit [Quit: AtashiCon] 07:33 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-hfmuacmpeaniwfwq] has joined #bitcoin-core-dev 07:33 -!- dirtynewshoes [~dirtynews@sydnns0115w-156057252148.dhcp-dynamic.FibreOp.ns.bellaliant.net] has joined #bitcoin-core-dev 07:33 -!- AtashiCon [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 07:34 -!- zmanian__ [sid113594@gateway/web/irccloud.com/x-wcyrstgerdmymtrp] has joined #bitcoin-core-dev 07:34 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 07:34 -!- limpkin [sid20909@gateway/web/irccloud.com/x-jfqkbkiluxahzdqx] has joined #bitcoin-core-dev 07:34 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-frpzmxgdbudnnucx] has joined #bitcoin-core-dev 07:34 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:34 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-nzugzsawclgpjbfh] has joined #bitcoin-core-dev 07:34 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-csjodsspivzyrwkg] has joined #bitcoin-core-dev 07:34 -!- Cory [~C@unaffiliated/cory] has joined #bitcoin-core-dev 07:35 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 07:35 -!- BonyM [~BonyM-I@ua-83-227-211-4.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 07:36 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 07:36 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 07:36 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 07:36 -!- trippysalmon [~trippy@cyberdynesys.org] has joined #bitcoin-core-dev 07:36 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 07:37 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 07:37 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 07:39 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 07:40 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 07:43 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev 07:43 -!- Irssi: Join to #bitcoin-core-dev was synced in 657 secs 07:45 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 07:45 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 07:51 -!- alpalp [d86e4bba@gateway/web/cgi-irc/kiwiirc.com/ip.216.110.75.186] has joined #bitcoin-core-dev 07:56 < achow101> Also have an OSX mismatch 07:58 -!- alpalp [d86e4bba@gateway/web/cgi-irc/kiwiirc.com/ip.216.110.75.186] has left #bitcoin-core-dev [] 07:58 -!- NicLin [~textual@116.87.237.152] has joined #bitcoin-core-dev 07:59 < GitHub185> [bitcoin] UdjinM6 opened pull request #8372: Fix AddRef() usage for CNode (master...fixNodeRefCount) https://github.com/bitcoin/bitcoin/pull/8372 07:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:06 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 08:09 -!- NicLin [~textual@116.87.237.152] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 08:10 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev 08:10 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host] 08:10 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 08:12 -!- AtashiCon [arnavion@unaffiliated/arnavion] has quit [Quit: AtashiCon] 08:19 -!- AtashiCon [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 08:21 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has joined #bitcoin-core-dev 08:23 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 08:23 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 08:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:26 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 08:27 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 08:31 -!- so [~so@unaffiliated/so] has joined #bitcoin-core-dev 08:33 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 08:33 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 08:33 -!- haakonn [~haakonn@pdpc/supporter/active/haakonn] has joined #bitcoin-core-dev 08:35 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 08:35 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 08:38 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 08:39 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 08:42 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 08:42 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 08:44 -!- harrymm [~wayne@37.58.59.76] has joined #bitcoin-core-dev 08:44 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 08:44 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 08:47 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 08:47 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 08:47 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 08:48 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 08:48 -!- Samdney [~Samdney@nat-wlan2.rrze.uni-erlangen.de] has quit [Ping timeout: 276 seconds] 08:49 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 08:50 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 08:59 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 09:00 < michagogo> Could someone please paste a `git diff v0.12.1..v0.13.0rc1 doc/release-process.md`? 09:00 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 09:05 < MarcoFalke> http://pastebin.ubuntu.com/20051707/ 09:06 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [] 09:07 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 09:13 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 09:14 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection] 09:15 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 09:15 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Client Quit] 09:15 < wumpus> jonasschnelli: aren't the osx-unsigned always non-deterministic? cfields can confirm this, but I remember something like that 09:17 < cfields> wumpus: mm, i don't believe so. 09:18 < cfields> internet was down this morning, building now. 09:19 < gmaxwell> [semi-OT for this channel] https://www.reddit.com/r/Bitcoin/comments/4tly0n/blockstream_announces_an_open_patent_pledge_and/ 09:20 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 09:21 < michagogo> MarcoFalke: thanks! 09:21 < cfields> wumpus / jonasschnelli / achow101: could one of you make your osx build results available for comparison? I'm building now, not sure exactly what to ask for in particular yet. 09:31 < jonasschnelli> cfields: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/ 09:31 < jonasschnelli> And there are two signatures in the gitian sigs repo. 09:31 < jonasschnelli> Plus MarcoFalkes PR (also OS X sig) 09:32 < cfields> jonasschnelli: great, thanks. 09:41 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 09:41 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 09:41 < michagogo> My builds are dubbing now 09:41 < michagogo> Running 09:41 < michagogo> (Qt rebuild :-( ) 09:41 < achow101> cfields: everything I built is at https://github.com/achow101/bitcoin/releases/tag/v0.13.0rc1. sigs have been PR'ed 09:42 < cfields> achow101: thanks 09:43 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 09:44 -!- Samdney [~Samdney@dyn-ant666999.hawo.ipv6.uni-erlangen.de] has joined #bitcoin-core-dev 09:45 < cfields> jonasschnelli: hmm, our end-result osx binaries are the same, despite the different tarball hashes. I'm thinking it might just be timestamps in .tar's or so 09:45 < cfields> looking deeper now. 09:48 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 09:50 < cfields> whoops, nm. the osx64.tar.gz is the same for everyone. 09:52 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds] 09:53 < michagogo> Wait, we bumped the SDK? 09:53 < MarcoFalke> jup 09:53 < michagogo> :-/ 09:54 * michagogo looks up details 09:55 < cfields> achow101 / jonasschnelli: either of you have the bitcoin-0.13.0-osx-unsigned.tar.gz available? 09:56 < achow101> cfields: is that file supposed to be produced? I don't see it 09:56 < cfields> achow101: your script probably automatically moves it to gitian/inputs 09:57 < michagogo> (I'm still not used to having things like my browser launch instantaneously...) 09:59 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 09:59 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 09:59 < achow101> cfields: found it (I think) and uploaded to the page I linked earlier 09:59 < cfields> achow101: thanks 10:02 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 10:02 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 10:05 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 10:06 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 10:08 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 10:08 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 10:10 < jl2012> to build for osx, should I just put the MacOSX10.11.sdk.tar.gz to the inputs directory? 10:10 < achow101> jl2012: yes 10:10 < jl2012> thanks 10:19 < sdaftuar> sipa: in #8365 i noticed you didn't change the rpc handlers to output the sigops-adjusted-vsize. was that intentional? looks like the mempool rpc's would do the right thing, but decoderawtransaction would report unadjusted vsize 10:20 < cfields> aha, found the difference 10:20 < cfields> looks like the DS_Store generator isn't deterministic somehow. mine doesn't match achow101's 10:21 < sipa> sdaftuar: it's intentional, but i'm not sure what the best approach is 10:21 < MarcoFalke> You can also run twice and it doesn't match 10:21 < achow101> cfields: so how is that fixed? 10:22 < cfields> achow101: looking now to see how/why it differs 10:22 < sdaftuar> sipa: seems like the cleanest thing would be for vsize to our policy-adjusted vsize, and for us to add a field to the output which is the transaction weight 10:23 < sipa> sdaftuar: the difficulty is determining the sigops... 10:23 < sipa> for wallet txn 10:23 < sipa> for raw transactions it's just impossuble 10:24 < sdaftuar> i was thinking that there's an ambiguity for things that are in our mempool, but right i see your point 10:25 < sipa> i'd rather try to make sure we never produce transactions ourselves for which it has an effect :) 10:27 < sdaftuar> yeah, that might work fine for the wallet code. i'm a little worried that the approach of having two different sizes we use, a policy size and an actual size, will be error prone in the future. 10:27 < sdaftuar> so i was just trying to go through and identify every usage to make sure it made sense 10:29 < sdaftuar> seems like if we do end up eventually changing bytespersigop to 50, it'll be easy for wallet users to accidentally generate transactions that are affected by the policy 10:29 < sdaftuar> if you have a bunch of p2pkh outputs, you'll hit it 10:31 < sipa> really? 10:31 < sipa> signatures are 72 bytes 10:32 < sdaftuar> outputs -- legacy sigop count will get you 10:33 < sdaftuar> for instance, i found this tx, which is a bit extreme, but illustrates the point: https://www.blocktrail.com/BTC/tx/c9daddde3379f16e11a547b34e9723c7b5ca71c82bf1213fc93bf13d81cd601f 10:34 < sdaftuar> that's the one i found with sigop cost of 9644 10:37 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 10:45 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 10:50 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 11:00 -!- pedrobra_ [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 11:00 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:01 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 11:05 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Ping timeout: 276 seconds] 11:10 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 11:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:30 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 11:32 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 11:35 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 264 seconds] 11:37 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 11:37 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 11:38 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 11:39 -!- cryptapus [~cryptapus@87.254.202.247] has joined #bitcoin-core-dev 11:39 -!- cryptapus [~cryptapus@87.254.202.247] has quit [Changing host] 11:39 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 11:46 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 11:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:51 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 12:03 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 12:03 -!- mkarrer [~mkarrer@142.red-83-47-107.dynamicip.rima-tde.net] has quit [] 12:06 -!- mkarrer [~mkarrer@142.red-83-47-107.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 12:11 < BlueMatt> wumpus: needed a fix for "I think IsKeyType should be changed to include hdchain, not add an explicit hdchain check in ::Recover, since we probably definitely want it in ::LoadWallet as well." first 12:11 < BlueMatt> that is very bad behavior 12:12 < BlueMatt> oh, you already tagged rc1...ugh 12:17 < BlueMatt> wumpus: also you merged 8367 without fixing the bug I pointed out in it.......... 12:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:19 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 12:21 < gmaxwell> BlueMatt: open a PR to fix it. your "not that it really matters" might have understated your expectation that it would get fixed. 12:21 < BlueMatt> I mean I figured it'd get fixed before merge, even if its not a huge deal 12:27 < sipa> BlueMatt: i'm sure there'll be a second rc anyway 12:27 < sipa> i guess wumpus wanted to get an rc out to get testing from a wider audience 12:27 < gmaxwell> we're seriously late on the RC. It was good to get one out. 12:27 < cfields> i think i have the osx determinism issue worked out. any gitian builders around to verify? 12:28 < BlueMatt> yeayea, I'm not suggesting anything is gonna catch fire, just saying there are a few things here to fix for rc2 12:28 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer] 12:31 < MarcoFalke> The check is dead code and the strings in the exceptions need the function names adjusted ... 12:31 < MarcoFalke> It is good to have rc1 out. We can fix those later 12:32 < MarcoFalke> cfields: I can try 12:32 < cfields> MarcoFalke: ok. tested by hand, plugging it all in now. ready in ~10min 12:32 < MarcoFalke> Is it just a descriptor bump or do we need rc2 already? 12:33 < achow101> cfields: I can try it too 12:34 < cfields> MarcoFalke: i'll leave it up to wumpus. it's the .DS_Store, which is inconsequential and has no influence on the binary. but it means that gitian results won't match. 12:34 < michagogo> Got the new SDK -- my rc1 is building right now 12:39 < luke-jr> did we bump ds_store Python or smth? O.o 12:44 < GitHub16> [bitcoin] theuni opened pull request #8373: Fix OSX non-deterministic dmg (master...biplist-determinism) https://github.com/bitcoin/bitcoin/pull/8373 12:47 < luke-jr> ahh 12:48 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 12:51 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection] 12:52 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 12:54 < cfields> luke-jr: think there's any way to post-process an existing ds_store with unsorted plists inside so that we can just fix it up in the gitian descriptor for rc1? 12:55 < luke-jr> I would imagine so, but meh? :/ 12:55 < cfields> luke-jr: otherwise i don't think i can sign rc1 12:58 < luke-jr> cfields: can DS_Store do anything malicious? why not just compare the binaries without it? 12:58 < cfields> hmm, i guess that's not right. that file's outside of the .app, so i suppose it's not signed at all 12:59 < luke-jr> right 13:00 < luke-jr> so it's not a technical issue AFAIK, just potentially philosophical 13:01 < cfields> yep. i guess a few builders could manually fixup inside gitian to force an order, then at least there's a reference for a matching hash 13:02 < cfields> but yes, since it's not signed data and everyone's binaries should match, i'll carry on signing as usual 13:03 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds] 13:04 < michagogo> If you push the sigs before my script finishes running, it should grab them and generate sigs for the -signeds too 13:04 < michagogo> (I'm going to sleep now, but the PR should be pushed automatically) 13:08 < GitHub18> [bitcoin] sdaftuar opened pull request #8374: Add release notes for mining changes (0.13...release-notes-mining) https://github.com/bitcoin/bitcoin/pull/8374 13:08 < cfields> michagogo: great, thanks 13:11 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Read error: Connection reset by peer] 13:12 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 13:12 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Client Quit] 13:14 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 13:20 < achow101> Finished my build with cfields patch 13:20 < achow101> 9fa6b31128eee2cfa535774fe4eebaa384f0471c094ce6ee6aefe9aef93f134b bitcoin-0.13.99-osx-unsigned.dmg 13:20 < achow101> e2e33efea3d2c86d34391b3be20d032343b359909cdbe55b1153ba109ae5af4f bitcoin-0.13.99-osx-unsigned.tar.gz 13:20 < achow101> fc5a233b3be260ec7be63f699bbc128240ad190692cd5d4a82cc1352eb3c57df bitcoin-0.13.99-osx64.tar.gz 13:20 < achow101> 0269f915640886ba16c73450ab2dbcdde0304fa79807414c7e0cf4d4ba8f39df src/bitcoin-0.13.99.tar.gz 13:20 < achow101> ab0a5e271e81fb48cf355f866a105eca12713260e703da35330ae66e03336367 bitcoin-osx-0.13-res.yml 13:22 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 13:26 < MarcoFalke> achow101: You applied the patch on the gitian vm? 13:26 < achow101> yes 13:28 < MarcoFalke> cfields: Let us know if signing the binaries worked out for you 13:31 * luke-jr ponders how to best get P2SH^2 deployed. 13:31 < luke-jr> at least bloated spam discourages miners from including it 13:33 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:42 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 13:44 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 13:44 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 13:45 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 13:45 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 13:46 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 13:49 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 13:52 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 13:54 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 13:56 < cfields> MarcoFalke: will do, still working on it. 13:56 < MarcoFalke> great 13:57 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Ping timeout: 240 seconds] 13:58 < achow101> ran the build again and got the same results 13:59 < cfields> achow101: to clarify, you're testing master now, right? 13:59 < achow101> yes 14:00 < cfields> ok 14:04 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 14:07 -!- spudowiar1 [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 14:08 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Ping timeout: 244 seconds] 14:11 -!- spudowiar2 [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 14:13 -!- spudowiar1 [~spudowiar@unaffiliated/spudowiar] has quit [Ping timeout: 272 seconds] 14:15 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 14:20 < cfields> 0.13.0rc1 sigs pushed. 14:21 < cfields> achow101: building master with that PR on top now. thanks for doing that so quickly :) 14:24 < cfields> achow101: actually, before i build, could you specify the commit you built? Not sure if you cherry-picked or merged, and that'll change the result 14:26 < achow101> I grabbed the diff and applied it. 14:26 < achow101> probably wasn't the right thing to do, but i was being lazy 14:29 -!- spudowiar2 [~spudowiar@unaffiliated/spudowiar] has quit [Ping timeout: 272 seconds] 14:29 < cfields> achow101: mm, i don't think i'm going to be able to match your result, then 14:29 < achow101> err. actually I think I just built your branch. I was originally just going to use the diff but I screwed something up 14:30 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 14:31 < cfields> 3b3ce25df6cc, then? 14:31 < achow101> yes 14:32 < cfields> ok great, building that. 14:36 < phantomcircuit> jonasschnelli, i rebased 8152 can you review again 14:45 < phantomcircuit> jonasschnelli, why does CHDKeyStore::PrivateKeyDerivation take the keypath as a string? 14:50 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 14:55 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 15:08 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:16 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: zzzzzzz] 15:31 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection] 15:32 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 15:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:36 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 276 seconds] 15:40 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 15:51 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 15:53 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 15:56 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 16:15 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 16:20 < Chris_Stewart_5> Is nFilterBytes suppose to be a compact sized unsigned integer on this documentation? https://bitcoin.org/en/developer-reference#filterload 16:22 < phantomcircuit> Chris_Stewart_5, the docs there are literally wrong 16:22 < phantomcircuit> the literal serialization is 16:22 < phantomcircuit> serialized vector of uint8_t 16:22 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 16:23 < sipa> phantomcircuit: the docs always make lengths of vectors explicit 16:23 < phantomcircuit> uint32_t nhashfuncs, uint32_t ntweak, uint8_t nflags 16:23 < phantomcircuit> sipa, either way it's missing ntweak entirely 16:23 < sipa> ah 16:23 < sipa> eh, no? 16:23 < phantomcircuit> oh no it's not 16:23 < phantomcircuit> what 16:23 < Chris_Stewart_5> nTweak is there, is there suppose to be a tweak along with it? 16:23 < phantomcircuit> oh the weird warning makes it look like there's nothing below the fold 16:24 < sipa> Chris_Stewart_5: to answer your first question: yes 16:24 < phantomcircuit> yeah nvm it's right 16:24 < sipa> it's a compact integer 16:26 < Chris_Stewart_5> I've had issues even trying to find the classes/structs that correspond to some of these messages, where can I find the actual message structure in core? 16:26 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 244 seconds] 16:27 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 16:28 < Chris_Stewart_5> If I do a search I find references to 'FilterLoad' for instance in main.cpp, protocol.cpp and protocol.h but no class or struct, unless i'm missing something obvious 16:29 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 16:30 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 16:30 < sipa> else if (strCommand == NetMsgType::FILTERLOAD) 16:30 < sipa> { 16:30 < sipa> CBloomFilter filter; 16:30 < sipa> vRecv >> filter; 16:30 < sipa> CBloomFilter is defined in bloom.h 16:31 < Chris_Stewart_5> and there is some ffunction defined in CBloomFilter to deserialize the DataStream? 16:33 -!- jiggalator is now known as netsin 16:35 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 16:36 < Chris_Stewart_5> I'm just following the stack and it seems like we go from streams.h -> serialize.h which starts parsing the varint, but I don't see where the contents are explicitly passed to a constructure or anything 16:36 < Chris_Stewart_5> is there some C++ convention going on here? 16:36 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 16:37 < sipa> there is a lot of magic in serialize.h 16:38 < sipa> ADD_SERIALIZE_METHODS expands into the necessary serialization boilerplate 16:39 < Chris_Stewart_5> oh ok. Does it use some sort of reflection to call the necessary constructors? 16:39 < sipa> there are no constructors inbolved 16:39 < sipa> the constructor of CBloomFilter is invoked on the line where filter is declared 16:40 < sipa> the 'vRecv >> filter' just reads data from vRecv stream and fills filter with it 16:42 < Chris_Stewart_5> and this 'fill' function is defined in ADD_SERIALIZE_METHODS? 16:44 < GitHub8> [bitcoin] pstratem opened pull request #8375: Move key derivation logic from GenerateNewKey to DeriveNewKey (master...2016-07-19-cwallet-derivenewkey) https://github.com/bitcoin/bitcoin/pull/8375 16:44 < sipa> yes, it's called Deserializr 16:44 < sipa> Deserializr 16:45 < sipa> grr, stupid keyboard 16:45 < sipa> Deserialize 16:45 < Chris_Stewart_5> Your 'e' key wants you to go to sleep :-). Thanks sipa 16:50 < phantomcircuit> i think it's easier to read that way ^ 16:53 -!- Giszmo1 [~leo@ppp-83-171-187-230.dynamic.mnet-online.de] has quit [Ping timeout: 258 seconds] 16:54 -!- fengling [~fengling@58.135.95.135] has joined #bitcoin-core-dev 17:02 -!- Giszmo [~leo@ppp-83-171-187-230.dynamic.mnet-online.de] has joined #bitcoin-core-dev 17:08 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 17:16 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0.1/20160623154057]] 17:17 -!- NicLin [~textual@116.87.237.152] has joined #bitcoin-core-dev 17:25 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-uefecpeazkuppbfq] has quit [Quit: Connection closed for inactivity] 17:32 < gmaxwell> luke-jr: so whats the deal with this sigops checking thing. Help me understand your position. 17:33 < luke-jr> gmaxwell: does the comment I just posted help? or is there still confusion on it? 17:33 < luke-jr> (literally seconds ago) 17:34 * gmaxwell goes to read 17:35 -!- fengling [~fengling@58.135.95.135] has quit [Ping timeout: 240 seconds] 17:38 < GitHub99> [bitcoin] pstratem opened pull request #8376: Fix exception message to reference actual thrower. (master...2016-07-19-cwallet-sethmasterkey) https://github.com/bitcoin/bitcoin/pull/8376 17:39 < gmaxwell> okay, I see. We probably should make bare multisig non-standard, but it would be inadvisable to do that without a lot of notice and time. 17:40 < gmaxwell> It shouldn't be done accidentally on the sly via another fix. 17:40 < luke-jr> sure, I consider bare multisig policy entirely unrelated to these 2 PRs 17:40 < CodeShark> what's bare multisig? 17:41 < luke-jr> I think both PRs should be merged (once sipa's is updated to not remove the current bytespersigop) 17:41 < luke-jr> CodeShark: multisig without p2sh 17:41 < sipa> luke-jr: my PR does not remove -bytespersigop 17:41 < luke-jr> CodeShark: accidentally broken in 0.12, fixed in #8364 17:41 < luke-jr> sipa: it removes the current bytespersigop and adds a new one that does soemthing different. 17:42 < gmaxwell> luke-jr: okay, so if we're ordering transactions by the resources they actually use, and we'll make bare multisig non-standard via another path-- then why do we need bytespersigop? 17:42 < luke-jr> gmaxwell: for its original purpose: to filter spam misusing multisig 17:43 < gmaxwell> well what kind of spam? people trying to store lots of data don't have a problem having more bytes. 17:44 < gmaxwell> If someone is trying to burn signature operations, we're protected by the sigops limit and protected by the fact that sigops limit burning transactions have to pay as much fees as a set of ordinary txn that burns as many sigops. 17:45 < luke-jr> the "make tx take long to check" kind that has an old CVE I can't lookup because the wiki is apparently down(!) :/ 17:45 < luke-jr> nm, finally loaded: CVE-2013-2292 17:46 < luke-jr> and apparently there's some kind of spam that dex guy wants to abuse it for as well 17:47 -!- fengling [~fengling@58.135.95.135] has joined #bitcoin-core-dev 17:47 < gmaxwell> yes, but the dex guy won't get hit by the current limit, he may be too ignorant to realize this. 17:47 < luke-jr> simply saying "pay a higher fee" sends the message that the spam is encouraged; at least by padding people can't claim that 17:48 < gmaxwell> luke-jr: so the n minutes to verify thing is stopped by the maximum standard transaction size being 100k. It's a sighash gringing bug. You actually don't want small transactions to trigger that. 17:48 < gmaxwell> luke-jr: in particular they pay as much (or likely more) fee than doing the attack with more ordinary looking transactions. 17:48 -!- netsin [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection] 17:48 < gmaxwell> So the abusive use really isn't help, abusers will adapt to do whatever works best for them. 17:49 -!- alpalp [~allen@2605:6000:f4d6:d600:f8b5:2db5:b615:441b] has joined #bitcoin-core-dev 17:49 -!- alpalp [~allen@2605:6000:f4d6:d600:f8b5:2db5:b615:441b] has quit [Changing host] 17:49 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 17:49 < luke-jr> gmaxwell: how do we avoid people looking at this change and saying "see? as long as I pay the higher fee, I have a right to spam" ? 17:49 < gmaxwell> and we are currently left with bare multisig users that, we know know, have problems reliably producing transactions under this policy. 17:49 -!- netsin [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 17:49 < luke-jr> gmaxwell: #8364 entirely fixes the current problem 17:50 < gmaxwell> luke-jr: by stating it outright that it's not intended to enable transactions that store unrelated data in the blockchain or intentionally waste resources. 17:50 < gmaxwell> E.g. we could release note that. 17:50 < luke-jr> like we did with OP_RETURN? 17:50 < luke-jr> we all know how that turned out.. 17:50 < gmaxwell> luke-jr: but it adds a lot of code that is non-obvious in its exeuction and application.. and which transacting parties should have to model themselves to know if they pass the test or don't. 17:51 < luke-jr> huh? #8364 would fix the bug so transacting parties are never affected 17:51 < luke-jr> (sipa's change would probably do that, though) 17:52 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 17:52 -!- justanot1eruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:52 < gmaxwell> Yea, I think sipa's change is necessary and sufficient. and 8364 might be okay, but it's more complexity with potential surprise consequences, which at best I wouldn't want to rush out with. 17:53 < gmaxwell> and I think it's not actually needed, except in terms of making it clear that we don't support people storing arbritary non-transaction data in the blockchain. 17:53 < luke-jr> what potential surprise consequences? it's a simple bugfix to existing released code, that only allows more transactions that were false-positives 17:53 < luke-jr> re needed or not: keep in mind miners set their own policies, and the defaults of (eg) disabling bare multisig can be overridden 17:54 -!- netsin [~jiggalato@unaffiliated/jiggalator] has quit [Ping timeout: 258 seconds] 17:54 < luke-jr> miners might want to continue mining bare multisig after defaults change, yet not open this attack risk 17:54 < sipa> we're really talking about different problems 17:54 -!- justanot1eruser is now known as justanotheruser 17:54 < luke-jr> if de facto we end up in a situation where nobody is mining multisig, I guess that'd be a good time to remove the current bytespersigop.. but that's 0.14 at the earliest unless miners change it manually AIUI 17:54 < sipa> you're concerned about sending an unintentional signal that high-sigop transactions are ok 17:55 < sipa> i'm concerned about blocks being filled with garbage 17:55 < gmaxwell> s/are okay/are okay if you pay some market fee/ 17:55 < sipa> i think people will use whatever means necessary to store data in the chain, and saying that this must be stopped for the system to succeed is being blind for reality 17:56 -!- netsin [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 17:56 < sipa> however, we do now actually have a fee market 17:56 < gmaxwell> I can write some release note text that says that the network capacity is a shared resource and that just because a usecase is technically possible it doesn't mean that it's an intentionally supported usecase. 17:56 < luke-jr> sipa: if reality is they will, then reality is highly against Bitcoin surviving 17:56 < CodeShark> sipa: I agree - we should not be deciding use cases, only working to ensure incentives don't get out of whack 17:57 < sipa> luke-jr: and policy (and even consensus rules) can be proposed to combat certain behaviour that damages shared resources 17:57 < luke-jr> miners are less likely to mine spam-padded-to-bypass-spam-limits than spam-just-paying-a-higher-fee IMO 17:57 < luke-jr> intentionally* 17:57 < gmaxwell> luke-jr: yea, slightly,-- which is the argument against ltc like 'dust' limits. But it's a minor detail at this point. 17:58 < sipa> but 8364 on itself would allow high-consensus-sigop low-accurate-sigops transactions into blocks, allowing anyone on the network to fill a block with garbage for 1/20th of the market price 17:58 < gmaxwell> They're more likely to do harmful self-profiting things rather than long term community benefiting things if the defaults are so out of wack that they get encouraged by people to change them. 17:58 < sipa> that is a directly exploitable bug we'd be shipping in our mining code 17:59 < sipa> and much more serious than a worry about a potentially misinterpreted signal _to people who are already using it anyway_ 17:59 < luke-jr> what justification is there to exclude/replace the current bytespersigop this close to release? it does no harm at worst (especially if sipa's policy change is also included) 17:59 < gmaxwell> not just exploitable, previously actively exploited. 17:59 < luke-jr> sipa: I'm arguing for *both*, not 8364 *instead of* yours 17:59 < sipa> luke-jr: ok, fair enough 18:00 < gmaxwell> luke-jr: the _current_ unmodified bytes per sigops blocks some bare multisig usage. 18:00 < luke-jr> gmaxwell: accidentally 18:00 < gmaxwell> Sure. It's a bug, we need to fix it. 18:00 < luke-jr> so we fix that, and independently add sipa's policy. 18:00 < sipa> luke-jr: both together are acceptable, but more complexity, and i'm not sure what it gains 18:00 < gmaxwell> So to fix that we have to do something there. One option is to take it out. The other option is to do 8364. I think take it out is superior because with 8365 the marginal benefit from 8364 is small relative to the code complexity-- esp-- as you note, this close to release. 18:01 * luke-jr notes 8364 has been suggested as a fix without any controversy for months now. 18:01 < sipa> but you agree that 8364 (on its own) would be a bad idea? 18:02 < luke-jr> sipa: I don't believe I have sufficient information to answer that. 18:02 < luke-jr> or rather, I have to do some analysis of the information I have, that i have not yet done 18:04 < sipa> as far as i'm concerned, the only thing to prevent is having the mining code get confused by transactions, and producing a block that nobody would want to create 18:04 < gmaxwell> luke-jr: without 8365, 8364 would reintroduct the consensus-sigops block exhaustion attack that was being actively exploited. 18:05 < sipa> wrt concern about resource usage, we should propose to make bare multisig nonstandard 18:07 < gmaxwell> we should. But I think thats is seperate, perhaps just as a note in the release notes. 18:07 < luke-jr> seems like more of an economic concern than technical? after all, people could just pay 20x higher fees. admittedly, not a good situation of course 18:08 < luke-jr> seems just doing 1-of-2 baremultisigs legitimately might actually be an economic concern in the same sense 18:08 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 18:08 * luke-jr wonders why he has to defend "not 8365's new policy" when he has never argued for omitting it :p 18:10 < gmaxwell> hah. 18:10 < gmaxwell> My comment was just a reply to "notes 8364 has been suggested as a fix without any controversy for months now" -- apparently I must have missed that fix discussion since I would have complained that it reopened the attack. :) 18:11 < luke-jr> mostly on https://github.com/bitcoin/bitcoin/issues/8079 18:11 < luke-jr> IIRC 18:11 < luke-jr> maybe it got lost in the other bs on that thread 18:11 < sipa> i thought 8365 was the obvious fix all the time :) 18:12 < luke-jr> bbiab 18:12 < sipa> (because i assumed #7081 was intended to fix the sigop exhaustion attack, and its effect on relay was just a side effect instead of an intentional policy) 18:13 < gmaxwell> I missed 8079's discussion (because it got kind of hostile at some point). 18:16 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 258 seconds] 18:20 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 18:24 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has quit [Quit: END OF LINE] 18:27 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has joined #bitcoin-core-dev 18:32 -!- Giszmo1 [~leo@ppp-83-171-184-80.dynamic.mnet-online.de] has joined #bitcoin-core-dev 18:33 -!- Giszmo [~leo@ppp-83-171-187-230.dynamic.mnet-online.de] has quit [Ping timeout: 276 seconds] 18:42 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds] 18:45 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has quit [Quit: END OF LINE] 18:45 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 18:48 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has joined #bitcoin-core-dev 18:49 -!- netsin [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection] 19:01 -!- achow101 [~achow101@pool-108-2-58-173.phlapa.fios.verizon.net] has quit [Quit: Leaving] 19:01 -!- achow101 [~achow101@pool-108-2-58-173.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 19:04 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 19:19 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 19:21 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 19:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 19:27 -!- Samdney [~Samdney@dyn-ant666999.hawo.ipv6.uni-erlangen.de] has quit [Ping timeout: 258 seconds] 19:34 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 19:35 -!- netsin [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 19:38 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 19:40 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 250 seconds] 19:44 < GitHub106> [bitcoin] pstratem opened pull request #8377: Rename usdhd option to createhdwallet (master...2016-07-16-cwallet-createhdwallet) https://github.com/bitcoin/bitcoin/pull/8377 19:44 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:46 < phantomcircuit> jonasschnelli, fyi qa/rpc-tests/wallet-hd.py passes even when i changed usehd to createhdwallet 19:46 < phantomcircuit> which means it's broken maybe? 19:47 -!- netsin [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection] 19:48 < phantomcircuit> CHDChain & CKeyMetadata in walletdb.h seem like they could be in wallet.h instead 19:48 < phantomcircuit> they're not really specific to the walletdb 19:48 < phantomcircuit> otoh maybe it's reasonable that the abstraction be improved such that they are? 19:51 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 276 seconds] 19:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 19:54 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [] 19:55 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 19:59 -!- NicLin [~textual@116.87.237.152] has quit [Ping timeout: 264 seconds] 20:06 -!- netsin [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev 20:08 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has quit [Ping timeout: 264 seconds] 20:08 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 244 seconds] 20:09 -!- netsin [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection] 20:09 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has quit [Ping timeout: 250 seconds] 20:11 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 20:12 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has joined #bitcoin-core-dev 20:14 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has joined #bitcoin-core-dev 20:28 -!- achow101 [~achow101@pool-108-2-58-173.phlapa.fios.verizon.net] has quit [Quit: Leaving] 20:28 -!- achow101 [~achow101@pool-108-2-58-173.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 20:35 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 20:53 < michagogo> Okay, PR created -- looks like it didn't happen automatically because GitHub moved their API endpoint, and my Octokit was outdated. 21:22 < phantomcircuit> sipa: apparently returning a CKey doesn't work? 21:22 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 21:23 < phantomcircuit> had to do this to 8375 https://gist.github.com/pstratem/a01c49e3be2a82076d240819e3823f31 21:34 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 21:38 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 21:44 -!- fengling [~fengling@58.135.95.135] has quit [Ping timeout: 240 seconds] 22:13 -!- fengling [~fengling@58.135.95.135] has joined #bitcoin-core-dev 22:13 -!- ebfull [~sean@c-50-170-183-94.hsd1.co.comcast.net] has joined #bitcoin-core-dev 22:21 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 244 seconds] 22:25 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 22:31 -!- dirtynewshoes [~dirtynews@sydnns0115w-156057252148.dhcp-dynamic.FibreOp.ns.bellaliant.net] has quit [Ping timeout: 240 seconds] 22:32 < GitHub9> [bitcoin] pstratem opened pull request #8378: Move SetMinVersion for FEATURE_HD to SetHDMasterKey (master...2016-07-19-cwallet-initloadwallet-ordering) https://github.com/bitcoin/bitcoin/pull/8378 22:32 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 22:34 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 22:34 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 22:36 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 22:36 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 22:38 -!- baldur [~baldur@pool-72-69-25-42.nycmny.fios.verizon.net] has quit [Ping timeout: 250 seconds] 22:47 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 22:51 -!- baldur [~baldur@pool-72-69-25-42.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 23:08 -!- dirtynewshoes [~dirtynews@sydnns0115w-156057242005.dhcp-dynamic.FibreOp.ns.bellaliant.net] has joined #bitcoin-core-dev 23:37 -!- dirtynewshoes [~dirtynews@sydnns0115w-156057242005.dhcp-dynamic.FibreOp.ns.bellaliant.net] has quit [Ping timeout: 240 seconds] 23:42 -!- fengling [~fengling@58.135.95.135] has quit [Ping timeout: 240 seconds] 23:44 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev