--- Day changed Wed Jul 27 2016 00:03 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:05 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 00:06 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 00:17 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:31 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-htvngormznkllfcl] has joined #bitcoin-core-dev --- Log closed Wed Jul 27 00:38:29 2016 --- Log opened Wed Jul 27 00:39:01 2016 00:39 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 00:39 -!- Irssi: #bitcoin-core-dev: Total of 155 nicks [0 ops, 0 halfops, 0 voices, 155 normal] 00:40 -!- aalex_ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 00:49 -!- Irssi: Join to #bitcoin-core-dev was synced in 649 secs 00:52 -!- G1lius [~stefangil@85.17.25.23] has quit [Read error: Connection reset by peer] --- Log closed Wed Jul 27 01:11:00 2016 --- Log opened Wed Jul 27 01:11:34 2016 01:11 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 01:11 -!- Irssi: #bitcoin-core-dev: Total of 155 nicks [0 ops, 0 halfops, 0 voices, 155 normal] 01:13 -!- mturquette [sid66043@gateway/web/irccloud.com/x-vnjrccctgihwmqpi] has quit [Ping timeout: 250 seconds] 01:13 -!- mturquette [sid66043@gateway/web/irccloud.com/x-miqoiiqmqprnebre] has joined #bitcoin-core-dev 01:21 -!- Irssi: Join to #bitcoin-core-dev was synced in 648 secs 01:31 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 01:31 -!- aalex_ [~aalex@64.187.177.58] has quit [Ping timeout: 276 seconds] 01:34 < jonasschnelli> phantomcircuit: Looks good. I really want to run some tests. I'll do that soon. But 8152 is definitively useful and will be merged soon. 01:35 -!- aalex_ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 01:38 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 01:40 -!- Yv7trNY [~IUTYVExrY@79.115.58.210] has quit [Ping timeout: 252 seconds] 01:40 -!- aalex_ [~aalex@64.187.177.58] has quit [Max SendQ exceeded] 01:41 -!- aalex_ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 01:53 < jonasschnelli> wumpus: I think https://github.com/bitcoin/bitcoin/pull/8152 is ready for merge (into master) 01:55 < wumpus> thanks, taking a look 02:00 < wumpus> I'm still not entirely convinced that it won't reduce performance by causing more flushes to disk 02:01 -!- aalex_ [~aalex@64.187.177.58] has quit [Ping timeout: 265 seconds] 02:01 < wumpus> e.g. the reason for passing those CWalletDB in the first place (it wasn't always that way) was to prevent extraneous flushes, as sipa says in that pull 02:03 < wumpus> but if anyone can convince me that that problem has been handled in another way I'm ok with merging it 02:03 < wumpus> (or even better, benchmarks) 02:04 < wumpus> jonasschnelli: re: 8407, I think the second commit makes the code unncesarily complex; I think we can already handle all upgrade scenarios without it 02:04 -!- aalex_ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 02:04 < jonasschnelli> wumpus: IMO 8152 is only a refactoring to avoid having CWalletDB access in rpc code. 02:05 < jonasschnelli> wumpus: re 8407, I agree. I will remove the second commit asap 02:06 < wumpus> yes avoiding CWalletDB access in the RPC code is great; but that could also have been accomplished by adding a wrapper method in CWallet 02:06 < wumpus> that passes through the wtx to AddToWallet and opens the walletdb 02:07 < wumpus> what I'm worried about is the internal uses of AddToWallet that do pass their own walletdb 02:08 < wumpus> eh - do those exist at all? 02:08 < jonasschnelli> wumpus: I have checked the internal AddToWallet uses. And it seems like they all open CWalletDB shortly before resulting in the ~same behavior. 02:09 < jonasschnelli> I think the change form (external calls) pwalletMain->AddToWallet(wtx, false, &walletdb); to pwalletMain->AddToWallet(wtx); is good. 02:09 < jonasschnelli> It hides CWalletDB behind CWallet 02:09 -!- davidlj95 [~davidlj95@deic-dyn-232.uab.es] has joined #bitcoin-core-dev 02:09 < wumpus> hmm I agree 02:09 < jonasschnelli> (for callers using AddToWallet) 02:10 < wumpus> LOL @ line 910 02:10 < jonasschnelli> But as I said. I think its a refactoring PR 02:10 < jonasschnelli> wumpus: you mean the return false at L910 02:10 < wumpus> of wallet.cpp - that line could be deleted, no one is using that walletdb :-) 02:10 < wumpus> CWalletDB walletdb(strWalletFile, "r+", false); return AddToWallet(wtx); 02:11 < wumpus> I'm looking at the merged version, line numbers may be off 02:11 < jonasschnelli> Ah. Yes. That should be removed I guess. 02:12 < wumpus> so what changes here is the parameters under which walletdb is opened 02:12 < wumpus> for that AddWallet it used to be the ("r+", false), but now it wil open the walletdb inside AddToWallet with default parameters 02:13 -!- mkarrer [~mkarrer@109.69.10.67] has joined #bitcoin-core-dev 02:14 < wumpus> ok, commented on the pull 02:14 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:14 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 02:16 -!- mkarrer_ [~mkarrer@142.red-83-47-107.dynamicip.rima-tde.net] has quit [Ping timeout: 265 seconds] 02:23 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 02:32 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 244 seconds] 02:33 -!- Giszmo [~leo@ppp-83-171-179-206.dynamic.mnet-online.de] has joined #bitcoin-core-dev 02:39 -!- cdecker [2e8c34b6@gateway/web/cgi-irc/kiwiirc.com/ip.46.140.52.182] has joined #bitcoin-core-dev 02:42 -!- mkarrer [~mkarrer@109.69.10.67] has quit [Remote host closed the connection] 02:43 -!- mkarrer [~mkarrer@142.red-83-47-107.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 03:32 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has joined #bitcoin-core-dev 03:38 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 04:03 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:07 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 276 seconds] 04:22 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:26 < jonasschnelli> I think this one is ready for merge https://github.com/bitcoin/bitcoin/pull/8206 04:26 < jonasschnelli> Its a required 0.13 backport and relatively risk free 04:34 -!- davidlj95 [~davidlj95@deic-dyn-232.uab.es] has quit [Remote host closed the connection] 04:44 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Ping timeout: 258 seconds] 04:45 -!- spudowiar1 [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 04:47 -!- spudowiar1 is now known as spudowiar 04:53 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: Leaving.] 04:57 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:13 -!- Giszmo [~leo@ppp-83-171-179-206.dynamic.mnet-online.de] has quit [Quit: Leaving.] 05:20 -!- zooko [~user@2601:281:8000:8387:4c9d:2125:47cf:68ee] has joined #bitcoin-core-dev 05:24 -!- anu1 [~anu0@unaffiliated/anu0] has joined #bitcoin-core-dev 05:25 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has quit [Quit: Textual IRC Client: www.textualapp.com] 05:27 -!- anu0 [~anu0@unaffiliated/anu0] has quit [Ping timeout: 260 seconds] 05:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Client Quit] 05:41 < wumpus> jonasschnelli: yes I was planning to test it, will do so 05:41 < jonasschnelli> Thanks 05:45 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 05:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:02 < wumpus> jonasschnelli: a small nit: cVjNjjiDXCsTZKVP3VzjH3PPdNdeS7t51RXJ6rt99GgnzaTFtrxz 2016-07-27T13:00:33Z label= # addr=mfZRKaG9dfW5xEqUWiJFFFohe8XXoW297N hdkeypath: m/0'/0'/0' 06:02 < wumpus> let's format it hdkeypath= instead of hdkeypath: 06:02 < wumpus> that's more consistent 06:02 < jonasschnelli> ah. right. Let me change that directly 06:03 < wumpus> thanks 06:03 < wumpus> apart from that it works, tested with a non-HD and a HD wallet 06:03 < jonasschnelli> wumpus: what do you think about changing "oldhdmaster" to "inactivehdmaster"? 06:04 < jonasschnelli> oldhdmaster sound not ideal 06:04 < wumpus> yes seems more on-point 06:04 < jonasschnelli> okay. Will change that as well 06:04 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:05 < wumpus> it not so much matters whether old or new, just that it's not used at the moment 06:05 < wumpus> or maybe a more heretical idea: number the master keys, and store what master key was used with the key metadata 06:06 < wumpus> maybe for 0.14 06:07 < jonasschnelli> wumpus: yes. Though about that. But would add nother "long" string to each line 06:07 < jonasschnelli> or we could add an index to each master key (for simplification) 06:08 < wumpus> yes indeed my idea was an index/handle, not the full master key id 06:08 < wumpus> that would indeed be ugly, and would take up significant extra space in the metadata 06:09 < jonasschnelli> Yes. This would make sense for 0.14 I guess. 06:09 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/8206 is featureish and I think we only backport it to 0.13 because of possible complains because of lack of exporting the xpriv 06:10 < wumpus> yes I agree we don't want to do this for 0.13 06:10 < wumpus> it was just a wild idea 06:10 < wumpus> for 8206 let's just fix the output format and merge it 06:12 < jonasschnelli> wumpus: I think 8206 is ready now 06:13 < wumpus> re-testing 06:18 < wumpus> jonasschnelli: cRv7Mpp7w5vtf4y8joSPs6kwGZAuKfPa76GzhGS7Vecq3ss4t5Fh 2016-07-27T13:00:33Z reserve=1 # addr=mpEFHw5CXTi69tHcZm62x9DJgbQewP731j hdkeypath= m/0'/0'/1' 06:18 < wumpus> I think that's a space too much after = :) 06:19 < jonasschnelli> Damit... :) force pushed. 06:19 < jonasschnelli> ah. Forgot "git add". 06:19 < jonasschnelli> wumpus: now pushed 06:26 < GitHub44> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/beadffae6d65...4d4970fe530a 06:26 < GitHub44> bitcoin/master 77c912d Jonas Schnelli: [Wallet] add HD xpriv to dumpwallet 06:26 < GitHub44> bitcoin/master 4d4970f Wladimir J. van der Laan: Merge #8206: [Wallet] Add HD xpriv to dumpwallet... 06:26 < GitHub179> [bitcoin] laanwj closed pull request #8206: [Wallet] Add HD xpriv to dumpwallet (master...2016/06/hd_info) https://github.com/bitcoin/bitcoin/pull/8206 06:27 < jonasschnelli> wumpus: does 77c912d apply cleanly to 0.13 (should)? Just tell me if you want me to open a PR against 0.13 06:27 < wumpus> going to try 06:29 < wumpus> seems to just apply 06:41 < GitHub42> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/18b8ee1cd1b2c95faac53e49b9023200679f2bb1 06:41 < GitHub42> bitcoin/0.13 18b8ee1 Jonas Schnelli: [Wallet] add HD xpriv to dumpwallet... 06:41 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 06:42 -!- YOU-JI [~youyouyou@FL1-125-195-16-249.chb.mesh.ad.jp] has joined #bitcoin-core-dev 06:43 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 06:46 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 06:48 -!- Squidicc is now known as squidicuz 06:52 < wumpus> 8389 needs rebase 07:03 < jonasschnelli> rebased 07:07 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 07:09 -!- YOU-JI [~youyouyou@FL1-125-195-16-249.chb.mesh.ad.jp] has quit [Quit: Leaving...] 07:21 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:26 < wumpus> jonasschnelli: did you see my remark here: https://github.com/bitcoin/bitcoin/pull/8407/files#r72257114 ... I'm not sure what settings.value(strSettingsVersionKey) returns in the case !settings.contains(strSettingsVersionKey), but if it's garbage or raises an exception this may be problematic 07:31 < jonasschnelli> wumpus: yes saw it. But I thought the second expression in the if gets not executed if the first one (.contains()) fails. It's an OR. 07:31 < wumpus> yes that is true, but look inside the {} there is another settings.value(strSettingsVersionKey) 07:32 < wumpus> if (settings.value(strSettingsVersionKey) < 130000 && ... 07:32 < jonasschnelli> Ah. Right! 07:32 < jonasschnelli> That needs to be fixed. Will do soon (afk/phone typing). 07:32 < wumpus> yes, no hurry 07:43 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 07:44 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 07:47 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 07:59 -!- zooko [~user@2601:281:8000:8387:4c9d:2125:47cf:68ee] has quit [Ping timeout: 250 seconds] 08:00 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 08:00 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 08:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 08:28 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 08:33 -!- murch [~murch@p4FE393D2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 08:39 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:45 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 08:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 08:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:50 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 09:05 -!- Cory [~C@unaffiliated/cory] has quit [Ping timeout: 264 seconds] 09:08 -!- murch [~murch@p4FE393D2.dip0.t-ipconnect.de] has quit [Quit: Leaving.] 09:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 09:31 -!- gijensen is now known as gijensen3 09:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:33 -!- gijensen3 is now known as gijensen2 09:33 < GitHub191> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/0179a39f9da1fa417a592e7bf3ebbb1390a292b9 09:33 < GitHub191> bitcoin/0.13 0179a39 Wladimir J. van der Laan: qt: periodic translations update 09:34 -!- Cory [~C@unaffiliated/cory] has joined #bitcoin-core-dev 09:35 -!- gijensen2 is now known as gijensen3 09:40 -!- netzin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 09:43 -!- slackircbridge1 [~slackircb@45.55.41.36] has quit [Read error: Connection reset by peer] 09:43 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 09:46 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 09:51 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 09:52 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:52 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 09:56 -!- Cory [~C@unaffiliated/cory] has quit [Ping timeout: 252 seconds] 10:17 -!- Cory [~C@unaffiliated/cory] has joined #bitcoin-core-dev 10:33 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 10:34 -!- d_t [~textual@185.69.203.10] has joined #bitcoin-core-dev 10:34 -!- d_t [~textual@185.69.203.10] has quit [Max SendQ exceeded] 10:34 -!- aalex_ [~aalex@64.187.177.58] has quit [Ping timeout: 252 seconds] 10:36 -!- d_t [~textual@185.69.203.10] has joined #bitcoin-core-dev 10:44 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 276 seconds] 10:47 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 10:48 -!- netzin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 10:52 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 10:53 -!- eenoch [~eenoch@unaffiliated/eenoch] has quit [Ping timeout: 260 seconds] 10:53 -!- eenoch [~eenoch@unaffiliated/eenoch] has joined #bitcoin-core-dev 10:54 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 11:00 -!- menix01 [menix01@86.125.251.101] has quit [Ping timeout: 240 seconds] 11:01 -!- netzin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 11:02 -!- goatpig [56f74bcf@gateway/web/freenode/ip.86.247.75.207] has joined #bitcoin-core-dev 11:03 < goatpig> hi 11:04 < goatpig> you don't need the mask and flag when creating a tx with only segwit outputs, do you? 11:04 < goatpig> as in, no segwit inputs redeeming, only creating segwit outputs 11:04 < goatpig> non nested 11:07 -!- jtimon [~quassel@55.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 11:13 < luke-jr> goatpig: that is my understanding, correct 11:14 < luke-jr> furthermore, I think you can even include such outputs in non-segwit blocks. albeit, they would be vulnerable to easy theft until segwit activates. 11:14 < luke-jr> (but it's possible to mine non-segwit blocks even after segwit activates, so not entirely useless) 11:15 < goatpig> in this case they would just behave as anyone can spend wouldn't they? at least until miners start enforcing segwit rules 11:17 < luke-jr> right 11:17 < goatpig> so the proper guideline would be to add mask and flag when creating non nested segwit outputs, regardless of inputs? 11:18 < luke-jr> even after segwit activates, libblkmaker will produce non-segwit blocks if there are no witness-as-input transactions being mined 11:18 < gmaxwell> Well they're non-standard currently. 11:18 < luke-jr> goatpig: I don't understand your question there 11:18 < goatpig> im thinking for after segwit is activated, I don't intent to allow ppl to create SW tx with Armory until a few weeks after that happens on the mainnet 11:18 < luke-jr> IIRC, it's invalid to have dummy/flag if there's no witness data for inputs 11:19 < goatpig> luke-jr: oic 11:19 < luke-jr> (I could be wrong on that, but IIRC) 11:19 < goatpig> wouldn't that mean that you can't mix regular and sw outputs in a same tx? 11:19 < luke-jr> goatpig: no, you can have dummy/flag so long as at least one input needs witness data 11:20 < goatpig> ok 11:20 < goatpig> aight that sums it for me 11:20 < goatpig> thanks for the help 11:31 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 11:45 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:45 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 11:49 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 11:53 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 12:08 -!- OxADADA [~OxADADA@alumni-linux.ccs.neu.edu] has quit [Quit: leaving] 12:09 -!- OxADADA [~OxADADA@alumni-linux.ccs.neu.edu] has joined #bitcoin-core-dev 12:46 < jtimon> mhmm, there's a bitcoinconsensus_SCRIPT_FLAGS_VERIFY_WITNESS but not a bitcoinconsensus_SCRIPT_VERIFY_CHECKSEQUENCEVERIFY in script/bitcoinconsensus.h... 12:49 < sipa> jtimon: good point, we should fix that 12:50 < jtimon> I'll PR it, just wanted to confirm first 12:50 < jtimon> sipa: thanks 12:50 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 12:51 < jtimon> actually found out while adapting my consensus branch to ScriptFlagsFromConsensus()as discussed (WIP) 12:55 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 13:03 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 258 seconds] 13:03 -!- goatpig [56f74bcf@gateway/web/freenode/ip.86.247.75.207] has quit [Ping timeout: 250 seconds] 13:13 -!- d_t [~textual@185.69.203.10] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 13:24 -!- anu0 [~anu0@unaffiliated/anu0] has joined #bitcoin-core-dev 13:27 -!- anu1 [~anu0@unaffiliated/anu0] has quit [Ping timeout: 240 seconds] 13:28 -!- d_t [~textual@185.69.203.10] has joined #bitcoin-core-dev 13:36 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 13:51 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 13:53 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 13:54 -!- owowo [ovovo@gateway/vpn/mullvad/x-mfdkczlepgtktxtt] has joined #bitcoin-core-dev 13:56 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 14:02 -!- owowo [ovovo@gateway/vpn/mullvad/x-mfdkczlepgtktxtt] has quit [Ping timeout: 240 seconds] 14:08 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 14:13 < GitHub48> [bitcoin] jtimon opened pull request #8412: libconsensus: Expose a flag for BIP112 (master...0.13-consensus-bip112-flag) https://github.com/bitcoin/bitcoin/pull/8412 14:14 < jtimon> does this little thing break rc1? 14:23 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has quit [Ping timeout: 260 seconds] 14:25 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 14:31 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 14:35 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 14:49 < GitHub132> [bitcoin] jtimon opened pull request #8413: Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock (master...0.13-consensus-last-params) https://github.com/bitcoin/bitcoin/pull/8413 14:53 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 14:57 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 14:59 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 15:13 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:18 < jtimon> btcdrak: quick question https://github.com/bitcoin/bitcoin/pull/8412#issuecomment-235738474 15:19 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 276 seconds] 15:26 < jtimon> never mind, updated without bip112 at the end 15:32 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 15:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:52 -!- d_t [~textual@185.69.203.10] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:54 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 15:58 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 16:32 -!- cdecker [2e8c34b6@gateway/web/cgi-irc/kiwiirc.com/ip.46.140.52.182] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 16:32 < GitHub43> [bitcoin] kazcw opened pull request #8414: prepend license statement to indirectmap.h (master...indirectmap-license) https://github.com/bitcoin/bitcoin/pull/8414 16:35 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 16:55 -!- netzin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 17:02 -!- evoskuil [~evoskuil@c-67-168-100-165.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 17:53 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving] 17:55 -!- netzin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 18:00 -!- netzin [~netsin@unaffiliated/jiggalator] has quit [Ping timeout: 276 seconds] 18:05 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-htvngormznkllfcl] has quit [Quit: Connection closed for inactivity] 18:24 -!- netzin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 18:36 -!- shesek [~shesek@bzq-84-110-209-97.cablep.bezeqint.net] has quit [Read error: Connection reset by peer] 18:39 -!- xiangfu [~xiangfu@58.135.95.141] has quit [Quit: leaving] 18:40 -!- xiangfu [~xiangfu@58.135.95.141] has joined #bitcoin-core-dev 18:55 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 250 seconds] 18:55 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Remote host closed the connection] 19:01 -!- shesek [~shesek@bzq-84-110-7-137.red.bezeqint.net] has joined #bitcoin-core-dev 19:24 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:25 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 19:35 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:36 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 19:38 -!- nsh [~lol@wikipedia/nsh] has quit [Ping timeout: 258 seconds] 19:41 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev 19:51 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 19:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 19:56 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:07 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:17 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 20:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 20:47 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 240 seconds] 21:05 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds] 21:21 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 21:24 -!- anu1 [~anu0@unaffiliated/anu0] has joined #bitcoin-core-dev 21:27 -!- anu0 [~anu0@unaffiliated/anu0] has quit [Ping timeout: 276 seconds] 21:42 -!- netzin [~netsin@unaffiliated/jiggalator] has quit [] 21:42 < GitHub179> [bitcoin] shinradev opened pull request #8415: Update tor.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/8415 21:50 -!- d_t [~textual@185.69.203.10] has joined #bitcoin-core-dev 21:53 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 21:55 -!- d_t [~textual@185.69.203.10] has quit [Ping timeout: 260 seconds] 22:32 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:33 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:35 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 23:12 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: Leaving.] 23:14 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 23:27 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: gtg sleepz] 23:36 -!- btcfan [~btcfan@93-33-55-139.ip43.fastwebnet.it] has joined #bitcoin-core-dev 23:36 -!- d_t [~textual@185.69.203.10] has joined #bitcoin-core-dev 23:45 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:47 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 23:49 < jonasschnelli> wumpus: I guess this is now safe: https://github.com/bitcoin/bitcoin/pull/8407/files#diff-bd81cc35fa9249ec9e6a2ace6d3a4d59R446