--- Day changed Tue Sep 13 2016 00:03 -!- face [~face@mail.hmel.org] has quit [Ping timeout: 276 seconds] 00:13 -!- rubensayshi [~ruben@82.201.93.169] has joined #bitcoin-core-dev 00:56 -!- netsin_ [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 00:57 -!- netzin [~netsin@unaffiliated/jiggalator] has quit [Ping timeout: 250 seconds] 00:59 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 01:01 -!- netsin_ [~netsin@unaffiliated/jiggalator] has quit [Ping timeout: 250 seconds] 01:08 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 01:18 < wumpus> do we really need a zillion pulls updating copyright messages :/ 01:20 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 01:21 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 01:21 < jonasschnelli> wumpus: heh. Indeed. 01:23 < wumpus> omg #8653 tells people building for windows to disable hardening :( 01:24 < wumpus> any pulls that I should review that make me happy instead of depressed? 01:24 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 01:27 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/8653 is indeed silly... 01:27 < jonasschnelli> Can't you not just use a PPA with a mingw compiler that suppors c++11 including threads? 01:27 < wumpus> why do the only people with an actual clue about security on windows seem to be the blackhats that try to steal your coins 01:28 < jonasschnelli> haha 01:28 < wumpus> well switching to a posix-compliant compiler is not silly 01:28 < wumpus> although it' a bit weird that it is needed 01:28 < wumpus> it's working around a mingw bug indeed 01:29 < jonasschnelli> I never had problems on any of my machines crosscompiling with minwg even after the c++11 switch... 01:30 < wumpus> apparently the non-POSIX version doesn't give you c++11 synchronization, but piling on a posix emulation layer is probably not ideal either 01:30 < jonasschnelli> I guess per default it installs the posix comp. mingw32-gcc/g++ 01:30 < wumpus> I've had no issues at all either 01:30 < wumpus> and have built for windows on 16.04 01:31 < jonasschnelli> But why is the --disable-hardenin required? 01:31 < wumpus> so either it installs the posix one by default, or this is a new problem 01:31 < wumpus> I don't know, ask the guy, seems like really bad advice 01:31 < wumpus> 'our security system reports a problem sir'.. 'just disable it, it must be a false alarm' 01:31 < jonasschnelli> Yes. The advice comes also without a concrete reason... 01:31 < jonasschnelli> "You may also need to disable..." 01:31 < wumpus> heh. 01:32 < wumpus> I understand lazy developers, but being lazy with security issues areound bitcoin is a deadly sin 01:35 < GitHub32> [bitcoin] laanwj pushed 10 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a0836f6d5e7...7e9ab9555cab 01:35 < GitHub32> bitcoin/master d2cd9c0 nomnombtc: add script to generate manpages with help2man 01:35 < GitHub32> bitcoin/master 6edf2fd nomnombtc: add gen-manpages.sh description to README.md 01:35 < GitHub32> bitcoin/master eb5643b nomnombtc: add autogenerated manpages by help2man 01:35 < GitHub42> [bitcoin] laanwj closed pull request #8608: Install manpages via make install, also add some autogenerated manpages (master...man_automake2) https://github.com/bitcoin/bitcoin/pull/8608 01:45 < Eliel> wumpus: I have this theory that there's not an actual shortage of people who have an actual clue about windows security but the motivations for actually learning about it are because they think the skill will make them money, so unless you're willing to pay a lot, it's not generally available. 01:47 < wumpus> Eliel: yes, that's how my reasoning goes, too. One popular way to make a lot of money from knowing windows internals is exploiting them or working for companies that sell add-on security products, but helping secure open source software is not one of them at least 01:48 < wumpus> it's a different kind of culture, in Linux people show that they know about e.g. kernel internals by working on them in public, in windows it's all much more hush hush 01:50 < midnightmagic> the Sysinternals guys (used to?) do *incredible* workshops 01:50 < wumpus> I'm sure an issue "ASLR doesn't seem to work properly on " Linux/*BSD or even MacOSX would be solved in a day 01:51 < wumpus> for windows you get one reply from a clueless user 'look at the DLL flags' .. .yea, we hadn't thought of that yet 01:51 < wumpus> yes the sysinternals guys are extrememly clueful, too clueful to be allowed to exist outside Microsoft so they were bought up :) 01:55 -!- whphhg [~whphhg@unaffiliated/whphhg] has joined #bitcoin-core-dev 01:55 < luke-jr> jonasschnelli: being able to build from source is important; it's not enough to just have hacks that work for gitian 01:56 < wumpus> which 'hacks that work for gitian'? 01:56 < jonasschnelli> Yes. Please elaborate... :) 01:56 < jonasschnelli> As far as i know we are using the default unpatched mingw compiler in out ubuntu vm 01:56 < midnightmagic> <3 the sysinternals guys. very cool what they do. srsly, if they have workshops, attend them, just being around them makes you smarter. :) 01:57 < dcousens> wumpus: it doesn't seem that GetNextWorkRequired was called with a NULL argument since 2010 when pIndexBest =NULL was the default in main.cpp 01:57 < dcousens> but, I haven't checked *every* commit since then :S 01:58 < dcousens> I'd hazard it stopped having that oppurtunity when pindexBest was refactored out 01:59 < wumpus> dcousens: then an assert makes some sense; although in a more general sense we do use assert too much for invalid input handling 02:00 < dcousens> wumpus: its probably just an indication we should use more references rather than pointers? (unless the aim is to be C compatible) 02:00 < wumpus> though an assertion crash is absolutely preferable to a SIGSEGV due to a null pointer 02:00 -!- whphhg [~whphhg@unaffiliated/whphhg] has quit [Client Quit] 02:00 -!- whphhg [~whphhg@unaffiliated/whphhg] has joined #bitcoin-core-dev 02:01 < dcousens> to me, the assertion just indicates, we're 99% this doesn't happen, but not 100% sure enough to dereference at the call site 02:01 < wumpus> yes 02:01 < wumpus> I didn't mean that as an argument againt your specific change 02:01 < dcousens> wumpus: oh I know, I agree with you 02:03 < wumpus> using references would indeed avoid the issue in this case 02:03 < GitHub125> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7e9ab9555cab...4ced5de71d4d 02:03 < GitHub125> bitcoin/master bc1d1f2 instagibbs: Update p2p-segwit.py to reflect correct AskFor behavior 02:03 < GitHub125> bitcoin/master 5547aeb instagibbs: p2psegwit.py transaction is rejected due to premature witness not size 02:03 < GitHub125> bitcoin/master 4ced5de Wladimir J. van der Laan: Merge #8528: Update p2p-segwit.py to reflect correct behavior... 02:03 < GitHub57> [bitcoin] laanwj closed pull request #8528: Update p2p-segwit.py to reflect correct behavior (master...rejectsw) https://github.com/bitcoin/bitcoin/pull/8528 02:05 < GitHub197> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4ced5de71d4d...256215244105 02:05 < GitHub197> bitcoin/master 46606af BtcDrak: Update btcdrak signing key 02:05 < GitHub197> bitcoin/master 2562152 Wladimir J. van der Laan: Merge #8662: Update btcdrak signing key... 02:05 < GitHub118> [bitcoin] laanwj closed pull request #8662: Update btcdrak signing key (master...updatekey) https://github.com/bitcoin/bitcoin/pull/8662 02:06 < wumpus> jonasschnelli: as far as I know we're using an unpatched compiler for gitian win32/64 building too; I dont think we do any specific hacks to get it to build/run 02:07 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 02:07 < wumpus> well there is one hack to zero the heap during compilation to work around an issue in 14.04's mingw gcc compiler where four random heap bytes leak into the executable, but that's only required for determinism 02:08 < wumpus> so yes there are some hacks for determinism, someone building from source for themselves can safely skip them, that's why they're not described in doc/build-*.md 02:12 -!- whphhg [~whphhg@unaffiliated/whphhg] has quit [Quit: Leaving] 02:13 < wumpus> disabling hardening is advice you should never give anyone in good conscience though 02:16 < GitHub142> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/256215244105...39ac1ec64264 02:16 < GitHub142> bitcoin/master 1d635ae rodasmith: fix op order to append first alert 02:16 < GitHub142> bitcoin/master 39ac1ec Wladimir J. van der Laan: Merge #8697: fix op order to append first alert... 02:16 < GitHub145> [bitcoin] laanwj closed pull request #8697: fix op order to append first alert (master...fix-op-order-1st-alert) https://github.com/bitcoin/bitcoin/pull/8697 02:20 < wumpus> so is https://github.com/bitcoin/bitcoin/pull/8699 an intermediate measure for 0.13.1 or does the `createwitnessaddress` command need to disappear forever? 02:20 < dcousens> wumpus: my understanding was it was for testing, but has no purpose in mainnet? 02:21 < wumpus> right, so it should never have made it into a release at all, and needs to be removed now? 02:21 < wumpus> do people still use it for testing or is there a better alternative? 02:22 < wumpus> apparently the RPC tests don't use it otherwise it couldn't be removed without affecting the tests 02:24 < dcousens> wumpus: not sure about current testing, my understanding is the RPC now understand witness scripts? 02:24 < dcousens> not sure about the wallet code, haven't used it in terms of segwit tbh 02:26 -!- AaronvanW [~ewout@77pc231.sshunet.nl] has joined #bitcoin-core-dev 02:26 -!- AaronvanW [~ewout@77pc231.sshunet.nl] has quit [Changing host] 02:26 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:34 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has joined #bitcoin-core-dev 02:35 < GitHub171> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/39ac1ec64264...37ac67816afb 02:35 < GitHub171> bitcoin/master 152f45b Peter Todd: Add option to opt into full-RBF when sending funds 02:35 < GitHub171> bitcoin/master 05fa823 Wladimir J. van der Laan: wallet: Add BIP125 comment for MAXINT-1/-2 behavior 02:35 < GitHub171> bitcoin/master 86726d8 Wladimir J. van der Laan: Rename `-optintofullrbf` option to `-walletrbf`... 02:35 < GitHub29> [bitcoin] laanwj closed pull request #8601: Add option to opt into full-RBF when sending funds (rebase, original by petertodd) (master...2016_08_full_rbf_option) https://github.com/bitcoin/bitcoin/pull/8601 02:45 < GitHub97> [bitcoin] MarcoFalke opened pull request #8710: [0.13.1] qt Backports (0.13...Mf1609-qtBackports) https://github.com/bitcoin/bitcoin/pull/8710 02:50 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 02:51 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 02:51 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 02:52 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 02:55 < dcousens> wumpus: IIRC the txoutsbyaddress isn't utxos byaddress 02:55 < dcousens> its just txos, throughout history 02:55 < dcousens> aka, give me the balance of address X @ blockheight 233000 02:56 < dcousens> atleast, that was my impression 02:57 < dcousens> nvm 02:57 < dcousens> my impression was wrong 02:59 < wumpus> no, IIRC it ignores history and just gives you current utxo, that's what makes it interesting 03:00 < GitHub114> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/37ac67816afb...7fe6c5c99370 03:00 < GitHub114> bitcoin/master 438e94d whythat: remove root test directory for RPC tests 03:00 < GitHub114> bitcoin/master c62cc4e whythat: fix path for bak file 03:00 < GitHub114> bitcoin/master 7fe6c5c MarcoFalke: Merge #8652: [qa]: remove root test directory for RPC tests... 03:01 < GitHub174> [bitcoin] MarcoFalke closed pull request #8652: [qa]: remove root test directory for RPC tests (master...cleanup) https://github.com/bitcoin/bitcoin/pull/8652 03:13 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 03:48 -!- JackH [~Jack@79-73-191-94.dynamic.dsl.as9105.com] has quit [Ping timeout: 255 seconds] 03:53 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 03:57 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Ping timeout: 244 seconds] 04:06 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 04:19 -!- Samdney [~Samdney@dyn-ant666999.hawo.ipv6.uni-erlangen.de] has joined #bitcoin-core-dev 04:19 < jl2012> wumpus: I think nothing in the RPC test is using createwitnessaddress, and that could be done with 2 lines of python code 04:19 < wumpus> right, nothing is using it 04:20 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:27 -!- JackH [~Jack@81.141.186.212] has joined #bitcoin-core-dev 04:27 -!- JackH [~Jack@81.141.186.212] has quit [Remote host closed the connection] 04:43 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has quit [Quit: Later.] 05:05 -!- cheese_ [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 05:09 -!- rubensayshi_ [~ruben@82.201.93.169] has joined #bitcoin-core-dev 05:09 -!- rubensayshi [~ruben@82.201.93.169] has quit [Read error: Connection reset by peer] 05:23 -!- achow101 [~achow101@129.2.206.174] has quit [Quit: Leaving] 05:30 -!- achow101 [~achow101@129.2.206.174] has joined #bitcoin-core-dev 05:41 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 05:46 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Ping timeout: 276 seconds] 06:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:26 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:35 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 06:55 < jonasschnelli> hmm... NotifyHeaderTip is firing during IBD for every block connected to the main chain... I though it should only fire when a new header gets append to the headers-chain. 06:55 < jonasschnelli> https://github.com/bitcoin/bitcoin/blob/39ac1ec6426447b924052c2da3f80e0220c308c3/src/main.cpp#L3004 06:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:59 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 07:01 < sipa> jonasschnelli: that's what it does 07:01 < jonasschnelli> For the overlay I'm working on, a notification of the header-chain tip update would be convinient.. 07:02 < sipa> i'm not sure why you think that's not what happens 07:02 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 07:02 -!- TomMc [~tom@unaffiliated/tommc] has quit [Client Quit] 07:03 < jonasschnelli> sipa: right now, I get NotifyHeaderTip() during IBDs header-sync of the blocks that gets connected (example: NotifyHeaderTip fires when header-chain is at 300'000 with a block-connect at height 100). 07:04 < jonasschnelli> Listening to the signal I cannot distinct between the actual header-sync-tip-update and the block-connect 07:05 < jonasschnelli> Or it looks like the listener cannot distinct. 07:06 < jonasschnelli> Well, now I can just load pindexBestHeader->nHeight when the signal fires.. 07:06 < sipa> i'm really confused 07:07 < jonasschnelli> Maybe I'm interpreting the signal wrong.. 07:07 < sipa> it should fire whenever we learn about a new best header 07:07 < jonasschnelli> What i'm looking for is a way to get a tip-update of the headers-chain (in order to calculate the remaining blocks to verify) 07:08 < sipa> ok 07:08 < sipa> that's what it doez 07:08 < sipa> does 07:08 < jonasschnelli> But it does fire _again_ when a block connects 07:08 < jonasschnelli> (with the header=true) 07:09 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 07:09 < sipa> it should not 07:11 < sipa> can you explain the call graph that results in that spurious call? 07:12 < jonasschnelli> sipa: I'll try to give you clear steps to reproduce... give me a minute 07:12 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer] 07:12 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 07:20 < jonasschnelli> sipa: I think I'm misunderstanding something. Isn't pindexBestHeader the chaintip of the headers-only chain? 07:21 < jonasschnelli> During the NotifyHeaderTip signal, I get something like: initialSync: 1, height: 359 but bestheaderheight->nHeight == 48000 07:21 < jonasschnelli> I expected the signal to fire (with headers=true) when pindexBestHeader get updated with the next chunk of headers. 07:24 < sipa> oh, i see 07:25 < sipa> i does not actually notify for the best header 07:25 < sipa> it notifies for updates to the best header chain which could be verified 07:25 < sipa> so only when all blocks towards it have been downloaded 07:26 < sipa> which is sufficient for reindexing 07:29 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 07:31 < jonasschnelli> sipa: Do you think it would make sense to extend the signal to also fire when the best header chain updates its tip? 07:31 < jonasschnelli> Or would that break the reindexing? 07:34 < sipa> i think that would be fine 07:34 < sipa> i'll try to create a PR 07:35 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Ping timeout: 252 seconds] 07:35 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev 07:35 < jonasschnelli> sipa: Super! +1 07:45 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 07:55 < GitHub50> [bitcoin] jl2012 closed pull request #8685: Discourage P2WSH with too big script or stack (master...bigp2wsh) https://github.com/bitcoin/bitcoin/pull/8685 07:59 < wumpus> I still don't get the situation around the createwitnessaddress command https://github.com/bitcoin/bitcoin/pull/8699 08:00 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 08:00 < wumpus> why does it exist? why was it ever added if it is never going to be useful, and even dangerous? 08:00 < wumpus> what is the point of it? 08:03 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 08:03 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 08:03 < moli> wumpus, afaik it's used to create multisig SW addresses 08:03 < sipa> creating them without adding them to the wallet 08:03 < GitHub83> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7fe6c5c99370...c9914c209468 08:03 < GitHub83> bitcoin/master 86c3f8d Johnson Lau: Remove createwitnessaddress... 08:03 < GitHub83> bitcoin/master c9914c2 Wladimir J. van der Laan: Merge #8699: Remove createwitnessaddress RPC command... 08:03 < sipa> it's a utility function to match the wallet code 08:03 < wumpus> ah like createmultisig 08:03 < GitHub163> [bitcoin] laanwj closed pull request #8699: Remove createwitnessaddress RPC command (master...nocreatewitadd) https://github.com/bitcoin/bitcoin/pull/8699 08:04 < wumpus> well in any case it's a historical curiosity now, probably should mention it is removed in the release notes, at least if adding it was 08:04 < sipa> it was only ever usable on testnet 08:04 < wumpus> I hope it will be gone before anyone loses their coins due to it 08:05 < sipa> with 0.13.0 it can never be used on mainnet, even after segwit activates 08:05 < wumpus> yes but my question was whether it should be removed on master 08:05 < wumpus> it is a pull to master 08:07 < wumpus> the description was indeed formulated as 'this is never useful on 0.13' ,so I asked whether it was on purpose that it removes it from master too, but appearantly it is 08:07 < MarcoFalke> We should still do a backport. Just for consistency. 08:07 < wumpus> yes 08:07 < wumpus> it's marked as needs backport 08:08 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer] 08:08 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 08:09 < sipa> i'd rather only add something like this back of there is a demand for it 08:09 < wumpus> agreed 08:09 < sipa> and then we can assess what protections are useful 08:10 -!- Expanse [sid146237@gateway/web/irccloud.com/x-bnofsiuwscxmumxl] has quit [Read error: Connection reset by peer] 08:10 -!- Yogh [~Yogh@f36186.upc-f.chello.nl] has quit [Ping timeout: 265 seconds] 08:10 < wumpus> it's just an utility call anyhow, it doesn't need to be on RPC 08:10 < sipa> indeed 08:10 < GitHub4> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c9914c209468...fa7caf6d9116 08:10 < GitHub4> bitcoin/master 62ffbbd instagibbs: add witness address to address book 08:10 < GitHub4> bitcoin/master fa7caf6 Wladimir J. van der Laan: Merge #8693: add witness address to address book... 08:11 < GitHub8> [bitcoin] laanwj closed pull request #8693: add witness address to address book (master...addwitbook) https://github.com/bitcoin/bitcoin/pull/8693 08:11 -!- nibor [~nibor@185.9.34.66] has quit [Ping timeout: 265 seconds] 08:12 -!- Expanse [sid146237@gateway/web/irccloud.com/x-shtzaaizqwbgoxlk] has joined #bitcoin-core-dev 08:12 -!- nibor [~nibor@185.9.34.66] has joined #bitcoin-core-dev 08:14 -!- Yogh [~Yogh@f36186.upc-f.chello.nl] has joined #bitcoin-core-dev 08:18 -!- JeromeLegoupil [~textual@46-127-102-197.dynamic.hispeed.ch] has joined #bitcoin-core-dev 08:22 < btcdrak> sipa: are there any more changes coming to #8393 (segwit cb) 08:23 < sipa> i haven't looked at matt's proposed changes yet 08:23 < GitHub11> [bitcoin] laanwj pushed 4 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/a9429ca26dd8...4731623777ab 08:23 < GitHub11> bitcoin/0.13 41fd852 rodasmith: fix op order to append first alert... 08:23 < GitHub11> bitcoin/0.13 d9f0d4e adlawren: Fix minimize and close bugs... 08:23 < GitHub11> bitcoin/0.13 a37cec5 Andrew Chow: Persist the datadir after option reset... 08:23 < GitHub93> [bitcoin] laanwj closed pull request #8710: [0.13.1] qt Backports (0.13...Mf1609-qtBackports) https://github.com/bitcoin/bitcoin/pull/8710 08:23 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 08:29 -!- rubensayshi_ [~ruben@82.201.93.169] has quit [Remote host closed the connection] 08:30 < jonasschnelli> Re: https://github.com/bitcoin/bitcoin/pull/8559 ... should we just remove the maxuploadtargets "recommended" minimum? 08:31 < jonasschnelli> Any objections? 08:35 < wumpus> no objections 08:39 < cfields> no objection here either 08:41 < btcdrak> no objections 08:42 < cfields> btw, https://github.com/bitcoin/bitcoin/pull/8708/commits/89c57428e335fefe87c6f5b4fd173c9ba9bdb486 may be worth backporting. I'm not sure what the implications are, but i assume it's possible for that to cause a stall in initial sync. Not quite sure how to test. 08:43 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 08:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:44 < cfields> basically if a user doesn't have the expected services, we start to disconnect, but we send them an initial getheaders anyway. Not sure how long it takes to recover from that, maybe a non-issue. 08:44 < cfields> s/user/peer/ 08:48 < wumpus> let's backport is just in case 08:49 < wumpus> btw: which maxupload test failure? does it fail intermittently? 08:49 < cfields> wumpus: the rpc test, in -extended 08:50 < wumpus> ok 08:51 < cfields> it fails 100% without #8707. With that, I think it's intermittent (depends on how much goes through the optimistic send) without #8708, which fixes it completely. 08:51 < wumpus> thanks for the explanation 08:51 < cfields> np, sorry for the breakage. 08:52 < cfields> thanks for shoving the CConnman PR in, btw. I had lots of stuff blocked on that :) 08:53 < GitHub110> [bitcoin] laanwj closed pull request #8457: Add block height support in rpc call getblock (master...feature/add-get-block-by-number) https://github.com/bitcoin/bitcoin/pull/8457 08:53 < wumpus> well this is a pretty light breakage as these things go, it had to happen at some time 08:53 < wumpus> now it's in it can be improved 08:53 < wumpus> right :) 08:54 < wumpus> I'm happy travis is so stable again 08:54 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 08:57 < cfields> yea, that was getting really annoying. And as gmaxwell said, it has a quick psychological effect. Doesn't take long before you start ignoring the failures completely. 08:57 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: Gotta Go Fast! TM] 08:58 < wumpus> yes, I was already starting to rely on local testing only again 08:59 < wumpus> (which means only one platform/compiler) 08:59 < cfields> yes, same 09:01 < GitHub58> [bitcoin] MarcoFalke closed pull request #7728: Fees: Tests: Check CFeeRate internal precision in mempool_tests.cpp (master...0.12.99-feerate-precision-test) https://github.com/bitcoin/bitcoin/pull/7728 09:12 < GitHub151> [bitcoin] jonasschnelli opened pull request #8712: Remove maxuploadtargets recommended minimum (master...2016/09/rem_maxupt_min) https://github.com/bitcoin/bitcoin/pull/8712 09:13 < GitHub20> [bitcoin] jonasschnelli closed pull request #8559: Change maxuploadtarget recommended minimum calculation (master...2016/08/max_ut) https://github.com/bitcoin/bitcoin/pull/8559 09:18 -!- fengling [~fengling@60.10.200.118] has quit [Ping timeout: 240 seconds] 09:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 09:19 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 09:20 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 09:26 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Ping timeout: 276 seconds] 09:27 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev 09:28 -!- JeromeLegoupil [~textual@46-127-102-197.dynamic.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:34 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:38 < phantomcircuit> wumpus: can you take a peak at 8696 (and 8695 but less urgently as no acks yet) 09:39 < phantomcircuit> oh you did look at 8695 09:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 09:49 -!- JeromeLegoupil [~textual@46-127-102-197.dynamic.hispeed.ch] has joined #bitcoin-core-dev 09:50 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has left #bitcoin-core-dev [] 09:55 -!- spudowiar is now known as SlimBottet 09:56 -!- SlimBottet is now known as spudowiar 09:58 -!- JeromeLegoupil [~textual@46-127-102-197.dynamic.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 10:04 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has quit [Disconnected by services] 10:04 -!- drizztbsd [~quassel@archlinux/trusteduser/DrizztBSD] has joined #bitcoin-core-dev 10:05 -!- drizztbsd is now known as timothy 10:12 -!- JeromeLegoupil [~textual@46-127-102-197.dynamic.hispeed.ch] has joined #bitcoin-core-dev 10:36 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 10:38 -!- JeromeLegoupil [~textual@46-127-102-197.dynamic.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 10:40 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Ping timeout: 240 seconds] 10:42 -!- JeromeLegoupil [~textual@46-127-102-197.dynamic.hispeed.ch] has joined #bitcoin-core-dev 10:45 < GitHub170> [bitcoin] MarcoFalke opened pull request #8713: [qa] create_cache: Delete temp dir when done (master...Mf1609-qaCacheTempdir) https://github.com/bitcoin/bitcoin/pull/8713 10:46 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 264 seconds] 10:50 < GitHub155> [bitcoin] MarcoFalke opened pull request #8714: [qa] gitignore, travis: Remove unused lines (master...Mf1609-qaUnused) https://github.com/bitcoin/bitcoin/pull/8714 10:52 -!- JeromeLegoupil [~textual@46-127-102-197.dynamic.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 10:54 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 10:55 -!- fengling [~fengling@60.10.200.118] has quit [Ping timeout: 240 seconds] 10:56 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has joined #bitcoin-core-dev 10:56 < MarcoFalke> cfields: Do you think it is hard to get osx builds woring? 10:57 < cfields> MarcoFalke: we already do a cross osx build. You mean a native one? 10:57 < Lightsword> what’s wrong with osx builds? 10:57 < MarcoFalke> If there is no plan to add native ones, we don't need the os:linux 10:57 < MarcoFalke> strictly speaking 10:57 -!- JeromeLegoupil [~textual@46-127-102-197.dynamic.hispeed.ch] has joined #bitcoin-core-dev 10:58 < cfields> MarcoFalke: sure, it's just explicit there in case it's ever required 11:00 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:01 < morcos> cfields: additional slight bug in shutdown related to ConnMan 11:01 < morcos> you call g_connman->Stop() when it might be a null pointer 11:02 < morcos> there is even a comment above warning you not to do that. :) 11:02 < cfields> heh, looking 11:02 -!- dermoth [~thomas@dsl-66-36-143-95.mtl.aei.ca] has quit [Ping timeout: 244 seconds] 11:02 < morcos> can be demonstrated by just running 2 bitcoind's the second one tries to exit due to data directory locked and then segfaults 11:04 < cfields> morcos: indeed. Thanks, fixing. 11:08 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has left #bitcoin-core-dev [] 11:09 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev 11:13 -!- silva_ [~silva@96-92-139-13-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:25 -!- silva_ [~silva@96-92-139-13-static.hfc.comcastbusiness.net] has quit [] 11:25 -!- silva [~silva@96-92-139-13-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:29 -!- e4xit [~e4xit@cpc92302-cmbg19-2-0-cust1369.5-4.cable.virginm.net] has joined #bitcoin-core-dev 11:31 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 11:36 -!- dermoth [~thomas@24.114.85.189] has joined #bitcoin-core-dev 11:37 -!- fengling [~fengling@60.10.200.118] has quit [Ping timeout: 240 seconds] 11:37 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:38 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev 11:40 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 11:40 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 11:49 -!- tadasv [ttttt@gateway/shell/panicbnc/x-zwetgfjzxafdqvbq] has quit [Ping timeout: 264 seconds] 11:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:57 -!- tadasv [ttttt@gateway/shell/panicbnc/x-oylfhgwxfkapjjns] has joined #bitcoin-core-dev 11:57 -!- achow101 [~achow101@129.2.206.174] has quit [Quit: Leaving] 11:58 -!- achow101 [~achow101@129.2.206.174] has joined #bitcoin-core-dev 11:58 < GitHub32> [bitcoin] theuni opened pull request #8715: net: only delete CConnman if it's been created (master...fix-connman-shutdown) https://github.com/bitcoin/bitcoin/pull/8715 12:00 < cfields> morcos: ^^. Thanks. 12:05 -!- fengling [~fengling@60.10.200.118] has quit [Ping timeout: 240 seconds] 12:06 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev 12:07 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has quit [Disconnected by services] 12:07 -!- drizztbsd [~quassel@archlinux/trusteduser/DrizztBSD] has joined #bitcoin-core-dev 12:07 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: Gotta Go Fast! TM] 12:07 -!- drizztbsd is now known as timothy 12:18 -!- Netsplit *.net <-> *.split quits: Arnavion, sdaftuar, shaiguit1r, musalbas, echonaut1, wangchun, Guyver2, Madars, trippysalmon, fengling, (+101 more, use /NETSPLIT to show all of them) 12:18 -!- Netsplit *.net <-> *.split quits: ghtdak, aj, xiangfu, lclc, Ylbam, Silence_, dermoth, Anduck, jrayhawk, Eliel, (+12 more, use /NETSPLIT to show all of them) 12:18 -!- Netsplit *.net <-> *.split quits: jasonv75, gmaxwell, amiller, nickler, berndj, murr4y 12:18 -!- Netsplit over, joins: gluytium 12:23 -!- Netsplit over, joins: haakonn 12:23 -!- owowo [ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:23 -!- justanotheruser [~justanoth@24.219.72.136] has joined #bitcoin-core-dev 12:23 -!- jl2012 [uid133844@unaffiliated/jl2012] has joined #bitcoin-core-dev 12:23 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 12:23 -!- Netsplit over, joins: crescendo, mr_burdell, nanotube, paveljanik, lclc, achow101, Cheeseo, timothy, cryptapus 12:23 -!- jrayhawk_ [~jrayhawk@nursie.omgwallhack.org] has joined #bitcoin-core-dev 12:23 -!- Netsplit over, joins: CodeShark, warren, midnightmagic, eragmus, OxADADA, musalbas, nsh, Lauda, windsok, da2ce7 (+19 more) 12:23 -!- asoltys [~bitcoinco@23.94.96.232] has joined #bitcoin-core-dev 12:23 -!- cfields_ [~quassel@2001:4802:7800:2:be76:4eff:fe20:5aaa] has joined #bitcoin-core-dev 12:23 -!- Netsplit over, joins: jonasschnelli, Lightsword, go1111111, PaulCapestany, neha, jeremyrubin, BonyM1, waxwing, arowser, isis (+26 more) 12:23 -!- Netsplit over, joins: ybit 12:23 -!- ghtdak [~ghtdak@173-10-78-129-BusName-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:23 -!- Netsplit over, joins: berndj, gmaxwell, silva, nickler, jron, d9b4bef9, xiangfu, jasonv75, baldur, bsm117532 (+2 more) 12:23 -!- Netsplit over, joins: Eliel 12:23 -!- arubi [~ese168@bzq-109-65-168-116.red.bezeqint.net] has joined #bitcoin-core-dev 12:23 -!- kinlo [peter@62.213.207.202] has joined #bitcoin-core-dev 12:23 -!- Netsplit over, joins: BashCo, Arnavion 12:23 -!- Netsplit over, joins: Anduck 12:23 -!- Netsplit over, joins: luke-jr, mjdecour, blkdb, Naphex 12:23 -!- Netsplit over, joins: petertodd 12:23 -!- Madars [~null@contents-vnder-pressvre.mit.edu] has joined #bitcoin-core-dev 12:23 -!- aj_ [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 12:23 -!- Silence__ [jb@ip.fi] has joined #bitcoin-core-dev 12:23 -!- Netsplit over, joins: mn3monic, Taek, Giszmo, Bootvis 12:24 -!- arubi [~ese168@bzq-109-65-168-116.red.bezeqint.net] has quit [Client Quit] 12:24 -!- kinlo [peter@62.213.207.202] has quit [Changing host] 12:24 -!- kinlo [peter@unaffiliated/kinlo] has joined #bitcoin-core-dev 12:24 -!- Netsplit over, joins: fengling 12:24 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 12:24 -!- Netsplit over, joins: zxzzt 12:24 -!- owowo [ovovo@unaffiliated/ovovo] has quit [Changing host] 12:24 -!- owowo [ovovo@gateway/vpn/mullvad/x-cgpalkkcalnxhnou] has joined #bitcoin-core-dev 12:24 -!- jl2012 [uid133844@unaffiliated/jl2012] has quit [Changing host] 12:24 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-jcmiqzzflvizwaoe] has joined #bitcoin-core-dev 12:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/session] has joined #bitcoin-core-dev 12:24 -!- ghtdak is now known as Guest45108 12:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/session] has quit [Changing host] 12:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hofklcldkglscuhw] has joined #bitcoin-core-dev 12:24 -!- arubi [~ese168@unaffiliated/arubi] has quit [Max SendQ exceeded] 12:24 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has joined #bitcoin-core-dev 12:24 -!- Madars is now known as Guest14267 12:24 -!- petertodd is now known as Guest58799 12:24 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 12:24 -!- Guest45108 [~ghtdak@173-10-78-129-BusName-Washington.hfc.comcastbusiness.net] has quit [Quit: WeeChat 1.4] 12:24 -!- ghtdak_ [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev 12:25 -!- ghtdak_ [~ghtdak@unaffiliated/ghtdak] has quit [Client Quit] 12:25 -!- Netsplit over, joins: niska 12:25 -!- ghtdak_ [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev 12:25 -!- ghtdak_ [~ghtdak@unaffiliated/ghtdak] has quit [Client Quit] 12:27 -!- gluytium [~g@45.63.97.181] has quit [Max SendQ exceeded] 12:30 -!- Netsplit over, joins: gribble 12:31 -!- Netsplit over, joins: morcos 12:31 -!- fengling [~fengling@60.10.200.118] has quit [Ping timeout: 268 seconds] 12:34 -!- Guest14267 [~null@contents-vnder-pressvre.mit.edu] has quit [Quit: reconnect] 12:36 -!- Netsplit over, joins: BCBot 12:37 -!- Madars_ [~null@unaffiliated/madars] has joined #bitcoin-core-dev 12:45 -!- gluytium [~g@45.63.97.181] has joined #bitcoin-core-dev 12:46 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-mihymkurbpttuqak] has joined #bitcoin-core-dev 12:48 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-zmvygnwxhmsvliuh] has joined #bitcoin-core-dev 12:54 < GitHub83> [bitcoin] MarcoFalke opened pull request #8716: [qa] wallet: Check legacy wallet as well (master...Mf1609-qaWalletLegacy) https://github.com/bitcoin/bitcoin/pull/8716 12:56 -!- fengling [~fengling@60.10.203.207] has joined #bitcoin-core-dev 12:56 -!- mturquette [sid66043@gateway/web/irccloud.com/x-uughgfplczjhrekl] has joined #bitcoin-core-dev 12:58 -!- limpkin [sid20909@gateway/web/irccloud.com/x-mtwmmazhxemvczfk] has joined #bitcoin-core-dev 12:59 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-fhvnzpldhohvoqwg] has joined #bitcoin-core-dev 13:01 -!- binns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev 13:01 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-jtjzvvedmnjcxgsj] has joined #bitcoin-core-dev 13:02 -!- zmanian__ [sid113594@gateway/web/irccloud.com/x-otsenxlwizzbpiyc] has joined #bitcoin-core-dev 13:02 -!- mappum [sid43795@gateway/web/irccloud.com/x-aylckcjxvpzvmyjs] has joined #bitcoin-core-dev 13:05 -!- fengling [~fengling@60.10.203.207] has quit [Ping timeout: 268 seconds] 13:07 -!- Expanse [sid146237@gateway/web/irccloud.com/x-zfanrqteqjzwzwni] has joined #bitcoin-core-dev 13:12 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 13:18 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds] 13:19 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 13:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 13:22 -!- dermoth [~thomas@24.114.85.189] has quit [Ping timeout: 244 seconds] 13:24 -!- achow101 [~achow101@129.2.206.174] has quit [Ping timeout: 240 seconds] 13:25 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 13:26 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 13:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 13:35 -!- fengling [~fengling@60.10.203.207] has joined #bitcoin-core-dev 13:36 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Ping timeout: 240 seconds] 13:38 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has left #bitcoin-core-dev [] 13:40 -!- dermoth [~thomas@24.114.97.129] has joined #bitcoin-core-dev 13:42 -!- eenoch [~eenoch@unaffiliated/eenoch] has joined #bitcoin-core-dev 13:45 -!- fengling [~fengling@60.10.203.207] has quit [Ping timeout: 268 seconds] 13:51 -!- achow101 [~achow101@129-2-207-18.student.umd.edu] has joined #bitcoin-core-dev 14:14 -!- Yogh [~Yogh@f36186.upc-f.chello.nl] has quit [Ping timeout: 250 seconds] 14:16 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 14:16 -!- Yogh [~Yogh@f36186.upc-f.chello.nl] has joined #bitcoin-core-dev 14:21 -!- Netsplit *.net <-> *.split quits: owowo, dermoth 14:22 -!- Netsplit over, joins: dermoth 14:25 -!- fengling [~fengling@60.10.203.207] has joined #bitcoin-core-dev 14:28 -!- Netsplit *.net <-> *.split quits: Naphex, mjdecour, blkdb 14:30 -!- fengling [~fengling@60.10.203.207] has quit [Ping timeout: 268 seconds] 14:32 -!- owowo [ovovo@gateway/vpn/mullvad/x-tkkwivilgxlwvzyh] has joined #bitcoin-core-dev 14:32 -!- owowo [ovovo@gateway/vpn/mullvad/x-tkkwivilgxlwvzyh] has quit [Changing host] 14:32 -!- owowo [ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 14:32 -!- owowo [ovovo@unaffiliated/ovovo] has quit [Changing host] 14:32 -!- owowo [ovovo@gateway/vpn/mullvad/x-tkkwivilgxlwvzyh] has joined #bitcoin-core-dev 14:40 -!- droark [~droark@50-233-123-210-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:58 -!- Naphex [~naphex@naphex.rocks] has joined #bitcoin-core-dev 15:00 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has joined #bitcoin-core-dev 15:06 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds] 15:07 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds] 15:08 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 15:08 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 15:28 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds] 15:28 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds] 15:30 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 15:30 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 15:30 < GitHub132> [bitcoin] spencerlievens opened pull request #8717: [WALLET] Addition of ImmatureCreditCached to MarkDirty() (master...patch-2) https://github.com/bitcoin/bitcoin/pull/8717 15:31 < GitHub169> [bitcoin] SCDeveloper closed pull request #8703: Addition of ImmatureCreditCached to MarkDirty() (master...patch-5) https://github.com/bitcoin/bitcoin/pull/8703 15:46 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 244 seconds] 15:47 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds] 15:48 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 15:48 -!- morcos [~morcos@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:52 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds] 15:54 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 16:01 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev 16:14 -!- fengling [~fengling@60.10.203.207] has joined #bitcoin-core-dev 16:15 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: power off] 16:20 -!- fengling [~fengling@60.10.203.207] has quit [Ping timeout: 268 seconds] 16:41 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds] 16:42 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 16:48 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 255 seconds] 16:51 -!- Guest58799 is now known as petertodd 16:51 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 16:55 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds] 16:56 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 16:57 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:57 -!- aalex [~aalex@64.187.177.58] has quit [Max SendQ exceeded] 16:57 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 17:04 -!- zxzzt [~prod@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 17:08 -!- fengling [~fengling@60.10.203.207] has joined #bitcoin-core-dev 17:13 -!- fengling [~fengling@60.10.203.207] has quit [Ping timeout: 268 seconds] 17:33 -!- droark [~droark@50-233-123-210-static.hfc.comcastbusiness.net] has quit [Quit: ZZZzzz…] 17:37 -!- fengling [~fengling@60.10.203.207] has joined #bitcoin-core-dev 17:39 -!- justanotheruser [~justanoth@24.219.72.136] has quit [Quit: WeeChat 1.4] 17:39 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 17:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:42 -!- fengling [~fengling@60.10.203.207] has quit [Ping timeout: 268 seconds] 17:46 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hofklcldkglscuhw] has quit [Quit: Connection closed for inactivity] 17:52 -!- fengling [~fengling@60.10.203.207] has joined #bitcoin-core-dev 17:57 -!- fengling [~fengling@60.10.203.207] has quit [Ping timeout: 268 seconds] 17:59 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 18:04 -!- justanotheruser is now known as hughmungus 18:04 -!- hughmungus is now known as justanotheruser 19:04 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev 19:07 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-fhvnzpldhohvoqwg] has quit [Quit: Connection closed for inactivity] 19:49 -!- fengling [~fengling@60.10.200.118] has quit [Ping timeout: 268 seconds] 20:06 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev 20:07 -!- fengling [~fengling@60.10.200.118] has quit [Client Quit] 20:20 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:21 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:22 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 20:24 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 20:31 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 20:35 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:36 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:47 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 20:53 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:54 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:00 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 21:00 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 21:07 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:08 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:21 -!- aj_ is now known as aj 21:23 -!- netsin [~netsin@unaffiliated/jiggalator] has joined #bitcoin-core-dev 21:30 -!- netsin [~netsin@unaffiliated/jiggalator] has quit [Remote host closed the connection] 21:31 -!- Ismar [ac04b62a@gateway/web/freenode/ip.172.4.182.42] has joined #bitcoin-core-dev 21:36 -!- Ismar [ac04b62a@gateway/web/freenode/ip.172.4.182.42] has quit [Ping timeout: 240 seconds] 21:49 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:50 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 22:00 -!- Squidicc [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has quit [Read error: Connection reset by peer] 22:00 -!- Squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 22:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 22:03 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:04 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:05 -!- Squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has quit [Ping timeout: 265 seconds] 22:09 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-uuiottdcbxbvfyyh] has joined #bitcoin-core-dev 22:12 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has left #bitcoin-core-dev [] 22:13 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 22:47 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 22:56 -!- owowo [ovovo@gateway/vpn/mullvad/x-tkkwivilgxlwvzyh] has quit [Ping timeout: 255 seconds] 23:01 -!- Squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 23:13 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 23:14 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 23:25 -!- Madars_ is now known as Madars 23:32 -!- assder [2e3b026a@gateway/web/freenode/ip.46.59.2.106] has joined #bitcoin-core-dev 23:32 < GitHub186> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa7caf6d9116...57b34599b2de 23:32 < GitHub186> bitcoin/master 1b6bcdd Jonas Schnelli: Remove maxuploadtargets recommended minimum 23:32 < GitHub186> bitcoin/master 57b3459 Jonas Schnelli: Merge #8712: Remove maxuploadtargets recommended minimum... 23:33 < GitHub42> [bitcoin] jonasschnelli closed pull request #8712: Remove maxuploadtargets recommended minimum (master...2016/09/rem_maxupt_min) https://github.com/bitcoin/bitcoin/pull/8712 23:43 -!- owowo [ovovo@gateway/vpn/mullvad/x-decfthfismoywygk] has joined #bitcoin-core-dev 23:48 < jonasschnelli> I guess the Travis master issue is due to a random flickering in walletbackup.py 23:50 < jonasschnelli> Would be nice if anyone could review/ACK/NACK https://github.com/bitcoin/bitcoin/pull/7783 (nested RPC commands). 23:51 < dcousens> jonasschnelli: how would you extend it to the RPC? 23:52 < jonasschnelli> dcousens: there are no plans to extend it to the RPC layer... the PR once had support for RPC but we decided to keep it QT only for now. 23:52 < jonasschnelli> Moving the function RPCExecuteCommandLine(std::string &strResult, const std::string &strCommand) to a core class would be trivial. 23:53 < jonasschnelli> We could either have a special RPC command that result in parsing and executing multiple nested commands...but I don't think this would be clever. 23:53 < jonasschnelli> The Qt version is "client-side". 23:53 < sipa> i'd have liked that, but it seems i was alone with that :) 23:53 < jonasschnelli> A better approach for the RPC layer would be to add it into bitcoin-cli 23:54 < jonasschnelli> Having it server-side i just fear some uncontrollable resource usage. 23:54 < jonasschnelli> I think its better to start with it client-side QT only, and if it turns to be useful, add it to bitcoin-cli. 23:54 < sipa> rpc already has uncontrollable resource usage 23:54 < dcousens> Personally I just always used bash, but I never use the QT UI so *shrug* 23:54 < sipa> fair enough :) 23:55 < jonasschnelli> dcousens: Adding in in Qt has less of exposures... a better test-bed .:) 23:55 < jonasschnelli> *it 23:55 < dcousens> As for the RPC extension, I think a special RPC command, say a mechanism to chain calls - makes sense, would feel like the idea by wumpus, but won't break all our RPC implementations 23:56 < dcousens> s/break/require changing 23:56 < dcousens> as for resource usage, RPC is already meant to be a "safe space", haha 23:57 < sipa> well if we turn it into an RPC thing, we'd arguably want more discussion about what the "query language" will look like 23:57 < sipa> as it may be harder to make incompatible changes latee 23:58 < dcousens> sipa: absolutely, the amount of time to get right may not be worth the extra line/rpc call for the few times this matters :P 23:58 < jonasschnelli> The query language is pretty homebrew and non-standard.. 23:59 < jonasschnelli> Also,... once we have it in RPC, people are going to see it as part of the API... 23:59 < jonasschnelli> changes at this point will probably more "difficult". 23:59 < jonasschnelli> Lets find out through Qt how it could work in RPC. :) 23:59 < dcousens> ultimately any bulk usage of the RPC ends up seeing the piped network latency being completely insignificant... and chaining the commands won't lower the JSON bulk 23:59 < dcousens> unless their doing it over an open network I suppose