--- Day changed Thu Oct 06 2016 00:14 -!- rubensayshi [~ruben@82.201.92.138] has joined #bitcoin-core-dev 00:18 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fcirwpntegkbwebm] has joined #bitcoin-core-dev 00:19 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 00:26 -!- laurentmt [~Thunderbi@80.215.234.232] has joined #bitcoin-core-dev 00:28 < GitHub95> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/223f4c2dd5fa...61d191fbf953 00:28 < GitHub95> bitcoin/master 7d8afb4 fanquake: [Doc] Improve GitHub issue template 00:28 < GitHub95> bitcoin/master 61d191f MarcoFalke: Merge #8887: [Doc] Improve GitHub issue template... 00:28 < GitHub95> [bitcoin] MarcoFalke closed pull request #8887: [Doc] Improve GitHub issue template (master...link-stackexchange) https://github.com/bitcoin/bitcoin/pull/8887 00:28 -!- laurentmt [~Thunderbi@80.215.234.232] has quit [Client Quit] 00:28 -!- laurentmt [~Thunderbi@80.215.234.232] has joined #bitcoin-core-dev 00:29 -!- laurentmt [~Thunderbi@80.215.234.232] has quit [Client Quit] 00:31 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:20 -!- h1d [~h1d@unaffiliated/h1d] has joined #bitcoin-core-dev 01:20 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:21 -!- h1d [~h1d@unaffiliated/h1d] has quit [Client Quit] 01:28 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Read error: Connection reset by peer] 01:29 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 01:55 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 01:56 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 02:04 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 265 seconds] 02:04 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 02:05 -!- mkarrer [~mkarrer@159.red-83-47-122.dynamicip.rima-tde.net] has quit [Read error: No route to host] 02:05 -!- mkarrer_ [~mkarrer@159.red-83-47-122.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 02:09 -!- rexnsh [~ensign@2001:41d0:8:d711::1] has quit [Changing host] 02:09 -!- rexnsh [~ensign@wikipedia/nsh] has joined #bitcoin-core-dev 02:46 -!- GAit [~GAit@2-228-102-98.ip191.fastwebnet.it] has joined #bitcoin-core-dev 02:55 -!- GAit1 [~GAit@212.91.77.38] has joined #bitcoin-core-dev 02:58 -!- GAit [~GAit@2-228-102-98.ip191.fastwebnet.it] has quit [Ping timeout: 264 seconds] 02:58 < NicolasDorier> roasbeef: You can now measure your size https://testnet.smartbit.com.au/block/0000000000001280a3d758cb956e565daffd5af0e6b6723f28e1cbcda0da8652 ;) 02:59 -!- shesek [~shesek@bzq-84-110-55-54.red.bezeqint.net] has quit [Ping timeout: 252 seconds] 03:00 < btcdrak> ah, great it's been made segwitty 03:02 -!- GAit1 [~GAit@212.91.77.38] has quit [Quit: Leaving.] 03:05 -!- shesek [~shesek@bzq-84-110-55-54.red.bezeqint.net] has joined #bitcoin-core-dev 03:11 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 03:14 -!- shesek [~shesek@bzq-84-110-55-54.red.bezeqint.net] has quit [Ping timeout: 272 seconds] 03:29 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:30 -!- aalex_ [~aalex@64.187.177.58] has quit [Ping timeout: 252 seconds] 03:30 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 03:34 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev] 04:04 -!- cdecker [~quassel@2a02:aa16:1105:4a80:b16e:e2a4:ecd2:4483] has joined #bitcoin-core-dev 04:08 -!- GAit [~GAit@212.91.77.38] has joined #bitcoin-core-dev 04:19 -!- laurentmt [~Thunderbi@80.215.234.232] has joined #bitcoin-core-dev 04:19 -!- laurentmt [~Thunderbi@80.215.234.232] has quit [Client Quit] 04:23 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 04:39 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:46 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 04:47 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 05:14 -!- laurentmt [~Thunderbi@80.215.234.232] has joined #bitcoin-core-dev 05:17 -!- laurentmt [~Thunderbi@80.215.234.232] has quit [Client Quit] 05:23 -!- murch [~murch@p4FE382C4.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 05:31 -!- waxwing [~waxwing@93-33-110-54.ip44.fastwebnet.it] has joined #bitcoin-core-dev 05:32 -!- jnewbery [~jnewbery@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 05:36 -!- meowzus [~meowzus@bas8-hamilton14-2925006729.dsl.bell.ca] has joined #bitcoin-core-dev 05:36 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fcirwpntegkbwebm] has quit [Ping timeout: 256 seconds] 05:36 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-ygpcmldnlitucofw] has quit [Ping timeout: 252 seconds] 05:39 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rusikxtaaeiokrmw] has joined #bitcoin-core-dev 05:41 -!- laurentmt [~Thunderbi@80.215.234.232] has joined #bitcoin-core-dev 05:41 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-hljjpixlxhnzligo] has joined #bitcoin-core-dev 06:03 -!- laurentmt [~Thunderbi@80.215.234.232] has quit [Quit: laurentmt] 06:28 -!- GAit [~GAit@212.91.77.38] has quit [Quit: Leaving.] 06:29 -!- GAit [~GAit@212.91.77.38] has joined #bitcoin-core-dev 06:32 -!- jtimon [~quassel@150.110.132.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 06:42 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [] 06:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:53 -!- rubensayshi [~ruben@82.201.92.138] has quit [Remote host closed the connection] 06:58 -!- GAit [~GAit@212.91.77.38] has quit [Quit: Leaving.] 07:09 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 07:24 < morcos> gmaxwell: sorry i missed discussion yesterday on the cuckoo sigcache. jeremyrubin and i did put a LOT of work into different designs. but i do think this design if far better than the existing sig cache. 07:24 < sipa> morcos: i don't think there is doubt that it's better :) 07:25 < morcos> it might be fine to reduce the depth limit or untie it from the size of the table. but i seriously doubt it impacts the performance of ATMP. (once we saw how inefficient the old deleting behavior was anyway) 07:25 < jeremyrubin> wumpus: it wasn't a serious suggestion ;) 07:26 < morcos> one thing to keep in mind is that with a 40MB sigcache, it probably isn't going to get full except in the event of an attack. i ran a simulation over 6 months, and i was getting very close to the maximal possible hit rate on a 40MB cache. 07:26 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 07:26 < morcos> the fact that we delete sigs that were in blocks makes a HUGE difference 07:26 < sipa> morcos: yes... but we should know how it behaves in case of an attack as well 07:26 < sipa> without attack, i expect the size of the cache to not even matter that much 07:26 < sipa> as we'll only ever have live entries in it 07:27 < morcos> my idea for how to make it even more fool proof from ever getting full would be to implement a Rolling version where you have 2 and insert and check in both of them and then alternately clear them after some amount of time 07:27 < sipa> morcos: ha, the old rolling bloom filter design :) 07:27 < morcos> sipa: in the absence of attack there are still txs that get generated but are never mined (replaced, doublespent, too low fee) 07:27 < sipa> right 07:27 < morcos> sipa: yeah i just didn't think it was worth the complication for the first PR 07:28 < sipa> morcos: completely agreed 07:28 * sipa just hopes 0.13.1 is out the door soon 07:28 < jeremyrubin> generations are better than rolling I think 07:28 < sipa> jeremyrubin: yes, i think so 07:29 < sipa> especially given your entries are already 128-256 bits, adding a few bits for a generation number doesn't add much 07:29 < sipa> using two staggered sets effectively makes your entries twice the size 07:29 < sipa> or even 4 times 07:30 < morcos> sure, sounds good to me too 07:30 < sipa> as in the worst case time, you just emptied one, and the other one is half full, so you have 25% utilization of your entire set 07:30 < jeremyrubin> Also fee is maybe even better than generations 07:31 < sipa> use an ARC :) 07:31 < jeremyrubin> You can also emulate generations 07:31 < jeremyrubin> by createnewblocking a 10mb block or something from mempool 07:31 < jeremyrubin> after deleting a bunch of things randomly 07:31 < jeremyrubin> if you want 0 memory overhead 07:31 < sipa> https://en.wikipedia.org/wiki/Adaptive_replacement_cache 07:32 < jeremyrubin> sipa: ah, not automatic reference counting 07:32 < jeremyrubin> ARC seems not to work for this use case? 07:32 < jeremyrubin> Things are write once read once? 07:33 < sipa> ah, i'm confusing with the coin cache 07:53 -!- limpkin [sid20909@gateway/web/irccloud.com/x-bszmcbhqblmabwai] has quit [Ping timeout: 265 seconds] 07:54 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-yausoefdbsmkajua] has quit [Ping timeout: 265 seconds] 07:54 -!- aalex [uid189135@gateway/web/irccloud.com/x-dnqefolnfficvtgp] has quit [Ping timeout: 272 seconds] 07:55 -!- michagogo [uid14316@wikia/Michagogo] has quit [Write error: Connection reset by peer] 07:59 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 08:06 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 08:13 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 08:34 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-fnnljlibqeptdxln] has joined #bitcoin-core-dev 08:35 -!- aalex [uid189135@gateway/web/irccloud.com/x-hlllflsfxoxzeaxn] has joined #bitcoin-core-dev 08:35 -!- limpkin [sid20909@gateway/web/irccloud.com/x-hmachbnaxchnsdss] has joined #bitcoin-core-dev 08:46 -!- laurentmt [~Thunderbi@80.215.234.232] has joined #bitcoin-core-dev 08:49 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 08:53 -!- laurentmt [~Thunderbi@80.215.234.232] has quit [Quit: laurentmt] 08:59 -!- jnewbery [~jnewbery@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Remote host closed the connection] 09:00 -!- jnewbery [~jnewbery@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 09:04 -!- jnewbery [~jnewbery@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 265 seconds] 09:11 -!- droark [~droark@host191-16-static.241-95-b.business.telecomitalia.it] has joined #bitcoin-core-dev 09:15 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev] 09:21 -!- jnewbery [~jnewbery@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 09:38 -!- cchadwicka1 [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has joined #bitcoin-core-dev 09:40 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 09:56 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 09:56 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 09:56 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 10:06 < gmaxwell> morcos: part of the reason I was asking questions is that I wasn't sure if we knew how it would perform once someone sent in a huge set of junk transactions. But have no doubt, I'm sure its much better than what we currently have. 10:07 < gmaxwell> I'm surprised it didn't bencmark out as faster with only a single thread. 10:08 < morcos> gmaxwell: it was ever so slightly faster (1%) for a single thread, but thats within noise. i just think the amount of time taken in either case is small, it was only the lock contention that was a true problem. 10:09 < morcos> but now you inspired a hopefully efficient generation keeping design that will never get full, but only delete old generations if it needs to.. :) 10:11 < gmaxwell> sipa: re generation number, I had just assumed the entries would be changed to 252 bits, so you'd only lose at most 6% at a time, and would only delete things if it had to. 10:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:15 < morcos> the idea jeremyrubin and i want to try is actually a separate bit vector that just keeps track of whehter each entry is in the current generation or not. that's only touched during insert, so its lock free. and then use a simple heuristic to trigger an occasional testforcleanup. 10:16 < morcos> when doing that you just loop that vector and the garbage collection vector and if the current generation not marked for deletion is > 25% of capacity then mark for deletion old generation and increase generation. 10:17 < morcos> that has the nice property that you don't actually delete old things unless you have to, but under an attack you'll delete them often enough to stop yourself getting full. 10:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 10:22 -!- laurentmt [~Thunderbi@80.215.234.232] has joined #bitcoin-core-dev 10:26 -!- laurentmt [~Thunderbi@80.215.234.232] has quit [Client Quit] 10:45 < gmaxwell> I wish we could easily delete based on an entry being in the top of the mempool or not. 10:45 < gmaxwell> hm. I suppose that when we evict something from the mempool, we could revalidate it again with the cache in delete mode. 10:45 < gmaxwell> that would be kinda like that. 10:46 < gmaxwell> or insert things with a lower feerate 1 or two generations behind the current generation. (assuming many generations) 10:50 < michagogo> Today's lesson in my programming lessons: threading is hard 10:51 < sdaftuar> gmaxwell: i was thinking about doing that (revalidate in delete mode) for things that we don't accept to our mempool, as well 10:51 < morcos> gmaxwell: with a 40MB cache, it's just not necessary to make further optimizations. someone would have to flood you with 250k excess signatures in order for you to start marking for deletion things older than when the flood started. 10:51 < michagogo> (Also, each iteration of a for loop has its own scope for local variables, and those variables stick around even after the iteration is done and the name is reused for something else) 10:52 < morcos> if that time frame is recent enough that its causing a problem for your cache hit rate, then i think that implies your bigger problem is the tx flood and the DoS on checking all those sigs in the first place 10:52 < michagogo> (or rather, reused for the next iteration) 10:54 < gmaxwell> morcos: okay, for some reason I thought sipa's measurements had shown that we still had a needlessly low hitrate. 10:56 < morcos> gmaxwell: hmm, i'd be interested to see that, but i think any low hit rates we have are probably due to txs we never accepted to our mempool in the first place, not sigs that we accidentally evicted.. 10:57 < gmaxwell> yea, I may be conflating things. it might be that right now its from things we never accept, and when sipa tried validating everything, we found it tainted the cache. 10:58 < morcos> gmaxwell: i attempted an approximation by inserting 10 random signatures for every tx my node saw and deleting those same 10 if the tx appeared in a block 10:59 -!- cdecker [~quassel@2a02:aa16:1105:4a80:b16e:e2a4:ecd2:4483] has quit [Quit: No Ping reply in 180 seconds.] 10:59 < morcos> i ran that for 6 months and the hit rate was 98.35% on average, whereas perfect would have been 98.38% and the existing algo was 97.99%. with 40MB 11:00 < gmaxwell> hm. why was the existing algo lower? 11:00 < morcos> in reality many of those txs probably wouldn't have passed ATMP and made it into the cache, leading to a lower hit rate in practice, but not due to cache filling 11:00 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has quit [Remote host closed the connection] 11:00 -!- cdecker [~quassel@2a02:aa16:1105:4a80:7d5e:e317:2172:99d3] has joined #bitcoin-core-dev 11:00 < morcos> gmaxwell: primarily because you can cram more signatures in 40MB with the new design 11:00 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has joined #bitcoin-core-dev 11:00 < morcos> and partially because on a reorg the old algo doesn't have them, but the new one does with high probability 11:00 < gmaxwell> Makes sense. 11:01 < gmaxwell> yea, I'm really happy about the delete flag. I really didn't like the current code's behavior under reorg. 11:01 < gmaxwell> not good for network convergence for reorg to be much slower. 11:02 < morcos> gmaxwell: heh, probably MANY things to improve there 11:02 < gmaxwell> yes. but any improvement is good. :) 11:03 < gmaxwell> I'd take a wag that the validation performance limiter is now the additional sha256 used in the lookup. 11:06 -!- cchadwicka1 [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has quit [Read error: Connection reset by peer] 11:07 -!- cchadwicka [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has joined #bitcoin-core-dev 11:08 -!- jnewbery [~jnewbery@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [] 11:08 < morcos> gmaxwell: as far as jeremyrubin and i can tell, the biggest limiter now is how much you blow out your various machine caches with different permutations of coinsviewcache size and flushing algo, sig cache lookup pattern, etc.. although this tends to affect performance AFTER validation has finished. i.e. slows down removeForBlock 11:08 -!- Frederic94500 [4d808e1f@gateway/web/freenode/ip.77.128.142.31] has joined #bitcoin-core-dev 11:09 < morcos> to really get better performance we'll need to switch data representations to eliminate so much allocating, deallocating and copying of vectors. 11:10 < morcos> but sdaftuar's idea is the next lowest hanging fruit is to just speed the path from validation finished to actually relaying to new peers, which isn't optimized at all right now 11:10 -!- cchadwicka1 [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has joined #bitcoin-core-dev 11:10 < gmaxwell> well BIP152 allows you to send the block before its verified. 11:10 < gmaxwell> so that would be an obvious thing to actually do. 11:11 < morcos> sure. same issue still applies though. you're just deciding to send it earlier. 11:12 -!- cchadwicka1 [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has quit [Read error: Connection reset by peer] 11:13 < sdaftuar> i think gmaxwell's point is that the way you'd do that would be in the handling of eg ProcessNewBlock, so it'd actually go out earlier (rather than in SendMessages) 11:13 -!- cchadwicka [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has quit [Ping timeout: 265 seconds] 11:13 < sdaftuar> that's basically what i was planning to do 11:13 < gmaxwell> well it gets the whole validation process out of that critical path. 11:14 -!- cchadwicka [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has joined #bitcoin-core-dev 11:14 -!- cchadwicka [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has quit [Read error: Connection reset by peer] 11:16 -!- cchadwicka [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has joined #bitcoin-core-dev 11:20 -!- cchadwicka1 [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has joined #bitcoin-core-dev 11:21 -!- cchadwicka [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has quit [Ping timeout: 252 seconds] 11:29 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 11:34 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:40 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: Leaving.] 11:52 -!- Frederic94500 [4d808e1f@gateway/web/freenode/ip.77.128.142.31] has quit [Ping timeout: 240 seconds] 11:55 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 11:57 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:01 -!- cchadwicka1 [~ident@99-60-70-220.lightspeed.ltrkar.sbcglobal.net] has quit [Quit: —I-n-v-i-s-i-o-n— 3.3 (November '11)] 12:01 < michagogo> (Go figure... After a bunch of weeks of having something else every time, this week I'm around but the meeting is cancelled) 12:02 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 12:14 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:18 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 12:20 < jeremyrubin> gmaxwell: note you don't actually have to re-evaluate the signature, just see if it's hash is present on eviction (but you still need to eval script to extract signatures) 12:22 -!- Frederic94500 [4d808e1f@gateway/web/freenode/ip.77.128.142.31] has joined #bitcoin-core-dev 12:29 -!- Frederic94500 [4d808e1f@gateway/web/freenode/ip.77.128.142.31] has quit [Ping timeout: 240 seconds] 12:36 -!- cdecker [~quassel@2a02:aa16:1105:4a80:7d5e:e317:2172:99d3] has quit [Ping timeout: 252 seconds] 12:54 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 272 seconds] 12:54 -!- drnet [~drnett@77.119.131.90] has joined #bitcoin-core-dev 12:57 -!- drnet [~drnett@77.119.131.90] has quit [Client Quit] 13:01 -!- jtimon [~quassel@150.110.132.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 13:14 -!- JackH [~laptop@79-73-187-88.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 13:14 -!- e4xit [~e4xit@cpc92302-cmbg19-2-0-cust1369.5-4.cable.virginm.net] has quit [Quit: Right I'm out!] 13:22 -!- JackH [~laptop@79-73-187-88.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 13:28 -!- cjcj [d4555899@gateway/web/freenode/ip.212.85.88.153] has quit [Quit: Page closed] 13:28 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 13:29 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 13:34 -!- GAit [~GAit@93.56.73.119] has joined #bitcoin-core-dev 13:35 -!- GAit [~GAit@93.56.73.119] has quit [Client Quit] 13:39 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has quit [Disconnected by services] 13:39 -!- drizztbsd [~quassel@archlinux/trusteduser/DrizztBSD] has joined #bitcoin-core-dev 13:39 -!- drizztbsd is now known as timothy 13:44 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Quit: ZNC 1.6.3+deb1 - http://znc.in] 13:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:47 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 13:58 -!- JackH [~laptop@79-73-187-88.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 14:01 -!- HG [bc78d41d@gateway/web/cgi-irc/kiwiirc.com/ip.188.120.212.29] has joined #bitcoin-core-dev 14:02 -!- HG [bc78d41d@gateway/web/cgi-irc/kiwiirc.com/ip.188.120.212.29] has quit [Client Quit] 14:03 -!- Fonslls [bc78d41d@gateway/web/cgi-irc/kiwiirc.com/ip.188.120.212.29] has joined #bitcoin-core-dev 14:04 -!- Fonslls [bc78d41d@gateway/web/cgi-irc/kiwiirc.com/ip.188.120.212.29] has quit [Client Quit] 14:42 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:55 -!- cdecker [~quassel@2a02:aa16:1105:4a80:69ef:ff0a:b45e:2ab4] has joined #bitcoin-core-dev 14:57 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 15:01 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has quit [Disconnected by services] 15:01 -!- drizztbsd [~quassel@archlinux/trusteduser/DrizztBSD] has joined #bitcoin-core-dev 15:01 -!- drizztbsd is now known as timothy 15:12 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 15:39 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 15:48 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev 15:52 -!- GAit1 [~GAit@2-230-161-158.ip202.fastwebnet.it] has joined #bitcoin-core-dev 15:55 -!- GAit1 [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Client Quit] 15:56 -!- GAit [~GAit@2-230-161-158.ip202.fastwebnet.it] has quit [Ping timeout: 264 seconds] 16:05 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 16:15 -!- murch [~murch@p4FE382C4.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 16:43 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.1/20160922113459]] 17:13 < achow101> someone's spamming the github. please ban him 17:39 -!- JackH [~laptop@79-73-187-88.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 17:57 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rusikxtaaeiokrmw] has quit [Quit: Connection closed for inactivity] 18:02 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 263 seconds] 18:05 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 18:06 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 18:12 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Ping timeout: 244 seconds] 18:22 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 18:23 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 18:29 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 18:33 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 18:37 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 18:38 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 18:52 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 18:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 19:01 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 244 seconds] 19:05 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 19:07 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 264 seconds] 19:08 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 19:13 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 19:20 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:21 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 19:31 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:32 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 19:47 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:48 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:05 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer] 20:05 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 20:08 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:09 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:21 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:22 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 20:32 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:33 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:37 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 272 seconds] 20:40 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 20:43 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:44 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:57 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:58 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:16 < NicolasDorier> jl2012: I see that on https://github.com/bitcoin/bitcoin/pull/8499 we don't have any test in script_tests.json are you working on it or should I do it ? 21:17 < jl2012> NicolasDorier: I'm trying to do. But since the signing is disabled now it's a bit tricky 21:18 < jl2012> can't be automatic signing 21:18 < NicolasDorier> signing disabled ? I missed an episode 21:18 < jl2012> https://github.com/bitcoin/bitcoin/pull/8499/commits/3a4048de42e351d302c202ee8879a8fd4706e7f2 21:19 < NicolasDorier> ok 21:19 -!- waxwing [~waxwing@93-33-110-54.ip44.fastwebnet.it] has quit [Read error: Connection reset by peer] 21:19 < NicolasDorier> I can do it 21:19 < jl2012> there are several cases to test 21:20 < NicolasDorier> can you send that to me ? I will do it. Quite easy with nbitcoin 21:20 -!- waxwing [~waxwing@93-33-110-54.ip44.fastwebnet.it] has joined #bitcoin-core-dev 21:20 < jl2012> P2WPKH to uncompressed key (which is already tested in https://github.com/sdaftuar/bitcoin/commit/eeb9e9440fc0a6c1bfbbfc81905dae08af3dc0cb) 21:20 < jl2012> and some P2WSH cases 21:21 < jl2012> 0 1 2 CHECKMULTISIG should fail 21:21 < jl2012> 0 1 2 CHECKMULTISIG should also fail 21:21 < jl2012> 0 1 2 CHECKMULTISIG should pass 21:21 < jl2012> 0 1 2 CHECKMULTISIG should fail 21:21 < jl2012> the 3rd one should pass because the u-key2 is never used 21:22 < NicolasDorier> ok thanks, I'll do it 21:22 < jl2012> thanks! 21:24 < jl2012> i think it's obvious but " 0 IF CHECKSIG ENDIF" should pass 21:33 < sipa> jl2012: script_tests has its own signer code for the automatically generated tests 21:34 < sipa> it should work fine with uncompressed pubkeys 21:34 < sipa> it's also advantageous to use such automatically generated tests, as they're easier to recreate or adapt to newer scenarios later 21:35 < jl2012> ok, I see what you mean 21:36 < jl2012> TestBuilder& PushSig 21:51 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Quit: No Ping reply in 180 seconds.] 21:53 < sipa> you can disable the define at the top of the file 21:53 < sipa> and running the test will cause it to write out the json form 21:54 < sipa> which you can then copy-paste into the distribution file 21:55 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 22:00 -!- dermoth [~thomas@dsl-66-36-135-108.mtl.aei.ca] has quit [Read error: Connection reset by peer] 22:01 -!- dermoth [~thomas@dsl-66-36-135-108.mtl.aei.ca] has joined #bitcoin-core-dev 22:08 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:09 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:10 -!- droark [~droark@host191-16-static.241-95-b.business.telecomitalia.it] has quit [Quit: ZZZzzz…] 22:19 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:19 < NicolasDorier> jl2012: do you have the private key for the tests P2WSH in script_tests ? I see that the tests changed and they don't pass in NBitcoin anymore :/ 22:20 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:22 < NicolasDorier> actually this is strange... the public key hash of the test changed, but not the signature oO 22:22 < NicolasDorier> public key I mean 22:23 < NicolasDorier> well nevermind... investigating 22:29 < sipa> changing the compression of pubkeys does not change the signatures 22:31 < jl2012> NicolasDorier, I'm also working on script_tests 22:31 < NicolasDorier> sipa: that's not the problem, I'm catching up with the other recent changes in script_tests for now 22:31 < NicolasDorier> in NBitcoin test suite 22:32 < NicolasDorier> and now the test "Basic P2WSH" fail for some reason 22:32 < NicolasDorier> trying to findout why 22:32 < NicolasDorier> on the signature 22:32 < NicolasDorier> if you know the private key, I can checkout why 22:33 < jl2012> i guess the key is generated on the fly? 22:34 < NicolasDorier> no, I'm talking about script_tests.json 22:34 < jl2012> NicolasDorier: https://github.com/jl2012/bitcoin/commits/badwitnesscheck-tmp 22:34 < jl2012> this is what I have done so far 22:35 < NicolasDorier> my problem right now is with the script_tests.json as is in master... will find out 22:36 < jl2012> ok, then I'll keep working on script_test.cpp . 22:48 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:49 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:52 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tbdcalxlwvfjwcpg] has joined #bitcoin-core-dev 22:52 < NicolasDorier> found the problem finally 22:52 < NicolasDorier> jl2012: what tests are you doing ? if you are speaking about the one for uncompressed public key, I can do them 22:53 < jl2012> yes, i'm doing it in script_test.cpp 22:55 < jl2012> check the last commit in https://github.com/jl2012/bitcoin/commits/badwitnesscheck-tmp 22:59 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 23:03 -!- Cory [~C@unaffiliated/cory] has quit [Ping timeout: 252 seconds] 23:05 -!- Pasha [~C@unaffiliated/cory] has joined #bitcoin-core-dev 23:12 -!- Pasha is now known as Cory 23:36 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev] 23:40 -!- shaiguitar [~rosenfs@shairosenfeld.com] has quit [Ping timeout: 240 seconds] 23:43 -!- murch [~murch@p4FE3A154.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 23:44 -!- shaiguitar [~rosenfs@shairosenfeld.com] has joined #bitcoin-core-dev